4280 2005-08-03 23:33:39 -0700 Would be nice if webkitdirs.pm could check system/xcode version 2005-08-06 01:58:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P4 Enhancement --- 1 eric eric oldest_to_newest 15839 0 eric 2005-08-03 23:33:39 -0700 It would be nice if webkitdirs.pm could check system/xcode version. For example, a dev complained tonight that xcode wasn't building, with this log: localhost:~ user$ WebKitTools/Scripts/build-webkit xcodebuild: Error: the project name JavaScriptCore.xcodeproj does not have a valid extension. It would have been nice if we had checked the version info and printed something like "You need at least Xcode 2.1 installed to build WebKit", perhaps even provided a URL: http://developer.apple.com/ tools/xcode This would be pretty easy to do using "xcodebuild -version" and a bit of regex. Maybe I'll do that right now. ;-) 15840 1 3220 eric 2005-08-03 23:56:45 -0700 Created attachment 3220 A patch to make build-* scripts check os & xcode version 15842 2 3222 eric 2005-08-04 00:09:53 -0700 Created attachment 3222 Patch to add checking Xcode & OS X version to build-* scripts. 15852 3 3222 darin 2005-08-04 11:22:23 -0700 Comment on attachment 3222 Patch to add checking Xcode & OS X version to build-* scripts. This: if (substr($buildVersion, 0, 1) < 8) should just be $buildVersion < 8. The current version won't work for 10, for example, and there's no reason to go out of the way to do substr. But this looks fine, r=me. 3220 2005-08-03 23:56:45 -0700 2005-08-04 00:09:53 -0700 A patch to make build-* scripts check os & xcode version better_scripts.patch text/plain 3477 eric SW5kZXg6IGJ1aWxkLWRyYXd0ZXN0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJL aXRUb29scy9TY3JpcHRzL2J1aWxkLWRyYXd0ZXN0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEK ZGlmZiAtcCAtdSAtcjEuMSBidWlsZC1kcmF3dGVzdAotLS0gYnVpbGQtZHJhd3Rlc3QJMzEgSnVs IDIwMDUgMjA6MDI6MzMgLTAwMDAJMS4xCisrKyBidWlsZC1kcmF3dGVzdAk0IEF1ZyAyMDA1IDA2 OjQwOjAyIC0wMDAwCkBAIC0zNCw2ICszNCw3IEBAIHVzZSBGaW5kQmluOwogdXNlIGxpYiAkRmlu ZEJpbjo6QmluOwogdXNlIHdlYmtpdGRpcnM7CiAKK2NoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWco KTsKIHNldENvbmZpZ3VyYXRpb24oKTsKIGNoZGlyV2ViS2l0KCk7CiBteSBAb3B0aW9ucyA9IFhj b2RlT3B0aW9ucygpOwpJbmRleDogYnVpbGQtZHVtcHJlbmRlcnRyZWUKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTAKZGlmZiAtcCAtdSAtcjEuMTAgYnVpbGQtZHVtcHJl bmRlcnRyZWUKLS0tIGJ1aWxkLWR1bXByZW5kZXJ0cmVlCTIyIEp1bCAyMDA1IDAxOjIzOjAyIC0w MDAwCTEuMTAKKysrIGJ1aWxkLWR1bXByZW5kZXJ0cmVlCTQgQXVnIDIwMDUgMDY6NDA6MDIgLTAw MDAKQEAgLTM1LDYgKzM1LDcgQEAgdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47 CiB1c2Ugd2Via2l0ZGlyczsKIAorY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZygpOwogc2V0Q29u ZmlndXJhdGlvbigpOwogY2hkaXJXZWJLaXQoKTsKIG15IEBvcHRpb25zID0gWGNvZGVPcHRpb25z KCk7CkluZGV4OiBidWlsZC1zdmcycG5nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXN2ZzJwbmcsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MQpkaWZmIC1wIC11IC1yMS4xIGJ1aWxkLXN2ZzJwbmcKLS0tIGJ1aWxkLXN2ZzJwbmcJMzEgSnVs IDIwMDUgMjA6MDI6MzMgLTAwMDAJMS4xCisrKyBidWlsZC1zdmcycG5nCTQgQXVnIDIwMDUgMDY6 NDA6MDIgLTAwMDAKQEAgLTM0LDYgKzM0LDcgQEAgdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5k QmluOjpCaW47CiB1c2Ugd2Via2l0ZGlyczsKIAorY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZygp Owogc2V0Q29uZmlndXJhdGlvbigpOwogY2hkaXJXZWJLaXQoKTsKIG15IEBvcHRpb25zID0gWGNv ZGVPcHRpb25zKCk7CkluZGV4OiBidWlsZC13ZWJjb3JlLXN2Zwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJjb3JlLXN2Zyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLXAgLXUgLXIxLjEgYnVpbGQtd2ViY29yZS1zdmcKLS0t IGJ1aWxkLXdlYmNvcmUtc3ZnCTMxIEp1bCAyMDA1IDIwOjAyOjMzIC0wMDAwCTEuMQorKysgYnVp bGQtd2ViY29yZS1zdmcJNCBBdWcgMjAwNSAwNjo0MDowMiAtMDAwMApAQCAtMzMsNiArMzMsNyBA QCB1c2UgRmluZEJpbjsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3ZWJraXRkaXJzOwog CitjaGVja1JlcXVpcmVkU3lzdGVtQ29uZmlnKCk7CiBzZXRDb25maWd1cmF0aW9uKCk7CiBjaGRp cldlYktpdCgpOwogbXkgJHByb2R1Y3REaXIgPSBwcm9kdWN0RGlyKCk7CkluZGV4OiBidWlsZC13 ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzCmRpZmYgLXAgLXUgLXIxLjEz IGJ1aWxkLXdlYmtpdAotLS0gYnVpbGQtd2Via2l0CTIxIEp1bCAyMDA1IDE5OjQ0OjE4IC0wMDAw CTEuMTMKKysrIGJ1aWxkLXdlYmtpdAk0IEF1ZyAyMDA1IDA2OjQwOjAyIC0wMDAwCkBAIC0zMyw2 ICszMyw3IEBAIHVzZSBGaW5kQmluOwogdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIHdlYmtp dGRpcnM7CiAKK2NoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWcoKTsKIHNldENvbmZpZ3VyYXRpb24o KTsKIGNoZGlyV2ViS2l0KCk7CiBteSAkcHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKSW5kZXg6 IHdlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNApkaWZmIC1w IC11IC1yMS4xNCB3ZWJraXRkaXJzLnBtCi0tLSB3ZWJraXRkaXJzLnBtCTMxIEp1bCAyMDA1IDIw OjAyOjMzIC0wMDAwCTEuMTQKKysrIHdlYmtpdGRpcnMucG0JNCBBdWcgMjAwNSAwNjo0MDowMiAt MDAwMApAQCAtMTk4LDQgKzE5OCwyMCBAQCBzdWIgY2hlY2tTVkdGcmFtZXdvcmtzCiAgICAgfQog fQogCitzdWIgY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZworeworICAgIG15ICRzeXN0ZW1CdWls ZFZlcnNpb24gPSBgc3dfdmVycyAtYnVpbGRWZXJzaW9uYDsKKyAgICBpZiAoc3Vic3RyKCRzeXN0 ZW1CdWlsZFZlcnNpb24sIDEpIDwgOCkgeworICAgICAgICBwcmludCAiTWFjIE9TIFggVmVyc2lv biAxMC40LjAgb3IgbGF0ZXIgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0LlxuIjsKKyAgICAg ICAgcHJpbnQgIllvdSBoYXZlICIgLiBgc3dfdmVycyAtcHJvZHVjdFZlcnNpb25gIC4gIiwgdGh1 cyB0aGUgYnVpbGQgd2lsbCBtb3N0IGxpa2VseSBmYWlsLlxuIjsKKyAgICB9CisgICAgbXkgJHhj b2RlVmVyc2lvbiA9IGB4Y29kZWJ1aWxkIC12ZXJzaW9uYDsKKyAgICAkeGNvZGVWZXJzaW9uID1+ IHN8RGV2VG9vbHNDb3JlLSguKik7IHwkMXw7CisgICAgaWYgKCR4Y29kZVZlcnNpb24gPCA2MjAp IHsKKyAgICAgICAgcHJpbnQgIlhjb2RlIFZlcnNpb24gMi4xIG9yIGxhdGVyIGlzIHJlcXVpcmVk IHRvIGJ1aWxkIFdlYktpdC5cbiI7CisgICAgICAgIHByaW50ICJZb3UgaGF2ZSBhbiBlYXJsaWVy IHZlcnNpb24gb2YgWGNvZGUsIHRodXMgdGhlIGJ1aWxkIHdpbGwgbW9zdCBsaWtlbHkgZmFpbC5c biI7CisgICAgICAgIHByaW50ICJUaGUgbGF0ZXN0IFhjb2RlIGlzIGF2YWlsYWJsZSBmcm9tIGh0 dHA6Ly9kZXZlbG9wZXIuYXBwbGUuY29tL3Rvb2xzL3hjb2RlXG4iOworICAgIH0KK30KKwogMTsK 3222 2005-08-04 00:09:53 -0700 2005-08-04 11:22:23 -0700 Patch to add checking Xcode & OS X version to build-* scripts. better_scripts.patch text/plain 3883 eric SW5kZXg6IGJ1aWxkLWRyYXd0ZXN0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJL aXRUb29scy9TY3JpcHRzL2J1aWxkLWRyYXd0ZXN0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEK ZGlmZiAtcCAtdSAtcjEuMSBidWlsZC1kcmF3dGVzdAotLS0gYnVpbGQtZHJhd3Rlc3QJMzEgSnVs IDIwMDUgMjA6MDI6MzMgLTAwMDAJMS4xCisrKyBidWlsZC1kcmF3dGVzdAk0IEF1ZyAyMDA1IDA2 OjUzOjMxIC0wMDAwCkBAIC0zNCw2ICszNCw3IEBAIHVzZSBGaW5kQmluOwogdXNlIGxpYiAkRmlu ZEJpbjo6QmluOwogdXNlIHdlYmtpdGRpcnM7CiAKK2NoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWco KTsKIHNldENvbmZpZ3VyYXRpb24oKTsKIGNoZGlyV2ViS2l0KCk7CiBteSBAb3B0aW9ucyA9IFhj b2RlT3B0aW9ucygpOwpJbmRleDogYnVpbGQtZHVtcHJlbmRlcnRyZWUKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTAKZGlmZiAtcCAtdSAtcjEuMTAgYnVpbGQtZHVtcHJl bmRlcnRyZWUKLS0tIGJ1aWxkLWR1bXByZW5kZXJ0cmVlCTIyIEp1bCAyMDA1IDAxOjIzOjAyIC0w MDAwCTEuMTAKKysrIGJ1aWxkLWR1bXByZW5kZXJ0cmVlCTQgQXVnIDIwMDUgMDY6NTM6MzEgLTAw MDAKQEAgLTM1LDYgKzM1LDcgQEAgdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47 CiB1c2Ugd2Via2l0ZGlyczsKIAorY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZygpOwogc2V0Q29u ZmlndXJhdGlvbigpOwogY2hkaXJXZWJLaXQoKTsKIG15IEBvcHRpb25zID0gWGNvZGVPcHRpb25z KCk7CkluZGV4OiBidWlsZC1zdmcycG5nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXN2ZzJwbmcsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MQpkaWZmIC1wIC11IC1yMS4xIGJ1aWxkLXN2ZzJwbmcKLS0tIGJ1aWxkLXN2ZzJwbmcJMzEgSnVs IDIwMDUgMjA6MDI6MzMgLTAwMDAJMS4xCisrKyBidWlsZC1zdmcycG5nCTQgQXVnIDIwMDUgMDY6 NTM6MzEgLTAwMDAKQEAgLTM0LDYgKzM0LDcgQEAgdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5k QmluOjpCaW47CiB1c2Ugd2Via2l0ZGlyczsKIAorY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZygp Owogc2V0Q29uZmlndXJhdGlvbigpOwogY2hkaXJXZWJLaXQoKTsKIG15IEBvcHRpb25zID0gWGNv ZGVPcHRpb25zKCk7CkluZGV4OiBidWlsZC13ZWJjb3JlLXN2Zwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJjb3JlLXN2Zyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLXAgLXUgLXIxLjEgYnVpbGQtd2ViY29yZS1zdmcKLS0t IGJ1aWxkLXdlYmNvcmUtc3ZnCTMxIEp1bCAyMDA1IDIwOjAyOjMzIC0wMDAwCTEuMQorKysgYnVp bGQtd2ViY29yZS1zdmcJNCBBdWcgMjAwNSAwNjo1MzozMSAtMDAwMApAQCAtMzMsNiArMzMsNyBA QCB1c2UgRmluZEJpbjsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3ZWJraXRkaXJzOwog CitjaGVja1JlcXVpcmVkU3lzdGVtQ29uZmlnKCk7CiBzZXRDb25maWd1cmF0aW9uKCk7CiBjaGRp cldlYktpdCgpOwogbXkgJHByb2R1Y3REaXIgPSBwcm9kdWN0RGlyKCk7CkluZGV4OiBidWlsZC13 ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzCmRpZmYgLXAgLXUgLXIxLjEz IGJ1aWxkLXdlYmtpdAotLS0gYnVpbGQtd2Via2l0CTIxIEp1bCAyMDA1IDE5OjQ0OjE4IC0wMDAw CTEuMTMKKysrIGJ1aWxkLXdlYmtpdAk0IEF1ZyAyMDA1IDA2OjUzOjMxIC0wMDAwCkBAIC0zMyw2 ICszMyw3IEBAIHVzZSBGaW5kQmluOwogdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIHdlYmtp dGRpcnM7CiAKK2NoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWcoKTsKIHNldENvbmZpZ3VyYXRpb24o KTsKIGNoZGlyV2ViS2l0KCk7CiBteSAkcHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKSW5kZXg6 IHdlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNApkaWZmIC1w IC11IC1yMS4xNCB3ZWJraXRkaXJzLnBtCi0tLSB3ZWJraXRkaXJzLnBtCTMxIEp1bCAyMDA1IDIw OjAyOjMzIC0wMDAwCTEuMTQKKysrIHdlYmtpdGRpcnMucG0JNCBBdWcgMjAwNSAwNjo1MzozMSAt MDAwMApAQCAtMTk4LDQgKzE5OCwyNiBAQCBzdWIgY2hlY2tTVkdGcmFtZXdvcmtzCiAgICAgfQog fQogCitzdWIgY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZworeworICAgIG15ICRidWlsZFZlcnNp b24gPSBgc3dfdmVycyAtYnVpbGRWZXJzaW9uYDsKKyAgICBpZiAoc3Vic3RyKCRidWlsZFZlcnNp b24sIDAsIDEpIDwgOCkgeworICAgICAgICBjaG9tcChteSAkcHJvZHVjdFZlcnNpb24gPSBgc3df dmVycyAtcHJvZHVjdFZlcnNpb25gKTsKKyAgICAgICAgcHJpbnQgIioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKipcbiI7CisgICAgICAg IHByaW50ICJNYWMgT1MgWCBWZXJzaW9uIDEwLjQuMCBvciBsYXRlciBpcyByZXF1aXJlZCB0byBi dWlsZCBXZWJLaXQuXG4iOworICAgICAgICBwcmludCAiWW91IGhhdmUgIiAuICRwcm9kdWN0VmVy c2lvbiAuICIsIHRodXMgdGhlIGJ1aWxkIHdpbGwgbW9zdCBsaWtlbHkgZmFpbC5cbiI7CisgICAg ICAgIHByaW50ICIqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqXG4iOworICAgIH0KKyAgICBteSAkeGNvZGVWZXJzaW9uID0gYHhjb2Rl YnVpbGQgLXZlcnNpb25gOworICAgICR4Y29kZVZlcnNpb24gPX4gc3xEZXZUb29sc0NvcmUtKC4r Pyk7IC4qfCQxfDsKKyAgICBpZiAoJHhjb2RlVmVyc2lvbiA8IDYyMCkgeworICAgICAgICBwcmlu dCAiKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKlxuIjsKKyAgICAgICAgcHJpbnQgIlhjb2RlIFZlcnNpb24gMi4xIG9yIGxhdGVyIGlz IHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdC5cbiI7CisgICAgICAgIHByaW50ICJZb3UgaGF2ZSBh biBlYXJsaWVyIHZlcnNpb24gb2YgWGNvZGUsIHRodXMgdGhlIGJ1aWxkIHdpbGxcbiI7CisgICAg ICAgIHByaW50ICJtb3N0IGxpa2VseSBmYWlsLiAgVGhlIGxhdGVzdCBYY29kZSBpcyBhdmFpbGFi bGUgZnJvbSB0aGUgd2ViOlxuIjsKKyAgICAgICAgcHJpbnQgImh0dHA6Ly9kZXZlbG9wZXIuYXBw bGUuY29tL3Rvb2xzL3hjb2RlXG4iOworICAgICAgICBwcmludCAiKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKlxuIjsKKyAgICB9Cit9 CisKIDE7Cg==