42768 2010-07-21 10:21:10 -0700 [chromium] fast/forms/input-file-directory-upload.html fails on win after r63454 2010-07-22 18:00:18 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan johnnyg cmarrin commit-queue johnnyg webkit.review.bot oldest_to_newest 254388 0 ojan 2010-07-21 10:21:10 -0700 Looks like the issue is that the paths have backslashes instead of forward slashes. Does the relevant spec comment on this? I think we should normalize to forward slashes. The web shouldn't need to deal with mixed slashes. 254393 1 johnnyg 2010-07-21 10:22:01 -0700 Agreed, we should normalize to forward slashes, I'm working on a patch 254629 2 62254 johnnyg 2010-07-21 19:10:29 -0700 Created attachment 62254 Patch 254630 3 webkit.review.bot 2010-07-21 19:14:14 -0700 Attachment 62254 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/html/HTMLInputElement.cpp:2001: Missing spaces around / [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 254660 4 62254 tkent 2010-07-21 22:02:00 -0700 Comment on attachment 62254 Patch ok. 254870 5 62254 commit-queue 2010-07-22 10:23:12 -0700 Comment on attachment 62254 Patch Rejecting patch 62254 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20707 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 13.24s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3581339 254877 6 ojan 2010-07-22 10:48:12 -0700 > animations/play-state.html -> failed This test looks to have gotten flaky recently. Likely from http://trac.webkit.org/changeset/63862/. See http://crbug.com/49920 for more details. 254936 7 62254 johnnyg 2010-07-22 13:05:29 -0700 Comment on attachment 62254 Patch okay if it's just flaky i'll try CQ one more time 254985 8 62254 commit-queue 2010-07-22 14:27:10 -0700 Comment on attachment 62254 Patch Clearing flags on attachment: 62254 Committed r63914: <http://trac.webkit.org/changeset/63914> 254986 9 commit-queue 2010-07-22 14:27:16 -0700 All reviewed patches have been landed. Closing bug. 255120 10 johnnyg 2010-07-22 18:00:18 -0700 Committed r63932: <http://trac.webkit.org/changeset/63932> 62254 2010-07-21 19:10:29 -0700 2010-07-22 14:27:10 -0700 Patch bug-42768-20100721191027.patch text/plain 1678 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Mzg3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMjEgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBmYXN0L2Zvcm1zL2lucHV0LWZpbGUtZGlyZWN0b3J5LXVwbG9hZC5odG1sIGZhaWxz IG9uIHdpbiBhZnRlciByNjM0NTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQyNzY4CisKKyAgICAgICAgTm9ybWFsaXplIHBhdGggc2VwYXJhdG9ycyBm b3IgdGhlIHNjcmlwdCBBUEkgYnkgY29udmVyaW5nIFwncyB0byAvJ3MuCisKKyAgICAgICAgQ292 ZXJlZCBieSBpbnB1dC1maWxlLWRpcmVjdG9yeS11cGxvYWQuaHRtbAorCisgICAgICAgICogaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1l bnQ6OnNldEZpbGVMaXN0RnJvbVJlbmRlcmVyKToKKwogMjAxMC0wNy0yMSAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJ bmRleDogV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gNjM4NjQpCisrKyBXZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5OTYsOCAr MTk5NiwxMSBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldEZpbGVMaXN0RnJvbVJlCiAgICAg ICAgIH0KICAgICAgICAgcm9vdFBhdGggPSBkaXJlY3RvcnlOYW1lKHJvb3RQYXRoKTsKICAgICAg ICAgQVNTRVJUKHJvb3RQYXRoLmxlbmd0aCgpKTsKLSAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkg PCBzaXplOyBpKyspCi0gICAgICAgICAgICBtX2ZpbGVMaXN0LT5hcHBlbmQoRmlsZTo6Y3JlYXRl KHBhdGhzW2ldLnN1YnN0cmluZygxICsgcm9vdFBhdGgubGVuZ3RoKCkpLCBwYXRoc1tpXSkpOwor ICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IHNpemU7IGkrKykgeworICAgICAgICAgICAgLy8g Tm9ybWFsaXplIGJhY2tzbGFzaGVzIHRvIHNsYXNoZXMgYmVmb3JlIGV4cG9zaW5nIHRoZSByZWxh dGl2ZSBwYXRoIHRvIHNjcmlwdC4KKyAgICAgICAgICAgIFN0cmluZyByZWxhdGl2ZVBhdGggPSBw YXRoc1tpXS5zdWJzdHJpbmcoMSArIHJvb3RQYXRoLmxlbmd0aCgpKS5yZXBsYWNlKCdcXCcsJy8n KTsKKyAgICAgICAgICAgIG1fZmlsZUxpc3QtPmFwcGVuZChGaWxlOjpjcmVhdGUocmVsYXRpdmVQ YXRoLCBwYXRoc1tpXSkpOworICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgZm9yIChp bnQgaSA9IDA7IGkgPCBzaXplOyBpKyspCiAgICAgICAgICAgICBtX2ZpbGVMaXN0LT5hcHBlbmQo RmlsZTo6Y3JlYXRlKHBhdGhzW2ldKSk7Cg==