42755 2010-07-21 08:10:22 -0700 Web Inspector: Almost all inspector tests are failing if comma is used as decimal separator. 2010-08-11 00:11:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo webkit-unassigned ap bweinstein joepeck keishi krit pfeldman pmuellr rik timothy yurys oldest_to_newest 254288 0 loislo 2010-07-21 08:10:22 -0700 %subj% 254290 1 loislo 2010-07-21 08:11:28 -0700 Windows with Russian locale. 254300 2 62183 loislo 2010-07-21 08:18:19 -0700 Created attachment 62183 [patch] initial version. 254301 3 62183 darin 2010-07-21 08:19:36 -0700 Comment on attachment 62183 [patch] initial version. This is a workaround, and not the real fix. The real fix is to change to a String formatting function that is locale independent. 254302 4 pfeldman 2010-07-21 08:23:34 -0700 (In reply to comment #3) > (From update of attachment 62183 [details]) > This is a workaround, and not the real fix. The real fix is to change to a String formatting function that is locale independent. It is not clear whether String formatting should be changed as a whole because of this use case. The code being fixed is supposed to produce strings compatible with JSON and it is JSON spec that requires numbers to have "." separators. Anyways, the fix is incomplete. 254315 5 62183 pfeldman 2010-07-21 08:38:03 -0700 Comment on attachment 62183 [patch] initial version. Ok, given that 0.5 will be formatted Ok we should land this. 254374 6 ap 2010-07-21 10:04:24 -0700 As Darin said, String formatting needs to be fixed - see also bug 18994. This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. 254448 7 krit 2010-07-21 12:20:57 -0700 (In reply to comment #6) > As Darin said, String formatting needs to be fixed - see also bug 18994. > > This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. We should document all occurences of work arounds for the string formating problems. So we can fix them all at once. Otherwise, adding all this br's on bug 18994 is also some kind of documentation. 254451 8 loislo 2010-07-21 12:28:11 -0700 (In reply to comment #6) > As Darin said, String formatting needs to be fixed - see also bug 18994. > > This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. According to spec %f doesn't uses thousands separator. It will be the problem if some locale uses something different as decimal separator. 263031 9 loislo 2010-08-10 22:45:30 -0700 already landed 263070 10 krit 2010-08-10 23:37:24 -0700 (In reply to comment #8) > (In reply to comment #6) > > As Darin said, String formatting needs to be fixed - see also bug 18994. > > > > This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. > > According to spec %f doesn't uses thousands separator. > It will be the problem if some locale uses something different as decimal separator. I guess this is what ap tried to mention. :-P We have many localas with this schema (points and commas in a float). This fix is a hack, that works for some locals, but many still fail, or will fail now. It's sad that there was no FIXME added in the patch. Normaly this patch shouldn't be in trunk. :-( 263081 11 loislo 2010-08-11 00:11:13 -0700 yep. it should be fixed another way. https://bugs.webkit.org/show_bug.cgi?id=43832 62183 2010-07-21 08:18:19 -0700 2010-08-10 22:44:37 -0700 [patch] initial version. patch text/plain 1182 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWI2OWVjZC4uYjA5ZmY1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0yMSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBTZXJpYWxpemF0aW9uIHRvIEpTT04g aW4gSW5zcGVjdG9yVmFsdWUgd29ya3MgaW5jb3JyZWN0CisgICAgICAgIGlmIGNvbW1hIGlzIGFz c2lnbmVkIGFzIGRlY2ltYWwgc2VwYXJhdG9yLiBXaW5kb3dzIHdpdGggUnVzc2lhbiBsb2NhbGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjc1NQor CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclZhbHVlcy5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JCYXNpY1ZhbHVlOjp3cml0ZUpTT04pOgorCiAyMDEwLTA3LTIxICBIYW5z IFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3Rl dmUgQmxvY2suCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JWYWx1ZXMu Y3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVmFsdWVzLmNwcAppbmRleCBmZDQyYzY1 Li45MGE0MGY5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JWYWx1ZXMu Y3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclZhbHVlcy5jcHAKQEAgLTU1MCw2 ICs1NTAsNyBAQCB2b2lkIEluc3BlY3RvckJhc2ljVmFsdWU6OndyaXRlSlNPTihWZWN0b3I8VUNo YXI+KiBvdXRwdXQpIGNvbnN0CiAgICAgICAgICAgICBvdXRwdXQtPmFwcGVuZChmYWxzZVN0cmlu ZywgNSk7CiAgICAgfSBlbHNlIGlmICh0eXBlKCkgPT0gVHlwZURvdWJsZSkgewogICAgICAgICBT dHJpbmcgdmFsdWUgPSBTdHJpbmc6OmZvcm1hdCgiJWYiLCBtX2RvdWJsZVZhbHVlKTsKKyAgICAg ICAgdmFsdWUucmVwbGFjZSgnLCcsICcuJyk7CiAgICAgICAgIG91dHB1dC0+YXBwZW5kKHZhbHVl LmNoYXJhY3RlcnMoKSwgdmFsdWUubGVuZ3RoKCkpOwogICAgIH0KIH0K