42753 2010-07-21 07:22:40 -0700 [QT] Leak and few more fixes to qt port of geolocation 2010-08-24 06:42:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 maheshk maheshk commit-queue hausmann laszlo.gombos oldest_to_newest 254265 0 maheshk 2010-07-21 07:22:40 -0700 We have a memory leak of QGeoPositionInfoSource in qt port of geolocation. Default values of attributes (QGeoCoordinate) are set to "0.0" which is a valid number for few properties. Leave default value to the caller function. 254269 1 62179 maheshk 2010-07-21 07:36:59 -0700 Created attachment 62179 patch Fixes memory leak and default values set to attributes. 254278 2 62179 kenneth 2010-07-21 07:57:08 -0700 Comment on attachment 62179 patch where sit he leak fix? 254285 3 maheshk 2010-07-21 08:04:02 -0700 (In reply to comment #2) > (From update of attachment 62179 [details]) > where sit he leak fix? Thanks for the review, +++ WebCore/platform/qt/GeolocationServiceQt.cpp (working copy) @@ -55,6 +55,7 @@ GeolocationServiceQt::~GeolocationServiceQt() { + delete m_location; 254291 4 62179 commit-queue 2010-07-21 08:12:40 -0700 Comment on attachment 62179 patch Clearing flags on attachment: 62179 Committed r63819: <http://trac.webkit.org/changeset/63819> 254292 5 commit-queue 2010-07-21 08:12:45 -0700 All reviewed patches have been landed. Closing bug. 259953 6 hausmann 2010-08-04 03:31:20 -0700 Revision r63819 cherry-picked into qtwebkit-2.1 with commit f63e272bc955d7c6685fb9853348ed3c07de6358 62179 2010-07-21 07:36:59 -0700 2010-07-21 08:12:40 -0700 patch memory_leak.patch text/plain 2882 maheshk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzgwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDYtMTQgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxr YXJuaUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KKwor ICAgICAgICBbUVRdIExlYWsgYW5kIGZldyBtb3JlIGZpeGVzIHRvIHF0IHBvcnQgb2YgZ2VvbG9j YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQy NzUzCisKKyAgICAgICAgRml4ZXMgbWVtb3J5IGxlYWsgYW5kIGRlZmF1bHQgdmFsdWVzIHNldCB0 byBhdHRyaWJ1dGVzLiAKKyAgICAgICAgCisgICAgICAgIE1lbW9yeSBsZWFrIGZpeCBubyBuZXcg dGVzdCBjYXNlIGFkZGVkLiAKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0dlb2xvY2F0aW9uU2Vy dmljZVF0LmNwcDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvblNlcnZpY2VR dDo6fkdlb2xvY2F0aW9uU2VydmljZVF0KToKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9u U2VydmljZVF0Ojpwb3NpdGlvblVwZGF0ZWQpOgorCiAyMDEwLTA3LTIxICBab2x0YW4gSGVyY3pl ZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgTmlrb2xhcyBaaW1t ZXJtYW5uLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlvblNlcnZpY2VR dC5jcHAJKHJldmlzaW9uIDYzODA5KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlv blNlcnZpY2VRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1LDYgKzU1LDcgQEAKIAogR2VvbG9j YXRpb25TZXJ2aWNlUXQ6On5HZW9sb2NhdGlvblNlcnZpY2VRdCgpCiB7CisgICAgZGVsZXRlIG1f bG9jYXRpb247CiB9CiAKIHZvaWQgR2VvbG9jYXRpb25TZXJ2aWNlUXQ6OnBvc2l0aW9uVXBkYXRl ZChjb25zdCBRR2VvUG9zaXRpb25JbmZvICZnZW9Qb3NpdGlvbikKQEAgLTY1LDIwICs2NiwxOSBA QAogICAgIFFHZW9Db29yZGluYXRlIGNvb3JkID0gZ2VvUG9zaXRpb24uY29vcmRpbmF0ZSgpOwog ICAgIGRvdWJsZSBsYXRpdHVkZSA9IGNvb3JkLmxhdGl0dWRlKCk7CiAgICAgZG91YmxlIGxvbmdp dHVkZSA9IGNvb3JkLmxvbmdpdHVkZSgpOwotICAgIGJvb2wgcHJvdmlkZXNBbHRpdHVkZSA9IHRy dWU7CisgICAgYm9vbCBwcm92aWRlc0FsdGl0dWRlID0gKGdlb1Bvc2l0aW9uLmNvb3JkaW5hdGUo KS50eXBlKCkgPT0gUUdlb0Nvb3JkaW5hdGU6OkNvb3JkaW5hdGUzRCk7CiAgICAgZG91YmxlIGFs dGl0dWRlID0gY29vcmQuYWx0aXR1ZGUoKTsKIAotICAgIGRvdWJsZSBhY2N1cmFjeSA9IGdlb1Bv c2l0aW9uLmhhc0F0dHJpYnV0ZShRR2VvUG9zaXRpb25JbmZvOjpIb3Jpem9udGFsQWNjdXJhY3kp ID8KLSAgICAgICAgICAgICAgICAgICAgICAgIGdlb1Bvc2l0aW9uLmF0dHJpYnV0ZShRR2VvUG9z aXRpb25JbmZvOjpIb3Jpem9udGFsQWNjdXJhY3kpIDogMC4wOworICAgIGRvdWJsZSBhY2N1cmFj eSA9IGdlb1Bvc2l0aW9uLmF0dHJpYnV0ZShRR2VvUG9zaXRpb25JbmZvOjpIb3Jpem9udGFsQWNj dXJhY3kpOwogCiAgICAgYm9vbCBwcm92aWRlc0FsdGl0dWRlQWNjdXJhY3kgPSBnZW9Qb3NpdGlv bi5oYXNBdHRyaWJ1dGUoUUdlb1Bvc2l0aW9uSW5mbzo6VmVydGljYWxBY2N1cmFjeSk7Ci0gICAg ZG91YmxlIGFsdGl0dWRlQWNjdXJhY3kgPSBwcm92aWRlc0FsdGl0dWRlQWNjdXJhY3kgPyBnZW9Q b3NpdGlvbi5hdHRyaWJ1dGUoUUdlb1Bvc2l0aW9uSW5mbzo6VmVydGljYWxBY2N1cmFjeSkgOiAw LjA7CisgICAgZG91YmxlIGFsdGl0dWRlQWNjdXJhY3kgPSBnZW9Qb3NpdGlvbi5hdHRyaWJ1dGUo UUdlb1Bvc2l0aW9uSW5mbzo6VmVydGljYWxBY2N1cmFjeSk7CiAKICAgICBib29sIHByb3ZpZGVz SGVhZGluZyA9ICBnZW9Qb3NpdGlvbi5oYXNBdHRyaWJ1dGUoUUdlb1Bvc2l0aW9uSW5mbzo6RGly ZWN0aW9uKTsKLSAgICBkb3VibGUgaGVhZGluZyA9IHByb3ZpZGVzSGVhZGluZyA/IGdlb1Bvc2l0 aW9uLmF0dHJpYnV0ZShRR2VvUG9zaXRpb25JbmZvOjpEaXJlY3Rpb24pIDogMC4wOworICAgIGRv dWJsZSBoZWFkaW5nID0gZ2VvUG9zaXRpb24uYXR0cmlidXRlKFFHZW9Qb3NpdGlvbkluZm86OkRp cmVjdGlvbik7CiAKICAgICBib29sIHByb3ZpZGVzU3BlZWQgPSBnZW9Qb3NpdGlvbi5oYXNBdHRy aWJ1dGUoUUdlb1Bvc2l0aW9uSW5mbzo6R3JvdW5kU3BlZWQpOwotICAgIGRvdWJsZSBzcGVlZCA9 IHByb3ZpZGVzU3BlZWQgPyBnZW9Qb3NpdGlvbi5hdHRyaWJ1dGUoUUdlb1Bvc2l0aW9uSW5mbzo6 R3JvdW5kU3BlZWQpIDogMC4wOworICAgIGRvdWJsZSBzcGVlZCA9IGdlb1Bvc2l0aW9uLmF0dHJp YnV0ZShRR2VvUG9zaXRpb25JbmZvOjpHcm91bmRTcGVlZCk7CiAKICAgICBSZWZQdHI8Q29vcmRp bmF0ZXM+IGNvb3JkaW5hdGVzID0gQ29vcmRpbmF0ZXM6OmNyZWF0ZShsYXRpdHVkZSwgbG9uZ2l0 dWRlLCBwcm92aWRlc0FsdGl0dWRlLCBhbHRpdHVkZSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhY2N1cmFjeSwgcHJvdmlkZXNBbHRp dHVkZUFjY3VyYWN5LCBhbHRpdHVkZUFjY3VyYWN5LAo=