42747 2010-07-21 06:26:22 -0700 build-webkit should build MiniBrowser 2010-07-21 09:06:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 aroben aroben andersca sam sfalken oldest_to_newest 254249 0 aroben 2010-07-21 06:26:22 -0700 build-webkit should build MiniBrowser 254250 1 62174 aroben 2010-07-21 06:27:34 -0700 Created attachment 62174 Patch 254299 2 62174 darin 2010-07-21 08:17:47 -0700 Comment on attachment 62174 Patch Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right? 254313 3 aroben 2010-07-21 08:34:32 -0700 (In reply to comment #2) > (From update of attachment 62174 [details]) > Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right? We require the project dependency tree to be linear so that our "stop the build when any project fails" logic will work. MiniBrowser has no build-time or run-time dependency on WebKitTestRunner, but we mark it as depending on WebKitTestRunner so that Visual Studio won't try to build the two projects in parallel. (Unfortunately, this defeats Visual Studio's project-parallel compilation feature. Fortunately, pdevenv's file-parallel compilation feature mitigates this issue.) 254328 4 aroben 2010-07-21 09:06:38 -0700 Committed r63827: <http://trac.webkit.org/changeset/63827> 62174 2010-07-21 06:27:34 -0700 2010-07-21 08:17:47 -0700 Patch bug-42747-20100721092735.patch text/plain 3430 aroben ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK aW5kZXggZDYxZTRlMWZmNTc1YjNmNTExZjlkM2NiYWQ5YmQ5OTBmNzkyMTQ4OS4uMTZjZjA0ZDZi NTdiOWY2NzBhYjNjMzUxODNiMTA3ZTY2NzYyYWRlOSAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wNy0yMSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIE1p bmlCcm93c2VyIHRvIFdlYktpdC5zbG4KKworICAgICAgICBJdCBpcyB0aGUgbGFzdCBwcm9qZWN0 IHRvIGJ1aWxkLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzQyNzQ3PiBi dWlsZC13ZWJraXQgc2hvdWxkIGJ1aWxkCisgICAgICAgIE1pbmlCcm93c2VyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQudmNwcm9qL1dl YktpdC5zbG46IEFkZGVkIE1pbmlCcm93c2VyLCBhbmQgbWFkZSBpdCBkZXBlbmQgb24KKyAgICAg ICAgV2ViS2l0VGVzdFJ1bm5lci4KKwogMjAxMC0wNy0yMCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdlYktpdFRlc3RSdW5uZXIgYW5kIGZyaWVuZHMgdG8g V2ViS2l0LnNsbgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3dpbi9XZWJLaXQudmNwcm9qL1dlYktpdC5z bG4gYi9XZWJLaXQvd2luL1dlYktpdC52Y3Byb2ovV2ViS2l0LnNsbgppbmRleCA0MDgwMjQxN2Jj Zjk3MTYxMzAxYThlNmFiMDJkNjgyN2IzODY4ZDM3Li45YWM4OWU3MWU0OGY0YzQ3YTM5OWQ1YjRh MzY2NTAyZGE4MjhhMzlhIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL1dlYktpdC52Y3Byb2ovV2Vi S2l0LnNsbgorKysgYi9XZWJLaXQvd2luL1dlYktpdC52Y3Byb2ovV2ViS2l0LnNsbgpAQCAtMTMz LDYgKzEzMywxMSBAQCBQcm9qZWN0KCJ7OEJDOUNFQjgtOEI0QS0xMUQwLThEMTEtMDBBMEM5MUJD OTQyfSIpID0gIldlYktpdFRlc3RSdW5uZXIiLCAiLi5cLi5cLgogCQl7Q0JDMzM5MUMtRjA2MC00 QkY1LUE2NkUtODE0MDQxNjg4MTZCfSA9IHtDQkMzMzkxQy1GMDYwLTRCRjUtQTY2RS04MTQwNDE2 ODgxNkJ9DQogCUVuZFByb2plY3RTZWN0aW9uDQogRW5kUHJvamVjdA0KK1Byb2plY3QoIns4QkM5 Q0VCOC04QjRBLTExRDAtOEQxMS0wMEEwQzkxQkM5NDJ9IikgPSAiTWluaUJyb3dzZXIiLCAiLi5c Li5cLi5cV2ViS2l0VG9vbHNcTWluaUJyb3dzZXJcTWluaUJyb3dzZXIudmNwcm9qIiwgInsxNDgw Q0Y1Ri00MTYwLTQ3QjUtQTBFNi05NkFFQzgyNThGQjV9Ig0KKwlQcm9qZWN0U2VjdGlvbihQcm9q ZWN0RGVwZW5kZW5jaWVzKSA9IHBvc3RQcm9qZWN0DQorCQl7M0I5OTY2OUItMTgxNy00NDNCLUJD QkUtODM1NTgwMTQ2NjY4fSA9IHszQjk5NjY5Qi0xODE3LTQ0M0ItQkNCRS04MzU1ODAxNDY2Njh9 DQorCUVuZFByb2plY3RTZWN0aW9uDQorRW5kUHJvamVjdA0KIEdsb2JhbA0KIAlHbG9iYWxTZWN0 aW9uKFNvbHV0aW9uQ29uZmlndXJhdGlvblBsYXRmb3JtcykgPSBwcmVTb2x1dGlvbg0KIAkJRGVi dWdfQWxsfFdpbjMyID0gRGVidWdfQWxsfFdpbjMyDQpAQCAtNDQyLDYgKzQ0NywxOCBAQCBHbG9i YWwKIAkJezNCOTk2NjlCLTE4MTctNDQzQi1CQ0JFLTgzNTU4MDE0NjY2OH0uUmVsZWFzZV9DYWly b3xXaW4zMi5CdWlsZC4wID0gUmVsZWFzZXxXaW4zMg0KIAkJezNCOTk2NjlCLTE4MTctNDQzQi1C Q0JFLTgzNTU4MDE0NjY2OH0uUmVsZWFzZXxXaW4zMi5BY3RpdmVDZmcgPSBSZWxlYXNlfFdpbjMy DQogCQl7M0I5OTY2OUItMTgxNy00NDNCLUJDQkUtODM1NTgwMTQ2NjY4fS5SZWxlYXNlfFdpbjMy LkJ1aWxkLjAgPSBSZWxlYXNlfFdpbjMyDQorCQl7MTQ4MENGNUYtNDE2MC00N0I1LUEwRTYtOTZB RUM4MjU4RkI1fS5EZWJ1Z19BbGx8V2luMzIuQWN0aXZlQ2ZnID0gRGVidWdfQWxsfFdpbjMyDQor CQl7MTQ4MENGNUYtNDE2MC00N0I1LUEwRTYtOTZBRUM4MjU4RkI1fS5EZWJ1Z19BbGx8V2luMzIu QnVpbGQuMCA9IERlYnVnX0FsbHxXaW4zMg0KKwkJezE0ODBDRjVGLTQxNjAtNDdCNS1BMEU2LTk2 QUVDODI1OEZCNX0uRGVidWdfQ2Fpcm98V2luMzIuQWN0aXZlQ2ZnID0gRGVidWd8V2luMzINCisJ CXsxNDgwQ0Y1Ri00MTYwLTQ3QjUtQTBFNi05NkFFQzgyNThGQjV9LkRlYnVnX0NhaXJvfFdpbjMy LkJ1aWxkLjAgPSBEZWJ1Z3xXaW4zMg0KKwkJezE0ODBDRjVGLTQxNjAtNDdCNS1BMEU2LTk2QUVD ODI1OEZCNX0uRGVidWdfSW50ZXJuYWx8V2luMzIuQWN0aXZlQ2ZnID0gRGVidWdfSW50ZXJuYWx8 V2luMzINCisJCXsxNDgwQ0Y1Ri00MTYwLTQ3QjUtQTBFNi05NkFFQzgyNThGQjV9LkRlYnVnX0lu dGVybmFsfFdpbjMyLkJ1aWxkLjAgPSBEZWJ1Z19JbnRlcm5hbHxXaW4zMg0KKwkJezE0ODBDRjVG LTQxNjAtNDdCNS1BMEU2LTk2QUVDODI1OEZCNX0uRGVidWd8V2luMzIuQWN0aXZlQ2ZnID0gRGVi dWd8V2luMzINCisJCXsxNDgwQ0Y1Ri00MTYwLTQ3QjUtQTBFNi05NkFFQzgyNThGQjV9LkRlYnVn fFdpbjMyLkJ1aWxkLjAgPSBEZWJ1Z3xXaW4zMg0KKwkJezE0ODBDRjVGLTQxNjAtNDdCNS1BMEU2 LTk2QUVDODI1OEZCNX0uUmVsZWFzZV9DYWlyb3xXaW4zMi5BY3RpdmVDZmcgPSBSZWxlYXNlfFdp bjMyDQorCQl7MTQ4MENGNUYtNDE2MC00N0I1LUEwRTYtOTZBRUM4MjU4RkI1fS5SZWxlYXNlX0Nh aXJvfFdpbjMyLkJ1aWxkLjAgPSBSZWxlYXNlfFdpbjMyDQorCQl7MTQ4MENGNUYtNDE2MC00N0I1 LUEwRTYtOTZBRUM4MjU4RkI1fS5SZWxlYXNlfFdpbjMyLkFjdGl2ZUNmZyA9IFJlbGVhc2V8V2lu MzINCisJCXsxNDgwQ0Y1Ri00MTYwLTQ3QjUtQTBFNi05NkFFQzgyNThGQjV9LlJlbGVhc2V8V2lu MzIuQnVpbGQuMCA9IFJlbGVhc2V8V2luMzINCiAJRW5kR2xvYmFsU2VjdGlvbg0KIAlHbG9iYWxT ZWN0aW9uKFNvbHV0aW9uUHJvcGVydGllcykgPSBwcmVTb2x1dGlvbg0KIAkJSGlkZVNvbHV0aW9u Tm9kZSA9IEZBTFNFDQpAQCAtNDcyLDUgKzQ4OSw2IEBAIEdsb2JhbAogCQl7Q0JDMzM5MUMtRjA2 MC00QkY1LUE2NkUtODE0MDQxNjg4MTZCfSA9IHs2MkRDREZFNC1FQUQyLTQ4RTEtQTJCRC1CRDU0 QUQzQzc0NTl9DQogCQl7NDM0M0JDMEItQTJFMC00QjQ4LTgyNzctRjMzQ0ZCRkE4M0NEfSA9IHs2 MkRDREZFNC1FQUQyLTQ4RTEtQTJCRC1CRDU0QUQzQzc0NTl9DQogCQl7M0I5OTY2OUItMTgxNy00 NDNCLUJDQkUtODM1NTgwMTQ2NjY4fSA9IHs2MkRDREZFNC1FQUQyLTQ4RTEtQTJCRC1CRDU0QUQz Qzc0NTl9DQorCQl7MTQ4MENGNUYtNDE2MC00N0I1LUEwRTYtOTZBRUM4MjU4RkI1fSA9IHs2MkRD REZFNC1FQUQyLTQ4RTEtQTJCRC1CRDU0QUQzQzc0NTl9DQogCUVuZEdsb2JhbFNlY3Rpb24NCiBF bmRHbG9iYWwNCg==