42727 2010-07-21 00:41:15 -0700 The adoption agency doesn't properly attach() 2010-07-21 05:38:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 254150 0 abarth 2010-07-21 00:41:15 -0700 The adoption agency doesn't properly attach() 254152 1 62150 abarth 2010-07-21 00:44:07 -0700 Created attachment 62150 Patch 254215 2 62150 eric 2010-07-21 04:50:32 -0700 Comment on attachment 62150 Patch I think we want some version of parserAddChild which does attachment. I feel like we've needed it in more than this case. 254232 3 62150 commit-queue 2010-07-21 05:38:34 -0700 Comment on attachment 62150 Patch Clearing flags on attachment: 62150 Committed r63814: <http://trac.webkit.org/changeset/63814> 254233 4 commit-queue 2010-07-21 05:38:39 -0700 All reviewed patches have been landed. Closing bug. 62150 2010-07-21 00:44:07 -0700 2010-07-21 05:38:34 -0700 Patch bug-42727-20100721004406.patch text/plain 3484 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTUzN2Q0MjAxYTU3ZDJjZTkwZWFlOWE2ZDIzMWI5OWY4Njg4YjA1Zi4uODk3MDg5MjA0NzQ3NmQ4 NjI3OWQ1OWQxZjcwOTc0ZTY5NWM2MTRhYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwzMCBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFRoZSBhZG9wdGlvbiBhZ2VuY3kgZG9l c24ndCBwcm9wZXJseSBhdHRhY2goKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDI3MjcKKworICAgICAgICBUaGUgYWRvcHRpb24gYWdlbmN5IGlzIHRy YW5zbGl0ZXJhdGVkIHJhdGhlciBkaXJlY3RseSBmcm9tIHRoZSBzcGVjLAorICAgICAgICBidXQg aXQgbWlzc2VzIHNvbWUgb2YgdGhlIFdlYktpdC1zcGVjaWZpYyBtYWNoaW5hdGlvbnMsIHN1Y2gg YXMKKyAgICAgICAgYXR0YWNoaW5nIHRvIHRoZSByZW5kZXIgdHJlZS4KKworICAgICAgICBUaGUg YWxnb3JpdGhtLCBhcyB3cml0dGVuLCBpcyBhIG1pbm9yIGxheWVyIHZpb2xhdGlvbi4gIEkndmUg YWRkZWQgdG8KKyAgICAgICAgdGhlIHByb2JsZW0gYnkgY2FsbGluZyBhdHRhY2goKSBmcm9tIEhU TUxUcmVlQnVpbGRlciAoZXZlbiB0aG91Z2gKKyAgICAgICAgdGhhdCdzIHRoZSBqb2Igb2YgdGhl IEhUTUxDb25zdHJ1Y3Rpb25TaXRlKS4gIFdlJ2xsIG5lZWQgdG8gY2xlYW4gdXAKKyAgICAgICAg dGhlIGxheWVyaW5nIGEgYml0IGF0IHNvbWUgcG9pbnQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBo YWxmIGZpeGVzIGZhc3QvZm9ybXMvZm9ybW1vdmUzLmh0bWwuICBIb3BlZnVsbHkgSSdsbCBmaW5p c2gKKyAgICAgICAgZml4aW5nIGl0IGluIHRoZSBuZXh0IHBhdGNoLgorCisgICAgICAgICogaHRt bC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ29uc3Ry dWN0aW9uU2l0ZTo6Y3JlYXRlSFRNTEVsZW1lbnRGcm9tU2F2ZWRFbGVtZW50KToKKyAgICAgICAg KiBodG1sL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1 aWxkZXI6OmNhbGxUaGVBZG9wdGlvbkFnZW5jeSk6CisKKzIwMTAtMDctMjEgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKwogICAgICAgICA8aW5wdXQ+IGVsZW1lbnRzIHdpdGggbm8gdHlwZSBhdHRyaWJ1dGUgc2hv dWxkIGJlIGZvc3RlciBwYXJlbnRlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDI3MjUKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxDb25z dHJ1Y3Rpb25TaXRlLmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAK aW5kZXggYjg1NTkwZWE2ZGJmMTJhOGYxZTNkNDk0MmJkN2MwNDZiZDkzN2EwYi4uMTNhNmQzNjY0 NWM5YzdmNWZkNTdmY2ZiODk5ZjM4NWIyYWZiMzI4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1s L0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTENvbnN0cnVj dGlvblNpdGUuY3BwCkBAIC0zNDEsNyArMzQxLDcgQEAgUGFzc1JlZlB0cjxFbGVtZW50PiBIVE1M Q29uc3RydWN0aW9uU2l0ZTo6Y3JlYXRlSFRNTEVsZW1lbnRGcm9tU2F2ZWRFbGVtZW50KEVsZW0K ICAgICAvLyBGSVhNRTogVGhpcyBtZXRob2QgaXMgd3JvbmcuICBXZSBzaG91bGQgYmUgdXNpbmcg dGhlIG9yaWdpbmFsIHRva2VuLgogICAgIC8vIFVzaW5nIGFuIEVsZW1lbnQqIGNhdXNlcyB1cyB0 byBmYWlsIGV4YW1wbGVzIGxpa2UgdGhpczoKICAgICAvLyA8YiBpZD0iMSI+PHA+PHNjcmlwdD5k b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiMSIpLmlkID0gIjIiPC9zY3JpcHQ+PC9wPlRFWFQ8L2I+ Ci0gICAgLy8gV2hlbiByZWNvbnN0cnVjdEFjdGl2ZUZvcm1hdHRpbmdFbGVtZW50cyBjYWxscyB0 aGlzIG1ldGhvZCB0byBvcGVuCisgICAgLy8gV2hlbiByZWNvbnN0cnVjdFRoZUFjdGl2ZUZvcm1h dHRpbmdFbGVtZW50cyBjYWxscyB0aGlzIG1ldGhvZCB0byBvcGVuCiAgICAgLy8gYSBzZWNvbmQg PGI+IHRhZyB0byB3cmFwIFRFWFQsIGl0IHdpbGwgaGF2ZSBpZCAiMiIsIGV2ZW4gdGhvdWdoIHRo ZSBIVE1MNQogICAgIC8vIHNwZWMgaW1wbGllcyBpdCBzaG91bGQgYmUgIjEiLiAgTWluZWZpZWxk IG1hdGNoZXMgdGhlIEhUTUw1IHNwZWMgaGVyZS4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1s L0hUTUxUcmVlQnVpbGRlci5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcApp bmRleCBmN2Y4NTczZmE4ZmY4NjRlMDMyY2QxYjZkZDUxM2I3MzgwYzk5MWJjLi5kNjU5NWE0YmI1 Njk2ZTRlMzRkYWQyOWMxMTAyYmFkZWVjZDAzMGJjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwv SFRNTFRyZWVCdWlsZGVyLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNw cApAQCAtMTcxMiw3ICsxNzEyLDE1IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpjYWxsVGhlQWRv cHRpb25BZ2VuY3koQXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICAgICAgLy8gOQogICAgICAg ICByZXBhcmVudENoaWxkcmVuKGZ1cnRoZXN0QmxvY2stPmVsZW1lbnQoKSwgbmV3RWxlbWVudC5n ZXQoKSk7CiAgICAgICAgIC8vIDEwCi0gICAgICAgIGZ1cnRoZXN0QmxvY2stPmVsZW1lbnQoKS0+ cGFyc2VyQWRkQ2hpbGQobmV3RWxlbWVudCk7CisgICAgICAgIEVsZW1lbnQqIGZ1cnRoZXN0Qmxv Y2tFbGVtZW50ID0gZnVydGhlc3RCbG9jay0+ZWxlbWVudCgpOworICAgICAgICAvLyBGSVhNRTog QWxsIHRoaXMgY3JlYXRpb24gLyBwYXJzZXJBZGRDaGlsZCAvIGF0dGFjaCBidXNpbmVzcyBzaG91 bGQKKyAgICAgICAgLy8gICAgICAgIGJlIGluIEhUTUxDb25zdHJ1Y3Rpb25TaXRlLiAgTXkgZ3Vl c3MgaXMgdGhhdCBzdGVwcyA4LS0xMgorICAgICAgICAvLyAgICAgICAgc2hvdWxkIGFsbCBiZSBp biBzb21lIEhUTUxDb25zdHJ1Y3Rpb25TaXRlIGZ1bmN0aW9uLgorICAgICAgICBmdXJ0aGVzdEJs b2NrRWxlbWVudC0+cGFyc2VyQWRkQ2hpbGQobmV3RWxlbWVudCk7CisgICAgICAgIGlmIChmdXJ0 aGVzdEJsb2NrRWxlbWVudC0+YXR0YWNoZWQoKSkgeworICAgICAgICAgICAgQVNTRVJUKCFuZXdF bGVtZW50LT5hdHRhY2hlZCgpKTsKKyAgICAgICAgICAgIG5ld0VsZW1lbnQtPmF0dGFjaCgpOwor ICAgICAgICB9CiAgICAgICAgIC8vIDExCiAgICAgICAgIG1fdHJlZS5hY3RpdmVGb3JtYXR0aW5n RWxlbWVudHMoKS0+cmVtb3ZlKGZvcm1hdHRpbmdFbGVtZW50KTsKICAgICAgICAgbV90cmVlLmFj dGl2ZUZvcm1hdHRpbmdFbGVtZW50cygpLT5pbnNlcnRBdChuZXdFbGVtZW50LmdldCgpLCBib29r bWFyayk7Cg==