42715 2010-07-20 16:36:39 -0700 [chromium] by default, dumpAsText should disable pixel results 2010-07-20 18:29:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony commit-queue tkent oldest_to_newest 254064 0 tony 2010-07-20 16:36:39 -0700 [chromium] by default, dumpAsText should disable pixel results 254065 1 62133 tony 2010-07-20 16:37:26 -0700 Created attachment 62133 Patch 254067 2 tony 2010-07-20 16:38:47 -0700 This matches the behavior here: http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/LayoutTestController.cpp#L107 254093 3 62133 tkent 2010-07-20 18:10:28 -0700 Comment on attachment 62133 Patch Oh, this is why we have a lot of MISSING failures. http://trac.webkit.org/changeset/63536 made this problem. 254099 4 62133 commit-queue 2010-07-20 18:29:26 -0700 Comment on attachment 62133 Patch Clearing flags on attachment: 62133 Committed r63796: <http://trac.webkit.org/changeset/63796> 254100 5 commit-queue 2010-07-20 18:29:31 -0700 All reviewed patches have been landed. Closing bug. 62133 2010-07-20 16:37:26 -0700 2010-07-20 18:29:25 -0700 Patch bug-42715-20100720163735.patch text/plain 1457 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYTQyNjM5NDM3MTE1NzQ4ODcwMjkwZDkxYjUxNDA3NzI2OTJhOTlkLi43YTAzZDRl ZmY0ODYyMWQ1ODZmNjEzMTk5NTM4ZGQ3YWIzYTFhNzBmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDctMjAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGJ5IGRlZmF1 bHQsIGR1bXBBc1RleHQgc2hvdWxkIGRpc2FibGUgcGl4ZWwgcmVzdWx0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI3MTUKKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KExheW91dFRlc3RDb250cm9sbGVyOjpkdW1wQXNUZXh0KTogZGlzYWJsZSBwaXhlbCByZXN1bHRz LCBidXQgYWxsb3cgSlMgdG8gb3ZlcnJpZGUKKwogMjAxMC0wNy0yMCAgSm9zZXBoIFBlY29yYXJv ICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdh cmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5 b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDBhMDZjMTlhODZkYzc5ZGFiM2E2OWEw NTkzOGY4ZmFkZDk0MzVhMTIuLmVhMWZkMDE5OGMyZmFlMjRlZTBiYjcxMTkzODVkZDcxNWZjYTJi MWQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91 dFRlc3RDb250cm9sbGVyLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKQEAgLTIzMyw2ICsyMzMsNyBAQCB2b2lkIExh eW91dFRlc3RDb250cm9sbGVyOjpXb3JrUXVldWU6OmFkZFdvcmsoV29ya0l0ZW0qIHdvcmspCiB2 b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpkdW1wQXNUZXh0KGNvbnN0IENwcEFyZ3VtZW50TGlz dCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiB7CiAgICAgbV9kdW1wQXNUZXh0ID0g dHJ1ZTsKKyAgICBtX2dlbmVyYXRlUGl4ZWxSZXN1bHRzID0gZmFsc2U7CiAKICAgICAvLyBPcHRp b25hbCBwYXJhbWF0ZXIsIGRlc2NyaWJpbmcgd2hldGhlciBpdCdzIGFsbG93ZWQgdG8gZHVtcCBw aXhlbCByZXN1bHRzIGluIGR1bXBBc1RleHQgbW9kZS4KICAgICBpZiAoYXJndW1lbnRzLnNpemUo KSA+IDAgJiYgYXJndW1lbnRzWzBdLmlzQm9vbCgpKQo=