42682 2010-07-20 15:12:45 -0700 WebKitTestRunner needs layoutTestController.setPOSIXLocale 2011-01-28 19:31:25 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned abarth eric mjs webkit.review.bot oldest_to_newest 253961 0 sam 2010-07-20 15:12:45 -0700 WebKitTestRunner needs layoutTestController.setPOSIXLocale 254017 1 sam 2010-07-20 15:32:35 -0700 <rdar://problem/8213862> 341894 2 80529 mjs 2011-01-28 17:36:41 -0800 Created attachment 80529 Patch 341908 3 80529 darin 2011-01-28 17:59:05 -0800 Comment on attachment 80529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80529&action=review > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:378 > + JSStringGetUTF8CString(locale, localeBuf, sizeof(localeBuf)); > + setlocale(LC_ALL, localeBuf); Would be nicer to safely do nothing if JSStringGetUTF8CString fails. 341926 4 mjs 2011-01-28 18:25:54 -0800 Committed r77042: <http://trac.webkit.org/changeset/77042> 341958 5 webkit.review.bot 2011-01-28 19:31:25 -0800 http://trac.webkit.org/changeset/77042 might have broken GTK Linux 64-bit Debug 80529 2011-01-28 17:36:41 -0800 2011-01-28 17:59:05 -0800 Patch bug-42682-20110128173640.patch text/plain 5501 mjs SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc3MDM2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDEtMjggIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXRU ZXN0UnVubmVyIG5lZWRzIGxheW91dFRlc3RDb250cm9sbGVyLnNldFBPU0lYTG9jYWxlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjY4MgorCisgICAg ICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0 Q29udHJvbGxlci5pZGw6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRs ZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAgICAgIChXVFI6OkluamVjdGVkQnVuZGxlOjpyZXNl dExvY2FsU2V0dGluZ3MpOgorICAgICAgICAoV1RSOjpJbmplY3RlZEJ1bmRsZTo6ZGlkUmVjZWl2 ZU1lc3NhZ2UpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5q ZWN0ZWRCdW5kbGUuaDoKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0xheW91dFRlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6TGF5b3V0VGVzdENvbnRy b2xsZXI6OnNldFBPU0lYTG9jYWxlKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmg6CisKIDIwMTEtMDEtMjggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vODkz MDY5OT4gYnVpbGQtd2Via2l0IGdpdmVzIGEgYm9ndXMgd2FybmluZyB3aXRoIG5ld2VyIHZlcnNp b25zIG9mIFhjb2RlIApJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRs ZS9JbmplY3RlZEJ1bmRsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAJKHJldmlzaW9uIDc2OTE5KQorKysg VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExOCw2ICsxMTgsMTEgQEAgSW5qZWN0ZWRCdW5kbGVQYWdlKiBJ bmplY3RlZEJ1bmRsZTo6cGFnZQogICAgIHJldHVybiBtX3BhZ2VzWzBdLmdldCgpOwogfQogCit2 b2lkIEluamVjdGVkQnVuZGxlOjpyZXNldExvY2FsU2V0dGluZ3MoKQoreworICAgIHNldGxvY2Fs ZShMQ19BTEwsICIiKTsKK30KKwogdm9pZCBJbmplY3RlZEJ1bmRsZTo6ZGlkUmVjZWl2ZU1lc3Nh Z2UoV0tTdHJpbmdSZWYgbWVzc2FnZU5hbWUsIFdLVHlwZVJlZiBtZXNzYWdlQm9keSkKIHsKICAg ICBpZiAoV0tTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhtZXNzYWdlTmFtZSwgIkJlZ2luVGVz dCIpKSB7CkBAIC0xMzEsNiArMTM2LDkgQEAgdm9pZCBJbmplY3RlZEJ1bmRsZTo6ZGlkUmVjZWl2 ZU1lc3NhZ2UoVwogICAgICAgICByZXR1cm47CiAgICAgfSBlbHNlIGlmIChXS1N0cmluZ0lzRXF1 YWxUb1VURjhDU3RyaW5nKG1lc3NhZ2VOYW1lLCAiUmVzZXQiKSkgewogICAgICAgICBtX3N0YXRl ID0gSWRsZTsKKworICAgICAgICByZXNldExvY2FsU2V0dGluZ3MoKTsKKwogICAgICAgICByZXR1 cm47CiAgICAgfQogCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0luamVjdGVkQnVuZGxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5oCShyZXZpc2lvbiA3NjkxOSkKKysrIFRvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtODIsNiArODIsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgZGlkSW5pdGlhbGl6 ZVBhZ2VHcm91cChXS0J1bmRsZVBhZ2VHcm91cFJlZik7CiAgICAgdm9pZCBkaWRSZWNlaXZlTWVz c2FnZShXS1N0cmluZ1JlZiBtZXNzYWdlTmFtZSwgV0tUeXBlUmVmIG1lc3NhZ2VCb2R5KTsKIAor ICAgIHZvaWQgcmVzZXRMb2NhbFNldHRpbmdzKCk7CisKICAgICB2b2lkIGJlZ2luVGVzdGluZygp OwogCiAgICAgV0tCdW5kbGVSZWYgbV9idW5kbGU7CkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVu bmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9s bGVyLmNwcAkocmV2aXNpb24gNzY5MTkpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcx LDQgKzM3MSwxMSBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpldmFsdWF0ZVNjcmlwCiAg ICAgSlNFdmFsdWF0ZVNjcmlwdChqc0NvbnRleHQsIHNjcmlwdCwgMCwgMCwgMCwgMCk7IAogfQog Cit2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRQT1NJWExvY2FsZShKU1N0cmluZ1JlZiBs b2NhbGUpCit7CisgICAgY2hhciBsb2NhbGVCdWZbMzJdOworICAgIEpTU3RyaW5nR2V0VVRGOENT dHJpbmcobG9jYWxlLCBsb2NhbGVCdWYsIHNpemVvZihsb2NhbGVCdWYpKTsKKyAgICBzZXRsb2Nh bGUoTENfQUxMLCBsb2NhbGVCdWYpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXVFIKSW5kZXg6IFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xh eW91dFRlc3RDb250cm9sbGVyLmgJKHJldmlzaW9uIDc2OTE5KQorKysgVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMzEsNiArMTMxLDggQEAgcHVibGljOgogICAgIHZvaWQgZXZhbHVhdGVJbldlYklu c3BlY3Rvcihsb25nIGNhbGxJZCwgSlNTdHJpbmdSZWYgc2NyaXB0KTsKICAgICB2b2lkIHNldFRp bWVsaW5lUHJvZmlsaW5nRW5hYmxlZChib29sKTsKIAorICAgIHZvaWQgc2V0UE9TSVhMb2NhbGUo SlNTdHJpbmdSZWYpOworCiBwcml2YXRlOgogICAgIHN0YXRpYyBjb25zdCBkb3VibGUgd2FpdFRv RHVtcFdhdGNoZG9nVGltZXJJbnRlcnZhbDsKIApJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxlci5pZGwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9M YXlvdXRUZXN0Q29udHJvbGxlci5pZGwJKHJldmlzaW9uIDc2OTE5KQorKysgVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxlci5p ZGwJKHdvcmtpbmcgY29weSkKQEAgLTg1LDYgKzg1LDggQEAgbW9kdWxlIFdUUiB7CiAgICAgICAg IHZvaWQgY2xvc2VXZWJJbnNwZWN0b3IoKTsKICAgICAgICAgdm9pZCBldmFsdWF0ZUluV2ViSW5z cGVjdG9yKGluIGxvbmcgY2FsbElELCBpbiBET01TdHJpbmcgc2NyaXB0KTsKICAgICAgICAgdm9p ZCBzZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQoaW4gYm9vbGVhbiBlbmFibGVkKTsKKworICAg ICAgICB2b2lkIHNldFBPU0lYTG9jYWxlKGluIERPTVN0cmluZyBsb2NhbGUpOwogICAgIH07CiAK IH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3MDM2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMjggIE1hY2llaiBTdGFjaG93 aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIGxheW91dFRlc3RDb250cm9sbGVy LnNldFBPU0lYTG9jYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MjY4MgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkOgorCiAy MDExLTAxLTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQ7IEZpeGVkIENocm9taXVtIHRlc3QgZXhwZWN0YXRpb24uCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkCShyZXZpc2lvbiA3NjkxOSkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMTU3MiwxMSArMTU3 Miw2IEBAIGh0dHAvdGVzdHMvc2VjdXJpdHkvbG9jYWwtdXNlci1DU1MtZnJvbS0KICMgPGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjY3OT4gCiBmYXN0L2xvYWRlci91 c2VyLXN0eWxlc2hlZXQtZmFzdC1wYXRoLmh0bWwKIAotIyBXZWJLaXRUZXN0UnVubmVyIG5lZWRz IGxheW91dFRlc3RDb250cm9sbGVyLnNldFBPU0lYTG9jYWxlCi0jIDxodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2ODI+Ci1mYXN0L2Nzcy9vcGFjaXR5LWZsb2F0Lmh0 bWwKLWZhc3QvanMvbmF2aWdhdG9yLWxhbmd1YWdlLmh0bWwKLQogIyBXZWJLaXRUZXN0UnVubmVy IG5lZWRzIGxheW91dFRlc3RDb250cm9sbGVyLnNldENhY2hlTW9kZWwKICMgPGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjY4ND4KIGZhc3QvZG9tL0hUTUxTY3JpcHRF bGVtZW50L25lc3RlZC1leGVjdXRpb24uaHRtbAo=