42677 2010-07-20 15:01:31 -0700 Chrome browser Bug: Pause button stays when <audio> hits end 2010-07-27 08:06:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=21739 P2 Normal --- 0 pranavk webkit-unassigned ajwong commit-queue dimich pranavk oldest_to_newest 253944 0 pranavk 2010-07-20 15:01:31 -0700 This is a copy of bug 21739 on Chrome browser. Please see http://code.google.com/p/chromium/issues/detail?id=21739. Here is the description taken from the bug 21739: In chrome browser, go to http://en.wikipedia.org/wiki/The_Star-Spangled_Banner and click "play" on one of the media files (right hand side of screen). Notice that when the file hits the end, the "pause" button stays a "pause" button rather than turning into "play". This seems kinda broken. (I would expect the slider to return to the beginning and the button to turn to "play"). The fix of this bug is in WebKit/WebCore/rendering/RenderMediaControlsChromium.cpp. Hence filing this bug. Here is the diff of the fix: pranavk@pranavk-l1:/usr/local/google/home/pranavk/chrome/src/third_party/WebKit/WebCore$ svn diff Index: rendering/RenderMediaControlsChromium.cpp =================================================================== --- rendering/RenderMediaControlsChromium.cpp (revision 62294) +++ rendering/RenderMediaControlsChromium.cpp (working copy) @@ -96,7 +96,7 @@ if (!hasSource(mediaElement)) return paintMediaButton(paintInfo.context, rect, mediaPlayDisabled); - return paintMediaButton(paintInfo.context, rect, mediaElement->paused() ? mediaPlay : mediaPause); + return paintMediaButton(paintInfo.context, rect, mediaElement->canPlay() ? mediaPlay : mediaPause); } static Image* getMediaSliderThumb() pranavk@pranavk-l1:/usr/local/google/home/pranavk/chrome/src/third_party/WebKit/WebCore$ 255031 1 62352 pranavk 2010-07-22 15:57:50 -0700 Created attachment 62352 Proposed patch. 255082 2 62363 pranavk 2010-07-22 17:06:30 -0700 Created attachment 62363 New patch based on feedback. 255086 3 62363 dimich 2010-07-22 17:13:31 -0700 Comment on attachment 62363 New patch based on feedback. > Index: rendering/RenderMediaControlsChromium.cpp It seems the patch was created while current directory was different from the root WebKit one. I'm not sure commit-queue will be able to deal with it. Please re-submit patch created from WebKit root (where WebCore is a subdir) 255113 4 pranavk 2010-07-22 17:44:24 -0700 This proposed fix has been taken from the function MediaControlPlayButtonElement::updateDisplayType() in http://trac.webkit.org/browser/trunk/WebCore/rendering/MediaControlElements.cpp 256281 5 62620 pranavk 2010-07-26 15:25:04 -0700 Created attachment 62620 New revised patch after fresh enlistment in WebKit. The path issues should be resolved. 256587 6 62620 abarth 2010-07-27 07:50:58 -0700 Comment on attachment 62620 New revised patch after fresh enlistment in WebKit. The path issues should be resolved. Nice. Thanks. Do we need to update the test_expectations.txt? 256600 7 62620 commit-queue 2010-07-27 08:06:30 -0700 Comment on attachment 62620 New revised patch after fresh enlistment in WebKit. The path issues should be resolved. Clearing flags on attachment: 62620 Committed r64128: <http://trac.webkit.org/changeset/64128> 256601 8 commit-queue 2010-07-27 08:06:35 -0700 All reviewed patches have been landed. Closing bug. 62352 2010-07-22 15:57:50 -0700 2010-07-22 17:06:30 -0700 Proposed patch. Bug42677Patch.txt text/plain 1541 pranavk SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYzOTE3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDct MjIgIFByYW5hdiBLZWRpYSAgPHByYW5hdmtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9tZSBicm93c2VyIEJ1ZzogUGF1 c2UgYnV0dG9uIHN0YXlzIHdoZW4gPGF1ZGlvPiBoaXRzIGVuZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2NzcKKworICAgICAgICBUaGUgY2hhbmdl IGlzIGp1c3QgaW4gY2hyb21pdW0gbWVkaWEuIFRlc3RlZCB1c2luZyBtZWRpYSBwYXJ0IG9mCisJ V2ViS2l0IGxheW91dCB0ZXN0cy4gQWxsIHBhc3NpbmcgdGVzdHMgcGFzcy4gVGhlIGZvbGxvd2lu ZyB0ZXN0IHRoYXQKKwl3YXMgZmFpbGluZyBpcyBhbHNvIHBhc3NpbmcuCisJbWVkaWEvdmlkZW8t ZHVyYXRpb24ta25vd24tYWZ0ZXItZW9zLmh0bWwgLT4gdW5leHBlY3RlZCBwYXNzCisKKyAgICAg ICAgKiAuLi8uLi8uLi9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250cm9sc0Nocm9taXVtLmNwcDoK KwlVc2luZyBtZWRpYUVsZW1lbnQtPmNhblBsYXkoKSBpbnN0ZWFkIG9mIG1lZGlhRWxlbWVudC0+ cGF1c2VkKCkgdG8KKwlwYWludCB0aGUgcGxheS9wYXVzZSBidXR0b24uCisKIDIwMTAtMDctMjIg IEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBMYXN6bG8gR29tYm9zLgpJbmRleDogcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHND aHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHND aHJvbWl1bS5jcHAJKHJldmlzaW9uIDYyMjk0KQorKysgcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29u dHJvbHNDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDcgKzk2LDcgQEAgc3RhdGlj IGJvb2wgcGFpbnRNZWRpYVBsYXlCdXR0b24oUmVuZGVyTwogICAgIGlmICghaGFzU291cmNlKG1l ZGlhRWxlbWVudCkpCiAgICAgICAgIHJldHVybiBwYWludE1lZGlhQnV0dG9uKHBhaW50SW5mby5j b250ZXh0LCByZWN0LCBtZWRpYVBsYXlEaXNhYmxlZCk7CiAKLSAgICByZXR1cm4gcGFpbnRNZWRp YUJ1dHRvbihwYWludEluZm8uY29udGV4dCwgcmVjdCwgbWVkaWFFbGVtZW50LT5wYXVzZWQoKSA/ IG1lZGlhUGxheSA6IG1lZGlhUGF1c2UpOworICAgIHJldHVybiBwYWludE1lZGlhQnV0dG9uKHBh aW50SW5mby5jb250ZXh0LCByZWN0LCBtZWRpYUVsZW1lbnQtPmNhblBsYXkoKSA/IG1lZGlhUGxh eSA6IG1lZGlhUGF1c2UpOwogfQogCiBzdGF0aWMgSW1hZ2UqIGdldE1lZGlhU2xpZGVyVGh1bWIo KQo= 62363 2010-07-22 17:06:30 -0700 2010-07-26 15:25:04 -0700 New patch based on feedback. Bug42677Patch_2.txt text/plain 1532 pranavk SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYzOTE3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDct MjIgIFByYW5hdiBLZWRpYSAgPHByYW5hdmtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9taXVtIEJ1ZzogUGF1c2UgYnV0 dG9uIHN0YXlzIHdoZW4gPGF1ZGlvPiBoaXRzIGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2NzcKKworICAgICAgICBUaGUgY2hhbmdlIGlzIGp1 c3QgaW4gY2hyb21pdW0gbWVkaWEuIFRlc3RlZCB1c2luZyBtZWRpYSBwYXJ0IG9mCisgICAgICAg IFdlYktpdCBsYXlvdXQgdGVzdHMuIFRoZSBmb2xsb3dpbmcgdGVzdCB0aGF0IHdhcyBmYWlsaW5n IGlzIHBhc3NpbmcuCisgICAgICAgIG1lZGlhL3ZpZGVvLWR1cmF0aW9uLWtub3duLWFmdGVyLWVv cy5odG1sIC0+IHVuZXhwZWN0ZWQgcGFzcworCisgICAgICAgICogLi4vLi4vLi4vcmVuZGVyaW5n L1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHA6CisgICAgICAgIFVzaW5nIG1lZGlhRWxl bWVudC0+Y2FuUGxheSgpIGluc3RlYWQgb2YgbWVkaWFFbGVtZW50LT5wYXVzZWQoKSB0bworICAg ICAgICBwYWludCB0aGUgcGxheS9wYXVzZSBidXR0b24uCisKIDIwMTAtMDctMjIgIEFudG9uaW8g R29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6 bG8gR29tYm9zLgpJbmRleDogcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5j cHAJKHJldmlzaW9uIDYyMjk0KQorKysgcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJv bWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDcgKzk2LDcgQEAgc3RhdGljIGJvb2wgcGFp bnRNZWRpYVBsYXlCdXR0b24oUmVuZGVyTwogICAgIGlmICghaGFzU291cmNlKG1lZGlhRWxlbWVu dCkpCiAgICAgICAgIHJldHVybiBwYWludE1lZGlhQnV0dG9uKHBhaW50SW5mby5jb250ZXh0LCBy ZWN0LCBtZWRpYVBsYXlEaXNhYmxlZCk7CiAKLSAgICByZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbihw YWludEluZm8uY29udGV4dCwgcmVjdCwgbWVkaWFFbGVtZW50LT5wYXVzZWQoKSA/IG1lZGlhUGxh eSA6IG1lZGlhUGF1c2UpOworICAgIHJldHVybiBwYWludE1lZGlhQnV0dG9uKHBhaW50SW5mby5j b250ZXh0LCByZWN0LCBtZWRpYUVsZW1lbnQtPmNhblBsYXkoKSA/IG1lZGlhUGxheSA6IG1lZGlh UGF1c2UpOwogfQogCiBzdGF0aWMgSW1hZ2UqIGdldE1lZGlhU2xpZGVyVGh1bWIoKQo= 62620 2010-07-26 15:25:04 -0700 2010-07-27 08:06:30 -0700 New revised patch after fresh enlistment in WebKit. The path issues should be resolved. Bug42677Patch3.txt text/plain 1622 pranavk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDA4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDctMjYgIFByYW5hdiBLZWRpYSAgPHByYW5hdmtAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENocm9tZSBicm93c2VyIEJ1ZzogUGF1c2UgYnV0dG9uIHN0YXlzIHdoZW4gPGF1ZGlvPiBoaXRz IGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2 NzcKKworICAgICAgICBUaGUgY2hhbmdlIGlzIGp1c3QgaW4gY2hyb21pdW0gbWVkaWEuIFRlc3Rl ZCB1c2luZyBtZWRpYSBwYXJ0IG9mCisgICAgICAgIFdlYktpdCBsYXlvdXQgdGVzdHMuIFRoZSBm b2xsb3dpbmcgdGVzdCB0aGF0IHdhcyBmYWlsaW5nIGlzIHBhc3NpbmcuCisgICAgICAgIG1lZGlh L3ZpZGVvLWR1cmF0aW9uLWtub3duLWFmdGVyLWVvcy5odG1sIC0+IHVuZXhwZWN0ZWQgcGFzcwor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpwYWludE1lZGlhUGxheUJ1dHRvbik6CisgICAgICAgIFVzaW5nIG1l ZGlhRWxlbWVudC0+Y2FuUGxheSgpIGluc3RlYWQgb2YgbWVkaWFFbGVtZW50LT5wYXVzZWQoKSB0 bworICAgICAgICBwYWludCB0aGUgcGxheS9wYXVzZSBidXR0b24uCisKIDIwMTAtMDctMjYgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFD b250cm9sc0Nocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA2NDA3NCkKKysrIFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTk2LDcgKzk2LDcgQEAgc3RhdGljIGJvb2wgcGFpbnRNZWRpYVBsYXlCdXR0b24oUmVuZGVy TwogICAgIGlmICghaGFzU291cmNlKG1lZGlhRWxlbWVudCkpCiAgICAgICAgIHJldHVybiBwYWlu dE1lZGlhQnV0dG9uKHBhaW50SW5mby5jb250ZXh0LCByZWN0LCBtZWRpYVBsYXlEaXNhYmxlZCk7 CiAKLSAgICByZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4dCwgcmVjdCwg bWVkaWFFbGVtZW50LT5wYXVzZWQoKSA/IG1lZGlhUGxheSA6IG1lZGlhUGF1c2UpOworICAgIHJl dHVybiBwYWludE1lZGlhQnV0dG9uKHBhaW50SW5mby5jb250ZXh0LCByZWN0LCBtZWRpYUVsZW1l bnQtPmNhblBsYXkoKSA/IG1lZGlhUGxheSA6IG1lZGlhUGF1c2UpOwogfQogCiBzdGF0aWMgSW1h Z2UqIGdldE1lZGlhU2xpZGVyVGh1bWIoKQo=