42654 2010-07-20 11:32:02 -0700 HTML5 tree builder needs to call dispatchDocumentElementAvailable 2010-07-20 14:59:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 253835 0 abarth 2010-07-20 11:32:02 -0700 HTML5 tree builder needs to call dispatchDocumentElementAvailable 253837 1 62095 abarth 2010-07-20 11:33:44 -0700 Created attachment 62095 Patch 253838 2 abarth 2010-07-20 11:35:13 -0700 The another option is to teach HTMLElementStack how to do this, but it doesn't have a notion of Document, so that seemed like it was too low a layer. Similarly, we could do this work in HTMLTreeBuilder, but there are a lot more call sites, so that seemed too high level. 253839 3 62095 eric 2010-07-20 11:42:46 -0700 Comment on attachment 62095 Patch This is definitely the right layer. I hate that we duplicate this is parsing fragment state partially in the fragment scripting enum. 253851 4 62095 commit-queue 2010-07-20 12:18:20 -0700 Comment on attachment 62095 Patch Clearing flags on attachment: 62095 Committed r63762: <http://trac.webkit.org/changeset/63762> 253852 5 commit-queue 2010-07-20 12:18:25 -0700 All reviewed patches have been landed. Closing bug. 253884 6 abarth 2010-07-20 13:15:10 -0700 > This is definitely the right layer. I hate that we duplicate this is parsing fragment state partially in the fragment scripting enum. Can we make the enum more awesome to include this bit? It does seem really redundantly redundant. 253938 7 eric 2010-07-20 14:53:00 -0700 The enums are semantically different, I think. One is used throughout the code to mean fragment stuff. I think that the parser should probably have a separate state machine enum and know how to convert to the more generic one. I'm not 100% sure. 253940 8 eric 2010-07-20 14:59:57 -0700 No, I take that back. I think we could add a "NotFragment" value to the enum. I think all parts in teh code will have his same problem (where they have both fragment and non-fragment code paths). Or we could go the other way and remove the "fragment" part from the name if we want it to generically mean some scripting disable functionality. 62095 2010-07-20 11:33:44 -0700 2010-07-20 12:18:20 -0700 Patch bug-42654-20100720113342.patch text/plain 5722 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTI5ZTlhOTNkZjgwOTYyNjQ4ZmI0NmFlMWFiZTJiODY0YmY3ZWRiMy4uYjQ0ZjdmMTc3YjEzZTcx YmMzZjY2ZDU5OGQ5YWNhMGZlMDQwYTZmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyNiBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEhUTUw1IHRyZWUgYnVpbGRlciBuZWVk cyB0byBjYWxsIGRpc3BhdGNoRG9jdW1lbnRFbGVtZW50QXZhaWxhYmxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjY1NAorCisgICAgICAgIFRoaXMg cGF0Y2ggZml4ZXMgdGhlIGZvbGxvdXQgTGF5b3V0VGVzdHMgd2l0aCAtLWh0bWw1LXRyZWVidWls ZGVyOgorICAgICAgICAgIC0gdXNlcnNjcmlwdHMvc2NyaXB0LW5vdC1ydW4tZm9yLWZyYWdtZW50 cy5odG1sCisgICAgICAgICAgLSB1c2Vyc2NyaXB0cy9zY3JpcHQtcnVuLWF0LXN0YXJ0Lmh0bWwK KworICAgICAgICAqIGh0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTENvbnN0cnVjdGlvblNpdGU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlKToKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpkaXNwYXRjaERvY3VtZW50RWxlbWVu dEF2YWlsYWJsZUlmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25T aXRlOjppbnNlcnRIVE1MSHRtbFN0YXJ0VGFnQmVmb3JlSFRNTCk6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0SFRNTEh0bWxFbGVtZW50KToKKyAgICAgICAg KiBodG1sL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmg6CisgICAgICAgICogaHRtbC9IVE1MVHJlZUJ1 aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpIVE1MVHJlZUJ1 aWxkZXIpOgorCisyMDEwLTA3LTIwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgSFRNTDUgdHJl ZSBidWlsZGVyIHNob3VsZCByZXN0b3JlIGZvcm0gc3RhdGUKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNjQ0CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv aHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTENvbnN0cnVj dGlvblNpdGUuY3BwCmluZGV4IDJkOWVhMTQyNzQ4OWNhMTZmYjJlY2VmNGE4NDZhNzIxZTQzZDZi YzYuLmI4NTU5MGVhNmRiZjEyYThmMWUzZDQ5NDJiZDdjMDQ2YmQ5MzdhMGIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKKysrIGIvV2ViQ29yZS9odG1s L0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcApAQCAtMTI5LDkgKzEyOSwxMCBAQCB2b2lkIEhUTUxD b25zdHJ1Y3Rpb25TaXRlOjphdHRhY2hBdFNpdGUoY29uc3QgQXR0YWNobWVudFNpdGUmIHNpdGUs IFBhc3NSZWZQdHI8TgogICAgICAgICBjaGlsZC0+YXR0YWNoKCk7CiB9CiAKLUhUTUxDb25zdHJ1 Y3Rpb25TaXRlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZShEb2N1bWVudCogZG9jdW1lbnQsIEZyYWdt ZW50U2NyaXB0aW5nUGVybWlzc2lvbiBzY3JpcHRpbmdQZXJtaXNzaW9uKQorSFRNTENvbnN0cnVj dGlvblNpdGU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlKERvY3VtZW50KiBkb2N1bWVudCwgRnJhZ21l bnRTY3JpcHRpbmdQZXJtaXNzaW9uIHNjcmlwdGluZ1Blcm1pc3Npb24sIGJvb2wgaXNQYXJzaW5n RnJhZ21lbnQpCiAgICAgOiBtX2RvY3VtZW50KGRvY3VtZW50KQogICAgICwgbV9mcmFnbWVudFNj cmlwdGluZ1Blcm1pc3Npb24oc2NyaXB0aW5nUGVybWlzc2lvbikKKyAgICAsIG1faXNQYXJzaW5n RnJhZ21lbnQoaXNQYXJzaW5nRnJhZ21lbnQpCiAgICAgLCBtX3JlZGlyZWN0QXR0YWNoVG9Gb3N0 ZXJQYXJlbnQoZmFsc2UpCiB7CiB9CkBAIC0xNDAsMTEgKzE0MSwxOCBAQCBIVE1MQ29uc3RydWN0 aW9uU2l0ZTo6fkhUTUxDb25zdHJ1Y3Rpb25TaXRlKCkKIHsKIH0KIAordm9pZCBIVE1MQ29uc3Ry dWN0aW9uU2l0ZTo6ZGlzcGF0Y2hEb2N1bWVudEVsZW1lbnRBdmFpbGFibGVJZk5lZWRlZCgpCit7 CisgICAgaWYgKG1fZG9jdW1lbnQtPmZyYW1lKCkgJiYgIW1faXNQYXJzaW5nRnJhZ21lbnQpCisg ICAgICAgIG1fZG9jdW1lbnQtPmZyYW1lKCktPmxvYWRlcigpLT5kaXNwYXRjaERvY3VtZW50RWxl bWVudEF2YWlsYWJsZSgpOworfQorCiB2b2lkIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNlcnRI VE1MSHRtbFN0YXJ0VGFnQmVmb3JlSFRNTChBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogewogICAg IFJlZlB0cjxFbGVtZW50PiBlbGVtZW50ID0gSFRNTEh0bWxFbGVtZW50OjpjcmVhdGUobV9kb2N1 bWVudCk7CiAgICAgZWxlbWVudC0+c2V0QXR0cmlidXRlTWFwKHRva2VuLnRha2VBdHJpYnV0ZXMo KSwgbV9mcmFnbWVudFNjcmlwdGluZ1Blcm1pc3Npb24pOwogICAgIG1fb3BlbkVsZW1lbnRzLnB1 c2hIVE1MSHRtbEVsZW1lbnQoYXR0YWNoKG1fZG9jdW1lbnQsIGVsZW1lbnQucmVsZWFzZSgpKSk7 CisgICAgZGlzcGF0Y2hEb2N1bWVudEVsZW1lbnRBdmFpbGFibGVJZk5lZWRlZCgpOwogfQogCiB2 b2lkIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjptZXJnZUF0dHJpYnV0ZXNGcm9tVG9rZW5JbnRvRWxl bWVudChBdG9taWNIVE1MVG9rZW4mIHRva2VuLCBFbGVtZW50KiBlbGVtZW50KQpAQCAtMjEwLDYg KzIxOCw3IEBAIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2VydEhUTUxIdG1sRWxlbWVu dChBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogewogICAgIEFTU0VSVCghc2hvdWxkRm9zdGVyUGFy ZW50KCkpOwogICAgIG1fb3BlbkVsZW1lbnRzLnB1c2hIVE1MSHRtbEVsZW1lbnQoYXR0YWNoVG9D dXJyZW50KGNyZWF0ZUhUTUxFbGVtZW50KHRva2VuKSkpOworICAgIGRpc3BhdGNoRG9jdW1lbnRF bGVtZW50QXZhaWxhYmxlSWZOZWVkZWQoKTsKIH0KIAogdm9pZCBIVE1MQ29uc3RydWN0aW9uU2l0 ZTo6aW5zZXJ0SFRNTEhlYWRFbGVtZW50KEF0b21pY0hUTUxUb2tlbiYgdG9rZW4pCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2h0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuaCBiL1dlYkNvcmUvaHRtbC9I VE1MQ29uc3RydWN0aW9uU2l0ZS5oCmluZGV4IGUyNDhhZjhmNDkxYThmM2I2NjBkY2Y3ZDA4OWQy ZDMyNzJjZTY4NzAuLjE3NjQzM2I4NmRmMjIxYjExODI2NDM5ODAyOWMyM2FkYTA1YTlmN2EgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCisrKyBiL1dlYkNv cmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCkBAIC00Miw3ICs0Miw3IEBAIGNsYXNzIEVs ZW1lbnQ7CiAKIGNsYXNzIEhUTUxDb25zdHJ1Y3Rpb25TaXRlIDogcHVibGljIE5vbmNvcHlhYmxl IHsKIHB1YmxpYzoKLSAgICBIVE1MQ29uc3RydWN0aW9uU2l0ZShEb2N1bWVudCosIEZyYWdtZW50 U2NyaXB0aW5nUGVybWlzc2lvbik7CisgICAgSFRNTENvbnN0cnVjdGlvblNpdGUoRG9jdW1lbnQq LCBGcmFnbWVudFNjcmlwdGluZ1Blcm1pc3Npb24sIGJvb2wgaXNQYXJzaW5nRnJhZ21lbnQpOwog ICAgIH5IVE1MQ29uc3RydWN0aW9uU2l0ZSgpOwogCiAgICAgdm9pZCBpbnNlcnREb2N0eXBlKEF0 b21pY0hUTUxUb2tlbiYpOwpAQCAtMTI0LDEzICsxMjQsMTYgQEAgcHJpdmF0ZToKICAgICBQYXNz UmVmUHRyPEVsZW1lbnQ+IGNyZWF0ZUVsZW1lbnQoQXRvbWljSFRNTFRva2VuJiwgY29uc3QgQXRv bWljU3RyaW5nJiBuYW1lc3BhY2VVUkkpOwogCiAgICAgdm9pZCBtZXJnZUF0dHJpYnV0ZXNGcm9t VG9rZW5JbnRvRWxlbWVudChBdG9taWNIVE1MVG9rZW4mLCBFbGVtZW50Kik7CisgICAgdm9pZCBk aXNwYXRjaERvY3VtZW50RWxlbWVudEF2YWlsYWJsZUlmTmVlZGVkKCk7CiAKICAgICBEb2N1bWVu dCogbV9kb2N1bWVudDsKICAgICBSZWZQdHI8RWxlbWVudD4gbV9oZWFkOwogICAgIFJlZlB0cjxF bGVtZW50PiBtX2Zvcm07CiAgICAgbXV0YWJsZSBIVE1MRWxlbWVudFN0YWNrIG1fb3BlbkVsZW1l bnRzOwogICAgIG11dGFibGUgSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdCBtX2FjdGl2ZUZvcm1h dHRpbmdFbGVtZW50czsKKwogICAgIEZyYWdtZW50U2NyaXB0aW5nUGVybWlzc2lvbiBtX2ZyYWdt ZW50U2NyaXB0aW5nUGVybWlzc2lvbjsKKyAgICBib29sIG1faXNQYXJzaW5nRnJhZ21lbnQ7CiAK ICAgICAvLyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3Jr L211bHRpcGFnZS90b2tlbml6YXRpb24uaHRtbCNwYXJzaW5nLW1haW4taW50YWJsZQogICAgIC8v IEluIHRoZSAiaW4gdGFibGUiIGluc2VydGlvbiBtb2RlLCB3ZSBzb21ldGltZXMgZ2V0IGludG8g YSBzdGF0ZSB3aGVyZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5j cHAgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcAppbmRleCAxOWU2N2RmN2I4MDll YTUxNzExM2ViMDRjZTJkYWNjMDYyNzdkOTMwLi4zY2RmYTYzODE5N2NiYzMxM2FhYzE4YjFjYTI1 NGFhYzU0N2I1M2IwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNw cAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcApAQCAtMzIwLDcgKzMyMCw3 IEBAIHByaXZhdGU6CiBIVE1MVHJlZUJ1aWxkZXI6OkhUTUxUcmVlQnVpbGRlcihIVE1MVG9rZW5p emVyKiB0b2tlbml6ZXIsIEhUTUxEb2N1bWVudCogZG9jdW1lbnQsIGJvb2wgcmVwb3J0RXJyb3Jz KQogICAgIDogbV9mcmFtZXNldE9rKHRydWUpCiAgICAgLCBtX2RvY3VtZW50KGRvY3VtZW50KQot ICAgICwgbV90cmVlKGRvY3VtZW50LCBGcmFnbWVudFNjcmlwdGluZ0FsbG93ZWQpCisgICAgLCBt X3RyZWUoZG9jdW1lbnQsIEZyYWdtZW50U2NyaXB0aW5nQWxsb3dlZCwgZmFsc2UpCiAgICAgLCBt X3JlcG9ydEVycm9ycyhyZXBvcnRFcnJvcnMpCiAgICAgLCBtX2lzUGF1c2VkKGZhbHNlKQogICAg ICwgbV9pbnNlcnRpb25Nb2RlKEluaXRpYWxNb2RlKQpAQCAtMzQwLDcgKzM0MCw3IEBAIEhUTUxU cmVlQnVpbGRlcjo6SFRNTFRyZWVCdWlsZGVyKEhUTUxUb2tlbml6ZXIqIHRva2VuaXplciwgSFRN TERvY3VtZW50KiBkb2N1bWVuCiBIVE1MVHJlZUJ1aWxkZXI6OkhUTUxUcmVlQnVpbGRlcihIVE1M VG9rZW5pemVyKiB0b2tlbml6ZXIsIERvY3VtZW50RnJhZ21lbnQqIGZyYWdtZW50LCBGcmFnbWVu dFNjcmlwdGluZ1Blcm1pc3Npb24gc2NyaXB0aW5nUGVybWlzc2lvbikKICAgICA6IG1fZnJhbWVz ZXRPayh0cnVlKQogICAgICwgbV9kb2N1bWVudChmcmFnbWVudC0+ZG9jdW1lbnQoKSkKLSAgICAs IG1fdHJlZShmcmFnbWVudC0+ZG9jdW1lbnQoKSwgc2NyaXB0aW5nUGVybWlzc2lvbikKKyAgICAs IG1fdHJlZShmcmFnbWVudC0+ZG9jdW1lbnQoKSwgc2NyaXB0aW5nUGVybWlzc2lvbiwgdHJ1ZSkK ICAgICAsIG1fcmVwb3J0RXJyb3JzKGZhbHNlKSAvLyBGSVhNRTogV2h5IG5vdCByZXBvcnQgZXJy b3JzIGluIGZyYWdtZW50cz8KICAgICAsIG1faXNQYXVzZWQoZmFsc2UpCiAgICAgLCBtX2luc2Vy dGlvbk1vZGUoSW5pdGlhbE1vZGUpCg==