42650 2010-07-20 10:30:47 -0700 Implement NPN_GetURL and NPN_PostURL 2010-07-20 10:51:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 253797 0 andersca 2010-07-20 10:30:47 -0700 Implement NPN_GetURL and NPN_PostURL 253802 1 62089 andersca 2010-07-20 10:32:46 -0700 Created attachment 62089 Patch 253810 2 webkit.review.bot 2010-07-20 10:38:44 -0700 Attachment 62089 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:263: NPN_GetURL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:274: NPN_PostURL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 253817 3 andersca 2010-07-20 10:51:05 -0700 Committed r63756: <http://trac.webkit.org/changeset/63756> 62089 2010-07-20 10:32:46 -0700 2010-07-20 10:42:53 -0700 Patch bug-42650-20100720103245.patch text/plain 5209 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjA0OGQ2NjI5YjMwOTgyZmZiMjA2Nzc4ZDY3ZDg5NGQ3ZDZiMTZlZC4uNzEyNjc2MjQ3YjhhM2Rh YWY1YzhiMmZmMDA3NzU1ZjBkNDA1NmVkMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMCBAQAorMjAxMC0wNy0yMCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBOUE5fR2V0VVJMIGFuZCBOUE5f UG9zdFVSTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDI2NTAKKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJy b3dzZXJGdW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBhcnNlUG9zdEJ1ZmZlcik6CisgICAg ICAgIEFkZCBhIEZJWE1FIGFib3V0IGRlbGV0aW5nIHRoZSBmaWxlLgorCisgICAgICAgIChXZWJL aXQ6Om1ha2VVUkxTdHJpbmcpOgorICAgICAgICBNb3ZlIHRoaXMgc3RhdGljIG1ldGhvZCBiZWZv cmUgTlBOX0dldFVSTC4KKworICAgICAgICAoV2ViS2l0OjpOUE5fR2V0VVJMKToKKyAgICAgICAg Q2FsbCBOZXRzY2FwZVBMdWdpbjo6TG9hZFVSTC4KKyAgICAgICAgCisgICAgICAgIChXZWJLaXQ6 Ok5QTl9Qb3N0VVJMKToKKyAgICAgICAgRGl0dG8uCisKKyAgICAgICAgKFdlYktpdDo6TlBOX1Bv c3RVUkxOb3RpZnkpOgorICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRz Y2FwZVBsdWdpblN0cmVhbS5jcHA6CisgICAgICAgIFJlbW92ZSB1bnJlYWNoZWQgY29kZS4KKwor ICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpblN0cmVhbTo6ZGVsaXZlckRhdGFUb1BsdWdp bik6CisgICAgICAgIFN0b3AgdGhlIHN0cmVhbSBpZiB0aGUgcGx1Zy1pbiByZXR1cm5zIC0xIGZy b20gTlBQX1dyaXRlLgorCiAyMDEwLTA3LTE5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBh L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNz LmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3Nl ckZ1bmNzLmNwcAppbmRleCAxYTZmNzA3NWM1N2U3NDRhYWYyYmNhYTNjYTk4YjJkNTU0ZmU1NGRm Li5kZjFiZWU3OTRhZTQ0NzU1MDJmYjE5YTVhOTM2MmNmMzI2YzdhNTJjIDEwMDY0NAotLS0gYS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5j cHAKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93 c2VyRnVuY3MuY3BwCkBAIC0yMDksNiArMjA5LDggQEAgc3RhdGljIE5QRXJyb3IgcGFyc2VQb3N0 QnVmZmVyKGJvb2wgaXNGaWxlLCBjb25zdCBjaGFyICpidWZmZXIsIHVpbnQzMl90IGxlbmd0aCwK IAogICAgICAgICBwb3N0QnVmZmVyID0gZmlsZUNvbnRlbnRzLT5kYXRhKCk7CiAgICAgICAgIHBv c3RCdWZmZXJTaXplID0gZmlsZUNvbnRlbnRzLT5zaXplKCk7CisKKyAgICAgICAgLy8gRklYTUU6 IFRoZSBOUEFQSSBzcGVjIHN0YXRlcyB0aGF0IHRoZSBmaWxlIHNob3VsZCBiZSBkZWxldGVkIGhl cmUuCiAgICAgfSBlbHNlIHsKICAgICAgICAgcG9zdEJ1ZmZlciA9IGJ1ZmZlcjsKICAgICAgICAg cG9zdEJ1ZmZlclNpemUgPSBsZW5ndGg7CkBAIC0yNDcsMTggKzI0OSw0NSBAQCBzdGF0aWMgTlBF cnJvciBwYXJzZVBvc3RCdWZmZXIoYm9vbCBpc0ZpbGUsIGNvbnN0IGNoYXIgKmJ1ZmZlciwgdWlu dDMyX3QgbGVuZ3RoLAogICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKIH0KIAotc3RhdGljIE5Q RXJyb3IgTlBOX0dldFVSTChOUFAgaW5zdGFuY2UsIGNvbnN0IGNoYXIqIHVybCwgY29uc3QgY2hh ciogdGFyZ2V0KQorc3RhdGljIFN0cmluZyBtYWtlVVJMU3RyaW5nKGNvbnN0IGNoYXIqIHVybCkK IHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBOUEVSUl9HRU5FUklDX0VSUk9S OworICAgIFN0cmluZyB1cmxTdHJpbmcodXJsKTsKKyAgICAKKyAgICAvLyBTdHJpcCByZXR1cm4g Y2hhcmFjdGVycy4KKyAgICB1cmxTdHJpbmcucmVwbGFjZSgnXHInLCAiIik7CisgICAgdXJsU3Ry aW5nLnJlcGxhY2UoJ1xuJywgIiIpOworCisgICAgcmV0dXJuIHVybFN0cmluZzsKIH0KIAotc3Rh dGljIE5QRXJyb3IgTlBOX1Bvc3RVUkwoTlBQIGluc3RhbmNlLCBjb25zdCBjaGFyKiB1cmwsIGNv bnN0IGNoYXIqIHRhcmdldCwgdWludDMyX3QgbGVuLCBjb25zdCBjaGFyKiBidWYsIE5QQm9vbCBm aWxlKQorc3RhdGljIE5QRXJyb3IgTlBOX0dldFVSTChOUFAgbnBwLCBjb25zdCBjaGFyKiB1cmws IGNvbnN0IGNoYXIqIHRhcmdldCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICgh dXJsKQorICAgICAgICByZXR1cm4gTlBFUlJfR0VORVJJQ19FUlJPUjsKKyAgICAKKyAgICBSZWZQ dHI8TmV0c2NhcGVQbHVnaW4+IHBsdWdpbiA9IE5ldHNjYXBlUGx1Z2luOjpmcm9tTlBQKG5wcCk7 CisgICAgcGx1Z2luLT5sb2FkVVJMKCJHRVQiLCBtYWtlVVJMU3RyaW5nKHVybCksIHRhcmdldCwg SFRUUEhlYWRlck1hcCgpLCBWZWN0b3I8Y2hhcj4oKSwgZmFsc2UsIDApOworICAgIAogICAgIHJl dHVybiBOUEVSUl9HRU5FUklDX0VSUk9SOwogfQogCitzdGF0aWMgTlBFcnJvciBOUE5fUG9zdFVS TChOUFAgbnBwLCBjb25zdCBjaGFyKiB1cmwsIGNvbnN0IGNoYXIqIHRhcmdldCwgdWludDMyX3Qg bGVuLCBjb25zdCBjaGFyKiBidWYsIE5QQm9vbCBmaWxlKQoreworICAgIEhUVFBIZWFkZXJNYXAg aGVhZGVyRmllbGRzOworICAgIFZlY3RvcjxjaGFyPiBwb3N0RGF0YTsKKyAgICAKKyAgICAvLyBO UE5fUG9zdFVSTCBvbmx5IGFsbG93cyBoZWFkZXJzIGlmIHRoZSBwb3N0IGJ1ZmZlciBwb2ludHMg dG8gYSBmaWxlLgorICAgIGJvb2wgcGFyc2VIZWFkZXJzID0gZmlsZTsKKworICAgIE5QRXJyb3Ig ZXJyb3IgPSBwYXJzZVBvc3RCdWZmZXIoZmlsZSwgYnVmLCBsZW4sIHBhcnNlSGVhZGVycywgaGVh ZGVyRmllbGRzLCBwb3N0RGF0YSk7CisgICAgaWYgKGVycm9yICE9IE5QRVJSX05PX0VSUk9SKQor ICAgICAgICByZXR1cm4gZXJyb3I7CisKKyAgICBSZWZQdHI8TmV0c2NhcGVQbHVnaW4+IHBsdWdp biA9IE5ldHNjYXBlUGx1Z2luOjpmcm9tTlBQKG5wcCk7CisgICAgcGx1Z2luLT5sb2FkVVJMKCJQ T1NUIiwgbWFrZVVSTFN0cmluZyh1cmwpLCB0YXJnZXQsIGhlYWRlckZpZWxkcywgcG9zdERhdGEs IGZhbHNlLCAwKTsKKyAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7Cit9CisKIHN0YXRpYyBOUEVy cm9yIE5QTl9SZXF1ZXN0UmVhZChOUFN0cmVhbSogc3RyZWFtLCBOUEJ5dGVSYW5nZSogcmFuZ2VM aXN0KQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CkBAIC0zMzQsMTcgKzM2Myw2IEBAIHN0YXRp YyBqcmVmIE5QTl9HZXRKYXZhUGVlcihOUFAgaW5zdGFuY2UpCiAgICAgcmV0dXJuIDA7CiB9CiAK LXN0YXRpYyBTdHJpbmcgbWFrZVVSTFN0cmluZyhjb25zdCBjaGFyKiB1cmwpCi17Ci0gICAgU3Ry aW5nIHVybFN0cmluZyh1cmwpOwotICAgIAotICAgIC8vIFN0cmlwIHJldHVybiBjaGFyYWN0ZXJz LgotICAgIHVybFN0cmluZy5yZXBsYWNlKCdccicsICIiKTsKLSAgICB1cmxTdHJpbmcucmVwbGFj ZSgnXG4nLCAiIik7Ci0KLSAgICByZXR1cm4gdXJsU3RyaW5nOwotfQotCiBzdGF0aWMgTlBFcnJv ciBOUE5fR2V0VVJMTm90aWZ5KE5QUCBucHAsIGNvbnN0IGNoYXIqIHVybCwgY29uc3QgY2hhciog dGFyZ2V0LCB2b2lkKiBub3RpZnlEYXRhKQogewogICAgIGlmICghdXJsKQpAQCAtMzY3LDkgKzM4 NSw2IEBAIHN0YXRpYyBOUEVycm9yIE5QTl9Qb3N0VVJMTm90aWZ5KE5QUCBucHAsIGNvbnN0IGNo YXIqIHVybCwgY29uc3QgY2hhciogdGFyZ2V0LCB1CiAgICAgUmVmUHRyPE5ldHNjYXBlUGx1Z2lu PiBwbHVnaW4gPSBOZXRzY2FwZVBsdWdpbjo6ZnJvbU5QUChucHApOwogICAgIHBsdWdpbi0+bG9h ZFVSTCgiUE9TVCIsIG1ha2VVUkxTdHJpbmcodXJsKSwgdGFyZ2V0LCBoZWFkZXJGaWVsZHMsIHBv c3REYXRhLCB0cnVlLCBub3RpZnlEYXRhKTsKICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7Ci0g ICAgCi0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gTlBFUlJfR0VORVJJQ19FUlJP UjsKIH0KIAogc3RhdGljIE5QRXJyb3IgTlBOX0dldFZhbHVlKE5QUCBucHAsIE5QTlZhcmlhYmxl IHZhcmlhYmxlLCB2b2lkICp2YWx1ZSkKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luU3RyZWFtLmNwcCBiL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luU3RyZWFtLmNwcAppbmRleCAwYzdh MWZiODY3YmEyNmJkZTk4ODBlM2QwN2ZmOGZkNzQ5MGNlMGYyLi41ZTVlMDQxZDBkNjAyMjNiYzgz ZDk1NGU3NjUwN2Y3MGJmN2I5NmY2IDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVhbS5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5TdHJlYW0uY3BwCkBAIC0yMjAs OCArMjIwLDggQEAgdm9pZCBOZXRzY2FwZVBsdWdpblN0cmVhbTo6ZGVsaXZlckRhdGFUb1BsdWdp bigpCiAKICAgICAgICAgaW50MzJfdCBudW1CeXRlc1dyaXR0ZW4gPSBtX3BsdWdpbi0+TlBQX1dy aXRlKCZtX25wU3RyZWFtLCBtX29mZnNldCwgZGF0YUxlbmd0aCwgZGF0YSk7CiAgICAgICAgIGlm IChudW1CeXRlc1dyaXR0ZW4gPCAwKSB7Ci0gICAgICAgICAgICAvLyBGSVhNRTogRGVzdHJveSB0 aGUgc3RyZWFtIQotICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAg ICBzdG9wKE5QUkVTX05FVFdPUktfRVJSKTsKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAg fQogCiAgICAgICAgIC8vIE5QUF9Xcml0ZSBjb3VsZCBjYWxsIE5QTl9EZXN0cm95U3RyZWFtIGFu ZCBkZXN0cm95IHRoZSBzdHJlYW0uCg==