42644 2010-07-20 09:23:11 -0700 HTML5 tree builder should restore form state 2010-07-20 11:28:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue darin eric oldest_to_newest 253754 0 abarth 2010-07-20 09:23:11 -0700 HTML5 tree builder should restore form state 253755 1 62083 abarth 2010-07-20 09:25:37 -0700 Created attachment 62083 Patch 253758 2 62083 darin 2010-07-20 09:29:40 -0700 Comment on attachment 62083 Patch r=me I think it would be good to add some sort of debug assertion that every element gets a finishParsingChildren call before some later point in time, so we could see more directly, rather than indirectly, that every element gets it. 253761 3 abarth 2010-07-20 09:31:10 -0700 > I think it would be good to add some sort of debug assertion that every element gets a finishParsingChildren call before some later point in time, so we could see more directly, rather than indirectly, that every element gets it. That sounds like a good idea. When should we fire that ASSERT? 253764 4 62083 eric 2010-07-20 09:36:54 -0700 Comment on attachment 62083 Patch LGTM too. 253765 5 darin 2010-07-20 09:37:24 -0700 (In reply to comment #3) > That sounds like a good idea. When should we fire that ASSERT? One possibility is to walk the whole just-parsed tree and perhaps even the whole document as well firing that assert any time the parser finishes parsing. Another possibility is to fire the assertion at element destructor time. I think there are other possible times as well that won’t necessarily be quite as good: One is event dispatch, but there are probably lots of others. Anything that doesn’t happen during parsing, but almost always happens later could fit the bill. 253768 6 eric 2010-07-20 09:39:52 -0700 It's unclear to me if "finishedParsingChildren" will be required in the end. It's part of the old parser's logic, but we might need an equivalent in the new parser too. 253769 7 darin 2010-07-20 09:40:27 -0700 (In reply to comment #6) > It's unclear to me if "finishedParsingChildren" will be required in the end. It's part of the old parser's logic, but we might need an equivalent in the new parser too. I’m pretty sure that this or the equivalent will be needed. We removed it from the old parser at one point, and then had to add it back. 253770 8 abarth 2010-07-20 09:42:00 -0700 Does it only get called for parser-inserted elements? I guess I could look in the debugger. 253777 9 darin 2010-07-20 09:54:40 -0700 (In reply to comment #8) > Does it only get called for parser-inserted elements? I guess I could look in the debugger. It goes hand in hand with a "created by parser" flag passed when the element is created. 253833 10 62083 commit-queue 2010-07-20 11:28:44 -0700 Comment on attachment 62083 Patch Clearing flags on attachment: 62083 Committed r63760: <http://trac.webkit.org/changeset/63760> 253834 11 commit-queue 2010-07-20 11:28:49 -0700 All reviewed patches have been landed. Closing bug. 62083 2010-07-20 09:25:37 -0700 2010-07-20 11:28:44 -0700 Patch bug-42644-20100720092536.patch text/plain 2189 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWMzMGYwYTcwMTY2ZDQ2MDk5NDYyODA2ZWZkYTZlOWEwNzBlMjYxMS4uZTI5ZTlhOTNkZjgwOTYy NjQ4ZmI0NmFlMWFiZTJiODY0YmY3ZWRiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNy0yMCAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUw1IHRyZWUgYnVpbGRlciBzaG91bGQgcmVzdG9yZSBm b3JtIHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MjY0NAorCisgICAgICAgIFdlIG5lZWQgdG8gdGVsbCBzZWxmLWNsb3NpbmcgdGFncyB0aGF0 IHdlJ3JlIGRvbmUgcGFyc2luZyB0aGVpcgorICAgICAgICBjaGlsZHJlbi4gIFRoaXMgcGF0Y2gg Zml4ZXMgdGhlIGZvbGxvd2luZyBMYXlvdXRUZXN0cyB3aGVuIHJ1biB3aXRoCisgICAgICAgIC0t aHRtbDUtdHJlZWJ1aWxkZXI6CisKKyAgICAgICAgICBmYXN0L2Zvcm1zL2J1dHRvbi1zdGF0ZS1y ZXN0b3JlLmh0bWwKKyAgICAgICAgICBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWF1 dG9jb21wbGV0ZS1mb3JtLmh0bWwKKyAgICAgICAgICBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUt dG8tbm9uLWVkaXRlZC1jb250cm9scy5odG1sCisgICAgICAgICAgZmFzdC9oaXN0b3J5L3NhdmVz LXN0YXRlLWFmdGVyLWZyYWdtZW50LW5hdi5odG1sCisgICAgICAgICAgaHR0cC90ZXN0cy9uYXZp Z2F0aW9uL3Jlc3RvcmUtZm9ybS1zdGF0ZS1odHRwcy5odG1sCisKKyAgICAgICAgKiBodG1sL0hU TUxDb25zdHJ1Y3Rpb25TaXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb25zdHJ1Y3Rp b25TaXRlOjppbnNlcnRTZWxmQ2xvc2luZ0hUTUxFbGVtZW50KToKKwogMjAxMC0wNy0xOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxDb25zdHJ1Y3Rpb25TaXRl LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKaW5kZXggZDcyYTUz NmNhYWM4Y2ExZGYyOTFiNjU0NWM5ZWM4NGJlNmNhOTc5MS4uYTQwYTYyODI3NWY4YmIyMWZjNTAz ODVmYjg2ZGY4ZmM1MWQxNmFmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxDb25zdHJ1 Y3Rpb25TaXRlLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuY3Bw CkBAIC0yMzMsNyArMjMzLDExIEBAIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2VydEhU TUxFbGVtZW50KEF0b21pY0hUTUxUb2tlbiYgdG9rZW4pCiB2b2lkIEhUTUxDb25zdHJ1Y3Rpb25T aXRlOjppbnNlcnRTZWxmQ2xvc2luZ0hUTUxFbGVtZW50KEF0b21pY0hUTUxUb2tlbiYgdG9rZW4p CiB7CiAgICAgQVNTRVJUKHRva2VuLnR5cGUoKSA9PSBIVE1MVG9rZW46OlN0YXJ0VGFnKTsKLSAg ICBhdHRhY2hUb0N1cnJlbnQoY3JlYXRlSFRNTEVsZW1lbnQodG9rZW4pKTsKKyAgICBSZWZQdHI8 RWxlbWVudD4gZWxlbWVudCA9IGF0dGFjaFRvQ3VycmVudChjcmVhdGVIVE1MRWxlbWVudCh0b2tl bikpOworICAgIC8vIE5vcm1hbGx5IEhUTUxFbGVtZW50U3RhY2sgaXMgcmVzcG9uc2libGUgZm9y IGNhbGxpbmcgZmluaXNoUGFyc2luZ0NoaWxkcmVuLAorICAgIC8vIGJ1dCBzZWxmLWNsb3Npbmcg ZWxlbWVudHMgYXJlIG5ldmVyIGluIHRoZSBlbGVtZW50IHN0YWNrIHNvIHRoZSBzdGFjaworICAg IC8vIGRvZXNuJ3QgZ2V0IGEgY2hhbmNlIHRvIHRlbGwgdGhlbSB0aGF0IHdlJ3JlIGRvbmUgcGFy c2luZyB0aGVpciBjaGlsZHJlbi4KKyAgICBlbGVtZW50LT5maW5pc2hQYXJzaW5nQ2hpbGRyZW4o KTsKICAgICAvLyBGSVhNRTogRG8gd2Ugd2FudCB0byBhY2tub3dsZWRnZSB0aGUgdG9rZW4ncyBz ZWxmLWNsb3NpbmcgZmxhZz8KICAgICAvLyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2Vi LWFwcHMvY3VycmVudC13b3JrL211bHRpcGFnZS90b2tlbml6YXRpb24uaHRtbCNhY2tub3dsZWRn ZS1zZWxmLWNsb3NpbmctZmxhZwogfQo=