42642 2010-07-20 08:00:36 -0700 [v8] Web Inspector: inspected page renderer crashes when inspected page has JS syntax error 2010-07-22 09:16:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 42831 0 caseq webkit-unassigned pfeldman yurys oldest_to_newest 253723 0 62076 caseq 2010-07-20 08:00:36 -0700 Created attachment 62076 test page 1. Load a page with syntax error (sample attached) 2. Open inspector 3. Reload page 4. Observe crash in inspected page renderer Call stack: > chrome.dll!WTF::Vector<WTF::OwnPtr<WebCore::ScriptCallFrame>,0>::at(unsigned int i=0) Line 533 + 0x29 bytes C++ chrome.dll!WebCore::ScriptCallStack::at(unsigned int index=0) Line 119 + 0xf bytes C++ chrome.dll!WebCore::ConsoleMessage::ConsoleMessage(WebCore::MessageSource s=JSMessageSource, WebCore::MessageType t=UncaughtExceptionMessageType, WebCore::MessageLevel l=ErrorMessageLevel, const WebCore::String & m="Uncaught SyntaxError: Unexpected token )", WebCore::ScriptCallStack * callStack=0x0c238fc0, unsigned int g=0, bool storeTrace=true) Line 95 + 0x56 bytes C++ chrome.dll!WebCore::InspectorController::addMessageToConsole(WebCore::MessageSource source=JSMessageSource, WebCore::MessageType type=UncaughtExceptionMessageType, WebCore::MessageLevel level=ErrorMessageLevel, WebCore::ScriptCallStack * callStack=0x0c238fc0, const WebCore::String & message="Uncaught SyntaxError: Unexpected token )") Line 346 + 0x53 bytes C++ chrome.dll!WebCore::Console::addMessage(WebCore::MessageSource source=JSMessageSource, WebCore::MessageType type=UncaughtExceptionMessageType, WebCore::MessageLevel level=ErrorMessageLevel, const WebCore::String & message="Uncaught SyntaxError: Unexpected token )", unsigned int lineNumber=2, const WebCore::String & sourceURL="file:///E:/caseq/wip/syntxerr.html湨潴映汩᭸揳", WebCore::ScriptCallStack * callStack=0x0c238fc0) Line 159 C++ chrome.dll!WebCore::V8ConsoleMessage::dispatchNow(WebCore::Page * page=0x0a64d1e0, WebCore::ScriptCallStack * callStack=0x0c238fc0) Line 142 C++ chrome.dll!WebCore::V8ConsoleMessage::handler(v8::Handle<v8::Message> message={...}, v8::Handle<v8::Value> data={...}) Line 129 C++ chrome.dll!v8::internal::MessageHandler::ReportMessage(v8::internal::MessageLocation * loc=0x07bbea04, v8::internal::Handle<v8::internal::Object> message={...}) Line 146 + 0x28 bytes C++ chrome.dll!v8::internal::Top::ReportPendingMessages() Line 928 + 0xd bytes C++ chrome.dll!v8::internal::Compiler::Compile(v8::internal::Handle<v8::internal::String> source={...}, v8::internal::Handle<v8::internal::Object> script_name={...}, int line_offset=1, int column_offset=0, v8::Extension * extension=0x00000000, v8::internal::ScriptDataImpl * input_pre_data=0x00000000, v8::internal::Handle<v8::internal::Object> script_data={...}, v8::internal::NativesFlag natives=NOT_NATIVES_CODE) Line 350 C++ chrome.dll!v8::Script::New(v8::Handle<v8::String> source={...}, v8::ScriptOrigin * origin=0x07bbec20, v8::ScriptData * pre_data=0x00000000, v8::Handle<v8::String> script_data={...}) Line 1184 + 0x40 bytes C++ chrome.dll!v8::Script::Compile(v8::Handle<v8::String> source={...}, v8::ScriptOrigin * origin=0x07bbec20, v8::ScriptData * pre_data=0x00000000, v8::Handle<v8::String> script_data={...}) Line 1205 + 0x19 bytes C++ chrome.dll!WebCore::V8Proxy::compileScript(v8::Handle<v8::String> code={...}, const WebCore::String & fileName="file:///E:/caseq/wip/syntxerr.html", int baseLine=1, v8::ScriptData * scriptData=0x00000000) Line 244 + 0x20 bytes C++ chrome.dll!WebCore::V8Proxy::evaluate(const WebCore::ScriptSourceCode & source={...}, WebCore::Node * node=0x00000000) Line 399 + 0x38 bytes C++ chrome.dll!WebCore::ScriptController::evaluate(const WebCore::ScriptSourceCode & sourceCode={...}, WebCore::ShouldAllowXSS shouldAllowXSS=DoNotAllowXSS) Line 241 C++ chrome.dll!WebCore::ScriptController::executeScript(const WebCore::ScriptSourceCode & sourceCode={...}, WebCore::ShouldAllowXSS shouldAllowXSS=DoNotAllowXSS) Line 62 C++ 253730 1 62078 yurys 2010-07-20 08:09:46 -0700 Created attachment 62078 Patch 253735 2 62078 yurys 2010-07-20 08:17:48 -0700 Comment on attachment 62078 Patch Clearing flags on attachment: 62078 Committed r63746: <http://trac.webkit.org/changeset/63746> 253736 3 yurys 2010-07-20 08:17:58 -0700 All reviewed patches have been landed. Closing bug. 62076 2010-07-20 08:00:36 -0700 2010-07-20 08:00:36 -0700 test page syntxerr.html text/html 37 caseq PGh0bWw+DQo8c2NyaXB0Pik8L3NjcmlwdD4NCjwvaHRtbD4NCg== 62078 2010-07-20 08:09:46 -0700 2010-07-20 08:17:48 -0700 Patch bug-42642-20100720190944.patch text/plain 1514 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDkyNjc3MzAyMjY4MTE0MTY1OTU3YjlmOTg4OGQzMjZjY2FmMTgzMS4uZmQxOGEwNWE4MWRhYmRj NTliZTNhYWU2MmRkMjYxZjM2YmE5MGNhNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0yMCAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFdlYiBJbnNwZWN0b3I6IGluc3BlY3Rl ZCBwYWdlIHJlbmRlcmVyIGNyYXNoZXMgd2hlbiBpbnNwZWN0ZWQgcGFnZSBoYXMgSlMgc3ludGF4 IGVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MjY0MgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhDb25zb2xlTWVzc2FnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWOENvbnNvbGVNZXNzYWdlOjpoYW5kbGVyKToKKwogMjAxMC0wNy0yMCAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBm aXgKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhDb25zb2xlTWVzc2FnZS5jcHAg Yi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29uc29sZU1lc3NhZ2UuY3BwCmluZGV4IGY1ZTYzMDBh MGZhNmMwYjg2MjBiYzY2MDgwMzU5NDdkZmE3ZjQyYzcuLjhiNmJiMTc4NmE4NWM3OWJjZjAyZmRk ZTg1NDE2NTE3ZDFkMWE4NzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhDb25z b2xlTWVzc2FnZS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOENvbnNvbGVNZXNzYWdl LmNwcApAQCAtMTE1LDcgKzExNSw3IEBAIHZvaWQgVjhDb25zb2xlTWVzc2FnZTo6aGFuZGxlcih2 ODo6SGFuZGxlPHY4OjpNZXNzYWdlPiBtZXNzYWdlLCB2ODo6SGFuZGxlPHY4OjpWCiAgICAgdjg6 OkhhbmRsZTx2ODo6U3RhY2tUcmFjZT4gc3RhY2tUcmFjZSA9IG1lc3NhZ2UtPkdldFN0YWNrVHJh Y2UoKTsKICAgICBPd25QdHI8U2NyaXB0Q2FsbFN0YWNrPiBjYWxsU3RhY2s7CiAgICAgLy8gQ3Vy cmVudGx5IHN0YWNrIHRyYWNlIGlzIG9ubHkgY29sbGVjdGVkIHdoZW4gaW5zcGVjdG9yIGlzIG9w ZW4uCi0gICAgaWYgKCFzdGFja1RyYWNlLklzRW1wdHkoKSkgeworICAgIGlmICghc3RhY2tUcmFj ZS5Jc0VtcHR5KCkgJiYgc3RhY2tUcmFjZS0+R2V0RnJhbWVDb3VudCgpID4gMCkgewogICAgICAg ICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQgPSB2ODo6Q29udGV4dDo6R2V0RW50ZXJl ZCgpOwogICAgICAgICBTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUgPSBTY3JpcHRTdGF0ZTo6Zm9y Q29udGV4dChjb250ZXh0KTsKICAgICAgICAgY2FsbFN0YWNrID0gU2NyaXB0Q2FsbFN0YWNrOjpj cmVhdGUoc2NyaXB0U3RhdGUsIHN0YWNrVHJhY2UpOwo=