42622 2010-07-20 02:00:08 -0700 Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2 2010-07-22 08:04:06 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned abecsi andersca aroben commit-queue kenneth sam oldest_to_newest 253617 0 kbalazs 2010-07-20 02:00:08 -0700 It should not be necessary for a webkit2 port to implement this feature. Actually it is not implemented for qt and we would leave it over and going on with the rest of the work. 253618 1 62043 kbalazs 2010-07-20 02:05:48 -0700 Created attachment 62043 proposed patch 254770 2 62043 tonikitoo 2010-07-22 07:11:55 -0700 Comment on attachment 62043 proposed patch Looks sane to me since only Mac and Win platforms define that on WebCore. ... #if PLATFORM(WIN) || PLATFORM(MAC) #define WTF_USE_LAZY_NATIVE_CURSOR 1 #endif ... Please if you are planning on doing the real lazy cursor implementation as a follow up, paste the bug# here for reference. 254793 3 62043 commit-queue 2010-07-22 08:04:01 -0700 Comment on attachment 62043 proposed patch Clearing flags on attachment: 62043 Committed r63893: <http://trac.webkit.org/changeset/63893> 254794 4 commit-queue 2010-07-22 08:04:06 -0700 All reviewed patches have been landed. Closing bug. 62043 2010-07-20 02:05:48 -0700 2010-07-22 08:04:01 -0700 proposed patch guard_lazy_cursor.diff text/plain 2591 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjA0OGQ2Ni4uYTQyMjZkZSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0yMCAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTGF6eSBjdXJzb3IgY3JlYXRpb24gc2hvdWxkIGJlIGd1YXJkZWQg YnkgI2lmIFVTRShMQVpZX05BVElWRV9DVVJTT1IpIGluIFdlYktpdDIKKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2MjIKKworICAgICAgICAqIFNo YXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRSZWNlaXZlTWVz c2FnZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGll bnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6OnNldEN1cnNvcik6CisK IDIwMTAtMDctMTkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQv V2ViQ29yZUFyZ3VtZW50Q29kZXJzLmggYi9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRD b2RlcnMuaAppbmRleCA4OWRkNWY5Li5mYjVkMThlIDEwMDY0NAotLS0gYS9XZWJLaXQyL1NoYXJl ZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAorKysgYi9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJn dW1lbnRDb2RlcnMuaApAQCAtMTExLDYgKzExMSw3IEBAIHRlbXBsYXRlPD4gc3RydWN0IEFyZ3Vt ZW50Q29kZXI8V2ViQ29yZTo6UGx1Z2luSW5mbz4gewogICAgIH0KIH07CiAKKyNpZiBVU0UoTEFa WV9OQVRJVkVfQ1VSU09SKQogdGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxXZWJDb3Jl OjpDdXJzb3I+IHsKICAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyKiBlbmNv ZGVyLCBjb25zdCBXZWJDb3JlOjpDdXJzb3ImIGN1cnNvcikKICAgICB7CkBAIC0xMzQsNiArMTM1 LDcgQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpDdXJzb3I+IHsK ICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogfTsKKyNlbmRpZgogCiB9IC8vIG5hbWVzcGFj ZSBDb3JlSVBDCiAKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGU0OWU3NmUuLjU4 Y2Q3MzkgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysr IGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNTQ3LDEwICs1NDcsMTIg QEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZFJlY2VpdmVNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rp b24qIGNvbm5lY3Rpb24sIENvcmVJUEM6Ok0KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9 CiAgICAgICAgIGNhc2UgV2ViUGFnZVByb3h5TWVzc2FnZTo6U2V0Q3Vyc29yOiB7CisjaWYgVVNF KExBWllfTkFUSVZFX0NVUlNPUikKICAgICAgICAgICAgIEN1cnNvciBjdXJzb3I7CiAgICAgICAg ICAgICBpZiAoIWFyZ3VtZW50cy5kZWNvZGUoY3Vyc29yKSkKICAgICAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgICAgICBzZXRDdXJzb3IoY3Vyc29yKTsKKyNlbmRpZgogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBXZWJQYWdlUHJveHlNZXNzYWdlOjpTaG93 UGFnZTogewpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkNocm9tZUNsaWVudC5jcHAgYi9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi Q2hyb21lQ2xpZW50LmNwcAppbmRleCA4MzI4YTZhLi40MTQxYzEzIDEwMDY0NAotLS0gYS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAorKysgYi9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcApAQCAt NDIxLDcgKzQyMSw5IEBAIHZvaWQgV2ViQ2hyb21lQ2xpZW50OjpjaG9vc2VJY29uRm9yRmlsZXMo Y29uc3QgVmVjdG9yPFN0cmluZz4mLCBGaWxlQ2hvb3NlciopCiAKIHZvaWQgV2ViQ2hyb21lQ2xp ZW50OjpzZXRDdXJzb3IoY29uc3QgQ3Vyc29yJiBjdXJzb3IpCiB7CisjaWYgVVNFKExBWllfTkFU SVZFX0NVUlNPUikKICAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5jb25uZWN0aW9uKCktPnNlbmQo V2ViUGFnZVByb3h5TWVzc2FnZTo6U2V0Q3Vyc29yLCBtX3BhZ2UtPnBhZ2VJRCgpLCBDb3JlSVBD OjpJbihjdXJzb3IpKTsKKyNlbmRpZgogfQogCiB2b2lkIFdlYkNocm9tZUNsaWVudDo6Zm9ybVN0 YXRlRGlkQ2hhbmdlKGNvbnN0IE5vZGUqKQo=