42604 2010-07-19 16:21:26 -0700 Update expected results for a "tricky" test 2010-07-20 19:42:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 253448 0 abarth 2010-07-19 16:21:26 -0700 Update expected results for a "tricky" test 253454 1 62010 abarth 2010-07-19 16:24:16 -0700 Created attachment 62010 Patch 253474 2 62010 eric 2010-07-19 16:57:28 -0700 Comment on attachment 62010 Patch OK. 253597 3 62010 commit-queue 2010-07-20 01:02:49 -0700 Comment on attachment 62010 Patch Rejecting patch 62010 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/html5lib/resources/tricky01.dat patching file LayoutTests/html5lib/runner-expected-html5.txt Hunk #1 FAILED at 286. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file LayoutTests/html5lib/runner-expected.txt Full output: http://queues.webkit.org/results/3569261 254032 4 eric 2010-07-20 15:54:03 -0700 Here are reduced test cases: #data 1234 #errors #document | <html> | <head> | <body> | | "1" | | "2" | | | | "3" | "4" #data 123<script>document.getElementById("b").id = "c";document.getElementById("i").id = "j"</script>4 #errors #document | <html> | <head> | <body> | | id="c" | "1" | | id="j" | "2" | | id="i" | | | id="b" | "3" | <script> | "document.getElementById("b").id = "c";document.getElementById("i").id = "j"" | "4" It seems you can't hit AAA 6.5 without also hitting step 8, so both callsites ended up as one test. 254033 5 eric 2010-07-20 15:55:13 -0700 Sorry, wrong bug. 254108 6 62010 abarth 2010-07-20 19:14:03 -0700 Comment on attachment 62010 Patch This should land cleanly behind the patch in Bug 42594. 254112 7 62010 commit-queue 2010-07-20 19:41:57 -0700 Comment on attachment 62010 Patch Clearing flags on attachment: 62010 Committed r63799: <http://trac.webkit.org/changeset/63799> 254113 8 commit-queue 2010-07-20 19:42:01 -0700 All reviewed patches have been landed. Closing bug. 62010 2010-07-19 16:24:16 -0700 2010-07-20 19:41:56 -0700 Patch bug-42604-20100719162415.patch text/plain 4448 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZjczNjc1ZTg1MGZiMzUzZDM3YjNmNzFkNjZiZDM1ZGE0ZTdkNDdhLi42ZmZjN2Zm NDg2ODExMTE1NDcwMmIyNjYxYjI2MDE3MzQ1MTIyYzUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjMgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBVcGRhdGUg ZXhwZWN0ZWQgcmVzdWx0cyBmb3IgYSAidHJpY2t5IiB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjYwNAorCisgICAgICAgIE9yaWdpbmFsbHks IEkgY3JlYXRlZCB0aGVzZSBleHBlY3RhdGlvbnMgdXNpbmcgTWluZWZpZWxkLiAgSG93ZXZlciwg aXQKKyAgICAgICAgYXBwZWFycyB0aGF0IE1pbmVmaWVsZCBwYXJzZXMgdGhpcyBjYXNlIGluY29y cmVjdGx5IGFjY29yZGluZyB0byB0aGUKKyAgICAgICAgc3BlYy4gIEkndmUgZmlsZWQgPGh0dHBz Oi8vYnVnemlsbGEubW96aWxsYS5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDA5MT4uCisKKyAgICAg ICAgVGhpcyBwYXRjaCB1cGRhdGVzIG91ciBleHBlY3RlZCByZXN1bHRzIHRvIHdoYXQgSSBiZWxp ZXZlIGlzIGNvcnJlY3QuCisKKyAgICAgICAgKiBodG1sNWxpYi9yZXNvdXJjZXMvdHJpY2t5MDEu ZGF0OgorICAgICAgICAqIGh0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQ6CisgICAg ICAgICogaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4dDoKKworMjAxMC0wNy0xOSAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCiAgICAgICAgIEZvc3RlciBwYXJlbnRpbmcgZGVwZW5kcyBvbiB0aGUgY3VycmVu dCBlbGVtZW50IGF0IGluc2VydGlvbiB0aW1lCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjU5OQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odG1s NWxpYi9yZXNvdXJjZXMvdHJpY2t5MDEuZGF0IGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVzb3Vy Y2VzL3RyaWNreTAxLmRhdAppbmRleCBjNzY0NzBlODkzMjAxMDgyZTVjZjExYWU1NTNmYWM4NTg2 M2UxNmQ2Li4yNjQ1M2JmZmE5MzVkNWE2MjM1MmUyZjEwZTUxNTgyYWM4NDdlZjA5IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMvdHJpY2t5MDEuZGF0CisrKyBiL0xh eW91dFRlc3RzL2h0bWw1bGliL3Jlc291cmNlcy90cmlja3kwMS5kYXQKQEAgLTE2OSwyOSArMTY5 LDI2IEBAIEFsc28gbm90IGJvbGQuIgogfCAgICAgICAgICJZb3Ugc2hvdWxkIHNlZSBhIDEwMHgx MDAgZ3JlZW4gSW1hZ2UgYmVsb3cuCiAgICIKIHwgICAgIDxmb250PgotfCAgICAgICAiCi0iCiB8 ICAgICAgIDxpbWc+CiB8ICAgICAgICAgYWx0PSJJbWFnZSIKIHwgICAgICAgICBoZWlnaHQ9IjEw MCIKLXwgICAgICAgICBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47IgorfCAgICAgICAg IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOmdyZWVuIgogfCAgICAgICAgIHdpZHRoPSIxMDAiCiB8 ICAgICAgICIKICIKLXwgICAgIDxmb250PgotfCAgICAgICAiCi0iCi18ICAgICA8Zm9udD4KLXwg ICAgICAgIgotIgogfCAgICAgPHRhYmxlPgogfCAgICAgICAiCi0gICIKKyAgCisiCiB8ICAgICAg IDx0Ym9keT4KIHwgICAgICAgICA8dHI+CiB8ICAgICAgICAgICA8dGQ+CiB8ICAgICAgICAgICAg ICIKICIKK3wgICAgICAgICAgICIKKyIKK3wgICAgICAgICAiCisiCiAKICNkYXRhCiA8dGFibGU+ PHRyPjxwPjxhPjxwPllvdSBzaG91bGQgc2VlIHRoaXMgdGV4dC4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQgYi9MYXlvdXRUZXN0cy9o dG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQtaHRtbDUudHh0CmluZGV4IGNmYjlkM2VkOGE5MDNiZjc3 NzNlNGNiNWI4Y2NhYWExMjQ4Mzk1MTAuLjM3YzQwMjgxOGM1N2ZmZGVjYzQ3ZTU1ZDc2YjBkMjc2 MDRmZTZhNDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3Rl ZC1odG1sNS50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLWh0 bWw1LnR4dApAQCAtMjg2LDgyICsyODYsNSBAQCByZXNvdXJjZXMvaXNpbmRleC5kYXQ6IFBBU1MK IAogcmVzb3VyY2VzL3RhYmxlczAxLmRhdDogUEFTUwogCi1yZXNvdXJjZXMvdHJpY2t5MDEuZGF0 OgotNgotCi1UZXN0IDYgb2YgOSBpbiByZXNvdXJjZXMvdHJpY2t5MDEuZGF0IGZhaWxlZC4gSW5w dXQ6Ci08VEFCTEU+Ci0gIDxDRU5URVI+Ci0gIDxGT05UPllvdSBzaG91bGQgc2VlIGEgMTAweDEw MCBncmVlbiBJbWFnZSBiZWxvdy4KLSAgPC9DRU5URVI+Ci08SU1HIGFsdD0iSW1hZ2UiIHdpZHRo PTEwMCBoZWlnaHQ9MTAwIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOmdyZWVuIj4KLTx0cj48dGQ+ Ci08L3RkPgotPC90cj4KLTwvdGFibGU+Ci1Hb3Q6Ci18IDxodG1sPgotfCAgIDxoZWFkPgotfCAg IDxib2R5PgotfCAgICAgPGNlbnRlcj4KLXwgICAgICAgIgotICAiCi18ICAgICAgIDxmb250Pgot fCAgICAgICAgICJZb3Ugc2hvdWxkIHNlZSBhIDEwMHgxMDAgZ3JlZW4gSW1hZ2UgYmVsb3cuCi0g ICIKLXwgICAgIDxmb250PgotfCAgICAgICA8aW1nPgotfCAgICAgICAgIGFsdD0iSW1hZ2UiCi18 ICAgICAgICAgaGVpZ2h0PSIxMDAiCi18ICAgICAgICAgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6 Z3JlZW4iCi18ICAgICAgICAgd2lkdGg9IjEwMCIKLXwgICAgICAgIgotIgotfCAgICAgPHRhYmxl PgotfCAgICAgICAiCi0gIAotIgotfCAgICAgICA8dGJvZHk+Ci18ICAgICAgICAgPHRyPgotfCAg ICAgICAgICAgPHRkPgotfCAgICAgICAgICAgICAiCi0iCi18ICAgICAgICAgICAiCi0iCi18ICAg ICAgICAgIgotIgotRXhwZWN0ZWQ6Ci18IDxodG1sPgotfCAgIDxoZWFkPgotfCAgIDxib2R5Pgot fCAgICAgPGNlbnRlcj4KLXwgICAgICAgIgotICAiCi18ICAgICAgIDxmb250PgotfCAgICAgICAg ICJZb3Ugc2hvdWxkIHNlZSBhIDEwMHgxMDAgZ3JlZW4gSW1hZ2UgYmVsb3cuCi0gICIKLXwgICAg IDxmb250PgotfCAgICAgICAiCi0iCi18ICAgICAgIDxpbWc+Ci18ICAgICAgICAgYWx0PSJJbWFn ZSIKLXwgICAgICAgICBoZWlnaHQ9IjEwMCIKLXwgICAgICAgICBzdHlsZT0iYmFja2dyb3VuZC1j b2xvcjogZ3JlZW47IgotfCAgICAgICAgIHdpZHRoPSIxMDAiCi18ICAgICAgICIKLSIKLXwgICAg IDxmb250PgotfCAgICAgICAiCi0iCi18ICAgICA8Zm9udD4KLXwgICAgICAgIgotIgotfCAgICAg PHRhYmxlPgotfCAgICAgICAiCi0gICIKLXwgICAgICAgPHRib2R5PgotfCAgICAgICAgIDx0cj4K LXwgICAgICAgICAgIDx0ZD4KLXwgICAgICAgICAgICAgIgotIgorcmVzb3VyY2VzL3RyaWNreTAx LmRhdDogUEFTUwogI0VPRgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVy LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQK aW5kZXggODM0ZThjYjc5YzI3MDcxNGJlMmQ1NTFhODMzNGQ2MGE4MjQwNDZlYS4uYjAyYThmMDA4 YmVmOGVlZDMzYzllNmY4MzExNDgzNTAzNWYyNjc1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi9y dW5uZXItZXhwZWN0ZWQudHh0CkBAIC01MTMxLDI5ICs1MTMxLDI2IEBAIEV4cGVjdGVkOgogfCAg ICAgICAgICJZb3Ugc2hvdWxkIHNlZSBhIDEwMHgxMDAgZ3JlZW4gSW1hZ2UgYmVsb3cuCiAgICIK IHwgICAgIDxmb250PgotfCAgICAgICAiCi0iCiB8ICAgICAgIDxpbWc+CiB8ICAgICAgICAgYWx0 PSJJbWFnZSIKIHwgICAgICAgICBoZWlnaHQ9IjEwMCIKLXwgICAgICAgICBzdHlsZT0iYmFja2dy b3VuZC1jb2xvcjogZ3JlZW47IgorfCAgICAgICAgIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOmdy ZWVuIgogfCAgICAgICAgIHdpZHRoPSIxMDAiCiB8ICAgICAgICIKICIKLXwgICAgIDxmb250Pgot fCAgICAgICAiCi0iCi18ICAgICA8Zm9udD4KLXwgICAgICAgIgotIgogfCAgICAgPHRhYmxlPgog fCAgICAgICAiCi0gICIKKyAgCisiCiB8ICAgICAgIDx0Ym9keT4KIHwgICAgICAgICA8dHI+CiB8 ICAgICAgICAgICA8dGQ+CiB8ICAgICAgICAgICAgICIKICIKK3wgICAgICAgICAgICIKKyIKK3wg ICAgICAgICAiCisiCiAKIFRlc3QgNyBvZiA5IGluIHJlc291cmNlcy90cmlja3kwMS5kYXQgZmFp bGVkLiBJbnB1dDoKIDx0YWJsZT48dHI+PHA+PGE+PHA+WW91IHNob3VsZCBzZWUgdGhpcyB0ZXh0 Lgo=