42600 2010-07-19 15:24:45 -0700 [EFL] Enable Ecore-X on compile time 2010-07-20 12:56:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 antognolli+webkit webkit-unassigned barbieri commit-queue lucas.de.marchi oldest_to_newest 253425 0 antognolli+webkit 2010-07-19 15:24:45 -0700 [EFL] Enable Ecore-X on compile time 253427 1 62003 antognolli+webkit 2010-07-19 15:29:31 -0700 Created attachment 62003 Patch 253491 2 62003 tonikitoo 2010-07-19 17:50:23 -0700 Comment on attachment 62003 Patch > diff --git a/cmake/OptionsEfl.cmake b/cmake/OptionsEfl.cmake > index 78b91283aa27c8633995a7544541900ce25d7607..48e82c0d0ee944e0cea9de57de4e570d3cf74646 100644 > --- a/cmake/OptionsEfl.cmake > +++ b/cmake/OptionsEfl.cmake > @@ -43,12 +43,10 @@ ENDIF () > SET(WTF_USE_FREETYPE 1) > ADD_DEFINITIONS(-DUSE_FREETYPE=1) > > -ADD_DEFINITIONS(-DHAVE_ECORE_X) > - > -SET(JSC_EXECUTABLE_NAME jsc) > -SET(WTF_LIBRARY_NAME wtf) > -SET(JavaScriptCore_LIBRARY_NAME javascriptcore) > -SET(WebCore_LIBRARY_NAME webcore) > +SET(JSC_EXECUTABLE_NAME jsc_efl) > +SET(WTF_LIBRARY_NAME wtf_efl) > +SET(JavaScriptCore_LIBRARY_NAME javascriptcore_efl) > +SET(WebCore_LIBRARY_NAME webcore_efl) > SET(WebKit_LIBRARY_NAME ewebkit) Is this part of the patch related to the build time detection of ecore? 253526 3 barbieri 2010-07-19 19:18:54 -0700 (In reply to comment #2) > (From update of attachment 62003 [details]) > > > diff --git a/cmake/OptionsEfl.cmake b/cmake/OptionsEfl.cmake > > index 78b91283aa27c8633995a7544541900ce25d7607..48e82c0d0ee944e0cea9de57de4e570d3cf74646 100644 > > --- a/cmake/OptionsEfl.cmake > > +++ b/cmake/OptionsEfl.cmake > > @@ -43,12 +43,10 @@ ENDIF () > > SET(WTF_USE_FREETYPE 1) > > ADD_DEFINITIONS(-DUSE_FREETYPE=1) > > > > -ADD_DEFINITIONS(-DHAVE_ECORE_X) > > - > > -SET(JSC_EXECUTABLE_NAME jsc) > > -SET(WTF_LIBRARY_NAME wtf) > > -SET(JavaScriptCore_LIBRARY_NAME javascriptcore) > > -SET(WebCore_LIBRARY_NAME webcore) > > +SET(JSC_EXECUTABLE_NAME jsc_efl) > > +SET(WTF_LIBRARY_NAME wtf_efl) > > +SET(JavaScriptCore_LIBRARY_NAME javascriptcore_efl) > > +SET(WebCore_LIBRARY_NAME webcore_efl) > > SET(WebKit_LIBRARY_NAME ewebkit) > > Is this part of the patch related to the build time detection of ecore? err, it's not... it got in the patch I generated, should be split into another patch on its own (actually I thought that got in SVN a while ago...) 253844 4 62097 antognolli+webkit 2010-07-20 11:57:43 -0700 Created attachment 62097 Patch Ops, my bad, sorry for that... :-/ 253859 5 62097 tonikitoo 2010-07-20 12:28:27 -0700 Comment on attachment 62097 Patch thank you removing the unrelated change. r=me 253876 6 62097 commit-queue 2010-07-20 12:56:14 -0700 Comment on attachment 62097 Patch Clearing flags on attachment: 62097 Committed r63768: <http://trac.webkit.org/changeset/63768> 253877 7 commit-queue 2010-07-20 12:56:19 -0700 All reviewed patches have been landed. Closing bug. 62003 2010-07-19 15:29:31 -0700 2010-07-20 11:57:33 -0700 Patch bug-42600-20100719192930.patch text/plain 2574 antognolli+webkit ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2ZTlmNWJkYTlmMTg3M2Ix ZTA5MzY4MDIyZmVkYjBjZWJkNzQ5ODJhLi4xYmQ0MzU1MzM3MDQyOGIxZWFhYzJiM2NiYjNlYzBh MzdkMmQ2YWQ1IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTAtMDctMTkgIFJhZmFlbCBBbnRvZ25vbGxpICA8YW50b2dub2xsaUBwcm9m dXNpb24ubW9iaT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBFbmFibGUgRWNvcmUtWCBvbiBjb21waWxlIHRpbWUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNjAwCisKKyAgICAgICAgQ2hlY2sg Zm9yIGEgZmxhZyByZWNlaXZlZCBmcm9tIGNtYWtlIGNvbmZpZ3VyZSBhbmQgZGlzYWJsZSBpdAor ICAgICAgICBpZiBuZWNlc3NhcnkuIEFsc28gZGlzYWJsZSBpdCBpZiBFY29yZS1YIHdhc24ndCBm b3VuZC4KKworICAgICAgICBFRkwgcG9ydCBkb2VzIG5vdCBzdXBwb3J0IGF1dG9tYXRlZCB0ZXN0 cyB5ZXQuCisKKyAgICAgICAgKiBjbWFrZS9GaW5kRUZMLmNtYWtlOgorICAgICAgICAqIGNtYWtl L09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTAtMDctMTYgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5k cm9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgW0VGTF0gVW5yZXZpZXdlZCBidWlsZCBzeXN0 ZW0gY2xlYW51cC4KZGlmZiAtLWdpdCBhL2NtYWtlL0ZpbmRFRkwuY21ha2UgYi9jbWFrZS9GaW5k RUZMLmNtYWtlCmluZGV4IGMyZWZkY2JjNTlmZWViYjA5NDU3ZmJkMDUzYzBmMDhlYTdlY2I3MDQu LmNmZmY5NmZmYTY5MzE4ZmM0YWM1YzU2ZDA0MDUwYmYwZTZhYWY1YTcgMTAwNjQ0Ci0tLSBhL2Nt YWtlL0ZpbmRFRkwuY21ha2UKKysrIGIvY21ha2UvRmluZEVGTC5jbWFrZQpAQCAtMTEsNiArMTEs NiBAQCBQS0dfQ0hFQ0tfTU9EVUxFUyAoRUZMREVQUyBSRVFVSVJFRAogICBlY29yZS1ldmFzPj0w LjkuOS4wNjMKICAgZWRqZT49MC45LjkuMDYzKQogUEtHX0NIRUNLX01PRFVMRVMgKEVJTkEgUkVR VUlSRUQgZWluYS0wPj0wLjkuOS4wNjMpCi1QS0dfQ0hFQ0tfTU9EVUxFUyAoRUNPUkVfWCBSRVFV SVJFRCBlY29yZS14Pj0wLjkuOS4wNjMpCitQS0dfQ0hFQ0tfTU9EVUxFUyAoRUNPUkVfWCBlY29y ZS14Pj0wLjkuOS4wNjMpCiBQS0dfQ0hFQ0tfTU9EVUxFUyAoRVZBUyBSRVFVSVJFRCBldmFzPj0w LjkuOS4wNjMpCiAKZGlmZiAtLWdpdCBhL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgYi9jbWFrZS9P cHRpb25zRWZsLmNtYWtlCmluZGV4IDc4YjkxMjgzYWEyN2M4NjMzOTk1YTc1NDQ1NDE5MDBjZTI1 ZDc2MDcuLjQ4ZTgyYzBkMGVlOTQ0ZTBjZWE5ZGU1N2RlNGU1NzBkM2NmNzQ2NDYgMTAwNjQ0Ci0t LSBhL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpA QCAtNDMsMTIgKzQzLDEwIEBAIEVORElGICgpCiBTRVQoV1RGX1VTRV9GUkVFVFlQRSAxKQogQURE X0RFRklOSVRJT05TKC1EVVNFX0ZSRUVUWVBFPTEpCiAKLUFERF9ERUZJTklUSU9OUygtREhBVkVf RUNPUkVfWCkKLQotU0VUKEpTQ19FWEVDVVRBQkxFX05BTUUganNjKQotU0VUKFdURl9MSUJSQVJZ X05BTUUgd3RmKQotU0VUKEphdmFTY3JpcHRDb3JlX0xJQlJBUllfTkFNRSBqYXZhc2NyaXB0Y29y ZSkKLVNFVChXZWJDb3JlX0xJQlJBUllfTkFNRSB3ZWJjb3JlKQorU0VUKEpTQ19FWEVDVVRBQkxF X05BTUUganNjX2VmbCkKK1NFVChXVEZfTElCUkFSWV9OQU1FIHd0Zl9lZmwpCitTRVQoSmF2YVNj cmlwdENvcmVfTElCUkFSWV9OQU1FIGphdmFzY3JpcHRjb3JlX2VmbCkKK1NFVChXZWJDb3JlX0xJ QlJBUllfTkFNRSB3ZWJjb3JlX2VmbCkKIFNFVChXZWJLaXRfTElCUkFSWV9OQU1FIGV3ZWJraXQp CiAKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9BU19JTUFHRSAiRW5hYmxlIFNWRyBhcyBpbWFnZSIg REVGQVVMVCBPTiBTVkcpCkBAIC04OCw0ICs4NiwxNCBAQCBXRUJLSVRfRkVBVFVSRShFTkFCTEVf WEhUTUxNUCAiRW5hYmxlIFhIVE1MTVAiIERFRkFVTFQgT0ZGKQogV0VCS0lUX0ZFQVRVUkUoRU5B QkxFX1hQQVRIICJFbmFibGUgWFBhdGgiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFC TEVfWFNMVCAiRW5hYmxlIFhTTFQiIERFRkFVTFQgT04pCiAKK09QVElPTihFTkFCTEVfRUNPUkVf WCAiRW5hYmxlIEVjb3JlX1ggc3BlY2lmaWMgdXNhZ2UgKGN1cnNvciwgYmVsbCkiIE9OKQorSUYg KCR7RU5BQkxFX0VDT1JFX1h9KQorICAgIElGIChFQ09SRV9YX0ZPVU5EKQorICAgICAgICBNRVNT QUdFKFNUQVRVUyAiVXNpbmcgRWNvcmUtWCB0byBwcm92aWRlIGV4dGVuZGVkIHN1cHBvcnQuIikK KyAgICAgICAgQUREX0RFRklOSVRJT05TKC1ESEFWRV9FQ09SRV9YKQorICAgIEVMU0UgKCkKKyAg ICAgICAgTUVTU0FHRShFUlJPUiAiUmVxdWVzdGVkIEVjb3JlLVggYnV0IGl0IHdhcyBub3QgZm91 bmQhIikKKyAgICBFTkRJRiAoKQorRU5ESUYgKCkKKwogU0VUKENQQUNLX1NPVVJDRV9HRU5FUkFU T1IgVEJaMikK 62097 2010-07-20 11:57:43 -0700 2010-07-20 12:56:14 -0700 Patch bug-42600-20100720155741.patch text/plain 2253 antognolli+webkit ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlZmE2YTdjN2EzMDMxZWI1 YmJkNDdjMWFlYzcyZDQ4NDViN2Y3MWQ5Li5kZTJkN2Y4NmQ3ODdjMjEwYTNmZjVhZjhhZDc0MmFh NGQxYjRmNTVkIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTAtMDctMjAgIFJhZmFlbCBBbnRvZ25vbGxpICA8YW50b2dub2xsaUBwcm9m dXNpb24ubW9iaT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBFbmFibGUgRWNvcmUtWCBvbiBjb21waWxlIHRpbWUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNjAwCisKKyAgICAgICAgQ2hlY2sg Zm9yIGEgZmxhZyByZWNlaXZlZCBmcm9tIGNtYWtlIGNvbmZpZ3VyZSBhbmQgZGlzYWJsZSBpdAor ICAgICAgICBpZiBuZWNlc3NhcnkuIEFsc28gZGlzYWJsZSBpdCBpZiBFY29yZS1YIHdhc24ndCBm b3VuZC4KKworICAgICAgICBFRkwgcG9ydCBkb2VzIG5vdCBzdXBwb3J0IGF1dG9tYXRlZCB0ZXN0 cyB5ZXQuCisKKyAgICAgICAgKiBjbWFrZS9GaW5kRUZMLmNtYWtlOgorICAgICAgICAqIGNtYWtl L09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTAtMDctMjAgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTdGV2ZSBCbG9jay4KZGlmZiAtLWdp dCBhL2NtYWtlL0ZpbmRFRkwuY21ha2UgYi9jbWFrZS9GaW5kRUZMLmNtYWtlCmluZGV4IGMyZWZk Y2JjNTlmZWViYjA5NDU3ZmJkMDUzYzBmMDhlYTdlY2I3MDQuLmNmZmY5NmZmYTY5MzE4ZmM0YWM1 YzU2ZDA0MDUwYmYwZTZhYWY1YTcgMTAwNjQ0Ci0tLSBhL2NtYWtlL0ZpbmRFRkwuY21ha2UKKysr IGIvY21ha2UvRmluZEVGTC5jbWFrZQpAQCAtMTEsNiArMTEsNiBAQCBQS0dfQ0hFQ0tfTU9EVUxF UyAoRUZMREVQUyBSRVFVSVJFRAogICBlY29yZS1ldmFzPj0wLjkuOS4wNjMKICAgZWRqZT49MC45 LjkuMDYzKQogUEtHX0NIRUNLX01PRFVMRVMgKEVJTkEgUkVRVUlSRUQgZWluYS0wPj0wLjkuOS4w NjMpCi1QS0dfQ0hFQ0tfTU9EVUxFUyAoRUNPUkVfWCBSRVFVSVJFRCBlY29yZS14Pj0wLjkuOS4w NjMpCitQS0dfQ0hFQ0tfTU9EVUxFUyAoRUNPUkVfWCBlY29yZS14Pj0wLjkuOS4wNjMpCiBQS0df Q0hFQ0tfTU9EVUxFUyAoRVZBUyBSRVFVSVJFRCBldmFzPj0wLjkuOS4wNjMpCiAKZGlmZiAtLWdp dCBhL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgYi9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4 IDc4YjkxMjgzYWEyN2M4NjMzOTk1YTc1NDQ1NDE5MDBjZTI1ZDc2MDcuLjNiZTdiZGE2NzcxNTUw OWJkNjMwNDkxZmUxNmZhNzE4OWU4YWE3MmIgMTAwNjQ0Ci0tLSBhL2NtYWtlL09wdGlvbnNFZmwu Y21ha2UKKysrIGIvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNDMsOCArNDMsNiBAQCBFTkRJ RiAoKQogU0VUKFdURl9VU0VfRlJFRVRZUEUgMSkKIEFERF9ERUZJTklUSU9OUygtRFVTRV9GUkVF VFlQRT0xKQogCi1BRERfREVGSU5JVElPTlMoLURIQVZFX0VDT1JFX1gpCi0KIFNFVChKU0NfRVhF Q1VUQUJMRV9OQU1FIGpzYykKIFNFVChXVEZfTElCUkFSWV9OQU1FIHd0ZikKIFNFVChKYXZhU2Ny aXB0Q29yZV9MSUJSQVJZX05BTUUgamF2YXNjcmlwdGNvcmUpCkBAIC04OCw0ICs4NiwxNCBAQCBX RUJLSVRfRkVBVFVSRShFTkFCTEVfWEhUTUxNUCAiRW5hYmxlIFhIVE1MTVAiIERFRkFVTFQgT0ZG KQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1hQQVRIICJFbmFibGUgWFBhdGgiIERFRkFVTFQgT04p CiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfWFNMVCAiRW5hYmxlIFhTTFQiIERFRkFVTFQgT04pCiAK K09QVElPTihFTkFCTEVfRUNPUkVfWCAiRW5hYmxlIEVjb3JlX1ggc3BlY2lmaWMgdXNhZ2UgKGN1 cnNvciwgYmVsbCkiIE9OKQorSUYgKCR7RU5BQkxFX0VDT1JFX1h9KQorICAgIElGIChFQ09SRV9Y X0ZPVU5EKQorICAgICAgICBNRVNTQUdFKFNUQVRVUyAiVXNpbmcgRWNvcmUtWCB0byBwcm92aWRl IGV4dGVuZGVkIHN1cHBvcnQuIikKKyAgICAgICAgQUREX0RFRklOSVRJT05TKC1ESEFWRV9FQ09S RV9YKQorICAgIEVMU0UgKCkKKyAgICAgICAgTUVTU0FHRShFUlJPUiAiUmVxdWVzdGVkIEVjb3Jl LVggYnV0IGl0IHdhcyBub3QgZm91bmQhIikKKyAgICBFTkRJRiAoKQorRU5ESUYgKCkKKwogU0VU KENQQUNLX1NPVVJDRV9HRU5FUkFUT1IgVEJaMikK