42586 2010-07-19 12:40:59 -0700 Log all canceled authentication attempts in DumpRenderTree 2010-07-19 13:20:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap abarth eric webkit.review.bot oldest_to_newest 253334 0 ap 2010-07-19 12:40:59 -0700 DumpRenderTree already prints a log when it responds with preset credentials, but it doesn't log anything when there are no credentials (and it thus simulates a canceled auth sheet). It's important to know whether an auth sheet appeared. 253338 1 61980 ap 2010-07-19 12:42:57 -0700 Created attachment 61980 proposed patch 253345 2 61980 darin 2010-07-19 12:50:16 -0700 Comment on attachment 61980 proposed patch > + NSString *string = [NSString stringWithFormat:@"%@ - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet", identifier]; > + printf("%s\n", [string UTF8String]); I would either use puts instead of printf here, or continue to use printf but use UTF8String on the identifier instead of calling stringWithFormat and have a printf format string instead. r=me 253353 3 ap 2010-07-19 13:04:55 -0700 Committed <http://trac.webkit.org/changeset/63681>. > I would either use puts instead of printf here, or continue > to use printf but use UTF8String on the identifier instead of > calling stringWithFormat and have a printf format string instead. I didn't make this change, since such style matches what is done elsewhere in this file. 253361 4 webkit.review.bot 2010-07-19 13:20:09 -0700 http://trac.webkit.org/changeset/63681 might have broken Qt Linux Release 61980 2010-07-19 12:42:57 -0700 2010-07-19 12:50:16 -0700 proposed patch LogAuthSheet.txt text/plain 4234 ap SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYzNjgwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMTkgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTg2 CisgICAgICAgIExvZyBhbGwgY2FuY2VsZWQgYXV0aGVudGljYXRpb24gYXR0ZW1wdHMgaW4gRHVt cFJlbmRlclRyZWUKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9SZXNvdXJjZUxvYWRE ZWxlZ2F0ZS5tbToKKyAgICAgICAgKC1bUmVzb3VyY2VMb2FkRGVsZWdhdGUgd2ViVmlldzpyZXNv dXJjZTpkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2U6ZnJvbURhdGFTb3VyY2U6XSk6 CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL1Jlc291cmNlTG9hZERlbGVnYXRlLmNwcDoK KyAgICAgICAgKFJlc291cmNlTG9hZERlbGVnYXRlOjpkaWRSZWNlaXZlQXV0aGVudGljYXRpb25D aGFsbGVuZ2UpOgorICAgICAgICBJdCdzIGltcG9ydGFudCB0byBrbm93IHdoZXRoZXIgYW4gYXV0 aCBzaGVldCBhcHBlYXJlZC4gQWRkZWQgbG9nZ2luZyB0byAibm8gcHJlc2V0IGNyZWRlbnRpYWxz IgorICAgICAgICBjYXNlLgorCiAyMDEwLTA3LTE5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjM2 NzEuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvUmVzb3VyY2VMb2FkRGVs ZWdhdGUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL1Jl c291cmNlTG9hZERlbGVnYXRlLm1tCShyZXZpc2lvbiA2MzU2MSkKKysrIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL21hYy9SZXNvdXJjZUxvYWREZWxlZ2F0ZS5tbQkod29ya2luZyBjb3B5KQpA QCAtMTcyLDYgKzE3Miw5IEBAIC0oTlNVUkxSZXF1ZXN0ICopd2ViVmlldzogKFdlYlZpZXcgKil3 diAKIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXd2IHJlc291cmNlOihpZClpZGVudGlmaWVy IGRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTooTlNVUkxBdXRoZW50aWNhdGlvbkNo YWxsZW5nZSAqKWNoYWxsZW5nZSBmcm9tRGF0YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAqKWRhdGFT b3VyY2UKIHsKICAgICBpZiAoIWdMYXlvdXRUZXN0Q29udHJvbGxlci0+aGFuZGxlc0F1dGhlbnRp Y2F0aW9uQ2hhbGxlbmdlcygpKSB7CisgICAgICAgIE5TU3RyaW5nICpzdHJpbmcgPSBbTlNTdHJp bmcgc3RyaW5nV2l0aEZvcm1hdDpAIiVAIC0gZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxl bmdlIC0gU2ltdWxhdGluZyBjYW5jZWxsZWQgYXV0aGVudGljYXRpb24gc2hlZXQiLCBpZGVudGlm aWVyXTsKKyAgICAgICAgcHJpbnRmKCIlc1xuIiwgW3N0cmluZyBVVEY4U3RyaW5nXSk7CisKICAg ICAgICAgW1tjaGFsbGVuZ2Ugc2VuZGVyXSBjb250aW51ZVdpdGhvdXRDcmVkZW50aWFsRm9yQXV0 aGVudGljYXRpb25DaGFsbGVuZ2U6Y2hhbGxlbmdlXTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K SW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9SZXNvdXJjZUxvYWREZWxlZ2F0 ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL1Jlc291 cmNlTG9hZERlbGVnYXRlLmNwcAkocmV2aXNpb24gNjM2ODApCisrKyBXZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS93aW4vUmVzb3VyY2VMb2FkRGVsZWdhdGUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yOTIsNiArMjkyLDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBSZXNvdXJjZUxvYWRE ZQogICAgICAgICByZXR1cm4gRV9GQUlMOwogCiAgICAgaWYgKCFnTGF5b3V0VGVzdENvbnRyb2xs ZXItPmhhbmRsZXNBdXRoZW50aWNhdGlvbkNoYWxsZW5nZXMoKSkgeworICAgICAgICBwcmludGYo IiVTIC0gZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIC0gU2ltdWxhdGluZyBjYW5j ZWxsZWQgYXV0aGVudGljYXRpb24gc2hlZXRcbiIsIGRlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0 UmVzdWx0KGlkZW50aWZpZXIpLmNfc3RyKCkpOwogICAgICAgICBzZW5kZXItPmNvbnRpbnVlV2l0 aG91dENyZWRlbnRpYWxGb3JBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShjaGFsbGVuZ2UpOwogICAg ICAgICByZXR1cm4gU19PSzsKICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzY4MCkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEw LTA3LTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjU4NgorICAgICAgICBMb2cgYWxsIGNhbmNlbGVkIGF1dGhl bnRpY2F0aW9uIGF0dGVtcHRzIGluIER1bXBSZW5kZXJUcmVlCisKKyAgICAgICAgKiBodHRwL3Rl c3RzL21pc2MvNDAxLWFsdGVybmF0aXZlLWNvbnRlbnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvZmFpbGVkLWF1dGgtZXhwZWN0ZWQudHh0OgorICAg ICAgICBBZGRlZCB0aGUgbmV3IG1lc3NhZ2VzLgorCiAyMDEwLTA3LTE5ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjLzQwMS1hbHRlcm5hdGl2ZS1jb250 ZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21p c2MvNDAxLWFsdGVybmF0aXZlLWNvbnRlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA2MzU2MSkK KysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy80MDEtYWx0ZXJuYXRpdmUtY29udGVudC1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEgKzEsMiBAQAorPHVua25vd24+IC0gZGlk UmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIC0gU2ltdWxhdGluZyBjYW5jZWxsZWQgYXV0 aGVudGljYXRpb24gc2hlZXQKIFBBU1MKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1s aHR0cHJlcXVlc3QvZmFpbGVkLWF1dGgtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvZmFpbGVkLWF1dGgtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiA2MzU2MSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QvZmFpbGVkLWF1dGgtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNSBA QAorPHVua25vd24+IC0gZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIC0gU2ltdWxh dGluZyBjYW5jZWxsZWQgYXV0aGVudGljYXRpb24gc2hlZXQKKzx1bmtub3duPiAtIGRpZFJlY2Vp dmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAtIFNpbXVsYXRpbmcgY2FuY2VsbGVkIGF1dGhlbnRp Y2F0aW9uIHNoZWV0CiBUZXN0IGZvciBidWcgMTMwNzU6IFhNTEh0dHBSZXF1ZXN0IHdpdGggZmFp bGVkIGF1dGhlbnRpY2F0aW9uIHNob3VsZCBzZXQgc3RhdHVzIHRvIDQwMS4KIAogU3luYywgbm8g Y3JlZGVudGlhbHM6IE9LCg==