4258 2005-08-01 12:44:21 -0700 Date().toString() only includes GMT offset, not timezone string 2006-07-26 11:50:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED http://sackheads.org/~jpayne/timestring.html P2 Normal --- 1 john webkit-unassigned darin ian oldest_to_newest 15653 0 john 2005-08-01 12:44:21 -0700 So far this has only affected a company internal website that parse the datestring to get the timezone. Internet Explorer, Netscape and Mozilla all have different ways of reporting the timezone. I suggest adopting the Mozilla format, as that is closest to the rest of the output of Date().toString() Safari currently reports: Mon Aug 01 2005 15:21:19 GMT-0400 Mozilla (firefox) reports: Mon Aug 01 2005 15:21:22 GMT-0400 (EDT) It feels like you could use a lookup into KnownZone in formatTime() to accomplish this. 23541 1 john 2005-11-02 11:45:54 -0800 just updating OS to 10.4 and version to 412+ to highlight that this is also an issue on tiger... just in case things are being prioritised away from jaguar bugs :) 27384 2 5404 jhaygood 2005-12-31 13:40:05 -0800 Created attachment 5404 Makes JavaScriptCore match Mozilla Makes JavaScriptCore match Mozilla if the timezone is known. 27385 3 5404 jhaygood 2005-12-31 13:40:38 -0800 Comment on attachment 5404 Makes JavaScriptCore match Mozilla Moves KnownZones higher so that formatTime can find it, changes formatTime to make use of it. 27399 4 john 2005-12-31 17:24:35 -0800 from a checkout today... /Users/jpayne/src/webkit/JavaScriptCore/kjs/date_object.cpp: In function 'KJS::UString KJS::formatTime (const tm&)': /Users/jpayne/src/webkit/JavaScriptCore/kjs/date_object.cpp:245: warning: suggest parentheses around assignment used as truth value /Users/jpayne/src/webkit/JavaScriptCore/kjs/date_object.cpp:247: error: 'gmtOffset' was not declared in this scope /Users/jpayne/src/webkit/JavaScriptCore/kjs/date_object.cpp:263: error: name lookup of 'i' changed for new ISO 'for' scoping /Users/jpayne/src/webkit/JavaScriptCore/kjs/date_object.cpp:245: error: using obsolete binding at 'i' /Users/jpayne/src/webkit/JavaScriptCore/kjs/date_object.cpp:263: warning: format '%s' expects type 'char*', but argument 10 has type 'const KJS::KnownZone' ** BUILD FAILED ** 27405 5 5404 darin 2005-12-31 18:24:39 -0800 Comment on attachment 5404 Makes JavaScriptCore match Mozilla It seems strange to list the time zone only if it's one of the hardcoded "known time zones". On Mac OS X and many other Unix systems, the timezone() function can be used to get the time zone abbreviation. On Win32, the GetTimeZoneInformation() function can probably be used. 27540 6 mjs 2006-01-02 20:39:47 -0800 I agree with darin's suggestion. Please use a function that knows about more time zones. Also, please provide a test case for this, if it is not already covered by the JS tests. It may be tricky to write a layout test for this that is time zone independent. 50074 7 9500 rwlbuis 2006-07-16 12:06:49 -0700 Created attachment 9500 First attempt When in utc mode, I just use tm_zone info here. This should be ok since localtime should set it up correctly. Unfortunately there seem to be no tests for this. I used http://sackheads.org/~jpayne/timestring.html to test manually, and it matches Mozilla. Let me know if any tests should be added or whether we can reuse existing tests. Cheers, Rob. 50091 8 9500 darin 2006-07-16 15:29:11 -0700 Comment on attachment 9500 First attempt Looks fine to me, but doesn't this affect some of our tests? r=me if not 50284 9 rwlbuis 2006-07-18 08:01:49 -0700 Hi Darin, (In reply to comment #8) > (From update of attachment 9500 [edit]) > Looks fine to me, but doesn't this affect some of our tests? > > r=me if not bdash couldn't see any changed results. But we concluded, it may be best if someone in the PDC timezone checks it, as NZ timezone gives issues with some of the tests. Cheers, Rob. 50857 10 darin 2006-07-26 11:50:48 -0700 This change broke the Windows buildbot. 5404 2005-12-31 13:40:05 -0800 2006-01-02 20:40:02 -0800 Makes JavaScriptCore match Mozilla bugzilla_4528.patch text/plain 2954 jhaygood SW5kZXg6IGtqcy9kYXRlX29iamVjdC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3Jv b3QvSmF2YVNjcmlwdENvcmUva2pzL2RhdGVfb2JqZWN0LmNwcCx2DQpyZXRyaWV2aW5nIHJldmlz aW9uIDEuNjYNCmRpZmYgLXUgLXIxLjY2IGRhdGVfb2JqZWN0LmNwcA0KLS0tIGtqcy9kYXRlX29i amVjdC5jcHAJMTYgRGVjIDIwMDUgMjM6MDE6MzMgLTAwMDAJMS42Ng0KKysrIGtqcy9kYXRlX29i amVjdC5jcHAJMzEgRGVjIDIwMDUgMjE6Mzg6MDMgLTAwMDANCkBAIC0xOTcsNiArMTk3LDI3IEBA DQogDQogI2VuZGlmIC8vIF9fQVBQTEVfXw0KIA0KKy8vIFdlIGZvbGxvdyB0aGUgcmVjb21tZW5k YXRpb24gb2YgUkZDIDI4MjIgdG8gY29uc2lkZXIgYWxsDQorLy8gb2Jzb2xldGUgdGltZSB6b25l cyBub3QgbGlzdGVkIGhlcmUgZXF1aXZhbGVudCB0byAiLTAwMDAiLg0KK3N0YXRpYyBjb25zdCBz dHJ1Y3QgS25vd25ab25lIHsNCisjaWYgIVdJTjMyDQorICAgIGNvbnN0DQorI2VuZGlmDQorICAg ICAgICBjaGFyIHR6TmFtZVs0XTsNCisgICAgaW50IHR6T2Zmc2V0Ow0KK30ga25vd25fem9uZXNb XSA9IHsNCisgICAgeyAiVVQiLCAwIH0sDQorICAgIHsgIkdNVCIsIDAgfSwNCisgICAgeyAiRVNU IiwgLTMwMCB9LA0KKyAgICB7ICJFRFQiLCAtMjQwIH0sDQorICAgIHsgIkNTVCIsIC0zNjAgfSwN CisgICAgeyAiQ0RUIiwgLTMwMCB9LA0KKyAgICB7ICJNU1QiLCAtNDIwIH0sDQorICAgIHsgIk1E VCIsIC0zNjAgfSwNCisgICAgeyAiUFNUIiwgLTQ4MCB9LA0KKyAgICB7ICJQRFQiLCAtNDIwIH0N Cit9Ow0KKw0KIHN0YXRpYyBVU3RyaW5nIGZvcm1hdERhdGUoY29uc3QgdG0gJnQpDQogew0KICAg ICBjaGFyIGJ1ZmZlclsxMDBdOw0KQEAgLTIxNywxNCArMjM4LDMwIEBADQogDQogc3RhdGljIFVT dHJpbmcgZm9ybWF0VGltZShjb25zdCB0bSAmdCkNCiB7DQorDQorICAgIGludCBrbm93blpvbmVJ ZCA9IC0xOw0KKyAgICAvLyBJdGVyYXRlIHRocm91Z2ggS25vd25ab25lIHRvIGZpbmQgdGhlIHRp bWUtem9uZQ0KKwkNCisgICAgZm9yIChpbnQgaSA9IDA7IGkgPSBzaXplb2Yoa25vd25fem9uZXMp IC8gc2l6ZW9mKEtub3duWm9uZSk7IGkrKykgew0KKw0KKyAgICAgICAgaWYgKGtub3duX3pvbmVz W2ldLnR6T2Zmc2V0ID09IGdtdE9mZnNldCkNCisgICAgICAgICAgICBrbm93blpvbmVJZCA9IGk7 DQorICAgIH0NCisJDQogICAgIGNoYXIgYnVmZmVyWzEwMF07DQogICAgIGlmICh0LnRtX2dtdG9m ZiA9PSAwKSB7DQogICAgICAgICBzbnByaW50ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiJTAy ZDolMDJkOiUwMmQgR01UIiwgdC50bV9ob3VyLCB0LnRtX21pbiwgdC50bV9zZWMpOw0KICAgICB9 IGVsc2Ugew0KLSAgICAgICAgaW50IG9mZnNldCA9IGFicyh0LnRtX2dtdG9mZik7DQotICAgICAg ICBzbnByaW50ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiJTAyZDolMDJkOiUwMmQgR01UJWMl MDJkJTAyZCIsDQotICAgICAgICAgICAgdC50bV9ob3VyLCB0LnRtX21pbiwgdC50bV9zZWMsDQot ICAgICAgICAgICAgdC50bV9nbXRvZmYgPCAwID8gJy0nIDogJysnLCBvZmZzZXQgLyAoNjAqNjAp LCAob2Zmc2V0IC8gNjApICUgNjApOw0KKwkgICAgaW50IG9mZnNldCA9IGFicyh0LnRtX2dtdG9m Zik7DQorCSAgICBpZiAoa25vd25ab25lSWQgPT0gLTEpIHsNCisgICAgICAgICAgICBzbnByaW50 ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiJTAyZDolMDJkOiUwMmQgR01UJWMlMDJkJTAyZCIs DQorICAgICAgICAgICAgICAgIHQudG1faG91ciwgdC50bV9taW4sIHQudG1fc2VjLA0KKyAgICAg ICAgICAgICAgICB0LnRtX2dtdG9mZiA8IDAgPyAnLScgOiAnKycsIG9mZnNldCAvICg2MCo2MCks IChvZmZzZXQgLyA2MCkgJSA2MCk7DQorCQl9IGVsc2Ugew0KKyAgICAgICAgICAgIHNucHJpbnRm KGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICIlMDJkOiUwMmQ6JTAyZCBHTVQlYyUwMmQlMDJkICgl cykiLA0KKyAgICAgICAgICAgICAgICB0LnRtX2hvdXIsIHQudG1fbWluLCB0LnRtX3NlYywNCisg ICAgICAgICAgICAgICAgdC50bV9nbXRvZmYgPCAwID8gJy0nIDogJysnLCBvZmZzZXQgLyAoNjAq NjApLCAob2Zmc2V0IC8gNjApICUgNjAsIGtub3duX3pvbmVzW2ldKTsNCisJCX0NCiAgICAgfQ0K ICAgICByZXR1cm4gVVN0cmluZyhidWZmZXIpOw0KIH0NCkBAIC04MzMsMjcgKzg3MCw2IEBADQog ICAgIHJldHVybiAoKGRheXMgKiBob3Vyc1BlckRheSArIGhvdXIpICogbWludXRlc1BlckhvdXIg KyBtaW51dGUpICogc2Vjb25kc1Blck1pbnV0ZSArIHNlY29uZDsNCiB9DQogDQotLy8gV2UgZm9s bG93IHRoZSByZWNvbW1lbmRhdGlvbiBvZiBSRkMgMjgyMiB0byBjb25zaWRlciBhbGwNCi0vLyBv YnNvbGV0ZSB0aW1lIHpvbmVzIG5vdCBsaXN0ZWQgaGVyZSBlcXVpdmFsZW50IHRvICItMDAwMCIu DQotc3RhdGljIGNvbnN0IHN0cnVjdCBLbm93blpvbmUgew0KLSNpZiAhV0lOMzINCi0gICAgY29u c3QNCi0jZW5kaWYNCi0gICAgICAgIGNoYXIgdHpOYW1lWzRdOw0KLSAgICBpbnQgdHpPZmZzZXQ7 DQotfSBrbm93bl96b25lc1tdID0gew0KLSAgICB7ICJVVCIsIDAgfSwNCi0gICAgeyAiR01UIiwg MCB9LA0KLSAgICB7ICJFU1QiLCAtMzAwIH0sDQotICAgIHsgIkVEVCIsIC0yNDAgfSwNCi0gICAg eyAiQ1NUIiwgLTM2MCB9LA0KLSAgICB7ICJDRFQiLCAtMzAwIH0sDQotICAgIHsgIk1TVCIsIC00 MjAgfSwNCi0gICAgeyAiTURUIiwgLTM2MCB9LA0KLSAgICB7ICJQU1QiLCAtNDgwIH0sDQotICAg IHsgIlBEVCIsIC00MjAgfQ0KLX07DQotDQogc3RhdGljIGRvdWJsZSBtYWtlVGltZSh0bSAqdCwg ZG91YmxlIG1zLCBib29sIHV0YykNCiB7DQogICAgIGludCB1dGNPZmZzZXQ7DQo= 9500 2006-07-16 12:06:49 -0700 2006-07-16 15:29:11 -0700 First attempt 4258.diff text/plain 2075 rwlbuis SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDY3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDYtMDctMTYgIFJvYiBCdWlz ICA8YnVpc0BrZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDI1OAorICAgICAgICBEYXRlKCkudG9TdHJpbmcoKSBvbmx5IGluY2x1ZGVzIEdNVCBvZmZzZXQs IG5vdCB0aW1lem9uZSBzdHJpbmcKKworICAgICAgICBVc2UgdGhlIGluZm8gaW4gdG1fem9uZSB0 byBhcHBlbmQgdGltZXpvbmUgYWJicmV2aWF0aW9uCisgICAgICAgIHRvIERhdGUoKS50b1N0cmlu ZygpLgorCisgICAgICAgICoga2pzL2RhdGVfb2JqZWN0LmNwcDoKKyAgICAgICAgKEtKUzo6Zm9y bWF0VGltZSk6CisKIDIwMDYtMDctMTUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIC0gb29wcywgbWlzc2VkIGEgZmV3IG1vcmUgYXJyYXlzIHRoYXQgaGFkIHRvIGJl IGNvbnN0CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvZGF0ZV9vYmplY3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAJKHJldmlzaW9uIDE1NDY3 KQorKysgSmF2YVNjcmlwdENvcmUva2pzL2RhdGVfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjA3LDkgKzIwNywxNSBAQCBzdGF0aWMgVVN0cmluZyBmb3JtYXRUaW1lKGNvbnN0IHRtICZ0 LCBiCiAgICAgICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICIlMDJkOiUwMmQ6 JTAyZCBHTVQiLCB0LnRtX2hvdXIsIHQudG1fbWluLCB0LnRtX3NlYyk7CiAgICAgfSBlbHNlIHsK ICAgICAgICAgaW50IG9mZnNldCA9IGFicyhnbXRvZmZzZXQodCkpOwotICAgICAgICBzbnByaW50 ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiJTAyZDolMDJkOiUwMmQgR01UJWMlMDJkJTAyZCIs Ci0gICAgICAgICAgICB0LnRtX2hvdXIsIHQudG1fbWluLCB0LnRtX3NlYywKLSAgICAgICAgICAg IGdtdG9mZnNldCh0KSA8IDAgPyAnLScgOiAnKycsIG9mZnNldCAvICg2MCo2MCksIChvZmZzZXQg LyA2MCkgJSA2MCk7CisgICAgICAgIGlmICh0LnRtX3pvbmUpIHsKKyAgICAgICAgICAgIHNucHJp bnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICIlMDJkOiUwMmQ6JTAyZCBHTVQlYyUwMmQlMDJk ICglcykiLAorICAgICAgICAgICAgICAgIHQudG1faG91ciwgdC50bV9taW4sIHQudG1fc2VjLAor ICAgICAgICAgICAgICAgIGdtdG9mZnNldCh0KSA8IDAgPyAnLScgOiAnKycsIG9mZnNldCAvICg2 MCo2MCksIChvZmZzZXQgLyA2MCkgJSA2MCwgdC50bV96b25lKTsKKyAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICIlMDJkOiUwMmQ6 JTAyZCBHTVQlYyUwMmQlMDJkIiwKKyAgICAgICAgICAgICAgICB0LnRtX2hvdXIsIHQudG1fbWlu LCB0LnRtX3NlYywKKyAgICAgICAgICAgICAgICBnbXRvZmZzZXQodCkgPCAwID8gJy0nIDogJysn LCBvZmZzZXQgLyAoNjAqNjApLCAob2Zmc2V0IC8gNjApICUgNjApOworICAgICAgICB9CiAgICAg fQogICAgIHJldHVybiBVU3RyaW5nKGJ1ZmZlcik7CiB9CkBAIC02NTgsNiArNjY0LDcgQEAgSlNW YWx1ZSAqRGF0ZVByb3RvRnVuYzo6Y2FsbEFzRnVuY3Rpb24oRQogICAgIGJyZWFrOwogICBjYXNl IFNldFllYXI6CiAgICAgdC50bV95ZWFyID0gYXJnc1swXS0+dG9JbnQzMihleGVjKSA+PSAxOTAw ID8gYXJnc1swXS0+dG9JbnQzMihleGVjKSAtIDE5MDAgOiBhcmdzWzBdLT50b0ludDMyKGV4ZWMp OworCiAgICAgYnJlYWs7CiAgIH0KIAo=