42576 2010-07-19 10:25:03 -0700 [EFL] Use log functions instead of fprintf 2010-07-20 23:29:37 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 antognolli+webkit webkit-unassigned barbieri commit-queue lucas.de.marchi tonikitoo oldest_to_newest 253282 0 antognolli+webkit 2010-07-19 10:25:03 -0700 [EFL] Use log functions instead of fprintf 253284 1 61967 antognolli+webkit 2010-07-19 10:27:00 -0700 Created attachment 61967 Patch 253285 2 tonikitoo 2010-07-19 10:29:09 -0700 lgtm. Is that functional prior to bug 40807 is fixed? 253329 3 antognolli+webkit 2010-07-19 12:35:01 -0700 Yes, it should work fine. Just the channels are not initialised before that patch, but logs are already working. 254136 4 61967 commit-queue 2010-07-20 23:29:25 -0700 Comment on attachment 61967 Patch Clearing flags on attachment: 61967 Committed r63804: <http://trac.webkit.org/changeset/63804> 254137 5 commit-queue 2010-07-20 23:29:37 -0700 All reviewed patches have been landed. Closing bug. 61967 2010-07-19 10:27:00 -0700 2010-07-20 23:29:25 -0700 Patch bug-42576-20100719142659.patch text/plain 1951 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzhiMGE3YTQyZWI2ODExZjg4YjM3YzYwMTQ3ZTBhN2NhNjU5NmY0Zi4uZTdiNDVhMzA1MDEyZTIw MDYwNzhjM2Q5MWQ4YzljMjk5YTdjNjUyMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0xOSAgUmFm YWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFVzZSBsb2cgZnVuY3Rp b25zIGluc3RlYWQgb2YgZnByaW50ZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDI1NzYKKworICAgICAgICBVc2UgTE9HIGFuZCBMT0dfRVJST1IgaW5z dGVhZCBvZiBmcHJpbnRmLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gbmV3IGZ1bmN0aW9u YWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvV2lkZ2V0RWZsLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OldpZGdldDo6YXBwbHlGYWxsYmFja0N1cnNvcik6CisKIDIwMTAtMDctMTkgIEFk YW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBhbiBhc3NlcnRpb24g d2hlbiBhIHBsdWdpbiByZXR1cm5zIC0xIGZyb20gTlBQX1dyaXRlCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9XaWRnZXRFZmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvV2lk Z2V0RWZsLmNwcAppbmRleCBkNmE0ZDA4YzliYmNkY2NlMDMxMThmMGEzMjM2OTQwZDVlMWVjZjU3 Li42ZGJmMmMyZGU4Zjk2ZmU3ZDc1ODNiZjE5OGE3NTljNWZmNTllYjE2IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9XaWRnZXRFZmwuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v ZWZsL1dpZGdldEVmbC5jcHAKQEAgLTIxMSw4ICsyMTEsOCBAQCB2b2lkIFdpZGdldDo6YXBwbHlG YWxsYmFja0N1cnNvcigpCiAgICAgICAgIGludCBzaGFwZSA9IGN1cnNvclN0cmluZ01hcC5jdXJz b3IobV9kYXRhLT5tX2N1cnNvckdyb3VwLnV0ZjgoKS5kYXRhKCkpOwogCiAgICAgICAgIGlmIChz aGFwZSA8IEVDT1JFX1hfQ1VSU09SX1ggfHwgc2hhcGUgPiBFQ09SRV9YX0NVUlNPUl9YVEVSTSkg ewotICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJFUlJPUjogY2Fubm90IG1hcCBhbiBlcXVp dmFsZW50IFggY3Vyc29yIGZvciIKLSAgICAgICAgICAgICAgICAgICAgIiBjdXJzb3IgZ3JvdXAg JXMiLCBtX2RhdGEtPm1fY3Vyc29yR3JvdXAudXRmOCgpLmRhdGEoKSk7CisgICAgICAgICAgICBM T0dfRVJST1IoImNhbm5vdCBtYXAgYW4gZXF1aXZhbGVudCBYIGN1cnNvciBmb3IiCisgICAgICAg ICAgICAgICAgICAgICAgIiBjIHVyc29yIGdyb3VwICVzIiwgbV9kYXRhLT5tX2N1cnNvckdyb3Vw LnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICAgICAgc2hhcGUgPSBFQ09SRV9YX0NVUlNPUl9MRUZU X1BUUjsKICAgICAgICAgfQogCkBAIC0yMjEsMTAgKzIyMSw5IEBAIHZvaWQgV2lkZ2V0OjphcHBs eUZhbGxiYWNrQ3Vyc29yKCkKICAgICAgICAgZWNvcmVfeF93aW5kb3dfY3Vyc29yX3NldCh3aW4s IGN1cik7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0jZWxzZQotICAgIGZwcmludGYoc3RkZXJy LCAiRVJST1I6IE9vb3BzLCBubyBmYWxsYmFjayB0byBzZXQgY3Vyc29yICVzIVxuIiwKLSAgICAg ICAgICAgIG1fZGF0YS0+bV9jdXJzb3JHcm91cC51dGY4KCkuZGF0YSgpKTsKICNlbmRpZgorICAg IExPRygiT29vcHMsIG5vIGZhbGxiYWNrIHRvIHNldCBjdXJzb3IgJXMhXG4iLAorICAgICAgICBt X2RhdGEtPm1fY3Vyc29yR3JvdXAudXRmOCgpLmRhdGEoKSk7CiB9CiAKIHZvaWQgV2lkZ2V0Ojph cHBseUN1cnNvcigpCg==