42574 2010-07-19 09:32:58 -0700 [Chromium] add webkit api reset to WebIDBDatabaseError and WebIDBKey 2010-07-26 07:23:21 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 victorw victorw fishd jorlow oldest_to_newest 253258 0 victorw 2010-07-19 09:32:58 -0700 Add webkit api reset to WebIDBDatabaseError and WebIDBKey and refactor their destructors for chromium multi dll build. 253260 1 61964 victorw 2010-07-19 09:36:10 -0700 Created attachment 61964 Proposed Patch 253814 2 victorw 2010-07-20 10:43:43 -0700 Committed r63755: <http://trac.webkit.org/changeset/63755> 256035 3 jorlow 2010-07-26 07:23:21 -0700 LGTM 61964 2010-07-19 09:36:10 -0700 2010-07-19 10:30:30 -0700 Proposed Patch webidb.patch text/plain 3854 victorw SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjM2NjkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDctMTkgIFZpY3Rv ciBXYW5nICA8dmljdG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBBZGQgd2Via2l0IGFwaSByZXNldCB0 byBXZWJJREJEYXRhYmFzZUVycm9yIGFuZCBXZWJJREJLZXkKKyAgICAgICAgYW5kIHJlZmFjdG9y IHRoZWlyIGRlc3RydWN0b3JzIGZvciBjaHJvbWl1bSBtdWx0aSBkbGwgYnVpbGQuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTc0CisKKyAgICAg ICAgKiBwdWJsaWMvV2ViSURCRGF0YWJhc2VFcnJvci5oOgorICAgICAgICAoV2ViS2l0OjpXZWJJ REJEYXRhYmFzZUVycm9yOjp+V2ViSURCRGF0YWJhc2VFcnJvcik6CisgICAgICAgICogcHVibGlj L1dlYklEQktleS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJLZXk6On5XZWJJREJLZXkpOgor ICAgICAgICAqIHNyYy9XZWJJREJEYXRhYmFzZUVycm9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViSURCRGF0YWJhc2VFcnJvcjo6cmVzZXQpOgorICAgICAgICAqIHNyYy9XZWJJREJLZXkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJJREJLZXk6OnJlc2V0KToKKwogMjAxMC0wNy0xOSAgSWx5 YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRGF0 YWJhc2VFcnJvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURC RGF0YWJhc2VFcnJvci5oCShyZXZpc2lvbiA2MzUxMykKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSURCRGF0YWJhc2VFcnJvci5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBA IG5hbWVzcGFjZSBXZWJLaXQgewogLy8gU2VlIGNvbW1lbnQgaW4gV2ViSW5kZXhlZERhdGFiYXNl IGZvciBhIGhpZ2ggbGV2ZWwgb3ZlcnZpZXcgdGhlc2UgY2xhc3Nlcy4KIGNsYXNzIFdlYklEQkRh dGFiYXNlRXJyb3IgewogcHVibGljOgotICAgIFdFQktJVF9BUEkgfldlYklEQkRhdGFiYXNlRXJy b3IoKTsKKyAgICB+V2ViSURCRGF0YWJhc2VFcnJvcigpIHsgcmVzZXQoKTsgfQogCiAgICAgV0VC S0lUX0FQSSBXZWJJREJEYXRhYmFzZUVycm9yKHVuc2lnbmVkIHNob3J0IGNvZGUsIGNvbnN0IFdl YlN0cmluZyYgbWVzc2FnZSkgeyBhc3NpZ24oY29kZSwgbWVzc2FnZSk7IH0KICAgICBXRUJLSVRf QVBJIFdlYklEQkRhdGFiYXNlRXJyb3IoY29uc3QgV2ViSURCRGF0YWJhc2VFcnJvciYgZSkgeyBh c3NpZ24oZSk7IH0KQEAgLTUxLDYgKzUxLDcgQEAgcHVibGljOgogICAgIH0KIAogICAgIFdFQktJ VF9BUEkgdm9pZCBhc3NpZ24oY29uc3QgV2ViSURCRGF0YWJhc2VFcnJvciYpOworICAgIFdFQktJ VF9BUEkgdm9pZCByZXNldCgpOwogCiAgICAgV0VCS0lUX0FQSSB1bnNpZ25lZCBzaG9ydCBjb2Rl KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgbWVzc2FnZSgpIGNvbnN0OwpJbmRl eDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJLZXkuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYklEQktleS5oCShyZXZpc2lvbiA2MzUxMykKKysrIFdlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCS2V5LmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2 LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIFdlYklEQktleSB7CiBwdWJsaWM6Ci0g ICAgfldlYklEQktleSgpOworICAgIH5XZWJJREJLZXkoKSB7IHJlc2V0KCk7IH0KICAgCiAgICAg V0VCS0lUX0FQSSBzdGF0aWMgV2ViSURCS2V5IGNyZWF0ZU51bGwoKTsKICAgICBXRUJLSVRfQVBJ IHN0YXRpYyBXZWJJREJLZXkgY3JlYXRlSW52YWxpZCgpOwpAQCAtNTUsNiArNTUsNyBAQCBwdWJs aWM6CiAgICAgV0VCS0lUX0FQSSB2b2lkIGFzc2lnbihjb25zdCBXZWJTdHJpbmcmKTsKICAgICBX RUJLSVRfQVBJIHZvaWQgYXNzaWduKGludDMyX3QpOwogICAgIFdFQktJVF9BUEkgdm9pZCBhc3Np Z25JbnZhbGlkKCk7CisgICAgV0VCS0lUX0FQSSB2b2lkIHJlc2V0KCk7CiAKICAgICBlbnVtIFR5 cGUgewogICAgICAgICBOdWxsVHlwZSA9IDAsCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dl YklEQkRhdGFiYXNlRXJyb3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViSURCRGF0YWJhc2VFcnJvci5jcHAJKHJldmlzaW9uIDYzNTEzKQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJREJEYXRhYmFzZUVycm9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsMTEg KzQwLDYgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewog Ci1XZWJJREJEYXRhYmFzZUVycm9yOjp+V2ViSURCRGF0YWJhc2VFcnJvcigpCi17Ci0gICAgbV9w cml2YXRlLnJlc2V0KCk7Ci19Ci0KIHZvaWQgV2ViSURCRGF0YWJhc2VFcnJvcjo6YXNzaWduKGNv bnN0IFdlYklEQkRhdGFiYXNlRXJyb3ImIHZhbHVlKQogewogICAgIG1fcHJpdmF0ZSA9IHZhbHVl Lm1fcHJpdmF0ZTsKQEAgLTU1LDYgKzUwLDExIEBAIHZvaWQgV2ViSURCRGF0YWJhc2VFcnJvcjo6 YXNzaWduKHVuc2lnbmUKICAgICBtX3ByaXZhdGUgPSBJREJEYXRhYmFzZUVycm9yOjpjcmVhdGUo Y29kZSwgbWVzc2FnZSk7CiB9CiAKK3ZvaWQgV2ViSURCRGF0YWJhc2VFcnJvcjo6cmVzZXQoKQor eworICAgIG1fcHJpdmF0ZS5yZXNldCgpOworfQorCiB1bnNpZ25lZCBzaG9ydCBXZWJJREJEYXRh YmFzZUVycm9yOjpjb2RlKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9wcml2YXRlLT5jb2RlKCk7 CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQktleS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJLZXkuY3BwCShyZXZpc2lvbiA2MzUxMykKKysrIFdl YktpdC9jaHJvbWl1bS9zcmMvV2ViSURCS2V5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYsMTEg KzM2LDYgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewog Ci1XZWJJREJLZXk6On5XZWJJREJLZXkoKQotewotICAgIG1fcHJpdmF0ZS5yZXNldCgpOwotfQot CiBXZWJJREJLZXkgV2ViSURCS2V5OjpjcmVhdGVOdWxsKCkKIHsKICAgICBXZWJJREJLZXkga2V5 OwpAQCAtODAsNiArNzUsMTEgQEAgdm9pZCBXZWJJREJLZXk6OmFzc2lnbkludmFsaWQoKQogICAg IG1fcHJpdmF0ZSA9IDA7CiB9CiAKK3ZvaWQgV2ViSURCS2V5OjpyZXNldCgpCit7CisgICAgbV9w cml2YXRlLnJlc2V0KCk7Cit9CisKIFdlYklEQktleTo6VHlwZSBXZWJJREJLZXk6OnR5cGUoKSBj b25zdAogewogICAgIGlmICghbV9wcml2YXRlLmdldCgpKQo=