42562 2010-07-19 07:13:22 -0700 layout tests from changeset 56661 were missed 2011-01-03 11:14:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 robert robert abarth ap commit-queue eric tkent webkit.review.bot oldest_to_newest 253176 0 robert 2010-07-19 07:13:22 -0700 These tests were omitted from changeset 56661 See also webkit.org/n/32196 277703 1 67297 robert 2010-09-11 05:21:20 -0700 Created attachment 67297 Patch 293606 2 eric 2010-10-13 12:26:47 -0700 Attachment 67297 was posted by a committer and has review+, assigning to Robert Hogan for commit. 313829 3 67297 commit-queue 2010-11-25 11:25:30 -0800 Comment on attachment 67297 Patch Rejecting patch 67297 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: /fast/forms ....... platform/mac/fast/loader ..... platform/mac/fast/objc ... platform/mac/fast/overflow . platform/mac/fast/text ............ platform/mac/fast/text/international .. platform/mac/plugins ........... platform/mac/scrollbars . plugins .. plugins/application-plugin-plugins-disabled.html -> failed Exiting early after 1 failures. 18260 tests run. 393.52s total testing time 18259 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/6379063 321785 4 eric 2010-12-14 01:33:18 -0800 Looks like this patch isnt' quite right? I assume someone else already resolved these missing results though? Should this be closed? 328422 5 robert 2011-01-02 13:14:34 -0800 Committed r74872: <http://trac.webkit.org/changeset/74872> 328430 6 webkit.review.bot 2011-01-02 14:30:15 -0800 http://trac.webkit.org/changeset/74872 might have broken Leopard Intel Release (Tests), Leopard Intel Debug (Tests), SnowLeopard Intel Release (Tests), GTK Linux 32-bit Release, and GTK Linux 64-bit Debug The following tests are not passing: plugins/application-plugin-plugins-disabled.html 328431 7 robert 2011-01-02 14:35:45 -0800 (In reply to comment #6) > http://trac.webkit.org/changeset/74872 might have broken Leopard Intel Release (Tests), Leopard Intel Debug (Tests), SnowLeopard Intel Release (Tests), GTK Linux 32-bit Release, and GTK Linux 64-bit Debug > The following tests are not passing: > plugins/application-plugin-plugins-disabled.html Fixed with http://trac.webkit.org/changeset/74876 328463 8 tkent 2011-01-02 17:56:21 -0800 Why application-plugin-plugins-disabled-expected.txt is placed in LayoutTests/plugin/, and it doesn't have the corresponding pixel result? 328528 9 robert 2011-01-03 05:06:45 -0800 (In reply to comment #8) > Why application-plugin-plugins-disabled-expected.txt is placed in LayoutTests/plugin/, and it doesn't have the corresponding pixel result? I wasn't aware pixel results were mandatory. My setup would only allow me to generate a pixel result for qt or gtk - so not even sure they would be useful. All platforms for qt should have the same result as the one given in LayoutTests/plugins/ - bar minor metric differences. 328665 10 eric 2011-01-03 11:14:09 -0800 Chromium runs pixel tests always. The rest of the port should, but don't yet. :) We used to run pixel tests for the Apple Mac port on the bots, but haven't in years. 67297 2010-09-11 05:21:20 -0700 2010-11-25 11:25:30 -0800 Patch bug-42562-20100911132118.patch text/plain 5311 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3NDJjMTMyMjAwZjVjMGM3MjYyMDliMTZkNTRjYWI0NzcwYTVjYjk2Li44YzNmNzVh NWFmODAyNmMyOGE0ZDAyYmZkNmEwNmNkN2Q1NzVmNDY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDktMTEgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExheW91dCB0ZXN0cyBmcm9t IGNoYW5nZXNldCByNTY2NjEgd2VyZSBtaXNzZWQKKworICAgICAgICBUaGlzIHRlc3RzIHdhcyBh Y2NpZGVudGFsbHkgb21pdHRlZCBmcm9tIGNoYW5nZXNldCA1NjY2MS4KKworICAgICAgICBTZWUg YWxzbyB3ZWJraXQub3JnL2IvMzIxOTYKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDI1NjIKKworICAgICAgICAqIHBsYXRmb3JtL3F0L3BsdWdpbnMv YXBwbGljYXRpb24tcGx1Z2luLXBsdWdpbnMtZGlzYWJsZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBwbHVnaW5zL2FwcGxpY2F0aW9uLXBsdWdpbi1wbHVnaW5zLWRpc2FibGVkLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGx1Z2lucy9hcHBsaWNhdGlvbi1wbHVnaW4t cGx1Z2lucy1kaXNhYmxlZC5odG1sOiBBZGRlZC4KKwogMjAxMC0wOS0xMSAgTWloYWkgUGFycGFy aXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENo YW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvcGx1Z2lucy9hcHBsaWNh dGlvbi1wbHVnaW4tcGx1Z2lucy1kaXNhYmxlZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9wbHVnaW5zL2FwcGxpY2F0aW9uLXBsdWdpbi1wbHVnaW5zLWRpc2FibGVkLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NTM0ZjJlZjRjYmUxY2MyNWZjMzBlNGE0YWI1MThkNTQw YzQwMTE0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvcGx1Z2lu cy9hcHBsaWNhdGlvbi1wbHVnaW4tcGx1Z2lucy1kaXNhYmxlZC1leHBlY3RlZC50eHQKQEAgLTAs MCArMSwyMCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVy QmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9 IGF0ICg4LDgpIHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkg c2l6ZSA3ODR4MzUKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDE0KSBzaXplIDc0 eDIxCisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMTQpIHdpZHRoIDc0OiAiUXQgUGx1Z2luOiAi CisgICAgICAgIFJlbmRlckVtYmVkZGVkT2JqZWN0IHtPQkpFQ1R9IGF0ICg3NCwwKSBzaXplIDMw MHgzMCBbUVQ6IGdlb21ldHJ5OiB7YXQgKDgyLDgpIHNpemUgMzAweDMwfSBpc0hpZGRlbjogMCBp c1NlbGZWaXNpYmxlOiAxIGlzUGFyZW50VmlzaWJsZTogMSBtYXNrOiB7YXQgKDAsMCkgc2l6ZSAz MDB4MzB9IF0gCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAor ICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMzUpIHNpemUgNzg0eDM1CisgICAgICAgIFJl bmRlclRleHQgeyN0ZXh0fSBhdCAoMCwxNCkgc2l6ZSAxMjV4MjEKKyAgICAgICAgICB0ZXh0IHJ1 biBhdCAoMCwxNCkgd2lkdGggMTI1OiAiUXQgU3R5bGVkIFdpZGdldDogIgorICAgICAgICBSZW5k ZXJFbWJlZGRlZE9iamVjdCB7T0JKRUNUfSBhdCAoMTI1LDApIHNpemUgMzAweDMwIFtRVDogZ2Vv bWV0cnk6IHthdCAoMCwwKSBzaXplIDMwMHgzMH0gaXNIaWRkZW46IDEgaXNTZWxmVmlzaWJsZTog MSBpc1BhcmVudFZpc2libGU6IDEgbWFzazoge2F0ICgwLDApIHNpemUgMHgwfSBdIAorICAgICAg ICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKKyAgICAgIFJlbmRlckJsb2Nr IHtESVZ9IGF0ICgwLDcwKSBzaXplIDc4NHgxMDUKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9 IGF0ICgwLDg0KSBzaXplIDEzOHgyMQorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDg0KSB3aWR0 aCAxMzg6ICJUaGlyZC1wYXJ0eSBwbHVnaW46ICIKKyAgICAgICAgUmVuZGVyRW1iZWRkZWRPYmpl Y3Qge0VNQkVEfSBhdCAoMTM4LDApIHNpemUgMTAweDEwMAorICAgICAgICBSZW5kZXJUZXh0IHsj dGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsdWdpbnMv YXBwbGljYXRpb24tcGx1Z2luLXBsdWdpbnMtZGlzYWJsZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvcGx1Z2lucy9hcHBsaWNhdGlvbi1wbHVnaW4tcGx1Z2lucy1kaXNhYmxlZC1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNzA3MGUwOGI3OTNiZWViMDhkZGJmMmQ2NTE2NjhhMDY2OTY2NjY1 MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsdWdpbnMvYXBwbGljYXRpb24tcGx1 Z2luLXBsdWdpbnMtZGlzYWJsZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjAgQEAKK2xheWVy IGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYw MAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAo MCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4 NHg1ODQKKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDApIHNpemUgNzg0eDM1CisgICAg ICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwxNSkgc2l6ZSA2OXgyMAorICAgICAgICAgIHRl eHQgcnVuIGF0ICgwLDE1KSB3aWR0aCA2OTogIlF0IFBsdWdpbjogIgorICAgICAgICBSZW5kZXJF bWJlZGRlZE9iamVjdCB7T0JKRUNUfSBhdCAoNjksMCkgc2l6ZSAzMDB4MzAKKyAgICAgICAgUmVu ZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICBSZW5kZXJCbG9jayB7RElW fSBhdCAoMCwzNSkgc2l6ZSA3ODR4MzUKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgw LDE1KSBzaXplIDExOHgyMAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE1KSB3aWR0aCAxMTg6 ICJRdCBTdHlsZWQgV2lkZ2V0OiAiCisgICAgICAgIFJlbmRlckVtYmVkZGVkT2JqZWN0IHtPQkpF Q1R9IGF0ICgxMTgsMCkgc2l6ZSAzMDB4MzAKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDApIHNpemUgMHgwCisgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCw3MCkgc2l6ZSA3 ODR4MTA1CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCw4NCkgc2l6ZSAxMzh4MjEK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCw4NCkgd2lkdGggMTM4OiAiVGhpcmQtcGFydHkgcGx1 Z2luOiAiCisgICAgICAgIFJlbmRlckVtYmVkZGVkT2JqZWN0IHtFTUJFRH0gYXQgKDEzOCwwKSBz aXplIDEwMHgxMDAKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgw CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5zL2FwcGxpY2F0aW9uLXBsdWdpbi1wbHVn aW5zLWRpc2FibGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL2FwcGxpY2F0aW9uLXBsdWdp bi1wbHVnaW5zLWRpc2FibGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDZjYjgyY2U2NmRhMzZiZjIwNmRj OGE0ZGM1Nzc4NDAwN2IxZWYzNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsdWdp bnMvYXBwbGljYXRpb24tcGx1Z2luLXBsdWdpbnMtZGlzYWJsZWQuaHRtbApAQCAtMCwwICsxLDM0 IEBACis8IS0tIEFwcGxpY2F0aW9uIHBsdWdpbnMgYXJlIHBsdWdpbnMgaW1wbGVtZW50ZWQgYnkg dGhlIFdlYktpdCBjbGllbnQsIGFzIG9wcG9zZWQgdG8KKyAgICAgdGhpcmQtcGFydHkgcGx1Z2lu cyBzdWNoIGFzIEZsYXNoLiBBcHBsaWNhdGlvbiBwbHVnaW5zIGFyZSBleGVtcHRlZAorICAgICBm cm9tIHRoZSBwbHVnaW5zRW5hYmxlZCBjaGVjayBhcyBpdCBpcyB0aGUgY2xpZW50IHRoYXQgaW1w bGljaXRseSBkZWNpZGVzCisgICAgIHdoZXRoZXIgb3Igbm90IHRoZXkgZW5hYmxlZCB3aGVuIGl0 IGNob29zZXMgd2hldGhlciB0byBpbXBsZW1lbnQgdGhlbSBvciBub3QuCisKKyAgICAgQXQgdGhl IHRpbWUgb2Ygd3JpdGluZywgb25seSBRdCBjbGllbnRzIGNhbiBpbXBsZW1lbnQgdGhlaXIgb3du IHBsdWdpbnMuIC0tPgorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5vdmVy cmlkZVByZWZlcmVuY2UoIldlYktpdFBsdWdpbnNFbmFibGVkIiwgZmFsc2UpOworICAgIH0KKzwv c2NyaXB0PgorCis8IS0tIHF0IHBsdWdpbiB3aWRnZXQ6IHdpbGwgYmUgY3JlYXRlZCAtLT4KKzxk aXY+CitRdCBQbHVnaW46Cis8b2JqZWN0IHR5cGU9ImFwcGxpY2F0aW9uL3gtcXQtcGx1Z2luIiBj bGFzc2lkPSJRUHJvZ3Jlc3NCYXIiIG5hbWU9InByb2dyZXNzYmFyMSIgaGVpZ2h0PTMwPjwvb2Jq ZWN0PgorPC9kaXY+CisKKzwhLS0gcXQgc3R5bGVkIHdpZGdldDogd2lsbCBiZSBjcmVhdGVkIC0t PgorPGRpdj4KK1F0IFN0eWxlZCBXaWRnZXQ6Cis8b2JqZWN0IHR5cGU9ImFwcGxpY2F0aW9uL3gt cXQtc3R5bGVkLXdpZGdldCIgY2xhc3NpZD0iUVByb2dyZXNzQmFyIiBuYW1lPSJwcm9ncmVzc2Jh cjEiIGhlaWdodD0zMD48L29iamVjdD4KKzwvZGl2PgorCis8IS0tIHRoaXJkIHBhcnR5IHBsdWdp biB3aWRnZXQ6IHdpbGwgbm90IGJlIGNyZWF0ZWQgLS0+Cis8ZGl2PgorVGhpcmQtcGFydHkgcGx1 Z2luOgorPGVtYmVkIG5hbWU9InBsZyIgdHlwZT0iYXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1u ZXRzY2FwZSIgd2lkdGg9MTAwIGhlaWdodD0xMDA+PC9lbWJlZD4KKzwvZGl2PgorCis8L2JvZHk+ Cis8L2h0bWw+Cg==