42558 2010-07-19 05:03:43 -0700 Web Inspector: hide "toggle debugger" button when debugger is always enabled 2010-07-19 10:41:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys bweinstein joepeck keishi masterov pfeldman pmuellr rik timothy yurys oldest_to_newest 253142 0 yurys 2010-07-19 05:03:43 -0700 Web Inspector: hide "toggle debugger" button when debugger is always enabled. 253143 1 61939 yurys 2010-07-19 05:05:16 -0700 Created attachment 61939 Patch 253147 2 61939 yurys 2010-07-19 05:17:50 -0700 Comment on attachment 61939 Patch Clearing flags on attachment: 61939 Committed r63649: <http://trac.webkit.org/changeset/63649> 253148 3 yurys 2010-07-19 05:18:05 -0700 All reviewed patches have been landed. Closing bug. 253266 4 joepeck 2010-07-19 09:48:43 -0700 So, now how can the user turn the debugger off? Is it lazy initialized so that it is inactive until the user visits the Scripts panel? I don't like this change unless there is something I am missing. 253267 5 pfeldman 2010-07-19 09:50:54 -0700 (In reply to comment #4) > So, now how can the user turn the debugger off? Is it lazy initialized so that > it is inactive until the user visits the Scripts panel? I don't like this change > unless there is something I am missing. This is not affecting WebKit/JSC. This was a regression on Chromium side that had debugger enabled for all times. We've lost this little diverging bit of UI while aligning with the upstream inspector code. 253269 6 joepeck 2010-07-19 09:54:28 -0700 Ahh, I see. Thanks for the explanation. 253287 7 pmuellr 2010-07-19 10:41:49 -0700 (In reply to comment #4) > So, now how can the user turn the debugger off? Is it lazy initialized so that > it is inactive until the user visits the Scripts panel? I don't like this change > unless there is something I am missing. I had the same conversation on IRC a little earlier. :-) I think this would have been clearer if instead of Preferences.debuggerAlwaysEnabled it had been something like: Platform.debuggerAlwaysEnabled In this case, the "debuggerAlwaysEnabled" isn't really a "preference", it's a static state of the platform, or something. Always true for V8, always false for JSC, at least at that point in the code. If you just went by the name alone, you'd guess, as I and probably Joe did, that this was the state associated with the radio button in the "enable script debugging" panel. A comment would have also made this clear. 61939 2010-07-19 05:05:16 -0700 2010-07-19 05:17:49 -0700 Patch bug-42558-20100719160513.patch text/plain 1534 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjk3YjU0ZjkzMDAwNDI4MTdkNWJkMDFiZjJjNGJkOWQ1NjJhYzg2Yi4uZmY2MmNkNjdkNDgzMzlk ZDk1MjRmZDZmZjEyMzI3ODUxYTQ4ZGY2YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xOSAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBoaWRlICJ0b2dnbGUg ZGVidWdnZXIiIGJ1dHRvbiB3aGVuIGRlYnVnZ2VyIGlzIGFsd2F5cyBlbmFibGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjU1OAorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuU2NyaXB0c1BhbmVsKToKKwogMjAxMC0wNy0xNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5 LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKaW5kZXggMzky YmIxY2MyYTlhM2VhOWQ2NjNkNWViYTdkNzhhMDQwOTJjMzk2Mi4uN2ExYTRkNTdkMzY1YzIwZDI3 N2ZjNGMxM2EyMjdkYjg2ZjJhNTk4OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv U2NyaXB0c1BhbmVsLmpzCkBAIC0xNTgsNiArMTU4LDggQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQ YW5lbCA9IGZ1bmN0aW9uKCkKIAogICAgIHRoaXMuZW5hYmxlVG9nZ2xlQnV0dG9uID0gbmV3IFdl Ykluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24oIiIsICJlbmFibGUtdG9nZ2xlLXN0YXR1cy1iYXIt aXRlbSIpOwogICAgIHRoaXMuZW5hYmxlVG9nZ2xlQnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNs aWNrIiwgdGhpcy5fdG9nZ2xlRGVidWdnaW5nLmJpbmQodGhpcyksIGZhbHNlKTsKKyAgICBpZiAo UHJlZmVyZW5jZXMuZGVidWdnZXJBbHdheXNFbmFibGVkKQorICAgICAgICB0aGlzLmVuYWJsZVRv Z2dsZUJ1dHRvbi5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoImhpZGRlbiIpOwogCiAgICAgdGhpcy5f cGF1c2VPbkV4Y2VwdGlvbkJ1dHRvbiA9IG5ldyBXZWJJbnNwZWN0b3IuU3RhdHVzQmFyQnV0dG9u KCIiLCAic2NyaXB0cy1wYXVzZS1vbi1leGNlcHRpb25zLXN0YXR1cy1iYXItaXRlbSIsIDMpOwog ICAgIHRoaXMuX3BhdXNlT25FeGNlcHRpb25CdXR0b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2si LCB0aGlzLl90b2dnbGVQYXVzZU9uRXhjZXB0aW9ucy5iaW5kKHRoaXMpLCBmYWxzZSk7Cg==