4255 2005-08-01 11:52:35 -0700 underlines still print too thick 2005-08-01 14:35:29 -0700 1 1 1 Unclassified WebKit Printing 420+ Mac OS X 10.4 RESOLVED FIXED http://www.nytimes.com/ P2 Normal --- 1 trey trey oldest_to_newest 15648 0 trey 2005-08-01 11:52:35 -0700 Load any page with links. Print. The underlines under the links are too thick, especially compared to how they look on the screen. #4226 improved this a bit, but it still needs work. 15650 1 trey 2005-08-01 12:05:29 -0700 Here is a particularly bad case: Set the scale in Page Setup to 50%. Now Print. The underlines are extra thick. The problem is that drawLineForCharacters: in WebTextRenderer sets an absolute thickness for lines of 0 thickness. It applies the inverse CTM to pick a size that will be fixed on the paper, regardless of any scaling. 15661 2 3199 trey 2005-08-01 14:10:34 -0700 Created attachment 3199 proposed patch 15662 3 3199 sullivan 2005-08-01 14:30:06 -0700 Comment on attachment 3199 proposed patch I tried this out, and it's a very noticeable improvement. I'll check this in shortly. 15663 4 sullivan 2005-08-01 14:35:29 -0700 Checked in. 3199 2005-08-01 14:10:34 -0700 2005-08-01 14:30:06 -0700 proposed patch 4255.patch text/plain 2020 trey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjczCmRpZmYgLXAgLXUgLXIxLjMyNzMg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMSBBdWcgMjAwNSAxOToxMToxOCAtMDAwMAkxLjMyNzMK KysrIENoYW5nZUxvZwkxIEF1ZyAyMDA1IDIxOjExOjAzIC0wMDAwCkBAIC0xLDMgKzEsMTcgQEAK KzIwMDUtMDgtMDEgIFRyZXkgTWF0dGVzb24gIDx0cmV5QHVzYS5uZXQ+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4KKworICAgICAgICBGaXhlZCBodHRwOi8vYnVnemlsbGEu b3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTUKKyAgICAgICAgICB1bmRlcmxpbmVz IHN0aWxsIHByaW50IHRvbyB0aGljaworCisgICAgICAgIFRoZSByZWFsIHByb2JsZW0gaGVyZSBp cyB0aGF0IHdlIGhhdmUgY29kZSB0aGF0IHNjYWxlcyBhIDAgd2lkdGggbGluZSB0byBhbHdheXMK KyAgICAgICAgYmUgd2lkdGg9MS4wIGluIGRldmljZSBzcGFjZS4gIEknbSBsZWF2aW5nIHRoYXQg aW4gZm9yIHRoZSBzY3JlZW4sIGJ1dCB3aGVuIHByaW50aW5nCisgICAgICAgIGEgd2lkdGggb2Yg MC41IGxvb2tzIGdvb2QuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC5zdWJwcm9qL1dlYlRl eHRSZW5kZXJlci5tOgorICAgICAgICAoLVtXZWJUZXh0UmVuZGVyZXIgZHJhd0xpbmVGb3JDaGFy YWN0ZXJzOnlPZmZzZXQ6d2lkdGg6Y29sb3I6dGhpY2tuZXNzOl0pOgorCiAyMDA1LTA4LTAxICBF cmljIFNlaWRlbCAgPGVzZWlkZWxAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IGRh cmluLgpJbmRleDogLi9XZWJDb3JlU3VwcG9ydC5zdWJwcm9qL1dlYlRleHRSZW5kZXJlci5tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJv ai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xODQKZGlmZiAtcCAt dSAtcjEuMTg0IC4vV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubQotLS0g Li9XZWJDb3JlU3VwcG9ydC5zdWJwcm9qL1dlYlRleHRSZW5kZXJlci5tCTEgQXVnIDIwMDUgMTY6 MTk6NDkgLTAwMDAJMS4xODQKKysrIC4vV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVu ZGVyZXIubQkxIEF1ZyAyMDA1IDIxOjExOjE2IC0wMDAwCkBAIC01NzYsOCArNTc2LDEyIEBAIHN0 YXRpYyBCT09MIGFsd2F5c1VzZUFUU1UgPSBOTzsKICAgICB9CiAKICAgICBpZiAodGhpY2tuZXNz ID09IDAuMEYpIHsKLSAgICAgICAgQ0dTaXplIHNpemUgPSBDR1NpemVBcHBseUFmZmluZVRyYW5z Zm9ybShDR1NpemVNYWtlKDEuMEYsIDEuMEYpLCBDR0FmZmluZVRyYW5zZm9ybUludmVydChDR0Nv bnRleHRHZXRDVE0oY2dDb250ZXh0KSkpOwotICAgICAgICBDR0NvbnRleHRTZXRMaW5lV2lkdGgo Y2dDb250ZXh0LCBzaXplLndpZHRoKTsKKyAgICAgICAgaWYgKFtncmFwaGljc0NvbnRleHQgaXNE cmF3aW5nVG9TY3JlZW5dKSB7CisgICAgICAgICAgICBDR1NpemUgc2l6ZSA9IENHU2l6ZUFwcGx5 QWZmaW5lVHJhbnNmb3JtKENHU2l6ZU1ha2UoMS4wRiwgMS4wRiksIENHQWZmaW5lVHJhbnNmb3Jt SW52ZXJ0KENHQ29udGV4dEdldENUTShjZ0NvbnRleHQpKSk7CisgICAgICAgICAgICBDR0NvbnRl eHRTZXRMaW5lV2lkdGgoY2dDb250ZXh0LCBzaXplLndpZHRoKTsKKyAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgIENHQ29udGV4dFNldExpbmVXaWR0aChjZ0NvbnRleHQsIDAuNUYpOworICAg ICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgQ0dDb250ZXh0U2V0TGluZVdpZHRoKGNnQ29u dGV4dCwgdGhpY2tuZXNzKTsKICAgICB9Cg==