42542 2010-07-18 21:44:15 -0700 Always set the current NSGraphicsContext before calling drawWithFrame 2010-07-18 22:18:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric webkit.review.bot oldest_to_newest 253059 0 andersca 2010-07-18 21:44:15 -0700 Always set the current NSGraphicsContext before calling drawWithFrame 253061 1 61926 andersca 2010-07-18 21:46:35 -0700 Created attachment 61926 Patch 253066 2 61926 sam 2010-07-18 21:48:37 -0700 Comment on attachment 61926 Patch > + No new tests. (OOPS!) Please remove this line. 253078 3 eric 2010-07-18 21:51:45 -0700 Attachment 61926 did not build on mac: Build output: http://queues.webkit.org/results/3581193 253085 4 andersca 2010-07-18 21:52:41 -0700 Committed r63642: <http://trac.webkit.org/changeset/63642> 253092 5 webkit.review.bot 2010-07-18 22:18:51 -0700 http://trac.webkit.org/changeset/63642 might have broken Chromium Mac Release 61926 2010-07-18 21:46:35 -0700 2010-07-18 21:48:37 -0700 Patch bug-42542-20100718214633.patch text/plain 3007 andersca ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDM2ZDMyYTYzMGYwMTNhMjdjM2QyMzQ3NjQ4M2UzNWM0NzgyN2QyMC4uYjM0OGY5ZmZjODkwMDFl N2Q4MmFiNjJiNTZhZmQ5NGVkNjgyODA1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNy0xOCAgQW5k ZXJzIGNhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyBzZXQgdGhlIGN1cnJlbnQgTlNHcmFw aGljc0NvbnRleHQgYmVmb3JlIGNhbGxpbmcgZHJhd1dpdGhGcmFtZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI1NDIKKworICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludE1ldGVyKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkUmVzdWx0c0Rl Y29yYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OnBhaW50U2VhcmNo RmllbGRSZXN1bHRzQnV0dG9uKToKKwogMjAxMC0wNy0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYg LS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbSBiL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IGJiZjY5MDZmYjcwM2NlYzcwNDk2NjMzMTc3 NjFiNjRhOGY5NTMwZGUuLjU3NTk0MGY1Zjc2Zjg1Y2M3MWYxZmYwNTRiNTI3MDUyZjAwNTg3MGEg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCkBAIC04MjYsNiArODI2LDggQEAgYm9v bCBSZW5kZXJUaGVtZU1hYzo6cGFpbnRNZXRlcihSZW5kZXJPYmplY3QqIHJlbmRlck9iamVjdCwg Y29uc3QgUGFpbnRJbmZvJiBwYWkKICAgICBpZiAoIXJlbmRlck9iamVjdC0+aXNNZXRlcigpKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIExvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dCBs b2NhbENvbnRleHQocGFpbnRJbmZvLmNvbnRleHQpOworCiAgICAgLy8gQmVjYXVlIE5TTGV2ZWxJ bmRpY2F0b3JDZWxsIGRvZXNuJ3Qgc3VwcG9ydCB2ZXJ0aWNhbCBnYXVnZSwgd2UgdXNlIGEgcG9y dGFibGUgdmVyc2lvbiAKICAgICBpZiAocmVjdC53aWR0aCgpIDwgcmVjdC5oZWlnaHQoKSkKICAg ICAgICAgcmV0dXJuIFJlbmRlclRoZW1lOjpwYWludE1ldGVyKHJlbmRlck9iamVjdCwgcGFpbnRJ bmZvLCByZWN0KTsKQEAgLTEzNzksOCArMTM4MSw4IEBAIGJvb2wgUmVuZGVyVGhlbWVNYWM6OnBh aW50U2xpZGVyVGh1bWIoUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5m CiAKIGJvb2wgUmVuZGVyVGhlbWVNYWM6OnBhaW50U2VhcmNoRmllbGQoUmVuZGVyT2JqZWN0KiBv LCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYgcikKIHsKLSAgICBO U1NlYXJjaEZpZWxkQ2VsbCogc2VhcmNoID0gdGhpcy0+c2VhcmNoKCk7CiAgICAgTG9jYWxDdXJy ZW50R3JhcGhpY3NDb250ZXh0IGxvY2FsQ29udGV4dChwYWludEluZm8uY29udGV4dCk7CisgICAg TlNTZWFyY2hGaWVsZENlbGwqIHNlYXJjaCA9IHRoaXMtPnNlYXJjaCgpOwogCiAgICAgc2V0U2Vh cmNoQ2VsbFN0YXRlKG8sIHIpOwogCkBAIC0xNDgwLDYgKzE0ODIsNyBAQCBib29sIFJlbmRlclRo ZW1lTWFjOjpwYWludFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29u c3QgUGFpbnRJbgogICAgIGlmICghaW5wdXQtPnJlbmRlcmVyKCktPmlzQm94KCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAorICAgIExvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dCBsb2NhbENv bnRleHQocGFpbnRJbmZvLmNvbnRleHQpOwogICAgIHNldFNlYXJjaENlbGxTdGF0ZShpbnB1dC0+ cmVuZGVyZXIoKSwgcik7CiAKICAgICBOU1NlYXJjaEZpZWxkQ2VsbCogc2VhcmNoID0gdGhpcy0+ c2VhcmNoKCk7CkBAIC0xNTY4LDYgKzE1NzEsNyBAQCBib29sIFJlbmRlclRoZW1lTWFjOjpwYWlu dFNlYXJjaEZpZWxkUmVzdWx0c0RlY29yYXRpb24oUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBQYQog ICAgIGlmICghaW5wdXQtPnJlbmRlcmVyKCktPmlzQm94KCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAorICAgIExvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dCBsb2NhbENvbnRleHQocGFpbnRJ bmZvLmNvbnRleHQpOwogICAgIHNldFNlYXJjaENlbGxTdGF0ZShpbnB1dC0+cmVuZGVyZXIoKSwg cik7CiAKICAgICBOU1NlYXJjaEZpZWxkQ2VsbCogc2VhcmNoID0gdGhpcy0+c2VhcmNoKCk7CkBA IC0xNjAwLDYgKzE2MDQsNyBAQCBib29sIFJlbmRlclRoZW1lTWFjOjpwYWludFNlYXJjaEZpZWxk UmVzdWx0c0J1dHRvbihSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SQogICAgIGlmICghaW5w dXQtPnJlbmRlcmVyKCktPmlzQm94KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIExv Y2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dCBsb2NhbENvbnRleHQocGFpbnRJbmZvLmNvbnRleHQp OwogICAgIHNldFNlYXJjaENlbGxTdGF0ZShpbnB1dC0+cmVuZGVyZXIoKSwgcik7CiAKICAgICBO U1NlYXJjaEZpZWxkQ2VsbCogc2VhcmNoID0gdGhpcy0+c2VhcmNoKCk7Cg==