42527 2010-07-18 15:26:36 -0700 [Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling 2010-07-18 15:55:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling hausmann oldest_to_newest 253016 0 kling 2010-07-18 15:26:36 -0700 Running current Qt 4.7 and WebKit ToT: FAIL! : tst_QWebElement::firstChildNextSibling() '!table.isNull()' returned FALSE. () Loc: [tst_qwebelement.cpp(898)] FAIL! : tst_QWebElement::lastChildPreviousSibling() Compared values are not the same Actual (table.tagName()): P Expected (QString("TABLE")): TABLE Loc: [tst_qwebelement.cpp(911)] The test fails because it's using invalid HTML: <body><p>Test</p><p>Test</p><table> HTML5 has the following to say about comments: Comments must start with the four character sequence U+003C LESS-THAN SIGN, U+0021 EXCLAMATION MARK, U+002D HYPHEN-MINUS, U+002D HYPHEN-MINUS (). http://www.whatwg.org/specs/web-apps/current-work/#comments 253019 1 61915 kling 2010-07-18 15:30:59 -0700 Created attachment 61915 Proposed patch Correct the HTML used by these tests. 253021 2 61915 tonikitoo 2010-07-18 15:49:20 -0700 Comment on attachment 61915 Proposed patch > diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog > index efbee15..31b488f 100644 > --- a/WebKit/qt/ChangeLog > +++ b/WebKit/qt/ChangeLog > @@ -1,3 +1,16 @@ > +2010-07-18 Andreas Kling <andreas.kling@nokia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling > + https://bugs.webkit.org/show_bug.cgi?id=42527 > + > + Correct the HTML used by these tests. > + > + * tests/qwebelement/tst_qwebelement.cpp: > + (tst_QWebElement::firstChildNextSibling): > + (tst_QWebElement::lastChildPreviousSibling): > + > 2010-07-16 Zhe Su <suzhe@chromium.org> > > Reviewed by Darin Adler. > diff --git a/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp b/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp > index 8db0ec3..2f1097a 100644 > --- a/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp > +++ b/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp > @@ -887,7 +887,7 @@ void tst_QWebElement::nullSelect() > > void tst_QWebElement::firstChildNextSibling() > { > - m_mainFrame->setHtml("<body><p>Test</p><p>Test</p><table>"); > > QWebElement body = m_mainFrame->findFirstElement("body"); > QVERIFY(!body.isNull()); > @@ -902,7 +902,7 @@ void tst_QWebElement::firstChildNextSibling() > > void tst_QWebElement::lastChildPreviousSibling() > { > - m_mainFrame->setHtml("<body><p>Test</p><p>Test</p><table>"); > > QWebElement body = m_mainFrame->findFirstElement("body"); > QVERIFY(!body.isNull()); 253024 3 61915 kling 2010-07-18 15:55:46 -0700 Comment on attachment 61915 Proposed patch Clearing flags on attachment: 61915 Committed r63637: <http://trac.webkit.org/changeset/63637> 253025 4 kling 2010-07-18 15:55:57 -0700 All reviewed patches have been landed. Closing bug. 61915 2010-07-18 15:30:59 -0700 2010-07-18 15:55:46 -0700 Proposed patch bug-42527.diff text/plain 1704 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGVmYmVlMTUuLjMxYjQ4OGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA3LTE4ICBBbmRy ZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB0c3RfUVdlYkVsZW1lbnQgZmFpbHMg Zmlyc3RDaGlsZE5leHRTaWJsaW5nIGFuZCBsYXN0Q2hpbGRQcmV2aW91c1NpYmxpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTI3CisKKyAgICAg ICAgQ29ycmVjdCB0aGUgSFRNTCB1c2VkIGJ5IHRoZXNlIHRlc3RzLgorCisgICAgICAgICogdGVz dHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcDoKKyAgICAgICAgKHRzdF9RV2ViRWxl bWVudDo6Zmlyc3RDaGlsZE5leHRTaWJsaW5nKToKKyAgICAgICAgKHRzdF9RV2ViRWxlbWVudDo6 bGFzdENoaWxkUHJldmlvdXNTaWJsaW5nKToKKwogMjAxMC0wNy0xNiAgWmhlIFN1ICA8c3V6aGVA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJlbGVtZW50L3RzdF9xd2ViZWxlbWVudC5jcHAgYi9X ZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcAppbmRleCA4ZGIw ZWMzLi4yZjEwOTdhIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0 X3F3ZWJlbGVtZW50LmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3 ZWJlbGVtZW50LmNwcApAQCAtODg3LDcgKzg4Nyw3IEBAIHZvaWQgdHN0X1FXZWJFbGVtZW50Ojpu dWxsU2VsZWN0KCkKIAogdm9pZCB0c3RfUVdlYkVsZW1lbnQ6OmZpcnN0Q2hpbGROZXh0U2libGlu ZygpCiB7Ci0gICAgbV9tYWluRnJhbWUtPnNldEh0bWwoIjxib2R5PjwhLS1jb21tZW50LS0+PHA+ VGVzdDwvcD48IS0tYW5vdGhlciBjb21tZW5kPjx0YWJsZT4iKTsKKyAgICBtX21haW5GcmFtZS0+ c2V0SHRtbCgiPGJvZHk+PCEtLWNvbW1lbnQtLT48cD5UZXN0PC9wPjwhLS1hbm90aGVyIGNvbW1l bnQtLT48dGFibGU+Iik7CiAKICAgICBRV2ViRWxlbWVudCBib2R5ID0gbV9tYWluRnJhbWUtPmZp bmRGaXJzdEVsZW1lbnQoImJvZHkiKTsKICAgICBRVkVSSUZZKCFib2R5LmlzTnVsbCgpKTsKQEAg LTkwMiw3ICs5MDIsNyBAQCB2b2lkIHRzdF9RV2ViRWxlbWVudDo6Zmlyc3RDaGlsZE5leHRTaWJs aW5nKCkKIAogdm9pZCB0c3RfUVdlYkVsZW1lbnQ6Omxhc3RDaGlsZFByZXZpb3VzU2libGluZygp CiB7Ci0gICAgbV9tYWluRnJhbWUtPnNldEh0bWwoIjxib2R5PjwhLS1jb21tZW50LS0+PHA+VGVz dDwvcD48IS0tYW5vdGhlciBjb21tZW5kPjx0YWJsZT4iKTsKKyAgICBtX21haW5GcmFtZS0+c2V0 SHRtbCgiPGJvZHk+PCEtLWNvbW1lbnQtLT48cD5UZXN0PC9wPjwhLS1hbm90aGVyIGNvbW1lbnQt LT48dGFibGU+Iik7CiAKICAgICBRV2ViRWxlbWVudCBib2R5ID0gbV9tYWluRnJhbWUtPmZpbmRG aXJzdEVsZW1lbnQoImJvZHkiKTsKICAgICBRVkVSSUZZKCFib2R5LmlzTnVsbCgpKTsK