42519 2010-07-18 11:50:35 -0700 Begin work on NPRuntime support 2010-07-18 11:59:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 252978 0 andersca 2010-07-18 11:50:35 -0700 Begin work on NPRuntime support 252979 1 61905 andersca 2010-07-18 11:51:56 -0700 Created attachment 61905 Patch 252980 2 webkit.review.bot 2010-07-18 11:53:51 -0700 Attachment 61905 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:151: NPN_GetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:154: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 252981 3 andersca 2010-07-18 11:59:44 -0700 Committed r63629: <http://trac.webkit.org/changeset/63629> 61905 2010-07-18 11:51:56 -0700 2010-07-18 11:53:46 -0700 Patch bug-42519-20100718115154.patch text/plain 6667 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MDE5M2VjNjBmM2Q4ZjYwMTczZmIwMDE0MDY1ODk5MWEyNWYzOWE1NS4uNjg5ZWNiYTMyMGUyZjY3 NWMwZWQ3ZTg0YmRhZTYyMTY2MGI4MTEyMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyOSBAQAogMjAxMC0wNy0xOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlZ2luIHdvcmsgb24gTlBSdW50aW1lIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTE5 CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2Vy RnVuY3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOUE5fR2V0VmFsdWUpOgorICAgICAgICBIYW5k bGUgTlBOVldpbmRvd05QT2JqZWN0IGFuZCBOUE5WUGx1Z2luRWxlbWVudE5QT2JqZWN0LgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcDoK KyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OndpbmRvd1NjcmlwdE5QT2JqZWN0KToK KyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsdWdpbkVsZW1lbnROUE9iamVjdCk6 CisgICAgICAgIENhbGwgdGhlIHBsdWctaW4gY29udHJvbGxlci4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvUGx1Z2lucy9QbHVnaW5Db250cm9sbGVyLmg6CisgICAgICAgIEFkZCBuZXcgd2luZG93 U2NyaXB0TlBPYmplY3QgYW5kIHBsdWdpbkVsZW1lbnROUE9iamVjdCBmdW5jdGlvbnMuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJL aXQ6OlBsdWdpblZpZXc6OndpbmRvd1NjcmlwdE5QT2JqZWN0KToKKyAgICAgICAgKFdlYktpdDo6 UGx1Z2luVmlldzo6cGx1Z2luRWxlbWVudE5QT2JqZWN0KToKKyAgICAgICAgQWRkIHN0dWJiZWQg b3V0IGZ1bmN0aW9ucy4KKworMjAxMC0wNy0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FA YXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCiAKICAgICAg ICAgSW1wbGVtZW50IHNvbWUgTlBSdW50aW1lIHJlbGF0ZWQgTlBOXyBmdW5jdGlvbnMKZGlmZiAt LWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3Nl ckZ1bmNzLmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBl QnJvd3NlckZ1bmNzLmNwcAppbmRleCBiNDUwNGM4ZGU3ZGFjZmQzNjJkMjQzZWViMzNlN2YxNGYw MGE4MTk3Li5hOTk4NTYyNWQzNGYwYzMxM2M3NWQ3NmRkODhjMjI3MDExOGFhZmQ2IDEwMDY0NAot LS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJG dW5jcy5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2Nh cGVCcm93c2VyRnVuY3MuY3BwCkBAIC0xNDgsOSArMTQ4LDIzIEBAIHN0YXRpYyBOUEVycm9yIE5Q Tl9Qb3N0VVJMTm90aWZ5KE5QUCBpbnN0YW5jZSwgY29uc3QgY2hhciogdXJsLCBjb25zdCBjaGFy KiB0YXJnCiAgICAgcmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7CiB9CiAKLXN0YXRpYyBOUEVy cm9yIE5QTl9HZXRWYWx1ZShOUFAgaW5zdGFuY2UsIE5QTlZhcmlhYmxlIHZhcmlhYmxlLCB2b2lk ICp2YWx1ZSkKK3N0YXRpYyBOUEVycm9yIE5QTl9HZXRWYWx1ZShOUFAgbnBwLCBOUE5WYXJpYWJs ZSB2YXJpYWJsZSwgdm9pZCAqdmFsdWUpCiB7CiAgICAgc3dpdGNoICh2YXJpYWJsZSkgeworICAg ICAgICBjYXNlIE5QTlZXaW5kb3dOUE9iamVjdDogeworICAgICAgICAgICAgUmVmUHRyPE5ldHNj YXBlUGx1Z2luPiBwbHVnaW4gPSBOZXRzY2FwZVBsdWdpbjo6ZnJvbU5QUChucHApOworCisgICAg ICAgICAgICBOUE9iamVjdCogd2luZG93TlBPYmplY3QgPSBwbHVnaW4tPndpbmRvd1NjcmlwdE5Q T2JqZWN0KCk7CisgICAgICAgICAgICAqKE5QT2JqZWN0KiopdmFsdWUgPSB3aW5kb3dOUE9iamVj dDsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAgIGNhc2UgTlBOVlBsdWdp bkVsZW1lbnROUE9iamVjdDogeworICAgICAgICAgICAgUmVmUHRyPE5ldHNjYXBlUGx1Z2luPiBw bHVnaW4gPSBOZXRzY2FwZVBsdWdpbjo6ZnJvbU5QUChucHApOworCisgICAgICAgICAgICBOUE9i amVjdCogcGx1Z2luRWxlbWVudE5QT2JqZWN0ID0gcGx1Z2luLT5wbHVnaW5FbGVtZW50TlBPYmpl Y3QoKTsKKyAgICAgICAgICAgICooTlBPYmplY3QqKil2YWx1ZSA9IHBsdWdpbkVsZW1lbnROUE9i amVjdDsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CiAjaWYgUExBVEZPUk0oTUFDKQog ICAgICAgICBjYXNlIE5QTlZzdXBwb3J0c0NvcmVHcmFwaGljc0Jvb2w6CiAgICAgICAgICAgICAv LyBBbHdheXMgY2xhaW0gdG8gc3VwcG9ydCB0aGUgQ29yZSBHcmFwaGljcyBkcmF3aW5nIG1vZGVs LgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2Nh cGVQbHVnaW4uY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2Nh cGVQbHVnaW4uY3BwCmluZGV4IDA1MDg5Yzg4OTY4NDZiOTFlYjhhNjRkZTk2YjlmZjkxN2ZhZjU1 MDkuLjZkNjdmOGM3YTUxYzFlOTgzODUzNTgyYzE2MzJkM2YxYTBlZWM0YjEgMTAwNjQ0Ci0tLSBh L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcAor KysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5j cHAKQEAgLTE0Myw2ICsxNDMsMTYgQEAgTlBFcnJvciBOZXRzY2FwZVBsdWdpbjo6ZGVzdHJveVN0 cmVhbShOUFN0cmVhbSogc3RyZWFtLCBOUFJlYXNvbiByZWFzb24pCiAgICAgcmV0dXJuIHBsdWdp blN0cmVhbS0+ZGVzdHJveShyZWFzb24pOwogfQogCitOUE9iamVjdCogTmV0c2NhcGVQbHVnaW46 OndpbmRvd1NjcmlwdE5QT2JqZWN0KCkKK3sKKyAgICByZXR1cm4gbV9wbHVnaW5Db250cm9sbGVy LT53aW5kb3dTY3JpcHROUE9iamVjdCgpOworfQorCitOUE9iamVjdCogTmV0c2NhcGVQbHVnaW46 OnBsdWdpbkVsZW1lbnROUE9iamVjdCgpCit7CisgICAgcmV0dXJuIG1fcGx1Z2luQ29udHJvbGxl ci0+cGx1Z2luRWxlbWVudE5QT2JqZWN0KCk7Cit9CisKIHZvaWQgTmV0c2NhcGVQbHVnaW46OmNh bmNlbFN0cmVhbUxvYWQoTmV0c2NhcGVQbHVnaW5TdHJlYW0qIHBsdWdpblN0cmVhbSkKIHsKICAg ICAvLyBBc2sgdGhlIHBsdWctaW4gY29udHJvbGxlciB0byBjYW5jZWwgdGhpcyBzdHJlYW0gbG9h ZC4KZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNj YXBlUGx1Z2luLmggYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw ZVBsdWdpbi5oCmluZGV4IDFiMmVhNjMyMDM0MWUxNDJlZmY5YjRlYWU5MjUwN2E4NWEwZWM1ZTQu Ljg4YjQ3YmRkNjM5NWI3NDZjMTRiOTNjMzE2YTViMmUyNDU5NjA3MTUgMTAwNjQ0Ci0tLSBhL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmgKKysrIGIv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaApAQCAt NTUsNiArNTUsMTAgQEAgcHVibGljOgogICAgIHZvaWQgbG9hZFVSTChjb25zdCBXZWJDb3JlOjpT dHJpbmcmIHVybFN0cmluZywgY29uc3QgV2ViQ29yZTo6U3RyaW5nJiB0YXJnZXQsIGJvb2wgc2Vu ZE5vdGlmaWNhdGlvbiwgdm9pZCogbm90aWZpY2F0aW9uRGF0YSk7CiAgICAgTlBFcnJvciBkZXN0 cm95U3RyZWFtKE5QU3RyZWFtKiwgTlBSZWFzb24pOwogCisgICAgLy8gVGhlc2UgcmV0dXJuIHJl dGFpbmVkIG9iamVjdHMuCisgICAgTlBPYmplY3QqIHdpbmRvd1NjcmlwdE5QT2JqZWN0KCk7Cisg ICAgTlBPYmplY3QqIHBsdWdpbkVsZW1lbnROUE9iamVjdCgpOworCiAgICAgdm9pZCBjYW5jZWxT dHJlYW1Mb2FkKE5ldHNjYXBlUGx1Z2luU3RyZWFtKik7CiAgICAgdm9pZCByZW1vdmVQbHVnaW5T dHJlYW0oTmV0c2NhcGVQbHVnaW5TdHJlYW0qKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luQ29udHJvbGxlci5oIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvUGx1Z2luQ29udHJvbGxlci5oCmluZGV4IDAxNjBlMzVhZjA0MjY0MjRmZTY0YWM4NGZj MGQxNmE4ZjY2OTk5ZTEuLmJiYTZkYzlhODljN2ZlMzFjNmMwNTRiN2I1ZWI5Yzg4N2RhZGU3ODkg MTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbkNvbnRyb2xsZXIu aAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Db250cm9sbGVyLmgKQEAg LTI2LDYgKzI2LDggQEAKICNpZm5kZWYgUGx1Z2luQ29udHJvbGxlcl9oCiAjZGVmaW5lIFBsdWdp bkNvbnRyb2xsZXJfaAogCitzdHJ1Y3QgTlBPYmplY3Q7CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICBjbGFzcyBJbnRSZWN0OwogICAgIGNsYXNzIEtVUkw7CkBAIC01NCw2ICs1NiwxMiBAQCBw dWJsaWM6CiAgICAgLy8vIENhbmNlbHMgdGhlIGxvYWQgb2YgYSBzdHJlYW0gdGhhdCB3YXMgcmVx dWVzdGVkIGJ5IGxvYWRVUkwuCiAgICAgdmlydHVhbCB2b2lkIGNhbmNlbFN0cmVhbUxvYWQodWlu dDY0X3Qgc3RyZWFtSUQpID0gMDsKIAorICAgIC8vIEdldCB0aGUgTlBPYmplY3QgdGhhdCBjb3Jy ZXNwb25kcyB0byB0aGUgd2luZG93IEphdmFTY3JpcHQgb2JqZWN0LiBSZXR1cm5zIGEgcmV0YWlu ZWQgb2JqZWN0LgorICAgIHZpcnR1YWwgTlBPYmplY3QqIHdpbmRvd1NjcmlwdE5QT2JqZWN0KCkg PSAwOworCisgICAgLy8gR2V0IHRoZSBOUE9iamVjdCB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZSBw bHVnLWluJ3MgZWxlbWVudC4gUmV0dXJucyBhIHJldGFpbmVkIG9iamVjdC4KKyAgICB2aXJ0dWFs IE5QT2JqZWN0KiBwbHVnaW5FbGVtZW50TlBPYmplY3QoKSA9IDA7CisKIHByb3RlY3RlZDoKICAg ICB2aXJ0dWFsIH5QbHVnaW5Db250cm9sbGVyKCkgeyB9CiB9OwpkaWZmIC0tZ2l0IGEvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAgYi9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRleCBiNzdmYTZiZDI0YmQ2NDVmOTJmMzBkZTFjNGYw ZTY3MzcwYTIyMzEyLi42ZjMxYzE2ODJkM2Y5NDU2MDVhNTQ1MmI0ZmYwYWMzNGFjMDcyN2Q5IDEw MDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAorKysg Yi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcApAQCAtNTMxLDYgKzUz MSwxOCBAQCB2b2lkIFBsdWdpblZpZXc6OmNhbmNlbFN0cmVhbUxvYWQodWludDY0X3Qgc3RyZWFt SUQpCiAgICAgcmVtb3ZlU3RyZWFtKHN0cmVhbSk7CiB9CiAKK05QT2JqZWN0KiBQbHVnaW5WaWV3 Ojp3aW5kb3dTY3JpcHROUE9iamVjdCgpCit7CisgICAgLy8gRklYTUU6IEltcGxlbWVudC4KKyAg ICByZXR1cm4gMDsKK30KKworTlBPYmplY3QqIFBsdWdpblZpZXc6OnBsdWdpbkVsZW1lbnROUE9i amVjdCgpCit7CisgICAgLy8gRklYTUU6IEltcGxlbWVudC4KKyAgICByZXR1cm4gMDsKK30KKwog dm9pZCBQbHVnaW5WaWV3OjpkaWRGaW5pc2hMb2FkKFdlYkZyYW1lKiB3ZWJGcmFtZSkKIHsKICAg ICBSZWZQdHI8VVJMUmVxdWVzdD4gcmVxdWVzdCA9IG1fcGVuZGluZ0ZyYW1lTG9hZHMudGFrZSh3 ZWJGcmFtZSk7CmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmggYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmgKaW5kZXggYTE1 YjBlZjE2MzEwN2IwYjg4ZTBmYWZhNjJmOWVlYjUzYTk0NzU1ZS4uZjM3YzAxNjk2N2JkM2EwOGEw NDlkZTRmZDkxMzlhMGFlYmZkNzhkZSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvUGx1Z2luVmlldy5oCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuaApAQCAtOTAsNiArOTAsOCBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgV2ViQ29yZTo6 U3RyaW5nIHVzZXJBZ2VudChjb25zdCBXZWJDb3JlOjpLVVJMJik7CiAgICAgdmlydHVhbCB2b2lk IGxvYWRVUkwodWludDY0X3QgcmVxdWVzdElELCBjb25zdCBXZWJDb3JlOjpTdHJpbmcmIHVybFN0 cmluZywgY29uc3QgV2ViQ29yZTo6U3RyaW5nJiB0YXJnZXQsIGJvb2wgYWxsb3dQb3B1cHMpOwog ICAgIHZpcnR1YWwgdm9pZCBjYW5jZWxTdHJlYW1Mb2FkKHVpbnQ2NF90IHN0cmVhbUlEKTsKKyAg ICB2aXJ0dWFsIE5QT2JqZWN0KiB3aW5kb3dTY3JpcHROUE9iamVjdCgpOworICAgIHZpcnR1YWwg TlBPYmplY3QqIHBsdWdpbkVsZW1lbnROUE9iamVjdCgpOwogCiAgICAgLy8gV2ViRnJhbWU6Okxv YWRMaXN0ZW5lcgogICAgIHZpcnR1YWwgdm9pZCBkaWRGaW5pc2hMb2FkKFdlYkZyYW1lKik7Cg==