42518 2010-07-18 10:05:37 -0700 Implement some NPRuntime related NPN_ functions 2010-07-18 10:46:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 252971 0 andersca 2010-07-18 10:05:37 -0700 Implement some NPRuntime related NPN_ functions 252972 1 61904 andersca 2010-07-18 10:08:34 -0700 Created attachment 61904 Patch 252973 2 webkit.review.bot 2010-07-18 10:10:42 -0700 Attachment 61904 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:264: NPN_CreateObject is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 252976 3 andersca 2010-07-18 10:46:05 -0700 Committed r63628: <http://trac.webkit.org/changeset/63628> 61904 2010-07-18 10:08:34 -0700 2010-07-18 10:32:37 -0700 Patch bug-42518-20100718100833.patch text/plain 4831 andersca ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWVmZTk1NmEyMTE0NDJlY2FhMjU4MzI3Y2UxZjU2MmEyMzJhNzczNy4uNzdjZWE0NGEwNTI4MjEz Y2E2NGU3MmU3OTc4NTQyYzU2YmQ3YTVmYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBzb21lIE5QUnVudGltZSByZWxh dGVkIE5QTl8gZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MjUxOAorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisgICAgICAgIEV4 cG9ydCBJZGVudGlmaWVyUmVwIGZ1bmN0aW9ucy4KKwogMjAxMC0wNy0xNyAgVEogTGVlICA8dGps ZWUwOTA5QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIu CmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluIGIvV2ViQ29yZS9XZWJDb3JlLmV4 cC5pbgppbmRleCBlMzEwYTJkYTMyM2Q4OGRhMTAxNTE0NjEwMzBlMDdmMjljMTA1MjU2Li4wYWNl ZjIyZjk1ZGY3Y2I5NTEyNGRjMmIxYzFjNjc2MTIyODI4ZDMzIDEwMDY0NAotLS0gYS9XZWJDb3Jl L1dlYkNvcmUuZXhwLmluCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTI4Miw2ICsy ODIsOCBAQCBfX1pON1dlYkNvcmUxM0FYT2JqZWN0Q2FjaGUyMWdBY2Nlc3NpYmlsaXR5RW5hYmxl ZEUKIF9fWk43V2ViQ29yZTEzQVhPYmplY3RDYWNoZTQyZ0FjY2Vzc2liaWxpdHlFbmhhbmNlZFVz ZXJJbnRlcmZhY2VFbmFibGVkRQogX19aTjdXZWJDb3JlMTNIaXRUZXN0UmVzdWx0QzFFUktTMF8K IF9fWk43V2ViQ29yZTEzSGl0VGVzdFJlc3VsdEQxRXYKK19fWk43V2ViQ29yZTEzSWRlbnRpZmll clJlcDNnZXRFaQorX19aTjdXZWJDb3JlMTNJZGVudGlmaWVyUmVwM2dldEVQS2MKIF9fWk43V2Vi Q29yZTEzS2V5Ym9hcmRFdmVudEMxRVJLTlNfMTJBdG9taWNTdHJpbmdFYmJQTlNfOURPTVdpbmRv d0VSS05TXzZTdHJpbmdFamJiYmJiCiBfX1pON1dlYkNvcmUxM1R5cGluZ0NvbW1hbmQzOWluc2Vy dFBhcmFncmFwaFNlcGFyYXRvckluUXVvdGVkQ29udGVudEVQTlNfOERvY3VtZW50RQogX19aTjdX ZWJDb3JlMTN0b0RldmljZVNwYWNlRVJLTlNfOUZsb2F0UmVjdEVQOE5TV2luZG93CmRpZmYgLS1n aXQgYS9XZWJLaXQyL0NoYW5nZUxvZyBiL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDAxMzJlY2Y5 MjYwYzQ5OWVhMzA0YmY0NWE5NGY5ZTY3MzAxODcwZTMuLjgzNWQ2NzJlM2I3ZTg3YWVjYmE4ZmQz OGU3MTU3Nzg5YzAwOTczYzIgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTAtMDctMTggIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgc29tZSBOUFJ1bnRpbWUgcmVsYXRlZCBOUE5f IGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDI1MTgKKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw ZUJyb3dzZXJGdW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5QTl9HZXRTdHJpbmdJZGVudGlm aWVyKToKKyAgICAgICAgKFdlYktpdDo6TlBOX0dldFN0cmluZ0lkZW50aWZpZXJzKToKKyAgICAg ICAgKFdlYktpdDo6TlBOX0dldEludElkZW50aWZpZXIpOgorICAgICAgICAoV2ViS2l0OjpOUE5f SWRlbnRpZmllcklzU3RyaW5nKToKKyAgICAgICAgKFdlYktpdDo6TlBOX1VURjhGcm9tSWRlbnRp Zmllcik6CisgICAgICAgIChXZWJLaXQ6Ok5QTl9JbnRGcm9tSWRlbnRpZmllcik6CisgICAgICAg IChXZWJLaXQ6Ok5QTl9DcmVhdGVPYmplY3QpOgorCisyMDEwLTA3LTE4ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5z dGVpbi4KIAogICAgICAgICBBZGQgZHVtcGluZyBvZiBzdGF0dXNiYXIgdGV4dCB0byBXZWJLaXRU ZXN0UnVubmVyCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAKaW5kZXggOTA3Yzk5M2M1YzE5MGRiMjU4 YThlOGYxNTFkNWJhZjBkZmU4YzU2Zi4uYjQ1MDRjOGRlN2RhY2ZkMzYyZDI0M2VlYjMzZTdmMTRm MDBhODE5NyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv TmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcApAQCAtMjcsNiArMjcsNyBAQAogCiAj aW5jbHVkZSAiTmV0c2NhcGVQbHVnaW4uaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgor I2luY2x1ZGUgPFdlYkNvcmUvSWRlbnRpZmllclJlcC5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKIApAQCAtMjE2LDQzICsyMTcsNjQgQEAgc3RhdGljIHZvaWQgTlBOX0ZvcmNlUmVkcmF3 KE5QUCBpbnN0YW5jZSkKIAogc3RhdGljIE5QSWRlbnRpZmllciBOUE5fR2V0U3RyaW5nSWRlbnRp Zmllcihjb25zdCBOUFVURjggKm5hbWUpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICBy ZXR1cm4gMDsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8TlBJZGVudGlmaWVyPihJZGVudGlmaWVy UmVwOjpnZXQobmFtZSkpOwogfQogICAgIAogc3RhdGljIHZvaWQgTlBOX0dldFN0cmluZ0lkZW50 aWZpZXJzKGNvbnN0IE5QVVRGOCAqKm5hbWVzLCBpbnQzMl90IG5hbWVDb3VudCwgTlBJZGVudGlm aWVyICppZGVudGlmaWVycykKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIEFTU0VSVChu YW1lcyk7CisgICAgQVNTRVJUKGlkZW50aWZpZXJzKTsKKworICAgIGlmICghbmFtZXMgfHwgIWlk ZW50aWZpZXJzKQorICAgICAgICByZXR1cm47CisKKyAgICBmb3IgKGludDMyX3QgaSA9IDA7IGkg PCBuYW1lQ291bnQ7ICsraSkKKyAgICAgICAgaWRlbnRpZmllcnNbaV0gPSBOUE5fR2V0U3RyaW5n SWRlbnRpZmllcihuYW1lc1tpXSk7CiB9CiAKIHN0YXRpYyBOUElkZW50aWZpZXIgTlBOX0dldElu dElkZW50aWZpZXIoaW50MzJfdCBpbnRpZCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAg IHJldHVybiAwOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxOUElkZW50aWZpZXI+KElkZW50aWZp ZXJSZXA6OmdldChpbnRpZCkpOwogfQogCiBzdGF0aWMgYm9vbCBOUE5fSWRlbnRpZmllcklzU3Ry aW5nKE5QSWRlbnRpZmllciBpZGVudGlmaWVyKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0g ICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxJZGVudGlmaWVyUmVwKj4o aWRlbnRpZmllciktPmlzU3RyaW5nKCk7CiB9CiAKIHN0YXRpYyBOUFVURjggKk5QTl9VVEY4RnJv bUlkZW50aWZpZXIoTlBJZGVudGlmaWVyIGlkZW50aWZpZXIpCiB7Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgICByZXR1cm4gMDsKKyAgICBjb25zdCBjaGFyKiBzdHJpbmcgPSBzdGF0aWNfY2Fz dDxJZGVudGlmaWVyUmVwKj4oaWRlbnRpZmllciktPnN0cmluZygpOworICAgIGlmICghc3RyaW5n KQorICAgICAgICByZXR1cm4gMDsKKworICAgIHVpbnQzMl90IHN0cmluZ0xlbmd0aCA9IHN0cmxl bihzdHJpbmcpOworICAgIGNoYXIqIHV0ZjhTdHJpbmcgPSBzdGF0aWNfY2FzdDxjaGFyKj4oTlBO X01lbUFsbG9jKHN0cmluZ0xlbmd0aCArIDEpKTsKKyAgICBtZW1jcHkodXRmOFN0cmluZywgc3Ry aW5nLCBzdHJpbmdMZW5ndGgpOworICAgIHV0ZjhTdHJpbmdbc3RyaW5nTGVuZ3RoXSA9ICdcMCc7 CisgICAgCisgICAgcmV0dXJuIHV0ZjhTdHJpbmc7CiB9CiAKIHN0YXRpYyBpbnQzMl90IE5QTl9J bnRGcm9tSWRlbnRpZmllcihOUElkZW50aWZpZXIgaWRlbnRpZmllcikKIHsKLSAgICBub3RJbXBs ZW1lbnRlZCgpOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxJZGVudGlm aWVyUmVwKj4oaWRlbnRpZmllciktPm51bWJlcigpOwogfQogCi1zdGF0aWMgTlBPYmplY3QgKk5Q Tl9DcmVhdGVPYmplY3QoTlBQIG5wcCwgTlBDbGFzcyAqYUNsYXNzKQorc3RhdGljIE5QT2JqZWN0 KiBOUE5fQ3JlYXRlT2JqZWN0KE5QUCBucHAsIE5QQ2xhc3MgKm5wQ2xhc3MpCiB7Ci0gICAgbm90 SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gMDsKKyAgICBBU1NFUlQobnBDbGFzcyk7CisKKyAg ICBOUE9iamVjdCogb2JqZWN0OworICAgIGlmIChucENsYXNzLT5hbGxvY2F0ZSkKKyAgICAgICAg b2JqZWN0ID0gbnBDbGFzcy0+YWxsb2NhdGUobnBwLCBucENsYXNzKTsKKyAgICBlbHNlCisgICAg ICAgIG9iamVjdCA9IHN0YXRpY19jYXN0PE5QT2JqZWN0Kj4oTlBOX01lbUFsbG9jKHNpemVvZihO UE9iamVjdCkpKTsKKworICAgIG9iamVjdC0+X2NsYXNzID0gbnBDbGFzczsKKyAgICBvYmplY3Qt PnJlZmVyZW5jZUNvdW50ID0gMTsKKworICAgIHJldHVybiBvYmplY3Q7CiB9CiAKIHN0YXRpYyBO UE9iamVjdCAqTlBOX1JldGFpbk9iamVjdChOUE9iamVjdCAqbnBvYmopCg==