42510 2010-07-17 18:27:56 -0700 [Qt] Canvas: Wrong internal positioning of drawImage() shadows 2010-07-19 07:47:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED HTML5, Qt, QtTriaged P2 Normal --- 42508 1 kling kling abarth eric webkit.review.bot oldest_to_newest 252932 0 kling 2010-07-17 18:27:56 -0700 There is a bug in the internal (in-shadow) positioning of shadows generated for drawImage(). They are offset by the the 'destination' rect twice. This change fixes the following in-tree tests: - canvas/philip/tests/2d.shadow.canvas.alpha.html - canvas/philip/tests/2d.shadow.canvas.transparent.1.html - canvas/philip/tests/2d.shadow.canvas.transparent.2.html - canvas/philip/tests/2d.shadow.image.alpha.html - canvas/philip/tests/2d.shadow.image.transparent.1.html - canvas/philip/tests/2d.shadow.image.transparent.2.html 252933 1 61894 kling 2010-07-17 18:31:51 -0700 Created attachment 61894 Proposed patch Note that this patch depends on bug 42508 for the drawImage(canvas, ...) part. 253188 2 61894 kling 2010-07-19 07:28:02 -0700 Comment on attachment 61894 Proposed patch Clearing flags on attachment: 61894 Committed r63657: <http://trac.webkit.org/changeset/63657> 253189 3 kling 2010-07-19 07:28:12 -0700 All reviewed patches have been landed. Closing bug. 253198 4 webkit.review.bot 2010-07-19 07:47:39 -0700 http://trac.webkit.org/changeset/63657 might have broken Qt Linux Release 61894 2010-07-17 18:31:51 -0700 2010-07-19 07:28:02 -0700 Proposed patch bug-42510.diff text/plain 4079 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxOGQ2MDRjLi5hNzEyZDU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTAtMDct MTcgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENhbnZhczogV3Jvbmcg aW50ZXJuYWwgcG9zaXRpb25pbmcgb2YgZHJhd0ltYWdlKCkgc2hhZG93cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI1MTAKKworICAgICAgICBVbnNr aXA6CisgICAgICAgIC0gY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuY2FudmFzLmFscGhh Lmh0bWwKKyAgICAgICAgLSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5jYW52YXMudHJh bnNwYXJlbnQuMS5odG1sCisgICAgICAgIC0gY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cu Y2FudmFzLnRyYW5zcGFyZW50LjIuaHRtbAorICAgICAgICAtIGNhbnZhcy9waGlsaXAvdGVzdHMv MmQuc2hhZG93LmltYWdlLmFscGhhLmh0bWwKKyAgICAgICAgLSBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLnNoYWRvdy5pbWFnZS50cmFuc3BhcmVudC4xLmh0bWwKKyAgICAgICAgLSBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLnNoYWRvdy5pbWFnZS50cmFuc3BhcmVudC4yLmh0bWwKKworICAgICAgICAq IHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKKzIwMTAtMDctMTcgIEFuZHJlYXMgS2xpbmcgIDxhbmRy ZWFzLmtsaW5nQG5va2lhLmNvbT4KKwogICAgICAgICBbUXRdIFJlc2tpcCAyZC5wYXRoLnF1YWRy YXRpY0N1cnZlVG8uc2NhbGVkLmh0bWwKIAogICAgICAgICBUaGlzIHRlc3QgZmFpbHMgd2l0aCB0 aGUgUXQgdmVyc2lvbiBydW5uaW5nIG9uIHRoZSBib3QuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApp bmRleCAwOWU0OTM2Li5hMzVhYjE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTUyODks MTIgKzUyODksNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UuaW5jb21w bGV0ZS5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UubnVsbC5odG1s CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2Uuc3RyaW5nLmh0bWwKIGNhbnZh cy9waGlsaXAvdGVzdHMvMmQucGF0dGVybi5pbWFnZS51bmRlZmluZWQuaHRtbAotY2FudmFzL3Bo aWxpcC90ZXN0cy8yZC5zaGFkb3cuY2FudmFzLmFscGhhLmh0bWwKLWNhbnZhcy9waGlsaXAvdGVz dHMvMmQuc2hhZG93LmNhbnZhcy50cmFuc3BhcmVudC4xLmh0bWwKLWNhbnZhcy9waGlsaXAvdGVz dHMvMmQuc2hhZG93LmNhbnZhcy50cmFuc3BhcmVudC4yLmh0bWwKLWNhbnZhcy9waGlsaXAvdGVz dHMvMmQuc2hhZG93LmltYWdlLmFscGhhLmh0bWwKLWNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hh ZG93LmltYWdlLnRyYW5zcGFyZW50LjEuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFk b3cuaW1hZ2UudHJhbnNwYXJlbnQuMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRv dy50cmFuc2Zvcm0uMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnRleHQuZHJhdy5iYXNl bGluZS5ib3R0b20uaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC50ZXh0LmRyYXcuYmFzZWxp bmUuaGFuZ2luZy5odG1sCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDk4MmU2NTcuLmQ4ZjBkYzIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDct MTcgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENhbnZhczogV3Jvbmcg aW50ZXJuYWwgcG9zaXRpb25pbmcgb2YgZHJhd0ltYWdlKCkgc2hhZG93cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI1MTAKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFw SW1hZ2U6OmRyYXcpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VR dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdGlsbEltYWdlOjpkcmF3KToKKwogMjAxMC0wNy0x NiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L0ltYWdlUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZVF0LmNwcApp bmRleCBlYTgwNDg3Li5lMGFjNTc0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L0ltYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1h Z2VRdC5jcHAKQEAgLTIwMiw3ICsyMDIsNyBAQCB2b2lkIEJpdG1hcEltYWdlOjpkcmF3KEdyYXBo aWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBkc3QsCiAgICAgICAgIHAuc2V0Q29t cG9zaXRpb25Nb2RlKFFQYWludGVyOjpDb21wb3NpdGlvbk1vZGVfU291cmNlKTsKICAgICAgICAg cC5maWxsUmVjdChzaGFkb3dJbWFnZS5yZWN0KCksIHNoYWRvd0NvbG9yKTsKICAgICAgICAgcC5z ZXRDb21wb3NpdGlvbk1vZGUoUVBhaW50ZXI6OkNvbXBvc2l0aW9uTW9kZV9EZXN0aW5hdGlvbklu KTsKLSAgICAgICAgcC5kcmF3UGl4bWFwKG5vcm1hbGl6ZWREc3QsICppbWFnZSwgbm9ybWFsaXpl ZFNyYyk7CisgICAgICAgIHAuZHJhd1BpeG1hcChRUmVjdCgwLCAwLCBub3JtYWxpemVkRHN0Lndp ZHRoKCksIG5vcm1hbGl6ZWREc3QuaGVpZ2h0KCkpLCAqaW1hZ2UsIG5vcm1hbGl6ZWRTcmMpOwog ICAgICAgICBwLmVuZCgpOwogICAgICAgICBwYWludGVyLT5kcmF3SW1hZ2Uoc2hhZG93SW1hZ2VS ZWN0LCBzaGFkb3dJbWFnZSwgbm9ybWFsaXplZFNyYyk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TdGlsbEltYWdlUXQuY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9TdGlsbEltYWdlUXQuY3BwCmluZGV4IGE4NWQ0MWUuLjljNmFjYWIg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFnZVF0LmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VRdC5jcHAKQEAg LTg4LDcgKzg4LDcgQEAgdm9pZCBTdGlsbEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4 dCwgY29uc3QgRmxvYXRSZWN0JiBkc3QsCiAgICAgICAgIHAuc2V0Q29tcG9zaXRpb25Nb2RlKFFQ YWludGVyOjpDb21wb3NpdGlvbk1vZGVfU291cmNlKTsKICAgICAgICAgcC5maWxsUmVjdChzaGFk b3dJbWFnZS5yZWN0KCksIHNoYWRvd0NvbG9yKTsKICAgICAgICAgcC5zZXRDb21wb3NpdGlvbk1v ZGUoUVBhaW50ZXI6OkNvbXBvc2l0aW9uTW9kZV9EZXN0aW5hdGlvbkluKTsKLSAgICAgICAgcC5k cmF3UGl4bWFwKG5vcm1hbGl6ZWREc3QsICptX3BpeG1hcCwgbm9ybWFsaXplZFNyYyk7CisgICAg ICAgIHAuZHJhd1BpeG1hcChRUmVjdCgwLCAwLCBub3JtYWxpemVkRHN0LndpZHRoKCksIG5vcm1h bGl6ZWREc3QuaGVpZ2h0KCkpLCAqbV9waXhtYXAsIG5vcm1hbGl6ZWRTcmMpOwogICAgICAgICBw LmVuZCgpOwogICAgICAgICBwYWludGVyLT5kcmF3SW1hZ2Uoc2hhZG93SW1hZ2VSZWN0LCBzaGFk b3dJbWFnZSwgbm9ybWFsaXplZFNyYyk7CiAgICAgfQo=