42508 2010-07-17 17:35:10 -0700 [Qt] Render shadow when drawing one canvas onto another 2010-07-19 12:43:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED HTML5, Qt, QtTriaged P2 Normal --- 42510 1 kling webkit-unassigned qi.2.zhang oldest_to_newest 252925 0 kling 2010-07-17 17:35:10 -0700 This test currently fails for Qt: - canvas/philip/tests/2d.shadow.canvas.basic.html 252926 1 61891 kling 2010-07-17 17:37:19 -0700 Created attachment 61891 Proposed patch 253177 2 61891 kenneth 2010-07-19 07:16:57 -0700 Comment on attachment 61891 Proposed patch LGTM. Any change in performance? 253182 3 kling 2010-07-19 07:21:27 -0700 (In reply to comment #2) > (From update of attachment 61891 [details]) > LGTM. Any change in performance? If painting with a shadow, there is obviously a slight performance penalty. But no more painful than drawing something else with a shadow. 253185 4 61891 kling 2010-07-19 07:24:44 -0700 Comment on attachment 61891 Proposed patch Clearing flags on attachment: 61891 Committed r63656: <http://trac.webkit.org/changeset/63656> 253186 5 kling 2010-07-19 07:24:54 -0700 All reviewed patches have been landed. Closing bug. 253340 6 qi.2.zhang 2010-07-19 12:43:13 -0700 *** Bug 42582 has been marked as a duplicate of this bug. *** 61891 2010-07-17 17:37:19 -0700 2010-07-19 07:24:44 -0700 Proposed patch bug-42508.diff text/plain 4354 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlNTY2MDJiLi41Yjk0MWIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTAtMDct MTcgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJlbmRlciBzaGFkb3cg d2hlbiBkcmF3aW5nIG9uZSBjYW52YXMgb250byBhbm90aGVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjUwOAorCisgICAgICAgIFVuc2tpcDoKKyAg ICAgICAgLSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5jYW52YXMuYmFzaWMuaHRtbAor CisgICAgICAgIFJlc2tpcCAoYnVnIG5vdyBleHBvc2VkKToKKyAgICAgICAgLSBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLnNoYWRvdy5jYW52YXMudHJhbnNwYXJlbnQuMS5odG1sCisKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCisyMDEwLTA3LTE3ICBBbmRyZWFzIEtsaW5nICA8YW5k cmVhcy5rbGluZ0Bub2tpYS5jb20+CisKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU2ltb24g SGF1c21hbm4uCiAKICAgICAgICAgW1F0XSBVbnNraXBwZWQgdHdvIGNhbnZhcyB0ZXN0cyB0aGF0 IGFyZSBwYXNzaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCBlNGQ5YzhiLi5hMmRjZGE1 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTUyODksNyArNTI4OSw3IEBAIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQucGF0dGVybi5pbWFnZS5udWxsLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVz dHMvMmQucGF0dGVybi5pbWFnZS5zdHJpbmcuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5w YXR0ZXJuLmltYWdlLnVuZGVmaW5lZC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRv dy5jYW52YXMuYWxwaGEuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuY2FudmFz LmJhc2ljLmh0bWwKK2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmNhbnZhcy50cmFuc3Bh cmVudC4xLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmNhbnZhcy50cmFuc3Bh cmVudC4yLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmltYWdlLmFscGhhLmh0 bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmltYWdlLnRyYW5zcGFyZW50LjEuaHRt bApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA1NTcxZmIyLi5kZWI2OTk1IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA3LTE3ICBBbmRyZWFzIEts aW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW5kZXIgc2hhZG93IHdoZW4gZHJhd2luZyBv bmUgY2FudmFzIG9udG8gYW5vdGhlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDI1MDgKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1N0 aWxsSW1hZ2VRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdGlsbEltYWdlOjpkcmF3KToKKwog MjAxMC0wNy0xNSAgUWkgWmhhbmcgIDxxaS4yLnpoYW5nQG5va2lhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFnZVF0LmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFnZVF0LmNwcAppbmRleCAwMzQyMzRkLi5hODVkNDFlIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VRdC5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TdGlsbEltYWdlUXQuY3BwCkBAIC02 Nyw0NiArNjcsMzQgQEAgdm9pZCBTdGlsbEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4 dCwgY29uc3QgRmxvYXRSZWN0JiBkc3QsCiAgICAgaWYgKG1fcGl4bWFwLT5pc051bGwoKSkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgY3R4dC0+c2F2ZSgpOwotICAgIGN0eHQtPnNldENvbXBvc2l0 ZU9wZXJhdGlvbihvcCk7Ci0KLSAgICAvLyBUbyBzdXBwb3J0IHdpZHRoIG9yIGhlaWdodCBpcyBu ZWdhdGl2ZQotICAgIGZsb2F0IHN4ID0gc3JjLngoKTsKLSAgICBmbG9hdCBzeSA9IHNyYy55KCk7 Ci0gICAgZmxvYXQgc3cgPSBzcmMud2lkdGgoKTsKLSAgICBmbG9hdCBzaCA9IHNyYy5oZWlnaHQo KTsKLQotICAgIGlmIChzdyA8IDApIHsKLSAgICAgICAgc3ggPSBzeCArIHN3OwotICAgICAgICBz dyA9IC1zdzsKLSAgICB9CiAKLSAgICBpZiAoc2ggPCAwKSB7Ci0gICAgICAgIHN5ID0gc3kgKyBz aDsKLSAgICAgICAgc2ggPSAtc2g7Ci0gICAgfQorICAgIEZsb2F0UmVjdCBub3JtYWxpemVkU3Jj ID0gc3JjLm5vcm1hbGl6ZWQoKTsKKyAgICBGbG9hdFJlY3Qgbm9ybWFsaXplZERzdCA9IGRzdC5u b3JtYWxpemVkKCk7CiAKLSAgICBmbG9hdCBkeCA9IGRzdC54KCk7Ci0gICAgZmxvYXQgZHkgPSBk c3QueSgpOwotICAgIGZsb2F0IGR3ID0gZHN0LndpZHRoKCk7Ci0gICAgZmxvYXQgZGggPSBkc3Qu aGVpZ2h0KCk7CisgICAgUVBhaW50ZXIqIHBhaW50ZXIgPSBjdHh0LT5wbGF0Zm9ybUNvbnRleHQo KTsKKyAgICBRUGFpbnRlcjo6Q29tcG9zaXRpb25Nb2RlIG9sZENvbXBvc2l0aW9uTW9kZSA9IHBh aW50ZXItPmNvbXBvc2l0aW9uTW9kZSgpOwogCi0gICAgaWYgKGR3IDwgMCkgewotICAgICAgICBk eCA9IGR4ICsgZHc7Ci0gICAgICAgIGR3ID0gLWR3OwotICAgIH0KKyAgICBjdHh0LT5zZXRDb21w b3NpdGVPcGVyYXRpb24ob3ApOwogCi0gICAgaWYgKGRoIDwgMCkgewotICAgICAgICBkeSA9IGR5 ICsgZGg7Ci0gICAgICAgIGRoID0gLWRoOworICAgIEZsb2F0U2l6ZSBzaGFkb3dTaXplOworICAg IGZsb2F0IHNoYWRvd0JsdXI7CisgICAgQ29sb3Igc2hhZG93Q29sb3I7CisgICAgaWYgKGN0eHQt PmdldFNoYWRvdyhzaGFkb3dTaXplLCBzaGFkb3dCbHVyLCBzaGFkb3dDb2xvcikpIHsKKyAgICAg ICAgRmxvYXRSZWN0IHNoYWRvd0ltYWdlUmVjdChub3JtYWxpemVkRHN0KTsKKyAgICAgICAgc2hh ZG93SW1hZ2VSZWN0Lm1vdmUoc2hhZG93U2l6ZS53aWR0aCgpLCBzaGFkb3dTaXplLmhlaWdodCgp KTsKKworICAgICAgICBRSW1hZ2Ugc2hhZG93SW1hZ2UoUVNpemUoc3RhdGljX2Nhc3Q8aW50Pihu b3JtYWxpemVkU3JjLndpZHRoKCkpLCBzdGF0aWNfY2FzdDxpbnQ+KG5vcm1hbGl6ZWRTcmMuaGVp Z2h0KCkpKSwgUUltYWdlOjpGb3JtYXRfQVJHQjMyX1ByZW11bHRpcGxpZWQpOworICAgICAgICBR UGFpbnRlciBwKCZzaGFkb3dJbWFnZSk7CisgICAgICAgIHAuc2V0Q29tcG9zaXRpb25Nb2RlKFFQ YWludGVyOjpDb21wb3NpdGlvbk1vZGVfU291cmNlKTsKKyAgICAgICAgcC5maWxsUmVjdChzaGFk b3dJbWFnZS5yZWN0KCksIHNoYWRvd0NvbG9yKTsKKyAgICAgICAgcC5zZXRDb21wb3NpdGlvbk1v ZGUoUVBhaW50ZXI6OkNvbXBvc2l0aW9uTW9kZV9EZXN0aW5hdGlvbkluKTsKKyAgICAgICAgcC5k cmF3UGl4bWFwKG5vcm1hbGl6ZWREc3QsICptX3BpeG1hcCwgbm9ybWFsaXplZFNyYyk7CisgICAg ICAgIHAuZW5kKCk7CisgICAgICAgIHBhaW50ZXItPmRyYXdJbWFnZShzaGFkb3dJbWFnZVJlY3Qs IHNoYWRvd0ltYWdlLCBub3JtYWxpemVkU3JjKTsKICAgICB9CiAKLSAgICBGbG9hdFJlY3Qgc3Jj TShzeCwgc3ksIHN3LCBzaCk7Ci0gICAgRmxvYXRSZWN0IGRzdE0oZHgsIGR5LCBkdywgZGgpOwot ICAgIFFQYWludGVyKiBwYWludGVyKGN0eHQtPnBsYXRmb3JtQ29udGV4dCgpKTsKLQotICAgIHBh aW50ZXItPmRyYXdQaXhtYXAoZHN0TSwgKm1fcGl4bWFwLCBzcmNNKTsKLSAgICBjdHh0LT5yZXN0 b3JlKCk7CisgICAgcGFpbnRlci0+ZHJhd1BpeG1hcChub3JtYWxpemVkRHN0LCAqbV9waXhtYXAs IG5vcm1hbGl6ZWRTcmMpOworICAgIHBhaW50ZXItPnNldENvbXBvc2l0aW9uTW9kZShvbGRDb21w b3NpdGlvbk1vZGUpOwogfQogCiB9Cg==