42503 2010-07-17 13:05:56 -0700 Open streams should not keep a plug-in view alive 2010-07-28 16:36:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 252897 0 andersca 2010-07-17 13:05:56 -0700 Open streams should not keep a plug-in view alive 252898 1 61886 andersca 2010-07-17 13:09:30 -0700 Created attachment 61886 Patch 257443 2 andersca 2010-07-28 16:36:20 -0700 Committed r63611: <http://trac.webkit.org/changeset/63611> 61886 2010-07-17 13:09:30 -0700 2010-07-17 13:13:28 -0700 Patch bug-42503-20100717130930.patch text/plain 5556 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YjE3NGI2NjZmMjZhMWNjODA5NWMzZGRhYmIyYTYzM2Y2YjM3MDFjZS4uMzc5Nzc0ZTRhMmE3NTc0 YzA4NWE1MTcxMTBlZDEzNjI5MTEzMzdmZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMCBAQAorMjAxMC0wNy0xNyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9wZW4gc3RyZWFtcyBzaG91bGQgbm90IGtlZXAg YSBwbHVnLWluIHZpZXcgYWxpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQyNTAzCisKKyAgICAgICAgUGx1Z2luVmlldzo6U3RyZWFtIG5vdyBoYXMg YSB3ZWFrIHJlZmVyZW5jZSB0byBpdHMgUGx1Z2luVmlldy4KKworICAgICAgICAqIFdlYlByb2Nl c3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luVmlldzo6 U3RyZWFtOjp+U3RyZWFtKToKKyAgICAgICAgQXNzZXJ0IHRoYXQgdGhlIHBsdWctaW4gdmlldyBp cyBudWxsLgorCisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OlN0cmVhbTo6ZGlkRmFpbCk6 CisgICAgICAgIEFmdGVyIGNhbGxpbmcgcmVtb3ZlU3RyZWFtLCBzZXQgdGhlIHBsdWctaW4gdmll dyBtZW1iZXIgdmFyaWFibGUgdG8gMC4gVGhpcyBpcyBPSyB0byBkbworICAgICAgICBzaW5jZSB3 ZSBrZWVwIGEgcmVmZXJlbmNlIHRvIHRoZSBTdHJlYW0sIHNvIHdlJ3JlIHN1cmUgdGhhdCB0aGUg Y2FsbCB0byByZW1vdmVTdHJlYW0gZG9lcyBub3QKKyAgICAgICAgZGVzdHJveSB0aGUgc3RyZWFt LgorCisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OlN0cmVhbTo6ZGlkRmluaXNoTG9hZGlu Zyk6CisgICAgICAgIERpdHRvIC4KKworICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3Ojp+UGx1 Z2luVmlldyk6CisgICAgICAgIENhbmNlbCBhbGwgc3RyZWFtcy4KKyAgICAgICAgCisgICAgICAg IChXZWJLaXQ6OlBsdWdpblZpZXc6OmNhbmNlbEFsbFN0cmVhbXMpOgorICAgICAgICBDYW5jZWwg YWxsIHN0cmVhbXMuCisKIDIwMTAtMDctMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAgYi9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRleCBkZjE2Mjk1ZGJiZjBmNjViYTBl ZjFhNWM5MmZkZWNlMjViNzMwOTlhLi5iNzdmYTZiZDI0YmQ2NDVmOTJmMzBkZTFjNGYwZTY3Mzcw YTIyMzEyIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcApAQCAt NzIsNiArNzIsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3 IFN0cmVhbShwbHVnaW5WaWV3LCBzdHJlYW1JRCwgcmVxdWVzdCkpOwogICAgIH0KKyAgICB+U3Ry ZWFtKCk7CiAKICAgICB2b2lkIHN0YXJ0KCk7CiAgICAgdm9pZCBjYW5jZWwoKTsKQEAgLTg2LDEz ICs4NywxNCBAQCBwcml2YXRlOgogICAgICAgICAsIG1fc3RyZWFtV2FzQ2FuY2VsbGVkKGZhbHNl KQogICAgIHsKICAgICB9CisKICAgICAvLyBOZXRzY2FwZVBsdWdpblN0cmVhbUxvYWRlckNsaWVu dAogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlUmVzcG9uc2UoTmV0c2NhcGVQbHVnSW5TdHJl YW1Mb2FkZXIqLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJik7CiAgICAgdmlydHVhbCB2b2lkIGRp ZFJlY2VpdmVEYXRhKE5ldHNjYXBlUGx1Z0luU3RyZWFtTG9hZGVyKiwgY29uc3QgY2hhciosIGlu dCk7CiAgICAgdmlydHVhbCB2b2lkIGRpZEZhaWwoTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIq LCBjb25zdCBSZXNvdXJjZUVycm9yJik7CiAgICAgdmlydHVhbCB2b2lkIGRpZEZpbmlzaExvYWRp bmcoTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIqKTsKIAotICAgIFJlZlB0cjxQbHVnaW5WaWV3 PiBtX3BsdWdpblZpZXc7CisgICAgUGx1Z2luVmlldyogbV9wbHVnaW5WaWV3OwogICAgIHVpbnQ2 NF90IG1fc3RyZWFtSUQ7CiAgICAgY29uc3QgUmVzb3VyY2VSZXF1ZXN0IG1fcmVxdWVzdDsKICAg ICAKQEAgLTEwMyw2ICsxMDUsMTEgQEAgcHJpdmF0ZToKICAgICBSZWZQdHI8TmV0c2NhcGVQbHVn SW5TdHJlYW1Mb2FkZXI+IG1fbG9hZGVyOwogfTsKIAorUGx1Z2luVmlldzo6U3RyZWFtOjp+U3Ry ZWFtKCkKK3sKKyAgICBBU1NFUlQoIW1fcGx1Z2luVmlldyk7Cit9CisgICAgCiB2b2lkIFBsdWdp blZpZXc6OlN0cmVhbTo6c3RhcnQoKQogewogICAgIEFTU0VSVCghbV9sb2FkZXIpOwpAQCAtMTc1 LDE1ICsxODIsMTUgQEAgdm9pZCBQbHVnaW5WaWV3OjpTdHJlYW06OmRpZFJlY2VpdmVEYXRhKE5l dHNjYXBlUGx1Z0luU3RyZWFtTG9hZGVyKiwgY29uc3QgY2hhcioKIAogdm9pZCBQbHVnaW5WaWV3 OjpTdHJlYW06OmRpZEZhaWwoTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIqLCBjb25zdCBSZXNv dXJjZUVycm9yJiBlcnJvcikgCiB7Ci0gICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBjYWxsIHN0cmVh bURpZEZhaWwgaWYgdGhlIHN0cmVhbSB3YXMgZXhwbGljaXRseSBjYW5jZWxsZWQgYnkgdGhlIHBs dWctaW4uCi0gICAgaWYgKG1fc3RyZWFtV2FzQ2FuY2VsbGVkKQotICAgICAgICByZXR1cm47Ci0K ICAgICAvLyBDYWxsaW5nIHN0cmVhbURpZEZhaWwgY291bGQgY2F1c2UgdXMgdG8gYmUgZGVsZXRl ZCwgc28gd2UgaG9sZCBvbiB0byBhIHJlZmVyZW5jZSBoZXJlLgogICAgIFJlZlB0cjxTdHJlYW0+ IHByb3RlY3QodGhpcyk7CiAKLSAgICBtX3BsdWdpblZpZXctPm1fcGx1Z2luLT5zdHJlYW1EaWRG YWlsKG1fc3RyZWFtSUQsIGVycm9yLmlzQ2FuY2VsbGF0aW9uKCkpOworICAgIC8vIFdlIG9ubHkg d2FudCB0byBjYWxsIHN0cmVhbURpZEZhaWwgaWYgdGhlIHN0cmVhbSB3YXMgbm90IGV4cGxpY2l0 bHkgY2FuY2VsbGVkIGJ5IHRoZSBwbHVnLWluLgorICAgIGlmICghbV9zdHJlYW1XYXNDYW5jZWxs ZWQpCisgICAgICAgIG1fcGx1Z2luVmlldy0+bV9wbHVnaW4tPnN0cmVhbURpZEZhaWwobV9zdHJl YW1JRCwgZXJyb3IuaXNDYW5jZWxsYXRpb24oKSk7CisKICAgICBtX3BsdWdpblZpZXctPnJlbW92 ZVN0cmVhbSh0aGlzKTsKKyAgICBtX3BsdWdpblZpZXcgPSAwOwogfQogCiB2b2lkIFBsdWdpblZp ZXc6OlN0cmVhbTo6ZGlkRmluaXNoTG9hZGluZyhOZXRzY2FwZVBsdWdJblN0cmVhbUxvYWRlciop CkBAIC0xOTMsNiArMjAwLDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpTdHJlYW06OmRpZEZpbmlzaExv YWRpbmcoTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIqKQogCiAgICAgbV9wbHVnaW5WaWV3LT5t X3BsdWdpbi0+c3RyZWFtRGlkRmluaXNoTG9hZGluZyhtX3N0cmVhbUlEKTsKICAgICBtX3BsdWdp blZpZXctPnJlbW92ZVN0cmVhbSh0aGlzKTsKKyAgICBtX3BsdWdpblZpZXcgPSAwOwogfQogCiBQ bHVnaW5WaWV3OjpQbHVnaW5WaWV3KFdlYkNvcmU6OkhUTUxQbHVnSW5FbGVtZW50KiBwbHVnaW5F bGVtZW50LCBQYXNzUmVmUHRyPFBsdWdpbj4gcGx1Z2luLCBjb25zdCBQbHVnaW46OlBhcmFtZXRl cnMmIHBhcmFtZXRlcnMpCkBAIC0yMTAsMTIgKzIxOCwxNiBAQCBQbHVnaW5WaWV3Ojp+UGx1Z2lu VmlldygpCiAgICAgaWYgKG1faXNXYWl0aW5nVW50aWxNZWRpYUNhblN0YXJ0KQogICAgICAgICBt X3BsdWdpbkVsZW1lbnQtPmRvY3VtZW50KCktPnJlbW92ZU1lZGlhQ2FuU3RhcnRMaXN0ZW5lcih0 aGlzKTsKIAorICAgIC8vIENhbmNlbCBhbGwgcGVuZGluZyBmcmFtZSBsb2Fkcy4KICAgICBGcmFt ZUxvYWRNYXA6Oml0ZXJhdG9yIGVuZCA9IG1fcGVuZGluZ0ZyYW1lTG9hZHMuZW5kKCk7CiAgICAg Zm9yIChGcmFtZUxvYWRNYXA6Oml0ZXJhdG9yIGl0ID0gbV9wZW5kaW5nRnJhbWVMb2Fkcy5iZWdp bigpLCBlbmQgPSBtX3BlbmRpbmdGcmFtZUxvYWRzLmVuZCgpOyBpdCAhPSBlbmQ7ICsraXQpCiAg ICAgICAgIGl0LT5maXJzdC0+c2V0TG9hZExpc3RlbmVyKDApOwotICAgIAorCiAgICAgaWYgKG1f cGx1Z2luICYmIG1faXNJbml0aWFsaXplZCkKICAgICAgICAgbV9wbHVnaW4tPmRlc3Ryb3koKTsK KworICAgIC8vIENhbmNlbCBhbGwgc3RyZWFtcy4KKyAgICBjYW5jZWxBbGxTdHJlYW1zKCk7CiB9 CiAKIHZvaWQgUGx1Z2luVmlldzo6aW5pdGlhbGl6ZVBsdWdpbigpCkBAIC00NTQsNiArNDY2LDE4 IEBAIHZvaWQgUGx1Z2luVmlldzo6cmVtb3ZlU3RyZWFtKFN0cmVhbSogc3RyZWFtKQogICAgIG1f c3RyZWFtcy5yZW1vdmUoc3RyZWFtLT5zdHJlYW1JRCgpKTsKIH0KIAordm9pZCBQbHVnaW5WaWV3 OjpjYW5jZWxBbGxTdHJlYW1zKCkKK3sKKyAgICBWZWN0b3I8UmVmUHRyPFN0cmVhbT4gPiBzdHJl YW1zOworICAgIGNvcHlWYWx1ZXNUb1ZlY3RvcihtX3N0cmVhbXMsIHN0cmVhbXMpOworICAgIAor ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgc3RyZWFtcy5zaXplKCk7ICsraSkKKyAgICAgICAg c3RyZWFtc1tpXS0+Y2FuY2VsKCk7CisKKyAgICAvLyBDYW5jZWxsaW5nIGEgc3RyZWFtIHJlbW92 ZXMgaXQgZnJvbSB0aGUgbV9zdHJlYW1zIG1hcCwgc28gaWYgd2UgY2FuY2VsIGFsbCBzdHJlYW1z IHRoZSBtYXAgc2hvdWxkIGJlIGVtcHR5LgorICAgIEFTU0VSVChtX3N0cmVhbXMuaXNFbXB0eSgp KTsKK30KKwogdm9pZCBQbHVnaW5WaWV3OjppbnZhbGlkYXRlUmVjdChjb25zdCBJbnRSZWN0JiBk aXJ0eVJlY3QpCiB7CiAgICAgaWYgKCFwYXJlbnQoKSB8fCAhbV9wbHVnaW4gfHwgIW1faXNJbml0 aWFsaXplZCkKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZp ZXcuaCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuaAppbmRleCBiZmY0 M2VlNDIyZjBiMWY2ZjRhN2NhN2RlNDY2YjRmMzJiYzExN2FiLi5hMTViMGVmMTYzMTA3YjBiODhl MGZhZmE2MmY5ZWViNTNhOTQ3NTVlIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9QbHVnaW5WaWV3LmgKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2lu Vmlldy5oCkBAIC03Myw3ICs3Myw4IEBAIHByaXZhdGU6CiAgICAgY2xhc3MgU3RyZWFtOwogICAg IHZvaWQgYWRkU3RyZWFtKFN0cmVhbSopOwogICAgIHZvaWQgcmVtb3ZlU3RyZWFtKFN0cmVhbSop OwotICAgIAorICAgIHZvaWQgY2FuY2VsQWxsU3RyZWFtcygpOworCiAgICAgLy8gV2ViQ29yZTo6 V2lkZ2V0CiAgICAgdmlydHVhbCB2b2lkIHNldEZyYW1lUmVjdChjb25zdCBXZWJDb3JlOjpJbnRS ZWN0Jik7CiAgICAgdmlydHVhbCB2b2lkIHBhaW50KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCos IGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsK