42500 2010-07-17 11:36:48 -0700 HTMLLinkElement ignores dnsPrefetchingEnabled setting 2010-11-02 12:25:04 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 opendarwin webkit-unassigned commit-queue dbates timothy webkit.review.bot oldest_to_newest 252891 0 opendarwin 2010-07-17 11:36:48 -0700 A setting to disable DNS prefetching was landed in svn r62284: http://trac.webkit.org/changeset/62284/trunk DNS prefetching is done by the ResourceHandle::prepareForURL() function. Most calls to prepareForURL() are protected by a check of whether DNS prefetching is enabled. However, HTMLLinkElement does not perform such a check: https://trac.webkit.org/browser/trunk/WebCore/html/HTMLLinkElement.cpp 193 if (m_relAttribute.m_isDNSPrefetch && m_url.isValid() && !m_url.isEmpty()) 194 ResourceHandle::prepareForURL(m_url); A check should be added here to make sure DNS prefetching is enabled before triggering DNS prefetching. 252922 1 dbates 2010-07-17 16:40:25 -0700 It doesn't seem correct to override the WebKit setting for the HTML Link element. 252927 2 61892 tjlee0909 2010-07-17 18:06:29 -0700 Created attachment 61892 patch 252928 3 webkit.review.bot 2010-07-17 18:07:56 -0700 Attachment 61892 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:19: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 252929 4 61892 timothy 2010-07-17 18:20:44 -0700 Comment on attachment 61892 patch r- for tabs. 252931 5 61893 tjlee0909 2010-07-17 18:25:33 -0700 Created attachment 61893 patch 252937 6 61893 commit-queue 2010-07-17 18:59:40 -0700 Comment on attachment 61893 patch Clearing flags on attachment: 61893 Committed r63622: <http://trac.webkit.org/changeset/63622> 252938 7 commit-queue 2010-07-17 18:59:44 -0700 All reviewed patches have been landed. Closing bug. 262431 8 ddkilzer 2010-08-09 17:35:09 -0700 <rdar://problem/8290265> 303551 9 ap 2010-11-02 12:25:04 -0700 See bug 48813. 61892 2010-07-17 18:06:29 -0700 2010-07-17 18:25:33 -0700 patch bug42500.patch text/plain 1701 tjlee0909 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzYyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMTcgIFRKIExlZSAgPHRqbGVlMDkwOUBnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTExp bmtFbGVtZW50IGlnbm9yZXMgZG5zUHJlZmV0Y2hpbmdFbmFibGVkIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTAwCisKKwkJQ2hhbmdl ZCB0aGUgSFRNTCBMaW5rIHRhZyB0byBjaGVjayB0aGF0IHRoZSBicm93c2VyCisJCWhhcyBETlMt cHJlZmV0Y2hpbmcgZW5hYmxlZCBiZWZvcmUgY2FsbGluZyBSZXNvdXJjZUhhbmRsZTo6cHJlcGFy ZUZvclVSTC4KKworCQlUaGVyZSBhcmUgbm8gdGVzdCBjYXNlcyBmb3IgdGhpcyBwYXRjaCBiZWNh dXNlIGl0IHdhcyB1bmNsZWFyIGhvdyB0byB0ZXN0CisJCXRoaXMgdXNpbmcgYSBsYXlvdXQgdGVz dC4gQSBwb3NzaWJsZSB0ZXN0IGNhc2Ugd291bGQgYmUgdG8KKwkJY2xlYXIgdGhlIEROUyBjYWNo ZSBvbiB0aGUgY2xpZW50J3MgbWFjaGluZSBiZWZvcmUgbG9hZGluZyBhIHBhZ2Ugd2l0aAorCQk8 bGluayByZWw9ImRucy1wcmVmZXRjaCIgaHJlZj0iU29tZVNpdGVUaGF0c05vdFRoZUN1cnJlbnRP bmUuY29tIj4gYW5kCisJCXRoZW4gY2hlY2sgdGhlIG51bWJlciBvZiBETlMgY2FjaGUgZW50cmll cy4KKworICAgICAgICAqIGh0bWwvSFRNTExpbmtFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxMaW5rRWxlbWVudDo6cHJvY2Vzcyk6IAorCQkKIDIwMTAtMDctMTYgIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vp bmlnLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAJKHJldmlzaW9uIDYzNjE3KQorKysg V2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MCw3 ICsxOTAsNyBAQCB2b2lkIEhUTUxMaW5rRWxlbWVudDo6cHJvY2VzcygpCiAgICAgaWYgKG1fcmVs QXR0cmlidXRlLm1faXNJY29uICYmIG1fdXJsLmlzVmFsaWQoKSAmJiAhbV91cmwuaXNFbXB0eSgp KQogICAgICAgICBkb2N1bWVudCgpLT5zZXRJY29uVVJMKG1fdXJsLnN0cmluZygpLCB0eXBlKTsK IAotICAgIGlmIChtX3JlbEF0dHJpYnV0ZS5tX2lzRE5TUHJlZmV0Y2ggJiYgbV91cmwuaXNWYWxp ZCgpICYmICFtX3VybC5pc0VtcHR5KCkpCisgICAgaWYgKG1fcmVsQXR0cmlidXRlLm1faXNETlNQ cmVmZXRjaCAmJiBkb2N1bWVudCgpLT5pc0ROU1ByZWZldGNoRW5hYmxlZCgpICYmIG1fdXJsLmlz VmFsaWQoKSAmJiAhbV91cmwuaXNFbXB0eSgpKQogICAgICAgICBSZXNvdXJjZUhhbmRsZTo6cHJl cGFyZUZvclVSTChtX3VybCk7CiAKICNpZiBFTkFCTEUoTElOS19QUkVGRVRDSCkK 61893 2010-07-17 18:25:33 -0700 2010-07-17 18:59:40 -0700 patch bug42500.patch text/plain 1740 tjlee0909 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzYyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMTcgIFRKIExlZSAgPHRqbGVlMDkwOUBnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTExp bmtFbGVtZW50IGlnbm9yZXMgZG5zUHJlZmV0Y2hpbmdFbmFibGVkIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNTAwCisKKyAgICAgICAg Q2hhbmdlZCB0aGUgSFRNTCBMaW5rIHRhZyB0byBjaGVjayB0aGF0IHRoZSBicm93c2VyCisgICAg ICAgIGhhcyBETlMtcHJlZmV0Y2hpbmcgZW5hYmxlZCBiZWZvcmUgY2FsbGluZyBSZXNvdXJjZUhh bmRsZTo6cHJlcGFyZUZvclVSTC4KKworICAgICAgICBUaGVyZSBhcmUgbm8gdGVzdCBjYXNlcyBm b3IgdGhpcyBwYXRjaCBiZWNhdXNlIGl0IHdhcyB1bmNsZWFyIGhvdyB0byB0ZXN0CisgICAgICAg IHRoaXMgdXNpbmcgYSBsYXlvdXQgdGVzdC4gQSBwb3NzaWJsZSB0ZXN0IGNhc2Ugd291bGQgYmUg dG8KKyAgICAgICAgY2xlYXIgdGhlIEROUyBjYWNoZSBvbiB0aGUgY2xpZW50J3MgbWFjaGluZSBi ZWZvcmUgbG9hZGluZyBhIHBhZ2Ugd2l0aAorICAgICAgICA8bGluayByZWw9ImRucy1wcmVmZXRj aCIgaHJlZj0iU29tZVNpdGVUaGF0c05vdFRoZUN1cnJlbnRPbmUuY29tIj4gYW5kCisgICAgICAg IHRoZW4gY2hlY2sgdGhlIG51bWJlciBvZiBETlMgY2FjaGUgZW50cmllcy4KKworICAgICAgICAq IGh0bWwvSFRNTExpbmtFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxMaW5rRWxl bWVudDo6cHJvY2Vzcyk6CisKIDIwMTAtMDctMTYgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViQ29y ZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hU TUxMaW5rRWxlbWVudC5jcHAJKHJldmlzaW9uIDYzNjE3KQorKysgV2ViQ29yZS9odG1sL0hUTUxM aW5rRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MCw3ICsxOTAsNyBAQCB2b2lkIEhU TUxMaW5rRWxlbWVudDo6cHJvY2VzcygpCiAgICAgaWYgKG1fcmVsQXR0cmlidXRlLm1faXNJY29u ICYmIG1fdXJsLmlzVmFsaWQoKSAmJiAhbV91cmwuaXNFbXB0eSgpKQogICAgICAgICBkb2N1bWVu dCgpLT5zZXRJY29uVVJMKG1fdXJsLnN0cmluZygpLCB0eXBlKTsKIAotICAgIGlmIChtX3JlbEF0 dHJpYnV0ZS5tX2lzRE5TUHJlZmV0Y2ggJiYgbV91cmwuaXNWYWxpZCgpICYmICFtX3VybC5pc0Vt cHR5KCkpCisgICAgaWYgKG1fcmVsQXR0cmlidXRlLm1faXNETlNQcmVmZXRjaCAmJiBkb2N1bWVu dCgpLT5pc0ROU1ByZWZldGNoRW5hYmxlZCgpICYmIG1fdXJsLmlzVmFsaWQoKSAmJiAhbV91cmwu aXNFbXB0eSgpKQogICAgICAgICBSZXNvdXJjZUhhbmRsZTo6cHJlcGFyZUZvclVSTChtX3VybCk7 CiAKICNpZiBFTkFCTEUoTElOS19QUkVGRVRDSCkK