42493 2010-07-16 18:43:41 -0700 [chromium] refactor npapi plugin copy step 2010-07-19 10:26:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony dglazkov tkent webkit.review.bot oldest_to_newest 252804 0 tony 2010-07-16 18:43:41 -0700 [chromium] refactor npapi plugin copy step 252806 1 61869 tony 2010-07-16 18:44:31 -0700 Created attachment 61869 Patch 252807 2 tony 2010-07-16 18:45:00 -0700 This depends on http://codereview.chromium.org/2825055/show so will also need a DEPS roll. 252808 3 webkit.review.bot 2010-07-16 18:51:12 -0700 Attachment 61869 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3564091 253028 4 61918 tony 2010-07-18 16:25:30 -0700 Created attachment 61918 Patch 253283 5 tony 2010-07-19 10:26:43 -0700 Committed r63676: <http://trac.webkit.org/changeset/63676> 61869 2010-07-16 18:44:31 -0700 2010-07-16 18:55:59 -0700 Patch bug-42493-20100716184432.patch text/plain 3520 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDhjMmExMTdhMmE0ZmQzZTBiYzM0OGY4ZDY0OWQ2MWFiNzJjZTNhNjMu LmE0YTAyMzk3YWIyYzRmNTEzMDFkYWFjMmEwZGE2MTM3NzM1MDIwYTAgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDEwLTA3LTE2ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSByZWZhY3RvciBucGFwaSBwbHVnaW4gY29weSBzdGVwCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ5MworCisgICAgICAgIFRoaXMgaXMg dG8gYXZvaWQgZHVwbGljYXRlIGNvcHkgcnVsZXMgaW4gdGhlIExpbnV4IG1ha2UgYnVpbGQuCisK KyAgICAgICAgKiBXZWJLaXQuZ3lwOgorCiAyMDEwLTA3LTE2ICBaaGUgU3UgIDxzdXpoZUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQg YS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cCBiL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lw CmluZGV4IGRiYjlkZGFlN2JjYmUzZmFiZjlkMjNjZmYwMmFmYzFjNThkYjY4YTguLmI0N2Q3NTYy NmVmNGZiZmJhYzZlZjEwMGUxNjIyMTYxNWZjM2E2MzEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9XZWJLaXQuZ3lwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBAIC03MzEs NyArNzMxLDcgQEAKICAgICAgICAgICAgICAgICAnd2Via2l0JywKICAgICAgICAgICAgICAgICAn Li4vLi4vSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5 cDp3dGZfY29uZmlnJywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGly ZF9wYXJ0eS9pY3UvaWN1Lmd5cDppY3V1YycsCi0gICAgICAgICAgICAgICAgJzwoY2hyb21pdW1f c3JjX2Rpcikvd2Via2l0L3N1cHBvcnQvd2Via2l0X3N1cHBvcnQuZ3lwOm5wYXBpX2xheW91dF90 ZXN0X3BsdWdpbicsCisgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikvd2Via2l0 L3N1cHBvcnQvd2Via2l0X3N1cHBvcnQuZ3lwOmNvcHlfbnBhcGlfbGF5b3V0X3Rlc3RfcGx1Z2lu JywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9ydC93 ZWJraXRfc3VwcG9ydC5neXA6d2Via2l0X3N1cHBvcnQnLAogICAgICAgICAgICAgICAgICc8KGNo cm9taXVtX3NyY19kaXIpL2dwdS9ncHUuZ3lwOmdsZXMyX2NfbGliJwogICAgICAgICAgICAgXSwK QEAgLTc3NywxNiArNzc3LDYgQEAKICAgICAgICAgICAgICAgICAgICAgJ2NvcGllcyc6IFt7CiAg ICAgICAgICAgICAgICAgICAgICAgICAnZGVzdGluYXRpb24nOiAnPChQUk9EVUNUX0RJUiknLAog ICAgICAgICAgICAgICAgICAgICAgICAgJ2ZpbGVzJzogWyc8KGFoZW1fcGF0aCknXSwKLSAgICAg ICAgICAgICAgICAgICAgfSwgewotICAgICAgICAgICAgICAgICAgICAgICAgIyBUaGlzIHNob3Vs ZCByZWFsbHkgYmUgZG9uZSBpbiB0aGUgJ25wYXBpX2xheW91dF90ZXN0X3BsdWdpbicKLSAgICAg ICAgICAgICAgICAgICAgICAgICMgdGFyZ2V0LCBidXQgdGhlIGN1cnJlbnQgVlMgZ2VuZXJhdG9y IGhhbmRsZXMgJ2NvcGllcycKLSAgICAgICAgICAgICAgICAgICAgICAgICMgc2V0dGluZ3MgYXMg QWRkaXRpb25hbERlcGVuZGVuY2llcywgd2hpY2ggbWVhbnMgdGhhdAotICAgICAgICAgICAgICAg ICAgICAgICAgIyB3aGVuIGl0J3Mgb3ZlciB0aGVyZSwgaXQgdHJpZXMgdG8gZG8gdGhlIGNvcHkg KmJlZm9yZSoKLSAgICAgICAgICAgICAgICAgICAgICAgICMgdGhlIGZpbGUgaXMgYnVpbHQsIGlu c3RlYWQgb2YgYWZ0ZXIuICBXZSB3b3JrIGFyb3VuZCB0aGlzCi0gICAgICAgICAgICAgICAgICAg ICAgICAjIGJ5IGF0dGFjaGluZyB0aGUgY29weSBoZXJlLCBzaW5jZSBpdCBkZXBlbmRzIG9uIHRo YXQKLSAgICAgICAgICAgICAgICAgICAgICAgICMgdGFyZ2V0LgotICAgICAgICAgICAgICAgICAg ICAgICAgJ2Rlc3RpbmF0aW9uJzogJzwoUFJPRFVDVF9ESVIpL3BsdWdpbnMnLAotICAgICAgICAg ICAgICAgICAgICAgICAgJ2ZpbGVzJzogWyc8KFBST0RVQ1RfRElSKS9ucGFwaV9sYXlvdXRfdGVz dF9wbHVnaW4uZGxsJ10sCiAgICAgICAgICAgICAgICAgICAgIH1dLAogICAgICAgICAgICAgICAg IH0seyAjIE9TIT0id2luIgogICAgICAgICAgICAgICAgICAgICAnc291cmNlcy8nOiBbCkBAIC04 MzEsMTAgKzgyMSw2IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAnLi4vLi4vV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjkwMC50dGYnLAogICAg ICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC90 ZXh0QXJlYVJlc2l6ZUNvcm5lci5wbmcnLAogICAgICAgICAgICAgICAgICAgICBdLAotICAgICAg ICAgICAgICAgICAgICAnY29waWVzJzogW3sKLSAgICAgICAgICAgICAgICAgICAgICAgICdkZXN0 aW5hdGlvbic6ICc8KFBST0RVQ1RfRElSKS9EdW1wUmVuZGVyVHJlZS5hcHAvQ29udGVudHMvUGx1 Z0lucy8nLAotICAgICAgICAgICAgICAgICAgICAgICAgJ2ZpbGVzJzogWyc8KFBST0RVQ1RfRElS KS9UZXN0TmV0c2NhcGVQbHVnSW4ucGx1Z2luLyddLAotICAgICAgICAgICAgICAgICAgICB9XSwK ICAgICAgICAgICAgICAgICB9LHsgIyBPUyE9Im1hYyIKICAgICAgICAgICAgICAgICAgICAgJ3Nv dXJjZXMvJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgIyAubW0gaXMgYWxyZWFkeSBleGNs dWRlZCBieSBjb21tb24uZ3lwaQpAQCAtODQ5LDkgKzgzNSw2IEBACiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJy4uLy4uL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL2Zv bnRzLmNvbmYnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICc8KElOVEVSTUVESUFURV9E SVIpL3JlcGFjay9EdW1wUmVuZGVyVHJlZS5wYWsnLAogICAgICAgICAgICAgICAgICAgICAgICAg XQotICAgICAgICAgICAgICAgICAgICB9LCB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAnZGVz dGluYXRpb24nOiAnPChQUk9EVUNUX0RJUikvcGx1Z2lucycsCi0gICAgICAgICAgICAgICAgICAg ICAgICAnZmlsZXMnOiBbJzwoUFJPRFVDVF9ESVIpL2xpYm5wYXBpX2xheW91dF90ZXN0X3BsdWdp bi5zbyddLAogICAgICAgICAgICAgICAgICAgICB9XSwKICAgICAgICAgICAgICAgICB9LHsgIyBP UyE9ImxpbnV4IiBhbmQgT1MhPSJmcmVlYnNkIiBhbmQgT1MhPSJvcGVuYnNkIiBhbmQgT1MhPSJz b2xhcmlzIgogICAgICAgICAgICAgICAgICAgICAnc291cmNlcy8nOiBbCg== 61918 2010-07-18 16:25:30 -0700 2010-07-18 16:25:30 -0700 Patch bug-42493-20100718162535.patch text/plain 4311 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDNlYzdlMjliMmNlY2NhMGIzYmFjODIyNTg4Nzc5ZTFhMThmZWFhMjgu Ljk4NmZmMjQyZDBjNDM4MDJmODY1ZGMwNzY3MzdhODNlM2UxZTkxNWYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA3LTE4ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSByZWZhY3RvciBucGFwaSBwbHVnaW4gY29weSBzdGVwCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ5MworCisgICAgICAgIFRoaXMgaXMg dG8gYXZvaWQgZHVwbGljYXRlIGNvcHkgcnVsZXMgaW4gdGhlIExpbnV4IG1ha2UgYnVpbGQuCisK KyAgICAgICAgKiBXZWJLaXQuZ3lwOgorICAgICAgICAqIERFUFM6IDUyNDgzOjUyODY5CisKIDIw MTAtMDctMTYgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9ERVBTIGIvV2ViS2l0L2Nocm9taXVtL0RFUFMKaW5kZXggNjBiM2EwNzdlN2E1NjMyNjQy NzVmMGJhNzMxODg5ZDRmMmVlYTA1Ni4uMjRiZjM4OWQ5NDMxMGFlMDY2ZjJmYzFkY2ExNDdlZmY4 ZmE4ZTJhMCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvV2ViS2l0L2No cm9taXVtL0RFUFMKQEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2Nocm9taXVtX3N2 bic6ICdodHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVt X3Jldic6ICc1MjQ4MycsCisgICdjaHJvbWl1bV9yZXYnOiAnNTI4NjknLAogfQogCiBkZXBzID0g ewpAQCAtODksNiArODksOCBAQCBkZXBzID0gewogICAgIFZhcignY2hyb21pdW1fc3ZuJykrJy9n cHVAJytWYXIoJ2Nocm9taXVtX3JldicpLAogICAnbWVkaWEnOgogICAgIFZhcignY2hyb21pdW1f c3ZuJykrJy9tZWRpYUAnK1ZhcignY2hyb21pdW1fcmV2JyksCisgICdwcmludGluZyc6CisgICAg VmFyKCdjaHJvbWl1bV9zdm4nKSsnL3ByaW50aW5nQCcrVmFyKCdjaHJvbWl1bV9yZXYnKSwKICAg J3RoaXJkX3BhcnR5L2FuZ2xlJzogICMgbmVlZGVkIGJ5IHRoZSBncHUgcHJvY2VzcwogICAgIEZy b20oJ2Nocm9taXVtX2RlcHMnLCAnc3JjL3RoaXJkX3BhcnR5L2FuZ2xlJyksCiAgICd0aGlyZF9w YXJ0eS9mZm1wZWcnOiAjIG5lZWRlZCBieSB3ZWJraXQvbWVkaWEKZGlmZiAtLWdpdCBhL1dlYktp dC9jaHJvbWl1bS9XZWJLaXQuZ3lwIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXgg ZGJiOWRkYWU3YmNiZTNmYWJmOWQyM2NmZjAyYWZjMWM1OGRiNjhhOC4uYjQ3ZDc1NjI2ZWY0ZmJm YmFjNmVmMTAwZTE2MjIxNjE1ZmMzYTYzMSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL1dl YktpdC5neXAKKysrIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKQEAgLTczMSw3ICs3MzEs NyBAQAogICAgICAgICAgICAgICAgICd3ZWJraXQnLAogICAgICAgICAgICAgICAgICcuLi8uLi9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnd0Zl9j b25maWcnLAogICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5 L2ljdS9pY3UuZ3lwOmljdXVjJywKLSAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGly KS93ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5neXA6bnBhcGlfbGF5b3V0X3Rlc3RfcGx1 Z2luJywKKyAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9y dC93ZWJraXRfc3VwcG9ydC5neXA6Y29weV9ucGFwaV9sYXlvdXRfdGVzdF9wbHVnaW4nLAogICAg ICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3dlYmtpdC9zdXBwb3J0L3dlYmtpdF9z dXBwb3J0Lmd5cDp3ZWJraXRfc3VwcG9ydCcsCiAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1f c3JjX2RpcikvZ3B1L2dwdS5neXA6Z2xlczJfY19saWInCiAgICAgICAgICAgICBdLApAQCAtNzc3 LDE2ICs3NzcsNiBAQAogICAgICAgICAgICAgICAgICAgICAnY29waWVzJzogW3sKICAgICAgICAg ICAgICAgICAgICAgICAgICdkZXN0aW5hdGlvbic6ICc8KFBST0RVQ1RfRElSKScsCiAgICAgICAg ICAgICAgICAgICAgICAgICAnZmlsZXMnOiBbJzwoYWhlbV9wYXRoKSddLAotICAgICAgICAgICAg ICAgICAgICB9LCB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAjIFRoaXMgc2hvdWxkIHJlYWxs eSBiZSBkb25lIGluIHRoZSAnbnBhcGlfbGF5b3V0X3Rlc3RfcGx1Z2luJwotICAgICAgICAgICAg ICAgICAgICAgICAgIyB0YXJnZXQsIGJ1dCB0aGUgY3VycmVudCBWUyBnZW5lcmF0b3IgaGFuZGxl cyAnY29waWVzJwotICAgICAgICAgICAgICAgICAgICAgICAgIyBzZXR0aW5ncyBhcyBBZGRpdGlv bmFsRGVwZW5kZW5jaWVzLCB3aGljaCBtZWFucyB0aGF0Ci0gICAgICAgICAgICAgICAgICAgICAg ICAjIHdoZW4gaXQncyBvdmVyIHRoZXJlLCBpdCB0cmllcyB0byBkbyB0aGUgY29weSAqYmVmb3Jl KgotICAgICAgICAgICAgICAgICAgICAgICAgIyB0aGUgZmlsZSBpcyBidWlsdCwgaW5zdGVhZCBv ZiBhZnRlci4gIFdlIHdvcmsgYXJvdW5kIHRoaXMKLSAgICAgICAgICAgICAgICAgICAgICAgICMg YnkgYXR0YWNoaW5nIHRoZSBjb3B5IGhlcmUsIHNpbmNlIGl0IGRlcGVuZHMgb24gdGhhdAotICAg ICAgICAgICAgICAgICAgICAgICAgIyB0YXJnZXQuCi0gICAgICAgICAgICAgICAgICAgICAgICAn ZGVzdGluYXRpb24nOiAnPChQUk9EVUNUX0RJUikvcGx1Z2lucycsCi0gICAgICAgICAgICAgICAg ICAgICAgICAnZmlsZXMnOiBbJzwoUFJPRFVDVF9ESVIpL25wYXBpX2xheW91dF90ZXN0X3BsdWdp bi5kbGwnXSwKICAgICAgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICAgICAgfSx7ICMg T1MhPSJ3aW4iCiAgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsKQEAgLTgzMSwxMCAr ODIxLDYgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICcuLi8uLi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9mb250cy9XZWJLaXRXZWlnaHRXYXRjaGVyOTAwLnR0ZicsCiAgICAgICAgICAg ICAgICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L3RleHRBcmVh UmVzaXplQ29ybmVyLnBuZycsCiAgICAgICAgICAgICAgICAgICAgIF0sCi0gICAgICAgICAgICAg ICAgICAgICdjb3BpZXMnOiBbewotICAgICAgICAgICAgICAgICAgICAgICAgJ2Rlc3RpbmF0aW9u JzogJzwoUFJPRFVDVF9ESVIpL0R1bXBSZW5kZXJUcmVlLmFwcC9Db250ZW50cy9QbHVnSW5zLycs Ci0gICAgICAgICAgICAgICAgICAgICAgICAnZmlsZXMnOiBbJzwoUFJPRFVDVF9ESVIpL1Rlc3RO ZXRzY2FwZVBsdWdJbi5wbHVnaW4vJ10sCi0gICAgICAgICAgICAgICAgICAgIH1dLAogICAgICAg ICAgICAgICAgIH0seyAjIE9TIT0ibWFjIgogICAgICAgICAgICAgICAgICAgICAnc291cmNlcy8n OiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAjIC5tbSBpcyBhbHJlYWR5IGV4Y2x1ZGVkIGJ5 IGNvbW1vbi5neXBpCkBAIC04NDksOSArODM1LDYgQEAKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnLi4vLi4vV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vZm9udHMuY29u ZicsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoSU5URVJNRURJQVRFX0RJUikvcmVw YWNrL0R1bXBSZW5kZXJUcmVlLnBhaycsCiAgICAgICAgICAgICAgICAgICAgICAgICBdCi0gICAg ICAgICAgICAgICAgICAgIH0sIHsKLSAgICAgICAgICAgICAgICAgICAgICAgICdkZXN0aW5hdGlv bic6ICc8KFBST0RVQ1RfRElSKS9wbHVnaW5zJywKLSAgICAgICAgICAgICAgICAgICAgICAgICdm aWxlcyc6IFsnPChQUk9EVUNUX0RJUikvbGlibnBhcGlfbGF5b3V0X3Rlc3RfcGx1Z2luLnNvJ10s CiAgICAgICAgICAgICAgICAgICAgIH1dLAogICAgICAgICAgICAgICAgIH0seyAjIE9TIT0ibGlu dXgiIGFuZCBPUyE9ImZyZWVic2QiIGFuZCBPUyE9Im9wZW5ic2QiIGFuZCBPUyE9InNvbGFyaXMi CiAgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsK