42466 2010-07-16 10:13:16 -0700 Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file 2010-07-19 02:40:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hans webkit-unassigned commit-queue darin levin steveblock oldest_to_newest 252577 0 hans 2010-07-16 10:13:16 -0700 Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file 252578 1 61821 hans 2010-07-16 10:17:25 -0700 Created attachment 61821 Patch 252583 2 61821 levin 2010-07-16 10:27:17 -0700 Comment on attachment 61821 Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 4558db60cf53f1b2d7bdc4fddb487c8516f91d66..079c9321a32ab8ba68b3b37fb35ed13fade0533a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,21 @@ > +2010-07-16 Hans Wennborg <hans@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file > + https://bugs.webkit.org/show_bug.cgi?id=42466 > + > + This avoids needing to have the full declaration of DeviceOrientation > + in DeviceOrientationEvent.h, which was otherwise necessary because > + of the implicit destructor. Consider moving this comment (and shortening) to be where the function is listed in the ChangeLog. > + (Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447) > + > + No new tests. (OOPS!) This should be removed -- perhaps replaced by "No new functionality so no new tests.". > + > + * dom/DeviceOrientationEvent.cpp: > + (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Right here. Something like: "Move here to voids needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h" > + * dom/DeviceOrientationEvent.h: r- due to OOPS for no new tests (as this won't auto-commit). 252883 3 61884 hans 2010-07-17 09:37:32 -0700 Created attachment 61884 Patch 253115 4 61884 steveblock 2010-07-19 01:56:42 -0700 Comment on attachment 61884 Patch r=me 253124 5 61884 commit-queue 2010-07-19 02:40:37 -0700 Comment on attachment 61884 Patch Clearing flags on attachment: 61884 Committed r63646: <http://trac.webkit.org/changeset/63646> 253125 6 commit-queue 2010-07-19 02:40:42 -0700 All reviewed patches have been landed. Closing bug. 61821 2010-07-16 10:17:25 -0700 2010-07-17 09:37:26 -0700 Patch bug-42466-20100716181723.patch text/plain 2145 hans ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDU1OGRiNjBjZjUzZjFiMmQ3YmRjNGZkZGI0ODdjODUxNmY5MWQ2Ni4uMDc5YzkzMjFhMzJhYjhi YTY4YjNiMzdmYjM1ZWQxM2ZhZGUwNTMzYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wNy0xNiAgSGFu cyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGxpY2l0bHkgZGVjbGFyZSBEZXZpY2VPcmllbnRh dGlvbkV2ZW50IGRlc3RydWN0b3IgYW5kIGRlZmluZSBpdCBpbiB0aGUgLmNwcCBmaWxlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ2NgorCisgICAg ICAgIFRoaXMgYXZvaWRzIG5lZWRpbmcgdG8gaGF2ZSB0aGUgZnVsbCBkZWNsYXJhdGlvbiBvZiBE ZXZpY2VPcmllbnRhdGlvbgorICAgICAgICBpbiBEZXZpY2VPcmllbnRhdGlvbkV2ZW50LmgsIHdo aWNoIHdhcyBvdGhlcndpc2UgbmVjZXNzYXJ5IGJlY2F1c2UKKyAgICAgICAgb2YgdGhlIGltcGxp Y2l0IGRlc3RydWN0b3IuCisgICAgICAgIChPcmlnaW5hbCBwcm9ibGVtIGF0IGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ0NykKKworICAgICAgICBObyBuZXcgdGVz dHMuIChPT1BTISkKKworICAgICAgICAqIGRvbS9EZXZpY2VPcmllbnRhdGlvbkV2ZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uRXZlbnQ6On5EZXZpY2VPcmllbnRh dGlvbkV2ZW50KToKKyAgICAgICAgKiBkb20vRGV2aWNlT3JpZW50YXRpb25FdmVudC5oOgorCiAy MDEwLTA3LTE1ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAZ21haWwuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50 YXRpb25FdmVudC5jcHAgYi9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbkV2ZW50LmNwcApp bmRleCA4YTc1MjI2OGYwODY1NjYxZDNmOTJhNGNlYzM2ZWY2OGNiNTg1OTEyLi45OTJiNmNlZjQz OWQ5MjlkODQ1MDlhODcxNGZmMmQ1MmE0Yjg0NTYyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9E ZXZpY2VPcmllbnRhdGlvbkV2ZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRh dGlvbkV2ZW50LmNwcApAQCAtMzIsNiArMzIsMTAgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewog CitEZXZpY2VPcmllbnRhdGlvbkV2ZW50Ojp+RGV2aWNlT3JpZW50YXRpb25FdmVudCgpCit7Cit9 CisKIERldmljZU9yaWVudGF0aW9uRXZlbnQ6OkRldmljZU9yaWVudGF0aW9uRXZlbnQoKQogICAg IDogbV9vcmllbnRhdGlvbihEZXZpY2VPcmllbnRhdGlvbjo6Y3JlYXRlKCkpCiB7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbkV2ZW50LmggYi9XZWJDb3JlL2RvbS9E ZXZpY2VPcmllbnRhdGlvbkV2ZW50LmgKaW5kZXggMTY1YjFkZjI3Njc4ZjM5YWM4Njg4NzViOWRj MmM2NDU0ODg1NWFlYi4uYmZkZjhmYmVkNjVjNjczNDY4N2YzNTEzZmFhYmQwNDE1ZTY1YzhiNCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50YXRpb25FdmVudC5oCisrKyBiL1dl YkNvcmUvZG9tL0RldmljZU9yaWVudGF0aW9uRXZlbnQuaApAQCAtMjYsMTMgKzI2LDE1IEBACiAj aWZuZGVmIERldmljZU9yaWVudGF0aW9uRXZlbnRfaAogI2RlZmluZSBEZXZpY2VPcmllbnRhdGlv bkV2ZW50X2gKIAotI2luY2x1ZGUgIkRldmljZU9yaWVudGF0aW9uLmgiCiAjaW5jbHVkZSAiRXZl bnQuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBEZXZpY2VPcmllbnRhdGlvbjsK KwogY2xhc3MgRGV2aWNlT3JpZW50YXRpb25FdmVudCA6IHB1YmxpYyBFdmVudCB7CiBwdWJsaWM6 CisgICAgfkRldmljZU9yaWVudGF0aW9uRXZlbnQoKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxE ZXZpY2VPcmllbnRhdGlvbkV2ZW50PiBjcmVhdGUoKQogICAgIHsKICAgICAgICAgcmV0dXJuIGFk b3B0UmVmKG5ldyBEZXZpY2VPcmllbnRhdGlvbkV2ZW50KTsK 61884 2010-07-17 09:37:32 -0700 2010-07-19 02:40:37 -0700 Patch bug-42466-20100717173730.patch text/plain 2096 hans ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTM1Y2QwYzQ1ZmVmMDgyYTI5NTg0ZjUzYWU5MWU3MTliYTIyY2ZhZC4uMmUyMzBjYzAwMDhiZDdj NzJmZDkxYjI4ZWZjZDllNGNhYWM1YTg2YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNy0xNyAgSGFu cyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGxpY2l0bHkgZGVjbGFyZSBEZXZpY2VPcmllbnRh dGlvbkV2ZW50IGRlc3RydWN0b3IgYW5kIGRlZmluZSBpdCBpbiB0aGUgLmNwcCBmaWxlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ2NgorCisgICAg ICAgIChPcmlnaW5hbCBwcm9ibGVtIGF0IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MjQ0NykKKworICAgICAgICBObyBuZXcgZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcg dGVzdHMuCisKKyAgICAgICAgKiBkb20vRGV2aWNlT3JpZW50YXRpb25FdmVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkV2ZW50Ojp+RGV2aWNlT3JpZW50YXRpb25F dmVudCk6CisgICAgICAgIE1vdmUgaGVyZSB0byBhdm9pZCBuZWVkaW5nIHRvIGhhdmUgdGhlIGZ1 bGwgZGVjbGFyYXRpb24gb2YKKyAgICAgICAgRGV2aWNlT3JpZW50YXRpb24gaW4gRGV2aWNlT3Jp ZW50YXRpb25FdmVudC5oLgorICAgICAgICAqIGRvbS9EZXZpY2VPcmllbnRhdGlvbkV2ZW50Lmg6 CisKIDIwMTAtMDctMTcgIE5pa2l0YSBWYXNpbHlldiAgPG1lQGVsdjFzLnJ1PgogCiAgICAgICAg IFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9EZXZp Y2VPcmllbnRhdGlvbkV2ZW50LmNwcCBiL1dlYkNvcmUvZG9tL0RldmljZU9yaWVudGF0aW9uRXZl bnQuY3BwCmluZGV4IDhhNzUyMjY4ZjA4NjU2NjFkM2Y5MmE0Y2VjMzZlZjY4Y2I1ODU5MTIuLjk5 MmI2Y2VmNDM5ZDkyOWQ4NDUwOWE4NzE0ZmYyZDUyYTRiODQ1NjIgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvZG9tL0RldmljZU9yaWVudGF0aW9uRXZlbnQuY3BwCisrKyBiL1dlYkNvcmUvZG9tL0Rldmlj ZU9yaWVudGF0aW9uRXZlbnQuY3BwCkBAIC0zMiw2ICszMiwxMCBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKK0RldmljZU9yaWVudGF0aW9uRXZlbnQ6On5EZXZpY2VPcmllbnRhdGlvbkV2ZW50 KCkKK3sKK30KKwogRGV2aWNlT3JpZW50YXRpb25FdmVudDo6RGV2aWNlT3JpZW50YXRpb25FdmVu dCgpCiAgICAgOiBtX29yaWVudGF0aW9uKERldmljZU9yaWVudGF0aW9uOjpjcmVhdGUoKSkKIHsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RldmljZU9yaWVudGF0aW9uRXZlbnQuaCBiL1dlYkNv cmUvZG9tL0RldmljZU9yaWVudGF0aW9uRXZlbnQuaAppbmRleCAxNjViMWRmMjc2NzhmMzlhYzg2 ODg3NWI5ZGMyYzY0NTQ4ODU1YWViLi5iZmRmOGZiZWQ2NWM2NzM0Njg3ZjM1MTNmYWFiZDA0MTVl NjVjOGI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbkV2ZW50LmgK KysrIGIvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50YXRpb25FdmVudC5oCkBAIC0yNiwxMyArMjYs MTUgQEAKICNpZm5kZWYgRGV2aWNlT3JpZW50YXRpb25FdmVudF9oCiAjZGVmaW5lIERldmljZU9y aWVudGF0aW9uRXZlbnRfaAogCi0jaW5jbHVkZSAiRGV2aWNlT3JpZW50YXRpb24uaCIKICNpbmNs dWRlICJFdmVudC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIERldmljZU9yaWVu dGF0aW9uOworCiBjbGFzcyBEZXZpY2VPcmllbnRhdGlvbkV2ZW50IDogcHVibGljIEV2ZW50IHsK IHB1YmxpYzoKKyAgICB+RGV2aWNlT3JpZW50YXRpb25FdmVudCgpOwogICAgIHN0YXRpYyBQYXNz UmVmUHRyPERldmljZU9yaWVudGF0aW9uRXZlbnQ+IGNyZWF0ZSgpCiAgICAgewogICAgICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IERldmljZU9yaWVudGF0aW9uRXZlbnQpOwo=