42464 2010-07-16 09:52:23 -0700 Really add WARN_UNUSED_RESULT to leakRef 2010-07-16 12:43:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric levin webkit.review.bot oldest_to_newest 252570 0 andersca 2010-07-16 09:52:23 -0700 Really add WARN_UNUSED_RESULT to leakRef and leakPtr 252573 1 61819 andersca 2010-07-16 10:00:22 -0700 Created attachment 61819 Patch 252574 2 webkit.review.bot 2010-07-16 10:01:34 -0700 Attachment 61819 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/PassRefPtr.h:155: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/RetainPtr.h:74: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 252581 3 61819 levin 2010-07-16 10:21:47 -0700 Comment on attachment 61819 Patch > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > + * wtf/RetainPtr.h: > + (WTF::RetainPtr::releaseRef): > + Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need > + to be fixed first. fwiw, you appear to only have fixed one of them. 252584 4 andersca 2010-07-16 10:28:53 -0700 (In reply to comment #3) > (From update of attachment 61819 [details]) > > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > > + * wtf/RetainPtr.h: > > + (WTF::RetainPtr::releaseRef): > > + Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need > > + to be fixed first. > > fwiw, you appear to only have fixed one of them. I fixed the single RefPtr leakRef warning. There are two RetainPtr leakPtr calls that I would need to fix first before adding back WARN_UNUSED_RESULT on RetainPtr. 252591 5 andersca 2010-07-16 10:47:20 -0700 Committed r63562: <http://trac.webkit.org/changeset/63562> 252596 6 levin 2010-07-16 10:49:33 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 61819 [details] [details]) > > > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > > > + * wtf/RetainPtr.h: > > > + (WTF::RetainPtr::releaseRef): > > > + Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need > > > + to be fixed first. > > > > fwiw, you appear to only have fixed one of them. > > I fixed the single RefPtr leakRef warning. There are two RetainPtr leakPtr calls that I would need to fix first before adding back WARN_UNUSED_RESULT on RetainPtr. Of course, you said it right there. Sorry about that. 252655 7 webkit.review.bot 2010-07-16 12:43:07 -0700 http://trac.webkit.org/changeset/63562 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63561 http://trac.webkit.org/changeset/63562 http://trac.webkit.org/changeset/63563 61819 2010-07-16 10:00:22 -0700 2010-07-16 10:21:47 -0700 Patch bug-42464-20100716100021.patch text/plain 5435 andersca ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA5NTc3YzY5NmU5YWQ0ZmFmYzljNDM0OGM1ZTExYzMyNGVhNTMxMDI3Li5h YmJlY2JiYjI0NzIyOTA2OTA2NGM5ZDU3OTIzZGJlMDg2MDgxNTc0IDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTAtMDctMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWFsbHkgYWRkIFdBUk5fVU5VU0VEX1JFU1VMVCB0byBsZWFrUmVmCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ2NAorCisgICAgICAgICogd3RmL1Bh c3NSZWZQdHIuaDoKKyAgICAgICAgKFdURjo6UGFzc1JlZlB0cjo6KToKKyAgICAgICAgKFdURjo6 Tm9uTnVsbFBhc3NSZWZQdHI6Oik6CisgICAgICAgIFB1dCB0aGUgV0FSTl9VTlVTRURfUkVTVUxU IGF0dHJpYnV0ZSBhdCB0aGUgcmlnaHQgcGxhY2UuCisgIAorICAgICAgICAqIHd0Zi9SZXRhaW5Q dHIuaDoKKyAgICAgICAgKFdURjo6UmV0YWluUHRyOjpyZWxlYXNlUmVmKToKKyAgICAgICAgUmVt b3ZlIFdBUk5fVU5VU0VEX1JFU1VMVCBoZXJlIGZvciBub3csIGl0IGxlYWRzIHRvIHR3byB3YXJu aW5ncyB0aGF0IG5lZWQKKyAgICAgICAgdG8gYmUgZml4ZWQgZmlyc3QuCisKIDIwMTAtMDctMTUg IE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH ZW9mZiBHYXJlbi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVmUHRyLmgg Yi9KYXZhU2NyaXB0Q29yZS93dGYvUGFzc1JlZlB0ci5oCmluZGV4IDIzMDYzN2E5ZTVkZGE2M2Fi NDI2NjU2Y2M2YzIyYWIzODFmYzYxYzIuLjU0ZmExNGNlMjU2ODQ5MzliMjA1ZmYzMWFlZjNjMmZk NmViMDUyMjEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVmUHRyLmgKKysr IGIvSmF2YVNjcmlwdENvcmUvd3RmL1Bhc3NSZWZQdHIuaApAQCAtOTYsNyArOTYsNyBAQCBuYW1l c3BhY2UgV1RGIHsKICAgICAgICAgZnJpZW5kIFBhc3NSZWZQdHIgYWRvcHRSZWY8VD4oVCopOwog CiAgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgcmVsZWFzZVJlZiBvbmNlIHdlIGNoYW5nZSBhbGwg Y2FsbGVycyB0byBjYWxsIGxlYWtSZWYgaW5zdGVhZC4KLSAgICAgICAgVCogcmVsZWFzZVJlZigp IGNvbnN0IHsgcmV0dXJuIGxlYWtSZWYoKTsgfSBXQVJOX1VOVVNFRF9SRVRVUk47CisgICAgICAg IFQqIHJlbGVhc2VSZWYoKSBjb25zdCBXQVJOX1VOVVNFRF9SRVRVUk4geyByZXR1cm4gbGVha1Jl ZigpOyB9CiAKICAgICBwcml2YXRlOgogICAgICAgICAvLyBhZG9wdGluZyBjb25zdHJ1Y3RvcgpA QCAtMTUyLDEzICsxNTIsMTMgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIFQqIGdldCgpIGNv bnN0IHsgcmV0dXJuIG1fcHRyOyB9CiAKICAgICAgICAgdm9pZCBjbGVhcigpOwotICAgICAgICBU KiBsZWFrUmVmKCkgY29uc3QgeyBUKiB0bXAgPSBtX3B0cjsgbV9wdHIgPSAwOyByZXR1cm4gdG1w OyB9IFdBUk5fVU5VU0VEX1JFVFVSTjsKKyAgICAgICAgVCogbGVha1JlZigpIGNvbnN0IFdBUk5f VU5VU0VEX1JFVFVSTiB7IFQqIHRtcCA9IG1fcHRyOyBtX3B0ciA9IDA7IHJldHVybiB0bXA7IH0K IAogICAgICAgICBUJiBvcGVyYXRvciooKSBjb25zdCB7IHJldHVybiAqbV9wdHI7IH0KICAgICAg ICAgVCogb3BlcmF0b3ItPigpIGNvbnN0IHsgcmV0dXJuIG1fcHRyOyB9CiAKICAgICAgICAgLy8g RklYTUU6IFJlbW92ZSByZWxlYXNlUmVmIG9uY2Ugd2UgY2hhbmdlIGFsbCBjYWxsZXJzIHRvIGNh bGwgbGVha1JlZiBpbnN0ZWFkLgotICAgICAgICBUKiByZWxlYXNlUmVmKCkgY29uc3QgeyByZXR1 cm4gbGVha1JlZigpOyB9IFdBUk5fVU5VU0VEX1JFVFVSTjsKKyAgICAgICAgVCogcmVsZWFzZVJl ZigpIGNvbnN0IFdBUk5fVU5VU0VEX1JFVFVSTiB7IHJldHVybiBsZWFrUmVmKCk7IH0KIAogICAg IHByaXZhdGU6CiAgICAgICAgIG11dGFibGUgVCogbV9wdHI7CmRpZmYgLS1naXQgYS9KYXZhU2Ny aXB0Q29yZS93dGYvUmV0YWluUHRyLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUmV0YWluUHRyLmgK aW5kZXggMjc2OGJlNzc0ZDRiYTBkNzg4MzY4NWU3NWM5NzM1OTE3MTdlNjE3YS4uZjVhMDI3ZWFh ZGIxNzk2OWZmZDU5NmQ1ZDJlNjI1MDBhMmY2N2Y3NiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENv cmUvd3RmL1JldGFpblB0ci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9SZXRhaW5QdHIuaApA QCAtNzEsNyArNzEsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgCiAgICAgICAgIFB0clR5 cGUgZ2V0KCkgY29uc3QgeyByZXR1cm4gbV9wdHI7IH0KICAgICAgICAgCi0gICAgICAgIFB0clR5 cGUgcmVsZWFzZVJlZigpIHsgUHRyVHlwZSB0bXAgPSBtX3B0cjsgbV9wdHIgPSAwOyByZXR1cm4g dG1wOyB9IFdBUk5fVU5VU0VEX1JFVFVSTjsKKyAgICAgICAgUHRyVHlwZSByZWxlYXNlUmVmKCkg eyBQdHJUeXBlIHRtcCA9IG1fcHRyOyBtX3B0ciA9IDA7IHJldHVybiB0bXA7IH0KICAgICAgICAg CiAgICAgICAgIFB0clR5cGUgb3BlcmF0b3ItPigpIGNvbnN0IHsgcmV0dXJuIG1fcHRyOyB9CiAg ICAgICAgIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAyY2VjMzMxODk2NjM5ZmY0ZGI1N2E1OGVhYTEwYWY5MDU0ODc2NWM1Li4wNzhhMGUy MzVhMmQwOGE5NmM0M2YxNTA2YTcxZDJhODVkOTM3NWE2IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA3 LTE2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVhbGx5IGFkZCBXQVJOX1VOVVNF RF9SRVNVTFQgdG8gbGVha1JlZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDI0NjQKKworICAgICAgICBHZXQgcmlkIG9mIGEgY2FsbCB0byByZWxlYXNl UmVmIGhlcmUgYnkgcGFzc2luZyB0aGUgU2NyaXB0RXhlY3V0aW9uQ29udGV4dAorICAgICAgICBy ZWZlcmVuY2UgdGhyb3VnaCB0byB0aGUgRGVyZWZDb250ZXh0VGFzay4KKworICAgICAgICAqIHN0 b3JhZ2UvRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVyZWZDb250ZXh0VGFzazo6 Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkRlcmVmQ29udGV4dFRhc2s6OnBlcmZvcm1UYXNr KToKKyAgICAgICAgKFdlYkNvcmU6OkRlcmVmQ29udGV4dFRhc2s6OkRlcmVmQ29udGV4dFRhc2sp OgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJhc2U6On5EYXRhYmFzZSk6CisKIDIwMTAtMDctMTUg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5jcHAgYi9XZWJD b3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCmluZGV4IDE5ZjU4MmQ3MjBiMmMyMDQ5NGVkMzI5NDNh OGVlZTZiNDMyODZiOWUuLjVlMjcxYmRkMmU5YTNhOTRlYmVmOGI4MmExYzhjM2JlYjM0ZjIyZmUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5jcHAKKysrIGIvV2ViQ29yZS9z dG9yYWdlL0RhdGFiYXNlLmNwcApAQCAtMTQwLDI1ICsxNDAsMzcgQEAgRGF0YWJhc2U6OkRhdGFi YXNlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IFN0cmluZyYgbmFtZSwg Y29uc3QgU3QKIAogY2xhc3MgRGVyZWZDb250ZXh0VGFzayA6IHB1YmxpYyBTY3JpcHRFeGVjdXRp b25Db250ZXh0OjpUYXNrIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc093blB0cjxEZXJlZkNv bnRleHRUYXNrPiBjcmVhdGUoKQorICAgIHN0YXRpYyBQYXNzT3duUHRyPERlcmVmQ29udGV4dFRh c2s+IGNyZWF0ZShQYXNzUmVmUHRyPFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ+IGNvbnRleHQpCiAg ICAgewotICAgICAgICByZXR1cm4gbmV3IERlcmVmQ29udGV4dFRhc2soKTsKKyAgICAgICAgcmV0 dXJuIG5ldyBEZXJlZkNvbnRleHRUYXNrKGNvbnRleHQpOwogICAgIH0KIAogICAgIHZpcnR1YWwg dm9pZCBwZXJmb3JtVGFzayhTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgIHsK LSAgICAgICAgY29udGV4dC0+ZGVyZWYoKTsKKyAgICAgICAgQVNTRVJUKGNvbnRleHQgPT0gbV9j b250ZXh0KTsKKyAgICAgICAgbV9jb250ZXh0LmNsZWFyKCk7CiAgICAgfQogCiAgICAgdmlydHVh bCBib29sIGlzQ2xlYW51cFRhc2soKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CisKK3ByaXZhdGU6 CisgICAgRGVyZWZDb250ZXh0VGFzayhQYXNzUmVmUHRyPFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ+ IGNvbnRleHQpCisgICAgICAgIDogbV9jb250ZXh0KGNvbnRleHQpCisgICAgeworICAgIH0KKyAg ICAKKyAgICBSZWZQdHI8U2NyaXB0RXhlY3V0aW9uQ29udGV4dD4gbV9jb250ZXh0OwogfTsKIAog RGF0YWJhc2U6On5EYXRhYmFzZSgpCiB7CiAgICAgLy8gVGhlIHJlZmVyZW5jZSB0byB0aGUgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCBuZWVkcyB0byBiZSBjbGVhcmVkIG9uIHRoZSBKYXZhU2NyaXB0 IHRocmVhZC4gIElmIHdlJ3JlIG9uIHRoYXQgdGhyZWFkIGFscmVhZHksIHdlIGNhbiBqdXN0IGxl dCB0aGUgUmVmUHRyJ3MgZGVzdHJ1Y3Rpb24gZG8gdGhlIGRlcmVmZmluZy4KICAgICBpZiAoIW1f c2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNDb250ZXh0VGhyZWFkKCkpIHsKLSAgICAgICAgbV9z Y3JpcHRFeGVjdXRpb25Db250ZXh0LT5wb3N0VGFzayhEZXJlZkNvbnRleHRUYXNrOjpjcmVhdGUo KSk7Ci0gICAgICAgIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC5yZWxlYXNlKCkucmVsZWFzZVJl ZigpOworICAgICAgICAvLyBHcmFiIGEgcG9pbnRlciB0byB0aGUgc2NyaXB0IGV4ZWN1dGlvbiBo ZXJlIGJlY2F1c2Ugd2UncmUgcmVsZWFzaW5nIGl0IHdoZW4gd2UgcGFzcyBpdCB0bworICAgICAg ICAvLyBEZXJlZkNvbnRleHRUYXNrOjpjcmVhdGUuCisgICAgICAgIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgPSBtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQu Z2V0KCk7CisgICAgICAgIAorICAgICAgICBzY3JpcHRFeGVjdXRpb25Db250ZXh0LT5wb3N0VGFz ayhEZXJlZkNvbnRleHRUYXNrOjpjcmVhdGUobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LnJlbGVh c2UoKSkpOwogICAgIH0KIH0KIAo=