42463 2010-07-16 09:36:18 -0700 [Qt] Avoid QImage::pixel() in getImageData() 2010-07-19 05:46:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 252559 0 kling 2010-07-16 09:36:18 -0700 From the QImage documentation: Warning: This function is expensive when used for massive pixel manipulations. We should use scanLine() (or even better in Qt 4.7, constScanLine()) instead. 252561 1 61817 kling 2010-07-16 09:38:02 -0700 Created attachment 61817 Proposed patch 252562 2 kling 2010-07-16 09:38:53 -0700 This change yields a 1% speedup on http://mrdoob.com/lab/javascript/effects/plane_deformations/ 252669 3 61840 kling 2010-07-16 13:01:48 -0700 Created attachment 61840 Proposed patch v2 Oops, don't use QRgb* to traverse the scan lines, since QRgb might be 64-bit. Use quint32* instead. 253155 4 61840 kling 2010-07-19 05:45:58 -0700 Comment on attachment 61840 Proposed patch v2 Clearing flags on attachment: 61840 Committed r63652: <http://trac.webkit.org/changeset/63652> 253156 5 kling 2010-07-19 05:46:08 -0700 All reviewed patches have been landed. Closing bug. 61817 2010-07-16 09:38:02 -0700 2010-07-16 13:01:48 -0700 Proposed patch bug-42463.diff text/plain 1601 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGZjMDcxOS4uNjRjNDYxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0xNiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQXZvaWQgUUltYWdlOjpwaXhlbCgpIGluIGdldElt YWdlRGF0YSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MjQ2MworCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRJbWFnZURhdGEpOiBVc2UgUUltYWdlOjpzY2FuTGlu ZSgpIGluc3RlYWQKKyAgICAgICAgb2YgZmV0Y2hpbmcgZGF0YSBwaXhlbC1ieS1waXhlbC4KKwog MjAxMC0wNy0xNiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLiBDaHJvbWl1bSBidWlsZCBmaXguIEFkZCBtaXNzaW5nIGluY2x1ZGUu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQu Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcAppbmRl eCBhNTQ2ZGVmLi5lNDliNTkyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ltYWdlQnVmZmVyUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv SW1hZ2VCdWZmZXJRdC5jcHAKQEAgLTE3OCw4ICsxNzgsMTMgQEAgUGFzc1JlZlB0cjxJbWFnZURh dGE+IGdldEltYWdlRGF0YShjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBJbWFnZUJ1ZmZlckRh dGEmIGkKICAgICB1bnNpZ25lZCBkZXN0Qnl0ZXNQZXJSb3cgPSA0ICogcmVjdC53aWR0aCgpOwog ICAgIHVuc2lnbmVkIGNoYXIqIGRlc3RSb3dzID0gZGF0YSArIGRlc3R5ICogZGVzdEJ5dGVzUGVy Um93ICsgZGVzdHggKiA0OwogICAgIGZvciAoaW50IHkgPSAwOyB5IDwgbnVtUm93czsgKyt5KSB7 CisjaWYgUVRfVkVSU0lPTiA+PSAweDA0MDcwMAorICAgICAgICBjb25zdCBRUmdiKiBzY2FuTGlu ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgUVJnYio+KGltYWdlLmNvbnN0U2NhbkxpbmUoeSAr IG9yaWdpbnkpKTsKKyNlbHNlCisgICAgICAgIFFSZ2IqIHNjYW5MaW5lID0gcmVpbnRlcnByZXRf Y2FzdDxRUmdiKj4oaW1hZ2Uuc2NhbkxpbmUoeSArIG9yaWdpbnkpKTsKKyNlbmRpZgogICAgICAg ICBmb3IgKGludCB4ID0gMDsgeCA8IG51bUNvbHVtbnM7IHgrKykgewotICAgICAgICAgICAgUVJn YiB2YWx1ZSA9IGltYWdlLnBpeGVsKHggKyBvcmlnaW54LCB5ICsgb3JpZ2lueSk7CisgICAgICAg ICAgICBRUmdiIHZhbHVlID0gc2NhbkxpbmVbeCArIG9yaWdpbnhdOwogICAgICAgICAgICAgaW50 IGJhc2V4ID0geCAqIDQ7CiAKICAgICAgICAgICAgIGRlc3RSb3dzW2Jhc2V4XSA9IHFSZWQodmFs dWUpOwo= 61840 2010-07-16 13:01:48 -0700 2010-07-19 05:45:57 -0700 Proposed patch v2 bug-42463-v2.diff text/plain 1582 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjUwMDFmYi4uMDM1YmEyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0xNiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQXZvaWQgUUltYWdlOjpwaXhlbCgpIGluIGdldElt YWdlRGF0YSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MjQ2MworCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRJbWFnZURhdGEpOiBVc2UgUUltYWdlOjpzY2FuTGlu ZSgpIGluc3RlYWQKKyAgICAgICAgb2YgZmV0Y2hpbmcgZGF0YSBwaXhlbC1ieS1waXhlbC4KKwog MjAxMC0wNy0xNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ltYWdlQnVmZmVyUXQuY3BwCmluZGV4IGE1NDZkZWYuLmJhMDE5NmIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcApAQCAtMTc4LDggKzE3 OCwxMyBAQCBQYXNzUmVmUHRyPEltYWdlRGF0YT4gZ2V0SW1hZ2VEYXRhKGNvbnN0IEludFJlY3Qm IHJlY3QsIGNvbnN0IEltYWdlQnVmZmVyRGF0YSYgaQogICAgIHVuc2lnbmVkIGRlc3RCeXRlc1Bl clJvdyA9IDQgKiByZWN0LndpZHRoKCk7CiAgICAgdW5zaWduZWQgY2hhciogZGVzdFJvd3MgPSBk YXRhICsgZGVzdHkgKiBkZXN0Qnl0ZXNQZXJSb3cgKyBkZXN0eCAqIDQ7CiAgICAgZm9yIChpbnQg eSA9IDA7IHkgPCBudW1Sb3dzOyArK3kpIHsKKyNpZiBRVF9WRVJTSU9OID49IDB4MDQwNzAwCisg ICAgICAgIGNvbnN0IHF1aW50MzIqIHNjYW5MaW5lID0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBx dWludDMyKj4oaW1hZ2UuY29uc3RTY2FuTGluZSh5ICsgb3JpZ2lueSkpOworI2Vsc2UKKyAgICAg ICAgcXVpbnQzMiogc2NhbkxpbmUgPSByZWludGVycHJldF9jYXN0PHF1aW50MzIqPihpbWFnZS5z Y2FuTGluZSh5ICsgb3JpZ2lueSkpOworI2VuZGlmCiAgICAgICAgIGZvciAoaW50IHggPSAwOyB4 IDwgbnVtQ29sdW1uczsgeCsrKSB7Ci0gICAgICAgICAgICBRUmdiIHZhbHVlID0gaW1hZ2UucGl4 ZWwoeCArIG9yaWdpbngsIHkgKyBvcmlnaW55KTsKKyAgICAgICAgICAgIFFSZ2IgdmFsdWUgPSBz Y2FuTGluZVt4ICsgb3JpZ2lueF07CiAgICAgICAgICAgICBpbnQgYmFzZXggPSB4ICogNDsKIAog ICAgICAgICAgICAgZGVzdFJvd3NbYmFzZXhdID0gcVJlZCh2YWx1ZSk7Cg==