42456 2010-07-16 08:22:49 -0700 [Qt] Path: Avoid creating a new GraphicsContext in strokeContains() and strokeBoundingRect() 2010-07-16 08:59:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 35784 1 kling webkit-qt-unassigned hausmann oldest_to_newest 252522 0 kling 2010-07-16 08:22:49 -0700 From PathQt.cpp: // FIXME: We should try to use a 'shared Context' instead of creating a new ImageBuffer // on each call. We should use the same "scratch context" pattern Skia uses. 252524 1 61808 kling 2010-07-16 08:26:14 -0700 Created attachment 61808 Proposed patch 252528 2 kling 2010-07-16 08:32:34 -0700 This change yields a 7% speedup on http://www.openrise.com/lab/FlowerPower/ 252530 3 61808 tonikitoo 2010-07-16 08:34:24 -0700 Comment on attachment 61808 Proposed patch Looks sane. r=me 252539 4 61808 kling 2010-07-16 08:50:16 -0700 Comment on attachment 61808 Proposed patch Clearing flags on attachment: 61808 Committed r63552: <http://trac.webkit.org/changeset/63552> 252540 5 kling 2010-07-16 08:50:26 -0700 All reviewed patches have been landed. Closing bug. 252541 6 kling 2010-07-16 08:59:38 -0700 Marking for cherry-pick into 2.0 since it's a very nice improvement for a very tiny change. 61808 2010-07-16 08:26:14 -0700 2010-07-16 08:50:16 -0700 Proposed patch bug-42456.diff text/plain 2290 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmI5M2QzMC4uZGY4YTkzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0xNiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUGF0aDogQXZvaWQgY3JlYXRpbmcgYSBuZXcgR3Jh cGhpY3NDb250ZXh0IGluIHN0cm9rZUNvbnRhaW5zKCkgYW5kIHN0cm9rZUJvdW5kaW5nUmVjdCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQ1Ngor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnNjcmF0Y2hDb250ZXh0KTogQWRkZWQsIHByb3ZpZGVzIGEgc2NyYXRjaCBHcmFwaGlj c0NvbnRleHQuCisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpzdHJva2VDb250YWlucyk6IFVzZSB0 aGUgc2NyYXRjaCBjb250ZXh0IGluc3RlYWQKKyAgICAgICAgb2YgY3JlYXRpbmcgYSBuZXcgR3Jh cGhpY3NDb250ZXh0LgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6c3Ryb2tlQm91bmRpbmdSZWN0 KTogRGl0dG8uCisKIDIwMTAtMDctMTYgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hp QHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAKaW5kZXggYTM2NzIxMi4uZDI5NmUy OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcApAQCAtMTIxLDE1ICsx MjEsMTggQEAgYm9vbCBQYXRoOjpjb250YWlucyhjb25zdCBGbG9hdFBvaW50JiBwb2ludCwgV2lu ZFJ1bGUgcnVsZSkgY29uc3QKICAgICByZXR1cm4gY29udGFpbnM7CiB9CiAKK3N0YXRpYyBHcmFw aGljc0NvbnRleHQqIHNjcmF0Y2hDb250ZXh0KCkKK3sKKyAgICBzdGF0aWMgSW1hZ2VCdWZmZXIq IHNjcmF0Y2ggPSBJbWFnZUJ1ZmZlcjo6Y3JlYXRlKEludFNpemUoMSwgMSkpLmxlYWtQdHIoKTsK KyAgICByZXR1cm4gc2NyYXRjaC0+Y29udGV4dCgpOworfQorCiBib29sIFBhdGg6OnN0cm9rZUNv bnRhaW5zKFN0cm9rZVN0eWxlQXBwbGllciogYXBwbGllciwgY29uc3QgRmxvYXRQb2ludCYgcG9p bnQpIGNvbnN0CiB7CiAgICAgQVNTRVJUKGFwcGxpZXIpOwogCi0gICAgLy8gRklYTUU6IFdlIHNo b3VsZCB0cnkgdG8gdXNlIGEgJ3NoYXJlZCBDb250ZXh0JyBpbnN0ZWFkIG9mIGNyZWF0aW5nIGEg bmV3IEltYWdlQnVmZmVyCi0gICAgLy8gb24gZWFjaCBjYWxsLgotICAgIE93blB0cjxJbWFnZUJ1 ZmZlcj4gc2NyYXRjaEltYWdlID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZShJbnRTaXplKDEsIDEpKTsK LSAgICBHcmFwaGljc0NvbnRleHQqIGdjID0gc2NyYXRjaEltYWdlLT5jb250ZXh0KCk7CiAgICAg UVBhaW50ZXJQYXRoU3Ryb2tlciBzdHJva2U7CisgICAgR3JhcGhpY3NDb250ZXh0KiBnYyA9IHNj cmF0Y2hDb250ZXh0KCk7CiAgICAgYXBwbGllci0+c3Ryb2tlU3R5bGUoZ2MpOwogCiAgICAgUVBl biBwZW4gPSBnYy0+cGVuKCk7CkBAIC0xNTcsMTAgKzE2MCw3IEBAIEZsb2F0UmVjdCBQYXRoOjpi b3VuZGluZ1JlY3QoKSBjb25zdAogCiBGbG9hdFJlY3QgUGF0aDo6c3Ryb2tlQm91bmRpbmdSZWN0 KFN0cm9rZVN0eWxlQXBwbGllciogYXBwbGllcikKIHsKLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxk IHRyeSB0byB1c2UgYSAnc2hhcmVkIENvbnRleHQnIGluc3RlYWQgb2YgY3JlYXRpbmcgYSBuZXcg SW1hZ2VCdWZmZXIKLSAgICAvLyBvbiBlYWNoIGNhbGwuCi0gICAgT3duUHRyPEltYWdlQnVmZmVy PiBzY3JhdGNoSW1hZ2UgPSBJbWFnZUJ1ZmZlcjo6Y3JlYXRlKEludFNpemUoMSwgMSkpOwotICAg IEdyYXBoaWNzQ29udGV4dCogZ2MgPSBzY3JhdGNoSW1hZ2UtPmNvbnRleHQoKTsKKyAgICBHcmFw aGljc0NvbnRleHQqIGdjID0gc2NyYXRjaENvbnRleHQoKTsKICAgICBRUGFpbnRlclBhdGhTdHJv a2VyIHN0cm9rZTsKICAgICBpZiAoYXBwbGllcikgewogICAgICAgICBhcHBsaWVyLT5zdHJva2VT dHlsZShnYyk7Cg==