42452 2010-07-16 06:39:34 -0700 Web Inspector: show actual breakpoint position in UI. 2010-07-19 02:21:04 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned pfeldman oldest_to_newest 252482 0 podivilov 2010-07-16 06:39:34 -0700 Web Inspector: show actual breakpoint position in UI. 252483 1 61801 podivilov 2010-07-16 06:42:02 -0700 Created attachment 61801 Proposed patch. 252870 2 61801 pfeldman 2010-07-17 04:48:36 -0700 Comment on attachment 61801 Proposed patch. WebKit/chromium/src/js/DebuggerScript.js:102 + return undefined; What will the user see in the UI when setting breakpoint on a comment? Does it simply vanish? 252961 3 pfeldman 2010-07-18 09:32:33 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/DebuggerScript.js Committed r63626 253121 4 podivilov 2010-07-19 02:21:04 -0700 (In reply to comment #2) > (From update of attachment 61801 [details]) > WebKit/chromium/src/js/DebuggerScript.js:102 > + return undefined; > What will the user see in the UI when setting breakpoint on a comment? Does it simply vanish? It will be set on nearest statement by v8 debugger. Here we got undefined only when trying to set a breakpoint outside a script. 61801 2010-07-16 06:42:02 -0700 2010-07-17 04:48:36 -0700 Proposed patch. pb.patch text/plain 1268 podivilov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYyNThjMmEuLjI3NjJiOGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA3LTE2ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtW OF0gV2ViIEluc3BlY3RvcjogZ2V0IGFjdHVhbCBicmVha3BvaW50IGxvY2F0aW9uIGZyb20gdjgg YW5kIHBhc3MgaXQKKyAgICAgICAgdG8gU2NyaXBEZWJ1Z1NlcnZlci4KKworICAgICAgICAqIHNy Yy9qcy9EZWJ1Z2dlclNjcmlwdC5qczoKKyAgICAgICAgKCk6CisKIDIwMTAtMDctMTYgIE1pa2hh aWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZWJ1 Z2dlclNjcmlwdC5qcyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvRGVidWdnZXJTY3JpcHQuanMK aW5kZXggNzBjMmZiZS4uYzJhZGIxZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9q cy9EZWJ1Z2dlclNjcmlwdC5qcworKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RlYnVnZ2Vy U2NyaXB0LmpzCkBAIC05Nyw3ICs5NywxMCBAQCBEZWJ1Z2dlclNjcmlwdC5zZXRCcmVha3BvaW50 ID0gZnVuY3Rpb24oZXhlY1N0YXRlLCBhcmdzKQogICAgIGlmICghYXJncy5lbmFibGVkKQogICAg ICAgICBEZWJ1Zy5kaXNhYmxlU2NyaXB0QnJlYWtQb2ludChicmVha0lkKTsKIAotICAgIHZhciBh Y3R1YWxMaW5lTnVtYmVyID0gYXJncy5saW5lTnVtYmVyOyAvLyBUT0RPOiByZXBsYWNlIHdpdGgg cmVhbCBzdHVmZiBhZnRlciB2OCByb2xsLgorICAgIHZhciBsb2NhdGlvbnMgPSBEZWJ1Zy5maW5k QnJlYWtQb2ludEFjdHVhbExvY2F0aW9ucyhicmVha0lkKTsKKyAgICBpZiAoIWxvY2F0aW9ucy5s ZW5ndGgpCisgICAgICAgIHJldHVybiB1bmRlZmluZWQ7CisgICAgdmFyIGFjdHVhbExpbmVOdW1i ZXIgPSBsb2NhdGlvbnNbMF0ubGluZTsKIAogICAgIHZhciBrZXkgPSBhcmdzLnNjcmlwdElkICsg IjoiICsgYWN0dWFsTGluZU51bWJlcjsKICAgICBpZiAoa2V5IGluIERlYnVnZ2VyU2NyaXB0Ll9i cmVha3BvaW50cykgewo=