42439 2010-07-15 22:19:53 -0700 WebSocket: Put echo-challenge_wsh.py under workers/resources directory 2010-07-16 10:54:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 yutak yutak abarth ap commit-queue eric ukai webkit.review.bot oldest_to_newest 252326 0 yutak 2010-07-15 22:19:53 -0700 Currently, websocket/tests/workers/worker-handshake-challenge-randomness.html depends on websocket/tests/echo-challenge_wsh.py. This configuration is not desirable for Chromium's worker test which only copies the content under workers/resources directory when running WebSocket worker tests. 252334 1 61767 yutak 2010-07-15 22:35:42 -0700 Created attachment 61767 Patch 252336 2 ukai 2010-07-15 22:38:54 -0700 Looks good 252339 3 61767 tkent 2010-07-15 22:45:02 -0700 Comment on attachment 61767 Patch OK. 252352 4 61767 commit-queue 2010-07-15 23:34:36 -0700 Comment on attachment 61767 Patch Clearing flags on attachment: 61767 Committed r63524: <http://trac.webkit.org/changeset/63524> 252353 5 commit-queue 2010-07-15 23:34:40 -0700 All reviewed patches have been landed. Closing bug. 252365 6 webkit.review.bot 2010-07-16 00:01:05 -0700 http://trac.webkit.org/changeset/63524 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/63521 http://trac.webkit.org/changeset/63522 http://trac.webkit.org/changeset/63523 http://trac.webkit.org/changeset/63524 http://trac.webkit.org/changeset/63525 252369 7 yutak 2010-07-16 00:12:03 -0700 (In reply to comment #6) > http://trac.webkit.org/changeset/63524 might have broken Tiger Intel Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/63521 > http://trac.webkit.org/changeset/63522 > http://trac.webkit.org/changeset/63523 > http://trac.webkit.org/changeset/63524 > http://trac.webkit.org/changeset/63525 This alarm seems irrelevant to this patch. 252602 8 ap 2010-07-16 10:54:51 -0700 I think that longer term, we need a better solution. Almost every feature of main document WebSocket should be also tested in workers - are we really going to have two copies of every script? 61767 2010-07-15 22:35:42 -0700 2010-07-15 23:34:35 -0700 Patch bug-42439-20100716143539.patch text/plain 2558 yutak ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMGZmYmExYmUwMTgxNTE5ZGM1NWFhZjI1NTc1NDg4ODU1MDQyYmRmLi5iZmNiNmU3 ODMwYzBhYzc2ZGMwNmNlNTE3ZTBlYzI5OWI0MWM2ZTBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTAtMDctMTUgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViU29ja2V0OiBQdXQg ZWNoby1jaGFsbGVuZ2Vfd3NoLnB5IHVuZGVyIHdvcmtlcnMvcmVzb3VyY2VzIGRpcmVjdG9yeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI0MzkKKwor ICAgICAgICBJIGhhdmUgcmVhbGl6ZWQgdGhhdCB0ZXN0cyB1bmRlciB3b3JrZXJzLyBkaXJlY3Rv cnkgc2hvdWxkIG5vdCBkZXBlbmQgb24KKyAgICAgICAgYSBweXdlYnNvY2tldCBzY3JpcHQgaW4g YSBkaXJlY3RvcnkgYWJvdmUuCisKKyAgICAgICAgUHV0dGluZyAqX3dzaC5weSBmaWxlcyB1bmRl ciByZXNvdXJjZXMvIGRpcmVjdG9yeSBhbHNvIGJlbmVmaXRzIENocm9taXVtJ3MKKyAgICAgICAg d29ya2VyIHRlc3Qgd2hpY2ggb25seSBjb3BpZXMgdGhlIGNvbnRlbnRzIHVuZGVyIHdvcmtlcnMv cmVzb3VyY2VzIGRpcmVjdG9yeQorICAgICAgICB3aGVuIHJ1bm5pbmcgV2ViU29ja2V0IHdvcmtl ciB0ZXN0cy4KKworICAgICAgICAqIHdlYnNvY2tldC90ZXN0cy93b3JrZXJzL3Jlc291cmNlcy9l Y2hvLWNoYWxsZW5nZV93c2gucHk6IENvcGllZCBmcm9tIExheW91dFRlc3RzL3dlYnNvY2tldC90 ZXN0cy9lY2hvLWNoYWxsZW5nZV93c2gucHkuCisgICAgICAgICogd2Vic29ja2V0L3Rlc3RzL3dv cmtlcnMvcmVzb3VyY2VzL3dvcmtlci1oYW5kc2hha2UtY2hhbGxlbmdlLXJhbmRvbW5lc3MuanM6 CisKIDIwMTAtMDctMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYnNv Y2tldC90ZXN0cy93b3JrZXJzL3Jlc291cmNlcy9lY2hvLWNoYWxsZW5nZV93c2gucHkgYi9MYXlv dXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvd29ya2Vycy9yZXNvdXJjZXMvZWNoby1jaGFsbGVuZ2Vf d3NoLnB5Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjBmZDE0ODVjYzFmZTk2NjA1OWRjN2E4OTUzMjNmZGUzODNiMjIw NTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvd29ya2Vy cy9yZXNvdXJjZXMvZWNoby1jaGFsbGVuZ2Vfd3NoLnB5CkBAIC0wLDAgKzEsMTAgQEAKK2Zyb20g bW9kX3B5d2Vic29ja2V0IGltcG9ydCBtc2d1dGlsCisKK2RlZiB3ZWJfc29ja2V0X2RvX2V4dHJh X2hhbmRzaGFrZShyZXF1ZXN0KToKKyAgICBwYXNzCisKK2RlZiB3ZWJfc29ja2V0X3RyYW5zZmVy X2RhdGEocmVxdWVzdCk6CisgICAgbXNndXRpbC5zZW5kX21lc3NhZ2UocmVxdWVzdCwgX2hleGlm eShyZXF1ZXN0LndzX2NoYWxsZW5nZSkpCisKK2RlZiBfaGV4aWZ5KGJ5dGVzKToKKyAgICByZXR1 cm4gJzonLmpvaW4oWyclMDJYJyAlIG9yZChieXRlKSBmb3IgYnl0ZSBpbiBieXRlc10pCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvd29ya2Vycy9yZXNvdXJjZXMvd29y a2VyLWhhbmRzaGFrZS1jaGFsbGVuZ2UtcmFuZG9tbmVzcy5qcyBiL0xheW91dFRlc3RzL3dlYnNv Y2tldC90ZXN0cy93b3JrZXJzL3Jlc291cmNlcy93b3JrZXItaGFuZHNoYWtlLWNoYWxsZW5nZS1y YW5kb21uZXNzLmpzCmluZGV4IDliZDQyYWM4ODk1Zjk5MTkwZTFlYjIxYTcwYjlhZDRhMWJlYWMy ZWEuLmU2OGFkOTU4MjgwN2M0NGFkNzhmYzU1ZDFmMjU3YWI4OTI2ZDI4NGQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy93b3JrZXJzL3Jlc291cmNlcy93b3JrZXItaGFu ZHNoYWtlLWNoYWxsZW5nZS1yYW5kb21uZXNzLmpzCisrKyBiL0xheW91dFRlc3RzL3dlYnNvY2tl dC90ZXN0cy93b3JrZXJzL3Jlc291cmNlcy93b3JrZXItaGFuZHNoYWtlLWNoYWxsZW5nZS1yYW5k b21uZXNzLmpzCkBAIC0xNCw3ICsxNCw3IEBAIGZ1bmN0aW9uIGVuZFRlc3QoKQogZnVuY3Rpb24g cnVuVGVzdHMoKQogewogICAgIHRyeSB7Ci0gICAgICAgIHZhciB1cmwgPSAnd3M6Ly9sb2NhbGhv c3Q6ODg4MC93ZWJzb2NrZXQvdGVzdHMvZWNoby1jaGFsbGVuZ2UnOworICAgICAgICB2YXIgdXJs ID0gJ3dzOi8vbG9jYWxob3N0Ojg4ODAvd2Vic29ja2V0L3Rlc3RzL3dvcmtlcnMvcmVzb3VyY2Vz L2VjaG8tY2hhbGxlbmdlJzsKICAgICAgICAgdmFyIHdzMSA9IG5ldyBXZWJTb2NrZXQodXJsKTsK IAogICAgICAgICB3czEub25tZXNzYWdlID0gZnVuY3Rpb24obWVzc2FnZUV2ZW50KQo=