42438 2010-07-15 19:42:49 -0700 Add directional property enums to the switch in applyProperty 2010-07-15 20:03:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 arv arv oldest_to_newest 252284 0 arv 2010-07-15 19:42:49 -0700 Add directional property enums to the switch in applyProperty 252285 1 61758 arv 2010-07-15 19:44:10 -0700 Created attachment 61758 Patch 252286 2 61758 levin 2010-07-15 19:55:46 -0700 Comment on attachment 61758 Patch I wish there was a "cleaner" way of doing it. (In fact, I can think of one but it involves macros and perhaps a little trickiness so maybe it wouldn't be that great.) Here's the shape of what I'm thinking of. A "header" file with a list like this. CSS_DIRECTION_AWARE_PROPERTY(CSSPropertyWebkitMarginEnd, CSSPropertyMarginRight, CSSPropertyMarginLeft) Anyway what you have here will work. 252289 3 arv 2010-07-15 20:03:01 -0700 Committed r63509: <http://trac.webkit.org/changeset/63509> 61758 2010-07-15 19:44:10 -0700 2010-07-15 19:55:46 -0700 Patch bug-42438-20100715194409.patch text/plain 2292 arv ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjMxODk5MjU5OWVlNjFiNzcxMTg2MzQ4MmMwOTk5NjhhMDA0MzcyNi4uYjgyZjkzZjZmOGIxNjgw YjVjNzg1MTAxNDRhMTlkYjMyODBmMzNlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0xNSAgRXJp ayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBkaXJlY3Rpb25hbCBwcm9wZXJ0eSBlbnVtcyB0 byB0aGUgc3dpdGNoIGluIGFwcGx5UHJvcGVydHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNDM4CisKKyAgICAgICAgQnVpbGQgZml4IGZvciBjaHJv bWl1bSBtYWMuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KToKKwogMjAxMC0wNy0x MyAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5h dGUgQ2hhcGluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAg Yi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCBmOTg2OTcwZmZkZmQzYWM4 ZjZmZWQ1ZDM2YzhlMGNhZmE5NTc4Mzk2Li5jYzQ4NDFkYTA3NmE5NzY1NGNhYTFjMDVmOTg4YzUy ZGU5MmY5Yzg5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAor KysgYi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcApAQCAtNTQ3OSw2ICs1NDc5LDIz IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eShpbnQgaWQsIENTU1ZhbHVl ICp2YWx1ZSkKICAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgQ1NTUHJvcGVydHlJbnZhbGlkOgog ICAgICAgICByZXR1cm47CisKKyAgICAvLyBEaXJlY3Rpb25hbCBwcm9wZXJ0aWVzIGFyZSByZXNv bHZlZCBieSByZXNvbHZlRGlyZWN0aW9uQXdhcmVQcm9wZXJ0eSgpIGJlZm9yZSB0aGUgc3dpdGNo LgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3JkZXJFbmQ6CisgICAgY2FzZSBDU1NQcm9w ZXJ0eVdlYmtpdEJvcmRlckVuZENvbG9yOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3Jk ZXJFbmRTdHlsZToKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyRW5kV2lkdGg6Cisg ICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlclN0YXJ0OgorICAgIGNhc2UgQ1NTUHJvcGVy dHlXZWJraXRCb3JkZXJTdGFydENvbG9yOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3Jk ZXJTdGFydFN0eWxlOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3JkZXJTdGFydFdpZHRo OgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRNYXJnaW5FbmQ6CisgICAgY2FzZSBDU1NQcm9w ZXJ0eVdlYmtpdE1hcmdpblN0YXJ0OgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRQYWRkaW5n RW5kOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRQYWRkaW5nU3RhcnQ6CisgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBicmVhazsKKwogICAgIGNhc2UgQ1NTUHJvcGVy dHlGb250U3RyZXRjaDoKICAgICBjYXNlIENTU1Byb3BlcnR5UGFnZToKICAgICBjYXNlIENTU1By b3BlcnR5UXVvdGVzOgpAQCAtNTQ5OCwxMCArNTUxNSw2IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rv cjo6YXBwbHlQcm9wZXJ0eShpbnQgaWQsIENTU1ZhbHVlICp2YWx1ZSkKICAgICBjYXNlIENTU1By b3BlcnR5VGV4dFVuZGVybGluZVN0eWxlOgogICAgIGNhc2UgQ1NTUHJvcGVydHlUZXh0VW5kZXJs aW5lV2lkdGg6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEZvbnRTaXplRGVsdGE6Ci0gICAg Y2FzZSBDU1NQcm9wZXJ0eVdlYmtpdE1hcmdpbkVuZDoKLSAgICBjYXNlIENTU1Byb3BlcnR5V2Vi a2l0TWFyZ2luU3RhcnQ6Ci0gICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFBhZGRpbmdFbmQ6Ci0g ICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFBhZGRpbmdTdGFydDoKICAgICBjYXNlIENTU1Byb3Bl cnR5V2Via2l0VGV4dERlY29yYXRpb25zSW5FZmZlY3Q6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdl YmtpdFRleHRTdHJva2U6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFZhcmlhYmxlRGVjbGFy YXRpb25CbG9jazoK