42437 2010-07-15 18:32:22 -0700 white-space: pre text containing tabs is not laid out correctly when the font lacks a space glyph 2010-07-16 09:09:06 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz oldest_to_newest 252269 0 mitz 2010-07-15 18:32:22 -0700 Tab width calculation in WidthIterator and ComplexTextController uses Font::tabWidth(), which is based on Font::spaceWidth(). When the specified font lacks a space glyph, spaceWidth() will be 0 or otherwise wrong. Instead, the width of the space glyph from the fallback font should be used. Patch forthcoming. 252273 1 mitz 2010-07-15 18:34:11 -0700 <rdar://problem/8198266> 252360 2 61770 mitz 2010-07-16 00:00:18 -0700 Created attachment 61770 Use the width of the space glyph from the font that supplies the space glyph 252543 3 61770 andersca 2010-07-16 09:00:58 -0700 Comment on attachment 61770 Use the width of the space glyph from the font that supplies the space glyph Looks like you can remove Font::tabWidth now. r=me 252549 4 mitz 2010-07-16 09:09:06 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/63556>. 61770 2010-07-16 00:00:18 -0700 2010-07-16 09:00:58 -0700 Use the width of the space glyph from the font that supplies the space glyph 8198266_r1.diff text/plain 2760 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzUyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDctMTUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vODE5ODI2Nj4gd2hpdGUtc3BhY2U6IHByZSB0ZXh0IGNvbnRhaW5pbmcgdGFi cyBpcyBub3QgbGFpZCBvdXQgY29ycmVjdGx5IHdoZW4gdGhlIGZvbnQgbGFja3MgYSBzcGFjZSBn bHlwaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI0 MzcKKworICAgICAgICBObyB0ZXN0IGJlY2F1c2Ugbm9uZSBvZiB0aGUgZm9udHMgYXZhaWxhYmxl IHRvIER1bXBSZW5kZXJUcmVlIGFyZSBtaXNzaW5nIGEgc3BhY2UgZ2x5cGguCisKKyAgICAgICAg Q2hhbmdlZCB0aGUgdGFiIHdpZHRoIGNvbXB1dGF0aW9uIHRvIHVzZSB0aGUgd2lkdGggb2YgdGhl IHNwYWNlIGdseXBoIGZyb20gdGhlIGZvbnQgdGhhdCBoYXMKKyAgICAgICAgYSBzcGFjZSBnbHlw aCwgd2hpY2ggbWF5IGJlIGEgZmFsbGJhY2sgZm9udCBpZiB0aGUgcHJpbWFyeSBmb250IGxhY2tz IGEgc3BhY2UgZ2x5cGguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJh dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldpZHRoSXRlcmF0b3I6OmFkdmFuY2UpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q29tcGxleFRleHRDb250cm9sbGVyOjphZGp1c3RHbHlwaHNBbmRB ZHZhbmNlcyk6CisKIDIwMTAtMDctMTUgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJdGVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcAkocmV2aXNpb24gNjM1MTkp CisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMzMsNyArMTMzLDcgQEAgdm9pZCBXaWR0aEl0ZXJhdG9yOjphZHZhbmNlKGlu dCBvZmZzZXQsIAogICAgICAgICAvLyBOb3cgdGhhdCB3ZSBoYXZlIGEgZ2x5cGggYW5kIGZvbnQg ZGF0YSwgZ2V0IGl0cyB3aWR0aC4KICAgICAgICAgZmxvYXQgd2lkdGg7CiAgICAgICAgIGlmIChj ID09ICdcdCcgJiYgbV9ydW4uYWxsb3dUYWJzKCkpIHsKLSAgICAgICAgICAgIGZsb2F0IHRhYldp ZHRoID0gbV9mb250LT50YWJXaWR0aCgpOworICAgICAgICAgICAgZmxvYXQgdGFiV2lkdGggPSA4 ICogY2VpbGYoZm9udERhdGEtPmFkanVzdGVkU3BhY2VXaWR0aCgpICsgbV9mb250LT5sZXR0ZXJT cGFjaW5nKCkpOwogICAgICAgICAgICAgd2lkdGggPSB0YWJXaWR0aCAtIGZtb2RmKG1fcnVuLnhQ b3MoKSArIG1fcnVuV2lkdGhTb0ZhciArIHdpZHRoU2luY2VMYXN0Um91bmRpbmcsIHRhYldpZHRo KTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHdpZHRoID0gZm9udERhdGEtPndpZHRo Rm9yR2x5cGgoZ2x5cGgpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29t cGxleFRleHRDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA2MzUxOSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ3NCw3ICs0NzQsNyBAQCB2b2lkIENvbXBsZXhUZXh0Q29udHJv bGxlcjo6YWRqdXN0R2x5cGhzCiAgICAgICAgICAgICBDR1NpemUgYWR2YW5jZSA9IHRyZWF0QXNT cGFjZSA/IENHU2l6ZU1ha2UoZm9udERhdGEtPnNwYWNlV2lkdGgoKSwgYWR2YW5jZXNbaV0uaGVp Z2h0KSA6IGFkdmFuY2VzW2ldOwogCiAgICAgICAgICAgICBpZiAoY2ggPT0gJ1x0JyAmJiBtX3J1 bi5hbGxvd1RhYnMoKSkgewotICAgICAgICAgICAgICAgIGZsb2F0IHRhYldpZHRoID0gbV9mb250 LnRhYldpZHRoKCk7CisgICAgICAgICAgICAgICAgZmxvYXQgdGFiV2lkdGggPSA4ICogY2VpbGYo Zm9udERhdGEtPmFkanVzdGVkU3BhY2VXaWR0aCgpICsgbV9mb250LmxldHRlclNwYWNpbmcoKSk7 CiAgICAgICAgICAgICAgICAgYWR2YW5jZS53aWR0aCA9IHRhYldpZHRoIC0gZm1vZGYobV9ydW4u eFBvcygpICsgbV90b3RhbFdpZHRoICsgd2lkdGhTaW5jZUxhc3RSb3VuZGluZywgdGFiV2lkdGgp OwogICAgICAgICAgICAgfSBlbHNlIGlmIChjaCA9PSB6ZXJvV2lkdGhTcGFjZSB8fCBGb250Ojp0 cmVhdEFzWmVyb1dpZHRoU3BhY2UoY2gpICYmICF0cmVhdEFzU3BhY2UpIHsKICAgICAgICAgICAg ICAgICBhZHZhbmNlLndpZHRoID0gMDsK