<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>42433</bug_id>
          
          <creation_ts>2010-07-15 17:56:28 -0700</creation_ts>
          <short_desc>[Qt] Enable Web Timing for Qt</short_desc>
          <delta_ts>2010-12-03 09:32:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P3</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>30685</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Tony Gentilcore">tonyg</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>ossy</cc>
    
    <cc>simonjam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>252258</commentid>
    <comment_count>0</comment_count>
    <who name="Tony Gentilcore">tonyg</who>
    <bug_when>2010-07-15 17:56:28 -0700</bug_when>
    <thetext>Web Timing should be enabled for the Qt port.

This involves the following:
1. Implement http://trac.webkit.org/browser/trunk/WebCore/platform/network/ResourceLoadTiming.h
2. Flip WEB_TIMING flag</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308245</commentid>
    <comment_count>1</comment_count>
      <attachid>73678</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-11-11 16:17:16 -0800</bug_when>
    <thetext>Created attachment 73678
first try</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308262</commentid>
    <comment_count>2</comment_count>
    <who name="Tony Gentilcore">tonyg</who>
    <bug_when>2010-11-11 16:43:32 -0800</bug_when>
    <thetext>I&apos;m excited to see this getting enabled, but backfilling the times from the network stack means that these attributes report incorrect values with no hint to the user. It also isn&apos;t compliant w/ the spec.

Assuming modifying the network stack isn&apos;t a reasonable option, I&apos;d recommend one of two approaches:
1. Keep zeroes for these times and just keep the failing tests in the Skipped file.
2. Do what is proposed in https://bugs.webkit.org/show_bug.cgi?id=48923 and make the webcore times enabled by default and just guard the network times with the enable web timing flag. This would result in those properties not being defined at all rather than backfilling or exposing zeroes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>309507</commentid>
    <comment_count>3</comment_count>
      <attachid>73944</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-11-15 16:43:42 -0800</bug_when>
    <thetext>Created attachment 73944
second-try

Revert changes in Timing.cpp and fail the corresponding test as suggested by Tony Gentilcore.

The intention for QtWebKit is to implement the network related timers as well in a separate patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>309511</commentid>
    <comment_count>4</comment_count>
    <who name="Tony Gentilcore">tonyg</who>
    <bug_when>2010-11-15 16:50:10 -0800</bug_when>
    <thetext>LGTM, thanks! (I&apos;m not a reviewer)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>309513</commentid>
    <comment_count>5</comment_count>
      <attachid>73944</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-11-15 16:58:03 -0800</bug_when>
    <thetext>Comment on attachment 73944
second-try

View in context: https://bugs.webkit.org/attachment.cgi?id=73944&amp;action=review

LGTM.

&gt; LayoutTests/ChangeLog:9
&gt; +        * fast/dom/webtiming-document-open-expected.txt: Add
&gt; +          webkitPerformance property

Should be &quot;Add an extra line to the expected results&quot;

&gt; LayoutTests/ChangeLog:14
&gt; +        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
&gt; +          Add an extra line to the expected results

Should be &quot;Add webkitPerformance property&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316546</commentid>
    <comment_count>6</comment_count>
      <attachid>75441</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-12-02 17:22:58 -0800</bug_when>
    <thetext>Created attachment 75441
fixed ChangeLog, uploading for cq to land

Thanks for the review Andreas.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316682</commentid>
    <comment_count>7</comment_count>
      <attachid>75441</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-02 22:49:29 -0800</bug_when>
    <thetext>Comment on attachment 75441
fixed ChangeLog, uploading for cq to land

Clearing flags on attachment: 75441

Committed r73241: &lt;http://trac.webkit.org/changeset/73241&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316683</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-02 22:49:37 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316775</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-12-03 04:07:59 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 75441 [details])
&gt; Clearing flags on attachment: 75441
&gt; 
&gt; Committed r73241: &lt;http://trac.webkit.org/changeset/73241&gt;

FYI: Unfortunately it broke many tests because modifying a define 
never trigger rebuild. :( I did a clean build on Qt bots manually.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316789</commentid>
    <comment_count>10</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-12-03 05:10:54 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #7)
&gt; &gt; (From update of attachment 75441 [details] [details])
&gt; &gt; Clearing flags on attachment: 75441
&gt; &gt; 
&gt; &gt; Committed r73241: &lt;http://trac.webkit.org/changeset/73241&gt;
&gt; 
&gt; FYI: Unfortunately it broke many tests because modifying a define 
&gt; never trigger rebuild. :( I did a clean build on Qt bots manually.

Thanks Ossy !</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316829</commentid>
    <comment_count>11</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-03 08:34:32 -0800</bug_when>
    <thetext>Seems like we should have a bug on this dependency problem in the Qt build.  Dependency problems cause all sorts of badness since humans have to step in to fix bots, etc.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>316845</commentid>
    <comment_count>12</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-12-03 09:32:41 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; Seems like we should have a bug on this dependency problem in the Qt build.  Dependency problems cause all sorts of badness since humans have to step in to fix bots, etc.

We have a bug about it, but there isn&apos;t a good way to solve it:
https://bugs.webkit.org/show_bug.cgi?id=38054
details: https://bugs.webkit.org/show_bug.cgi?id=42027#c26</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>73678</attachid>
            <date>2010-11-11 16:17:16 -0800</date>
            <delta_ts>2010-11-15 16:43:42 -0800</delta_ts>
            <desc>first try</desc>
            <filename>42433.patch</filename>
            <type>text/plain</type>
            <size>8657</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA3MTg2MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTEtMTEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF0gRW5hYmxlIFdlYiBUaW1pbmcgZm9yIFF0CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQzMworCisgICAgICAgICogZmVhdHVyZXMu
cHJpOiBFbmFibGUgV2ViIFRpbWluZyBmb3IgdHJ1bmsgKGJ1dCBub3QgeWV0IGZvciAKKyAgICAg
ICAgICBwcm9kdWN0aW9uKQorCisgICAgICAgICogcGFnZS9UaW1pbmcuY3BwOiBGaXggZWFybHkg
cmV0dXJuIHZhbHVlcyAod2hlbiBSZXNvdXJjZUxvYWRUaW1pbmcKKyAgICAgICAgICBpcyBub3Qg
YXZhaWxhYmxlKQorICAgICAgICAoV2ViQ29yZTo6VGltaW5nOjpkb21haW5Mb29rdXBTdGFydCk6
CisgICAgICAgIChXZWJDb3JlOjpUaW1pbmc6OmRvbWFpbkxvb2t1cEVuZCk6CisgICAgICAgIChX
ZWJDb3JlOjpUaW1pbmc6OmNvbm5lY3RTdGFydCk6CisgICAgICAgIChXZWJDb3JlOjpUaW1pbmc6
OmNvbm5lY3RFbmQpOgorICAgICAgICAoV2ViQ29yZTo6VGltaW5nOjpyZXF1ZXN0U3RhcnQpOgor
ICAgICAgICAoV2ViQ29yZTo6VGltaW5nOjpyZXNwb25zZVN0YXJ0KToKKwogMjAxMC0xMS0xMCAg
WmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l
dGggUnVzc2VsbC4KSW5kZXg6IFdlYkNvcmUvZmVhdHVyZXMucHJpCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl
YkNvcmUvZmVhdHVyZXMucHJpCShyZXZpc2lvbiA3MTgzOSkKKysrIFdlYkNvcmUvZmVhdHVyZXMu
cHJpCSh3b3JraW5nIGNvcHkpCkBAIC02LDYgKzYsNyBAQCBDT05GSUcobWluaW1hbCkgewogCiBD
T05GSUcocHJvZHVjdGlvbikgewogICAgIERFRklORVMgKz0gRU5BQkxFX1hTTFQ9MAorICAgIERF
RklORVMgKz0gRU5BQkxFX1dFQl9USU1JTkc9MAogfQogCiAjIyBsb2FkIG1vYmlsaXR5Y29uZmln
IGlmIG1vYmlsaXR5IGlzIGF2YWlsYWJsZQpAQCAtOTksNyArMTAwLDcgQEAgY29udGFpbnMoREVG
SU5FUywgRU5BQkxFX1NJTkdMRV9USFJFQURFRAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9X
RUJfU09DS0VUUz0uKTogREVGSU5FUyArPSBFTkFCTEVfV0VCX1NPQ0tFVFM9MQogCiAjIFdlYiBU
aW1pbmcgc3VwcG9ydC4KLSFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCX1RJTUlORz0uKTog
REVGSU5FUyArPSBFTkFCTEVfV0VCX1RJTUlORz0wCishY29udGFpbnMoREVGSU5FUywgRU5BQkxF
X1dFQl9USU1JTkc9Lik6IERFRklORVMgKz0gRU5BQkxFX1dFQl9USU1JTkc9MQogCiAjIFhTTFQg
c3VwcG9ydCB3aXRoIFF0WG1sUGF0dGVybnMKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfWFNM
VD0uKSB7CkluZGV4OiBXZWJDb3JlL3BhZ2UvVGltaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD
b3JlL3BhZ2UvVGltaW5nLmNwcAkocmV2aXNpb24gNzE4MzkpCisrKyBXZWJDb3JlL3BhZ2UvVGlt
aW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDExICsxMzIsMTIgQEAgdW5zaWduZWQgbG9u
ZyBsb25nIFRpbWluZzo6ZmV0Y2hTdGFydCgpIAogdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6
ZG9tYWluTG9va3VwU3RhcnQoKSBjb25zdAogewogICAgIFJlc291cmNlTG9hZFRpbWluZyogdGlt
aW5nID0gcmVzb3VyY2VMb2FkVGltaW5nKCk7CisKKyAgICAvLyBSYXRoZXIgdGhhbiBleHBvc2lu
ZyBhIHNwZWNpYWwgdmFsdWUgdGhhdCBpbmRpY2F0ZXMgbm8gRE5TLCB3ZSAiYmFja2ZpbGwiIHdp
dGggZmV0Y2hTdGFydC4KICAgICBpZiAoIXRpbWluZykKLSAgICAgICAgcmV0dXJuIDA7CisgICAg
ICAgIHJldHVybiBmZXRjaFN0YXJ0KCk7CiAKICAgICAvLyBUaGlzIHdpbGwgYmUgLTEgd2hlbiBh
IEROUyByZXF1ZXN0IGlzIG5vdCBwZXJmb3JtZWQuCi0gICAgLy8gUmF0aGVyIHRoYW4gZXhwb3Np
bmcgYSBzcGVjaWFsIHZhbHVlIHRoYXQgaW5kaWNhdGVzIG5vIEROUywgd2UgImJhY2tmaWxsIiB3
aXRoIGZldGNoU3RhcnQuCiAgICAgaW50IGRuc1N0YXJ0ID0gdGltaW5nLT5kbnNTdGFydDsKICAg
ICBpZiAoZG5zU3RhcnQgPCAwKQogICAgICAgICByZXR1cm4gZmV0Y2hTdGFydCgpOwpAQCAtMTQ3
LDExICsxNDgsMTIgQEAgdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6ZG9tYWluTG9va3VwUwog
dW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6ZG9tYWluTG9va3VwRW5kKCkgY29uc3QKIHsKICAg
ICBSZXNvdXJjZUxvYWRUaW1pbmcqIHRpbWluZyA9IHJlc291cmNlTG9hZFRpbWluZygpOworCisg
ICAgLy8gUmF0aGVyIHRoYW4gZXhwb3NpbmcgYSBzcGVjaWFsIHZhbHVlIHRoYXQgaW5kaWNhdGVz
IG5vIEROUywgd2UgImJhY2tmaWxsIiB3aXRoIGRvbWFpbkxvb2t1cFN0YXJ0LgogICAgIGlmICgh
dGltaW5nKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIGRvbWFpbkxvb2t1cFN0
YXJ0KCk7CiAKICAgICAvLyBUaGlzIHdpbGwgYmUgLTEgd2hlbiBhIEROUyByZXF1ZXN0IGlzIG5v
dCBwZXJmb3JtZWQuCi0gICAgLy8gUmF0aGVyIHRoYW4gZXhwb3NpbmcgYSBzcGVjaWFsIHZhbHVl
IHRoYXQgaW5kaWNhdGVzIG5vIEROUywgd2UgImJhY2tmaWxsIiB3aXRoIGRvbWFpbkxvb2t1cFN0
YXJ0LgogICAgIGludCBkbnNFbmQgPSB0aW1pbmctPmRuc0VuZDsKICAgICBpZiAoZG5zRW5kIDwg
MCkKICAgICAgICAgcmV0dXJuIGRvbWFpbkxvb2t1cFN0YXJ0KCk7CkBAIC0xNjIsMTUgKzE2NCwx
NiBAQCB1bnNpZ25lZCBsb25nIGxvbmcgVGltaW5nOjpkb21haW5Mb29rdXBFCiB1bnNpZ25lZCBs
b25nIGxvbmcgVGltaW5nOjpjb25uZWN0U3RhcnQoKSBjb25zdAogewogICAgIERvY3VtZW50TG9h
ZGVyKiBsb2FkZXIgPSBkb2N1bWVudExvYWRlcigpOworCisgICAgLy8gUmF0aGVyIHRoYW4gZXhw
b3NpbmcgYSBzcGVjaWFsIHZhbHVlIHRoYXQgaW5kaWNhdGVzIG5vIG5ldyBjb25uZWN0aW9uLCB3
ZSAiYmFja2ZpbGwiIHdpdGggZG9tYWluTG9va3VwRW5kLgogICAgIGlmICghbG9hZGVyKQotICAg
ICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIGRvbWFpbkxvb2t1cEVuZCgpOwogCiAgICAg
UmVzb3VyY2VMb2FkVGltaW5nKiB0aW1pbmcgPSBsb2FkZXItPnJlc3BvbnNlKCkucmVzb3VyY2VM
b2FkVGltaW5nKCk7CiAgICAgaWYgKCF0aW1pbmcpCi0gICAgICAgIHJldHVybiAwOworICAgICAg
ICByZXR1cm4gZG9tYWluTG9va3VwRW5kKCk7CiAKICAgICAvLyBjb25uZWN0U3RhcnQgd2lsbCBi
ZSAtMSB3aGVuIGEgbmV0d29yayByZXF1ZXN0IGlzIG5vdCBtYWRlLgotICAgIC8vIFJhdGhlciB0
aGFuIGV4cG9zaW5nIGEgc3BlY2lhbCB2YWx1ZSB0aGF0IGluZGljYXRlcyBubyBuZXcgY29ubmVj
dGlvbiwgd2UgImJhY2tmaWxsIiB3aXRoIGRvbWFpbkxvb2t1cEVuZC4KICAgICBpbnQgY29ubmVj
dFN0YXJ0ID0gdGltaW5nLT5jb25uZWN0U3RhcnQ7CiAgICAgaWYgKGNvbm5lY3RTdGFydCA8IDAg
fHwgbG9hZGVyLT5yZXNwb25zZSgpLmNvbm5lY3Rpb25SZXVzZWQoKSkKICAgICAgICAgcmV0dXJu
IGRvbWFpbkxvb2t1cEVuZCgpOwpAQCAtMTg2LDEyICsxODksMTQgQEAgdW5zaWduZWQgbG9uZyBs
b25nIFRpbWluZzo6Y29ubmVjdFN0YXJ0KAogdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6Y29u
bmVjdEVuZCgpIGNvbnN0CiB7CiAgICAgRG9jdW1lbnRMb2FkZXIqIGxvYWRlciA9IGRvY3VtZW50
TG9hZGVyKCk7CisKKyAgICAvLyBSYXRoZXIgdGhhbiBleHBvc2luZyBhIHNwZWNpYWwgdmFsdWUg
dGhhdCBpbmRpY2F0ZXMgbm8gbmV3IGNvbm5lY3Rpb24sIHdlICJiYWNrZmlsbCIgd2l0aCBjb25u
ZWN0U3RhcnQuCiAgICAgaWYgKCFsb2FkZXIpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICBy
ZXR1cm4gY29ubmVjdFN0YXJ0KCk7CiAKICAgICBSZXNvdXJjZUxvYWRUaW1pbmcqIHRpbWluZyA9
IGxvYWRlci0+cmVzcG9uc2UoKS5yZXNvdXJjZUxvYWRUaW1pbmcoKTsKICAgICBpZiAoIXRpbWlu
ZykKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBjb25uZWN0U3RhcnQoKTsKIAog
ICAgIC8vIGNvbm5lY3RFbmQgd2lsbCBiZSAtMSB3aGVuIGEgbmV0d29yayByZXF1ZXN0IGlzIG5v
dCBtYWRlLgogICAgIC8vIFJhdGhlciB0aGFuIGV4cG9zaW5nIGEgc3BlY2lhbCB2YWx1ZSB0aGF0
IGluZGljYXRlcyBubyBuZXcgY29ubmVjdGlvbiwgd2UgImJhY2tmaWxsIiB3aXRoIGNvbm5lY3RT
dGFydC4KQEAgLTIxMCw4ICsyMTUsMTAgQEAgdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6Y29u
bmVjdEVuZCgpIAogdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6cmVxdWVzdFN0YXJ0KCkgY29u
c3QKIHsKICAgICBSZXNvdXJjZUxvYWRUaW1pbmcqIHRpbWluZyA9IHJlc291cmNlTG9hZFRpbWlu
ZygpOworCisgICAgLy8gUmF0aGVyIHRoYW4gZXhwb3NpbmcgYSBzcGVjaWFsIHZhbHVlIHRoYXQg
aW5kaWNhdGVzIG5vIG5ldyBjb25uZWN0aW9uLCB3ZSAiYmFja2ZpbGwiIHdpdGggY29ubmVjdEVu
ZAogICAgIGlmICghdGltaW5nKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIGNv
bm5lY3RFbmQoKTsKIAogICAgIEFTU0VSVCh0aW1pbmctPnNlbmRTdGFydCA+PSAwKTsKICAgICBy
ZXR1cm4gcmVzb3VyY2VMb2FkVGltZVJlbGF0aXZlVG9BYnNvbHV0ZSh0aW1pbmctPnNlbmRTdGFy
dCk7CkBAIC0yMjAsOCArMjI3LDEwIEBAIHVuc2lnbmVkIGxvbmcgbG9uZyBUaW1pbmc6OnJlcXVl
c3RTdGFydCgKIHVuc2lnbmVkIGxvbmcgbG9uZyBUaW1pbmc6OnJlc3BvbnNlU3RhcnQoKSBjb25z
dAogewogICAgIFJlc291cmNlTG9hZFRpbWluZyogdGltaW5nID0gcmVzb3VyY2VMb2FkVGltaW5n
KCk7CisKKyAgICAvLyBSYXRoZXIgdGhhbiBleHBvc2luZyBhIHNwZWNpYWwgdmFsdWUgdGhhdCBp
bmRpY2F0ZXMgbm8gbmV3IGNvbm5lY3Rpb24sIHdlICJiYWNrZmlsbCIgd2l0aCByZXF1ZXN0U3Rh
cnQKICAgICBpZiAoIXRpbWluZykKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBy
ZXF1ZXN0U3RhcnQoKTsKIAogICAgIC8vIEZJWE1FOiBSZXNwb25zZSBzdGFydCBuZWVkcyB0byBi
ZSB0aGUgdGltZSBvZiB0aGUgZmlyc3QgcmVjZWl2ZWQgYnl0ZS4KICAgICAvLyBIb3dldmVyLCB0
aGUgUmVzb3VyY2VMb2FkVGltaW5nIEFQSSBjdXJyZW50bHkgb25seSBzdXBwb3J0cyB0aGUgdGlt
ZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz
L0NoYW5nZUxvZwkocmV2aXNpb24gNzE4NjEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv
cmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0xMSAgTGFzemxvIEdvbWJvcyAg
PGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgW1F0XSBFbmFibGUgV2ViIFRpbWluZyBmb3IgUXQKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNDMzCisKKyAgICAg
ICAgKiBmYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi1leHBlY3RlZC50eHQ6IEFkZAor
ICAgICAgICAgIHdlYmtpdFBlcmZvcm1hbmNlIHByb3BlcnR5CisKKyAgICAgICAgKiBwbGF0Zm9y
bS9xdC9Ta2lwcGVkOiBFbmFibGUgV2ViIFRpbWluZyB0ZXN0cworCisgICAgICAgICogcGxhdGZv
cm0vcXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3Rl
ZC50eHQ6CisgICAgICAgICAgQWRkIGFuIGV4dHJhIGxpbmUgdG8gdGhlIGV4cGVjdGVkIHJlc3Vs
dHMKKwogMjAxMC0xMS0xMCAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9t
L3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv
dXRUZXN0cy9mYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi1leHBlY3RlZC50eHQJKHJl
dmlzaW9uIDcxODM5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vd2VidGltaW5nLWRvY3VtZW50
LW9wZW4tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yNSwzICsyNSw0IEBAIFBBU1Mg
dGltaW5nLnVubG9hZEV2ZW50RW5kIGlzIG9yaWdpbmFsVGkKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFy
c2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y
bS9xdC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw
ZWQJKHJldmlzaW9uIDcxODM5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAko
d29ya2luZyBjb3B5KQpAQCAtNTE5MCwxOCArNTE5MCw2IEBAIGZhc3QvZm9ybXMvaW5wdXQtZmls
ZS1kaXJlY3RvcnktdXBsb2FkLmgKICMgTmVlZCBzZXRQcmludGluZy4gU2VlIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAxMQogcHJpbnRpbmcvc2V0UHJpbnRpbmcu
aHRtbAogCi0jIFdlYiBUaW1pbmcgaXMgbm90IGVuYWJsZWQuCi0jIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQzMwotZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9w
ZXJ0aWVzLXBlcmZvcm1hbmNlLmh0bWwKLWZhc3QvZG9tL25hdmlnYXRpb24tdHlwZS1iYWNrLWZv
cndhcmQuaHRtbAotZmFzdC9kb20vbmF2aWdhdGlvbi10eXBlLW5hdmlnYXRlLmh0bWwKLWZhc3Qv
ZG9tL25hdmlnYXRpb24tdHlwZS1yZWxvYWQuaHRtbAotZmFzdC9kb20vd2VidGltaW5nLmh0bWwK
LWZhc3QvZG9tL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLmh0bWwKLWZhc3QvZG9tL3dlYnRpbWlu
Zy1uYXZpZ2F0ZS13aXRoaW4tZG9jdW1lbnQuaHRtbAotaHR0cC90ZXN0cy9taXNjL3dlYnRpbWlu
Zy1vbmUtcmVkaXJlY3QucGhwCi1odHRwL3Rlc3RzL21pc2Mvd2VidGltaW5nLXR3by1yZWRpcmVj
dHMucGhwCi0KICMgQWR2YW5jZWQgY3JlZGVudGlhbCBoYW5kbGluZwogaHR0cC90ZXN0cy9zZWN1
cml0eS80MDEtbG9nb3V0LzQwMS1sb2dvdXQucGhwCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0
L3JlbWVtYmVyLWJhZC1wYXNzd29yZC5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9x
dC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4
dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cv
d2luZG93LXByb3BlcnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNzE4Mzkp
CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3Bl
cnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNDc0LDYgKzQ3
NCw3IEBAIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXAKIFBBU1MgdHlw
ZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAndW5kZWZpbmVkJykg
aXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Io
d2luZG93LCAndW5lc2NhcGUnKSBpcyAnb2JqZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93
blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd3ZWJraXROb3RpZmljYXRpb25zJykgaXMgJ29i
amVjdCcKK1BBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93
LCAnd2Via2l0UGVyZm9ybWFuY2UnKSBpcyAnb2JqZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0Lmdl
dE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd3aW5kb3cnKSBpcyAnb2JqZWN0JwogUEFT
UyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd3aW5kb3dQ
cm9wZXJ0eU5hbWVzJykgaXMgJ29iamVjdCcKIFBBU1MgT2JqZWN0LmdldE93blByb3BlcnR5RGVz
Y3JpcHRvcih3aW5kb3csICdfX2RlZmluZUdldHRlcl9fJykgaXMgdW5kZWZpbmVkLgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>73944</attachid>
            <date>2010-11-15 16:43:42 -0800</date>
            <delta_ts>2010-12-02 17:22:58 -0800</delta_ts>
            <desc>second-try</desc>
            <filename>42433-2.patch</filename>
            <type>text/plain</type>
            <size>4252</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA3MTg2MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMTMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF0gRW5hYmxlIFdlYiBUaW1pbmcgZm9yIFF0CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQzMworCisgICAgICAgICogZmVhdHVyZXMu
cHJpOiBFbmFibGUgV2ViIFRpbWluZyBmb3IgdHJ1bmsgKGJ1dCBub3QgeWV0IGZvciAKKyAgICAg
ICAgICBwcm9kdWN0aW9uKQorCiAyMDEwLTExLTEwICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5j
b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpJbmRleDogV2ViQ29y
ZS9mZWF0dXJlcy5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9mZWF0dXJlcy5wcmkJKHJldmlz
aW9uIDcxODM5KQorKysgV2ViQ29yZS9mZWF0dXJlcy5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTYs
NiArNiw3IEBAIENPTkZJRyhtaW5pbWFsKSB7CiAKIENPTkZJRyhwcm9kdWN0aW9uKSB7CiAgICAg
REVGSU5FUyArPSBFTkFCTEVfWFNMVD0wCisgICAgREVGSU5FUyArPSBFTkFCTEVfV0VCX1RJTUlO
Rz0wCiB9CiAKICMjIGxvYWQgbW9iaWxpdHljb25maWcgaWYgbW9iaWxpdHkgaXMgYXZhaWxhYmxl
CkBAIC05OSw3ICsxMDAsNyBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVB
REVECiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1dFQl9TT0NLRVRTPS4pOiBERUZJTkVTICs9
IEVOQUJMRV9XRUJfU09DS0VUUz0xCiAKICMgV2ViIFRpbWluZyBzdXBwb3J0LgotIWNvbnRhaW5z
KERFRklORVMsIEVOQUJMRV9XRUJfVElNSU5HPS4pOiBERUZJTkVTICs9IEVOQUJMRV9XRUJfVElN
SU5HPTAKKyFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCX1RJTUlORz0uKTogREVGSU5FUyAr
PSBFTkFCTEVfV0VCX1RJTUlORz0xCiAKICMgWFNMVCBzdXBwb3J0IHdpdGggUXRYbWxQYXR0ZXJu
cwogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9YU0xUPS4pIHsKSW5kZXg6IExheW91dFRlc3Rz
L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u
IDcxODYxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTggQEAKKzIwMTAtMTEtMTMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFtRdF0gRW5hYmxlIFdlYiBUaW1pbmcgZm9yIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQzMworCisgICAgICAgICogZmFzdC9kb20vd2VidGlt
aW5nLWRvY3VtZW50LW9wZW4tZXhwZWN0ZWQudHh0OiBBZGQKKyAgICAgICAgICB3ZWJraXRQZXJm
b3JtYW5jZSBwcm9wZXJ0eQorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDogRW5hYmxl
IFdlYiBUaW1pbmcgdGVzdHMKKworICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRv
dy93aW5kb3ctcHJvcGVydHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAgIEFk
ZCBhbiBleHRyYSBsaW5lIHRvIHRoZSBleHBlY3RlZCByZXN1bHRzCisKIDIwMTAtMTEtMTAgIFpo
ZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRo
IFJ1c3NlbGwuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQt
b3Blbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vd2Vi
dGltaW5nLWRvY3VtZW50LW9wZW4tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA3MTgzOSkKKysrIExh
eW91dFRlc3RzL2Zhc3QvZG9tL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLWV4cGVjdGVkLnR4dAko
d29ya2luZyBjb3B5KQpAQCAtMjUsMyArMjUsNCBAQCBQQVNTIHRpbWluZy51bmxvYWRFdmVudEVu
ZCBpcyBvcmlnaW5hbFRpCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1Qg
Q09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCShyZXZpc2lvbiA3MTgzOSkK
KysrIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTUx
OTIsMTUgKzUxOTIsNyBAQCBwcmludGluZy9zZXRQcmludGluZy5odG1sCiAKICMgV2ViIFRpbWlu
ZyBpcyBub3QgZW5hYmxlZC4KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTQyNDMzCi1mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtcGVyZm9ybWFuY2Uu
aHRtbAotZmFzdC9kb20vbmF2aWdhdGlvbi10eXBlLWJhY2stZm9yd2FyZC5odG1sCi1mYXN0L2Rv
bS9uYXZpZ2F0aW9uLXR5cGUtbmF2aWdhdGUuaHRtbAotZmFzdC9kb20vbmF2aWdhdGlvbi10eXBl
LXJlbG9hZC5odG1sCiBmYXN0L2RvbS93ZWJ0aW1pbmcuaHRtbAotZmFzdC9kb20vd2VidGltaW5n
LWRvY3VtZW50LW9wZW4uaHRtbAotZmFzdC9kb20vd2VidGltaW5nLW5hdmlnYXRlLXdpdGhpbi1k
b2N1bWVudC5odG1sCi1odHRwL3Rlc3RzL21pc2Mvd2VidGltaW5nLW9uZS1yZWRpcmVjdC5waHAK
LWh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmctdHdvLXJlZGlyZWN0cy5waHAKIAogIyBBZHZhbmNl
ZCBjcmVkZW50aWFsIGhhbmRsaW5nCiBodHRwL3Rlc3RzL3NlY3VyaXR5LzQwMS1sb2dvdXQvNDAx
LWxvZ291dC5waHAKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRv
dy93aW5kb3ctcHJvcGVydHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHkt
ZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA3MTgzOSkKKysrIExheW91dFRlc3Rz
L3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktZGVzY3JpcHRvcnMt
ZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC00NzQsNiArNDc0LDcgQEAgUEFTUyB0eXBl
b2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcAogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93
blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd1bmRlZmluZWQnKSBpcyAnb2JqZWN0JwogUEFT
UyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd1bmVzY2Fw
ZScpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlw
dG9yKHdpbmRvdywgJ3dlYmtpdE5vdGlmaWNhdGlvbnMnKSBpcyAnb2JqZWN0JworUEFTUyB0eXBl
b2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd3ZWJraXRQZXJmb3Jt
YW5jZScpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNj
cmlwdG9yKHdpbmRvdywgJ3dpbmRvdycpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3Qu
Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3dpbmRvd1Byb3BlcnR5TmFtZXMnKSBp
cyAnb2JqZWN0JwogUEFTUyBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywg
J19fZGVmaW5lR2V0dGVyX18nKSBpcyB1bmRlZmluZWQuCg==
</data>
<flag name="review"
          id="64477"
          type_id="1"
          status="+"
          setter="kling"
    />
    <flag name="commit-queue"
          id="64478"
          type_id="3"
          status="-"
          setter="kling"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>75441</attachid>
            <date>2010-12-02 17:22:58 -0800</date>
            <delta_ts>2010-12-02 22:49:29 -0800</delta_ts>
            <desc>fixed ChangeLog, uploading for cq to land</desc>
            <filename>42433.patch</filename>
            <type>text/plain</type>
            <size>4156</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBlNWRmMGY5Li5iMDRhOTNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTIt
MDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAgICAgW1F0XSBFbmFibGUgV2ViIFRp
bWluZyBmb3IgUXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTQyNDMzCisKKyAgICAgICAgKiBmYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi1l
eHBlY3RlZC50eHQ6CisgICAgICAgICAgQWRkIGFuIGV4dHJhIGxpbmUgdG8gdGhlIGV4cGVjdGVk
IHJlc3VsdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOiBFbmFibGUgV2ViIFRp
bWluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5k
b3ctcHJvcGVydHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAgIEFkZCB3ZWJr
aXRQZXJmb3JtYW5jZSBwcm9wZXJ0eS4KKwogMjAxMC0xMi0wMiAgRGFuIEJlcm5zdGVpbiAgPG1p
dHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi1leHBlY3Rl
ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi1leHBl
Y3RlZC50eHQKaW5kZXggNzA4MGNmNi4uZmNiMTJlNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv
ZmFzdC9kb20vd2VidGltaW5nLWRvY3VtZW50LW9wZW4tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91
dFRlc3RzL2Zhc3QvZG9tL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLWV4cGVjdGVkLnR4dApAQCAt
MjYsMyArMjYsNCBAQCBQQVNTIHRpbWluZy51bmxvYWRFdmVudFN0YXJ0IGlzIG9yaWdpbmFsVGlt
aW5nLnVubG9hZEV2ZW50U3RhcnQKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAog
VEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw
cGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA0ODQwYTc5Li4zNGY0
OWEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xh
eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTUyMDIsMTUgKzUyMDIsNyBAQCBwcmlu
dGluZy9zZXRQcmludGluZy5odG1sCiAKICMgV2ViIFRpbWluZyBpcyBub3QgZW5hYmxlZC4KICMg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNDMzCi1mYXN0L2RvbS9X
aW5kb3cvd2luZG93LXByb3BlcnRpZXMtcGVyZm9ybWFuY2UuaHRtbAotZmFzdC9kb20vbmF2aWdh
dGlvbi10eXBlLWJhY2stZm9yd2FyZC5odG1sCi1mYXN0L2RvbS9uYXZpZ2F0aW9uLXR5cGUtbmF2
aWdhdGUuaHRtbAotZmFzdC9kb20vbmF2aWdhdGlvbi10eXBlLXJlbG9hZC5odG1sCiBmYXN0L2Rv
bS93ZWJ0aW1pbmcuaHRtbAotZmFzdC9kb20vd2VidGltaW5nLWRvY3VtZW50LW9wZW4uaHRtbAot
ZmFzdC9kb20vd2VidGltaW5nLW5hdmlnYXRlLXdpdGhpbi1kb2N1bWVudC5odG1sCi1odHRwL3Rl
c3RzL21pc2Mvd2VidGltaW5nLW9uZS1yZWRpcmVjdC5waHAKLWh0dHAvdGVzdHMvbWlzYy93ZWJ0
aW1pbmctdHdvLXJlZGlyZWN0cy5waHAKIAogIyBBZHZhbmNlZCBjcmVkZW50aWFsIGhhbmRsaW5n
CiBodHRwL3Rlc3RzL3NlY3VyaXR5LzQwMS1sb2dvdXQvNDAxLWxvZ291dC5waHAKZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVy
dHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFz
dC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKaW5k
ZXggZjhiYzYyZC4uMmRkOTQ1MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv
ZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQK
KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9w
ZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKQEAgLTQ3Miw2ICs0NzIsNyBAQCBQQVNTIHR5
cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3RvcCcpIGlzICdv
YmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRv
dywgJ3VuZGVmaW5lZCcpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJv
cGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3VuZXNjYXBlJykgaXMgJ29iamVjdCcKIFBBU1MgdHlw
ZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnd2Via2l0Tm90aWZp
Y2F0aW9ucycpIGlzICdvYmplY3QnCitQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlE
ZXNjcmlwdG9yKHdpbmRvdywgJ3dlYmtpdFBlcmZvcm1hbmNlJykgaXMgJ29iamVjdCcKIFBBU1Mg
dHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnd2luZG93Jykg
aXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Io
d2luZG93LCAnd2luZG93UHJvcGVydHlOYW1lcycpIGlzICdvYmplY3QnCiBQQVNTIE9iamVjdC5n
ZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnX19kZWZpbmVHZXR0ZXJfXycpIGlzIHVu
ZGVmaW5lZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VM
b2cKaW5kZXggZjBiMmI5OS4uMDdjNzBkZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0wMiAgTGFz
emxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgQW5kcmVhcyBLbGluZy4KKworICAgICAgICBbUXRdIEVuYWJsZSBXZWIgVGltaW5nIGZv
ciBRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI0
MzMKKworICAgICAgICAqIGZlYXR1cmVzLnByaTogRW5hYmxlIFdlYiBUaW1pbmcgZm9yIHRydW5r
IChidXQgbm90IHlldCBmb3IKKyAgICAgICAgICBwcm9kdWN0aW9uKQorCiAyMDEwLTEyLTAyICBE
YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2
ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZmVhdHVyZXMucHJpIGIvV2ViQ29yZS9mZWF0
dXJlcy5wcmkKaW5kZXggM2VkMWRhMS4uNzJiZTcwZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9mZWF0
dXJlcy5wcmkKKysrIGIvV2ViQ29yZS9mZWF0dXJlcy5wcmkKQEAgLTYsNiArNiw3IEBAIENPTkZJ
RyhtaW5pbWFsKSB7CiAKIENPTkZJRyhwcm9kdWN0aW9uKSB7CiAgICAgREVGSU5FUyArPSBFTkFC
TEVfWFNMVD0wCisgICAgREVGSU5FUyArPSBFTkFCTEVfV0VCX1RJTUlORz0wCiB9CiAKIG1lZWdv
dG91Y2ggewpAQCAtMTA0LDcgKzEwNSw3IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9TSU5H
TEVfVEhSRUFERUQ9MSkgewogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9XRUJfU09DS0VUUz0u
KTogREVGSU5FUyArPSBFTkFCTEVfV0VCX1NPQ0tFVFM9MQogCiAjIFdlYiBUaW1pbmcgc3VwcG9y
dC4KLSFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCX1RJTUlORz0uKTogREVGSU5FUyArPSBF
TkFCTEVfV0VCX1RJTUlORz0wCishY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1dFQl9USU1JTkc9
Lik6IERFRklORVMgKz0gRU5BQkxFX1dFQl9USU1JTkc9MQogCiAjIFhTTFQgc3VwcG9ydCB3aXRo
IFF0WG1sUGF0dGVybnMKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfWFNMVD0uKSB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>