42424 2010-07-15 16:47:03 -0700 If needed, NPN_GetURL the src URL 2010-07-15 17:08:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 252218 0 andersca 2010-07-15 16:47:03 -0700 If needed, NPN_GetURL the src URL 252221 1 61746 andersca 2010-07-15 16:48:02 -0700 Created attachment 61746 Patch 252226 2 webkit.review.bot 2010-07-15 16:52:09 -0700 Attachment 61746 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:69: NPP_URLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:70: NPP_GetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:198: NetscapePlugin::NPP_GetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 252233 3 andersca 2010-07-15 17:08:02 -0700 Committed r63497: <http://trac.webkit.org/changeset/63497> 61746 2010-07-15 16:48:02 -0700 2010-07-15 17:04:34 -0700 Patch bug-42424-20100715164801.patch text/plain 3469 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZDkxMTQ1ZmFmY2YxMzg3MjEwZTUzNTI2MTY2MWFjZjlkYjcxZDkxNC4uM2Q4NGVjZWQwNzkyZmEw NDZkOGUyMTE2MWYyZDkzOTM3ZmViNzJkYiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMC0wNy0xNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIG5lZWRlZCwgTlBOX0dldFVSTCB0aGUgc3Jj IFVSTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI0 MjQKKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdp bi5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luOjpOUFBfR2V0VmFsdWUpOgor ICAgICAgICBBZGQgTlBQX0dldFZhbHVlIHdyYXBwZXIuCisKKyAgICAgICAgKFdlYktpdDo6TmV0 c2NhcGVQbHVnaW46OnNob3VsZExvYWRTcmNVUkwpOgorICAgICAgICBDaGVjayB3aGV0aGVyIHRo ZSBzcmMgdXJsIHNob3VsZCBiZSBjYW5jZWxsZWQuCisKKyAgICAgICAgKFdlYktpdDo6TmV0c2Nh cGVQbHVnaW46OmluaXRpYWxpemUpOgorICAgICAgICBJZiB0aGUgc3JjIFVSTCBzaG91bGQgYmUg bG9hZGVkLCB0aGVuIGxvYWQgaXQuCisgICAgICAgIAorMjAxMC0wNy0xNSAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWlu aWcuCiAKICAgICAgICAgU3RvcCB0aGUgcGx1Zy1pbiBzdHJlYW0gd2hlbiBpdCdzIGZpbmlzaGVk IGxvYWRpbmcKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L05ldHNjYXBlUGx1Z2luLmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L05ldHNjYXBlUGx1Z2luLmNwcAppbmRleCBjYzQxZjY2MDNjMzEzYmEyZWEyMjE2MGUzM2UzOTQ3 NTU2Y2QzZTgxLi5lMmM1MjcyNWE1MTNlOTBlYTEwZjRkNDg4NzlmNjEwMmU2NDJjMmEwIDEwMDY0 NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdp bi5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQ bHVnaW4uY3BwCkBAIC0xOTUsNiArMTk1LDExIEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46Ok5QUF9V UkxOb3RpZnkoY29uc3QgY2hhciogdXJsLCBOUFJlYXNvbiByZWFzb24sIHZvaWQqIG5vdGlmCiAg ICAgbV9wbHVnaW5Nb2R1bGUtPnBsdWdpbkZ1bmNzKCkudXJsbm90aWZ5KCZtX25wcCwgdXJsLCBy ZWFzb24sIG5vdGlmeURhdGEpOwogfQogCitOUEVycm9yIE5ldHNjYXBlUGx1Z2luOjpOUFBfR2V0 VmFsdWUoTlBQVmFyaWFibGUgdmFyaWFibGUsIHZvaWQgKnZhbHVlKQoreworICAgIHJldHVybiBt X3BsdWdpbk1vZHVsZS0+cGx1Z2luRnVuY3MoKS5nZXR2YWx1ZSgmbV9ucHAsIHZhcmlhYmxlLCB2 YWx1ZSk7Cit9CisKIHZvaWQgTmV0c2NhcGVQbHVnaW46OmNhbGxTZXRXaW5kb3coKQogewogICAg IG1fbnBXaW5kb3cueCA9IG1fZnJhbWVSZWN0LngoKTsKQEAgLTIwOSw2ICsyMTQsMTcgQEAgdm9p ZCBOZXRzY2FwZVBsdWdpbjo6Y2FsbFNldFdpbmRvdygpCiAgICAgTlBQX1NldFdpbmRvdygmbV9u cFdpbmRvdyk7CiB9CiAKK2Jvb2wgTmV0c2NhcGVQbHVnaW46OnNob3VsZExvYWRTcmNVUkwoKQor eworICAgIC8vIENoZWNrIGlmIHdlIHNob3VsZCBjYW5jZWwgdGhlIGxvYWQKKyAgICBOUEJvb2wg Y2FuY2VsU3JjU3RyZWFtID0gZmFsc2U7CisKKyAgICBpZiAoTlBQX0dldFZhbHVlKE5QUFZwbHVn aW5DYW5jZWxTcmNTdHJlYW0sICZjYW5jZWxTcmNTdHJlYW0pICE9IE5QRVJSX05PX0VSUk9SKQor ICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIHJldHVybiAhY2FuY2VsU3JjU3RyZWFtOworfQor CiBOZXRzY2FwZVBsdWdpblN0cmVhbSogTmV0c2NhcGVQbHVnaW46OnN0cmVhbUZyb21JRCh1aW50 NjRfdCBzdHJlYW1JRCkKIHsKICAgICByZXR1cm4gbV9zdHJlYW1zLmdldChzdHJlYW1JRCkuZ2V0 KCk7CkBAIC0yNjEsNiArMjc3LDEwIEBAIGJvb2wgTmV0c2NhcGVQbHVnaW46OmluaXRpYWxpemUo UGx1Z2luQ29udHJvbGxlciogcGx1Z2luQ29udHJvbGxlciwgY29uc3QgUGFyYW1lCiAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICB9CiAKKyAgICAvLyBMb2FkIHRoZSBzcmMgVVJMIGlmIG5lZWRl ZC4KKyAgICBpZiAoIXBhcmFtZXRlcnMudXJsLmlzRW1wdHkoKSAmJiBzaG91bGRMb2FkU3JjVVJM KCkpCisgICAgICAgIGxvYWRVUkwocGFyYW1ldGVycy51cmwuc3RyaW5nKCksIFN0cmluZygpLCBm YWxzZSwgMCk7CisgICAgCiAgICAgcmV0dXJuIHRydWU7CiB9CiAgICAgCmRpZmYgLS1naXQgYS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oIGIvV2Vi S2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaAppbmRleCBh NDMxYzRmNGE2MjE4MDBkYjBmMGYwMmEyNzZmNmFmYjY0YWRiMTgxLi5lMTNmZGU2YTE3Nzk0Mjlk Y2ExMDYyNDA5ZWQyZTY3MDFjOWJiNDdiIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmgKQEAgLTY2LDE0ICs2NiwxNCBAQCBw dWJsaWM6CiAgICAgTlBFcnJvciBOUFBfRGVzdHJveVN0cmVhbShOUFN0cmVhbSosIE5QUmVhc29u KTsKICAgICBpbnQzMl90IE5QUF9Xcml0ZVJlYWR5KE5QU3RyZWFtKik7CiAgICAgaW50MzJfdCBO UFBfV3JpdGUoTlBTdHJlYW0qLCBpbnQzMl90IG9mZnNldCwgaW50MzJfdCBsZW4sIHZvaWQqIGJ1 ZmZlcik7Ci0KLSAgICB2b2lkIE5QUF9VUkxOb3RpZnkoY29uc3QgY2hhciogdXJsLCBOUFJlYXNv biByZWFzb24sIHZvaWQqIG5vdGlmeURhdGEpOworICAgIHZvaWQgTlBQX1VSTE5vdGlmeShjb25z dCBjaGFyKiB1cmwsIE5QUmVhc29uLCB2b2lkKiBub3RpZnlEYXRhKTsKKyAgICBOUEVycm9yIE5Q UF9HZXRWYWx1ZShOUFBWYXJpYWJsZSwgdm9pZCAqdmFsdWUpOwogCiBwcml2YXRlOgogICAgIE5l dHNjYXBlUGx1Z2luKFBhc3NSZWZQdHI8TmV0c2NhcGVQbHVnaW5Nb2R1bGU+IHBsdWdpbk1vZHVs ZSk7CiAKICAgICB2b2lkIGNhbGxTZXRXaW5kb3coKTsKLQorICAgIGJvb2wgc2hvdWxkTG9hZFNy Y1VSTCgpOwogICAgIE5ldHNjYXBlUGx1Z2luU3RyZWFtKiBzdHJlYW1Gcm9tSUQodWludDY0X3Qg c3RyZWFtSUQpOwogCiAgICAgYm9vbCBwbGF0Zm9ybVBvc3RJbml0aWFsaXplKCk7Cg==