42408 2010-07-15 14:33:22 -0700 Assertion when turning Accelerated Compositing off on a composited page 2011-12-21 01:16:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser darin kbalazs qi.2.zhang simon.fraser oldest_to_newest 252115 0 simon.fraser 2010-07-15 14:33:22 -0700 When turning off Accelerated Compositing, we hit one of the ASSERT(willBeComposited == needsToBeComposited(layer)); assertions in RenderLayerCompositor::computeCompositingRequirements(). 252118 1 61724 simon.fraser 2010-07-15 14:36:03 -0700 Created attachment 61724 Patch 252125 2 61724 darin 2010-07-15 14:39:40 -0700 Comment on attachment 61724 Patch Does this fix only the assertion, or does it affect behavior too? If it does have an effect on behavior, what is that effect? 252143 3 simon.fraser 2010-07-15 14:58:52 -0700 There is no change in behavior; we used to do a bit of extra work for the one call to computeCompositingRequirements() after compositing was disabled, because we thought we needed to make layers, and then when we tried to, noticed that m_hasAcceleratedCompositing was false. With the patch we never even try to make layers in that situation. 252674 4 simon.fraser 2010-07-16 13:18:37 -0700 http://trac.webkit.org/changeset/63573 253337 5 qi.2.zhang 2010-07-19 12:42:52 -0700 *** Bug 42582 has been marked as a duplicate of this bug. *** 524595 6 kbalazs 2011-12-20 07:09:19 -0800 I have a similar issue: https://bugs.webkit.org/show_bug.cgi?id=74511. When running fast/multicol/pagination-v-vertical-lr.html it hits the assertion in RenderLayerCompositor: // If we just entered compositing mode, the root will have become composited (as long as accelerated compositing is enabled). if (layer->isRootLayer()) { if (inCompositingMode() && m_hasAcceleratedCompositing) willBeComposited = true; } ASSERT(willBeComposited == needsToBeComposited(layer)); <<<<<<<<<< In this case the layer is a root layer, and both inCompositingMode() and m_hasAcceleratedCompositing are true, but needsToBeComposited(layer) is false because layer->isNormalFlowOnly() => !layer->isSelfPaintingLayer() => !canBeComposited(layer) Do you think another condition could be sufficient? i.e: -if (layer->isRootLayer()) { +if (layer->isRootLayer() && canBeComposited(layer)) Thanks in advance to your help! 524603 7 simon.fraser 2011-12-20 07:21:52 -0800 (In reply to comment #6) > I have a similar issue: https://bugs.webkit.org/show_bug.cgi?id=74511. When running fast/multicol/pagination-v-vertical-lr.html it hits the assertion in RenderLayerCompositor: Please file a new bug for this assertion. > In this case the layer is a root layer, and both inCompositingMode() and m_hasAcceleratedCompositing are true, but needsToBeComposited(layer) is false because layer->isNormalFlowOnly() => !layer->isSelfPaintingLayer() => !canBeComposited(layer) > Do you think another condition could be sufficient? i.e: > -if (layer->isRootLayer()) { > +if (layer->isRootLayer() && canBeComposited(layer)) If the root layer cannot be composited, then all kinds of stuff will break. I think we'll have to fix this another way. 525183 8 kbalazs 2011-12-21 01:16:35 -0800 (In reply to comment #7) > (In reply to comment #6) > > I have a similar issue: https://bugs.webkit.org/show_bug.cgi?id=74511. When running fast/multicol/pagination-v-vertical-lr.html it hits the assertion in RenderLayerCompositor: > > Please file a new bug for this assertion. Filed https://bugs.webkit.org/show_bug.cgi?id=74999. 61724 2010-07-15 14:36:03 -0700 2010-07-15 22:13:01 -0700 Patch bug-42408-20100715143602.patch text/plain 1757 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjM0ZDc3ZDY0ZTczMmRlZGQ5ZmZiZDE1NTFmYmIyZWEzMjA3YWFiMy4uMWYyYTk4NzJmNjMwYWRm MTU5MGI3ODZjNjg4Yzc2ODI2MzhhZDliNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0xNSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBc3NlcnRpb24gd2hlbiB0dXJuaW5nIEFjY2Vs ZXJhdGVkIENvbXBvc2l0aW5nIG9mZiBvbiBhIGNvbXBvc2l0ZWQgcGFnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI0MDgKKworICAgICAgICBXaGVu IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIHR1cm5lZCBvZmYsIGNoZWNrIG1faGFzQWNjZWxl cmF0ZWRDb21wb3NpdGluZworICAgICAgICBiZWZvcmUgc2F5aW5nIHRoYXQgdGhlIHJvb3QgbGF5 ZXIgd2lsbCBiZSBjb21wb3NpdGVkLiBGaXhlcyBhbiBhc3NlcnRpb24uCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyQ29tcG9zaXRvcjo6Y29tcHV0ZUNvbXBvc2l0aW5nUmVxdWlyZW1lbnRzKToKKwog MjAxMC0wNy0wNyAgSm9obiBHcmVnZyAgPGpvaG5ueWdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKaWFuIExpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKaW5kZXggMWZkYTM0YzllNjA1YTE5OGQ0YTQ1ODA3ZTBkZjA1MGM5N2MwMWNkMC4u MzZhYTU3MGIxOGQ4YzM3OTJjMGEwMmE5NDk0NWFhNmZlNDIzNDY4MyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC02MDAsOSArNjAwLDExIEBAIHZv aWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpjb21wdXRlQ29tcG9zaXRpbmdSZXF1aXJlbWVudHMo UmVuZGVyTGF5ZXIqIGxheWVyLCBPCiAgICAgICAgIH0KICAgICB9CiAgICAgCi0gICAgLy8gSWYg d2UganVzdCBlbnRlcmVkIGNvbXBvc2l0aW5nIG1vZGUsIHRoZSByb290IHdpbGwgaGF2ZSBiZWNv bWUgY29tcG9zaXRlZC4KLSAgICBpZiAobGF5ZXItPmlzUm9vdExheWVyKCkgJiYgaW5Db21wb3Np dGluZ01vZGUoKSkKLSAgICAgICAgd2lsbEJlQ29tcG9zaXRlZCA9IHRydWU7CisgICAgLy8gSWYg d2UganVzdCBlbnRlcmVkIGNvbXBvc2l0aW5nIG1vZGUsIHRoZSByb290IHdpbGwgaGF2ZSBiZWNv bWUgY29tcG9zaXRlZCAoYXMgbG9uZyBhcyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBpcyBlbmFi bGVkKS4KKyAgICBpZiAobGF5ZXItPmlzUm9vdExheWVyKCkpIHsKKyAgICAgICAgaWYgKGluQ29t cG9zaXRpbmdNb2RlKCkgJiYgbV9oYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nKQorICAgICAgICAg ICAgd2lsbEJlQ29tcG9zaXRlZCA9IHRydWU7CisgICAgfQogICAgIAogICAgIEFTU0VSVCh3aWxs QmVDb21wb3NpdGVkID09IG5lZWRzVG9CZUNvbXBvc2l0ZWQobGF5ZXIpKTsKIAo=