42406 2010-07-15 14:13:07 -0700 minor fixes to sunspider to simplify automation 2010-10-13 14:14:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 slewis slewis commit-queue eric slewis oldest_to_newest 252099 0 61717 slewis 2010-07-15 14:13:07 -0700 Created attachment 61717 patch A couple of minor fixes to SunSpider to simplify running in automated test harness. 252101 1 61718 slewis 2010-07-15 14:15:22 -0700 Created attachment 61718 patch include bug number in Changelogs 252109 2 61718 ggaren 2010-07-15 14:26:49 -0700 Comment on attachment 61718 patch r=me 263016 3 61718 abarth 2010-08-10 22:33:26 -0700 Comment on attachment 61718 patch Shall we land this patch? 263173 4 61718 commit-queue 2010-08-11 04:26:10 -0700 Comment on attachment 61718 patch Rejecting patch 61718 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Geoffrey Garen', u'--force']" exit_code: 1 Last 500 characters of output: patching file SunSpider/sunspider Hunk #1 succeeded at 231 with fuzz 2 (offset 2 lines). patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/sunspider-compare-results Hunk #1 FAILED at 55. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/sunspider-compare-results.rej patching file WebKitTools/Scripts/webkitdirs.pm Hunk #1 FAILED at 258. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitdirs.pm.rej Full output: http://queues.webkit.org/results/3717049 293605 5 eric 2010-10-13 12:26:43 -0700 Attachment 61718 was posted by a committer and has review+, assigning to Stephanie Lewis for commit. 293704 6 slewis 2010-10-13 14:14:29 -0700 oops, I forgot to close this bug. Sorry! Landed in http://trac.webkit.org/projects/webkit/changeset/63463 61717 2010-07-15 14:13:07 -0700 2010-07-15 14:15:22 -0700 patch sunspider.patch text/plain 2810 slewis SW5kZXg6IFN1blNwaWRlci9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU3VuU3BpZGVyL0NoYW5n ZUxvZwkocmV2aXNpb24gNjM0NTIpCisrKyBTdW5TcGlkZXIvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMDctMTMgIFN0ZXBoYW5pZSBMZXdpcyAgPHNsZXdp c0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgT3V0cHV0IGxvY2F0aW9uIG9mIHJlc3VsdHMgZmlsZS4KKworICAgICAgICAqIHN1bnNw aWRlcjoKKwogMjAxMC0wNS0xNyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IFN1blNwaWRlci9zdW5zcGlk ZXIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU3VuU3BpZGVyL3N1bnNwaWRlcgkocmV2aXNpb24gNjM0NTIpCisr KyBTdW5TcGlkZXIvc3Vuc3BpZGVyCSh3b3JraW5nIGNvcHkpCkBAIC0yMjksNiArMjI5LDggQEAg ZHVtcFRvRmlsZShGaWxlOjpTcGVjLT5yZWwyYWJzKCRyZXN1bHRzRgogCiBzeXN0ZW0oIiRqc1No ZWxsUGF0aCIsICItZiIsICRwcmVmaXhGaWxlLCAiLWYiLCAkcmVzdWx0c0ZpbGUsICItZiIsICJy ZXNvdXJjZXMvc3Vuc3BpZGVyLWFuYWx5emUtcmVzdWx0cy5qcyIpOwogCitwcmludCgiXG5SZXN1 bHRzIGFyZSBsb2NhdGVkIGF0ICRyZXN1bHRzRmlsZVxuIik7CisKIGlmICgkcnVuU2hhcmspIHsK ICAgICBteSAkbmV3ZXN0TVNoYXJrID0gbmV3ZXN0RmlsZSgiLiIsIHFyL1wubXNoYXJrJC8pOwog ICAgIGlmICgkbmV3ZXN0TVNoYXJrKSB7CkluZGV4OiBXZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzQ1MikKKysrIFdl YktpdFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEw LTA3LTE1ICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgU3VuU3BpZGVyIHdvcmsg YmV0dGVyIHdpdGggcm9vdHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3N1bnNwaWRlci1jb21wYXJl LXJlc3VsdHM6IGZpeCBhcmd1bWVudCBidWcKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMu cG06IGxvb2sgaW5zaWRlIEphdmFTY3JpcHRDb3JlIGlmIGpzYyBpc24ndCB0b3AtbGV2ZWwuCisK IDIwMTAtMDctMTUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9zdW5zcGlk ZXItY29tcGFyZS1yZXN1bHRzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvc3Vu c3BpZGVyLWNvbXBhcmUtcmVzdWx0cwkocmV2aXNpb24gNjM0NTIpCisrKyBXZWJLaXRUb29scy9T Y3JpcHRzL3N1bnNwaWRlci1jb21wYXJlLXJlc3VsdHMJKHdvcmtpbmcgY29weSkKQEAgLTU1LDcg KzU1LDcgQEAgVXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gRklMRSBGSUxFCiAgIC0tcGFy c2Utb25seSAgICAgIFVzZSB0aGUgcGFyc2Utb25seSBiZW5jaG1hcmsgc3VpdGUuIFNhbWUgYXMg LS1zdWl0ZT1wYXJzZS1vbmx5CiBFT0YKIAotR2V0T3B0aW9ucygncm9vdD1zJyA9PiBzdWIgeyBt eSAoJGFyZ05hbWUsICR2YWx1ZSk7IHNldENvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyKEN3ZDo6YWJz X3BhdGgoJHZhbHVlKSk7IH0sCitHZXRPcHRpb25zKCdyb290PXMnID0+IHN1YiB7IG15ICgkYXJn TmFtZSwgJHZhbHVlKSA9IEBfOyBzZXRDb25maWd1cmF0aW9uUHJvZHVjdERpcihDd2Q6OmFic19w YXRoKCR2YWx1ZSkpOyB9LAogICAgICAgICAgICAnc3VpdGU9cycgPT4gXCRzdWl0ZSwKICAgICAg ICAgICAgJ3ViZW5jaCcgPT4gXCR1YmVuY2gsCiAgICAgICAgICAgICd2OCcgPT4gXCR2OCwKSW5k ZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDYzNDUyKQorKysgV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yNTgsNyArMjU4 LDggQEAgc3ViIGpzY1BhdGgoJCkKICAgICBteSAoJHByb2R1Y3REaXIpID0gQF87CiAgICAgbXkg JGpzY05hbWUgPSAianNjIjsKICAgICAkanNjTmFtZSAuPSAiX2RlYnVnIiAgaWYgKGlzQ3lnd2lu KCkgJiYgKCRjb25maWd1cmF0aW9uIGVxICJEZWJ1ZyIpKTsKLSAgICByZXR1cm4gIiRwcm9kdWN0 RGlyLyRqc2NOYW1lIjsKKyAgICByZXR1cm4gIiRwcm9kdWN0RGlyLyRqc2NOYW1lIiBpZiAtZSAi JHByb2R1Y3REaXIvJGpzY05hbWUiOworICAgIHJldHVybiAiJHByb2R1Y3REaXIvSmF2YVNjcmlw dENvcmUuZnJhbWV3b3JrL1Jlc291cmNlcy8kanNjTmFtZSI7CiB9CiAKIHN1YiBhcmd1bWVudHNG b3JDb25maWd1cmF0aW9uKCk= 61718 2010-07-15 14:15:22 -0700 2010-08-11 04:26:10 -0700 patch sunspider.patch text/plain 2921 slewis SW5kZXg6IFN1blNwaWRlci9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU3VuU3BpZGVyL0NoYW5n ZUxvZwkocmV2aXNpb24gNjM0NTIpCisrKyBTdW5TcGlkZXIvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMTUgIFN0ZXBoYW5pZSBMZXdpcyAgPHNsZXdp c0BhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQyNDA2CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE91dHB1dCBsb2NhdGlvbiBvZiByZXN1bHRzIGZpbGUuCisKKyAgICAgICAgKiBzdW5zcGlk ZXI6CisKIDIwMTAtMDUtMTcgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBTdW5TcGlkZXIvc3Vuc3BpZGVy Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFN1blNwaWRlci9zdW5zcGlkZXIJKHJldmlzaW9uIDYzNDUyKQorKysg U3VuU3BpZGVyL3N1bnNwaWRlcgkod29ya2luZyBjb3B5KQpAQCAtMjI5LDYgKzIyOSw4IEBAIGR1 bXBUb0ZpbGUoRmlsZTo6U3BlYy0+cmVsMmFicygkcmVzdWx0c0YKIAogc3lzdGVtKCIkanNTaGVs bFBhdGgiLCAiLWYiLCAkcHJlZml4RmlsZSwgIi1mIiwgJHJlc3VsdHNGaWxlLCAiLWYiLCAicmVz b3VyY2VzL3N1bnNwaWRlci1hbmFseXplLXJlc3VsdHMuanMiKTsKIAorcHJpbnQoIlxuUmVzdWx0 cyBhcmUgbG9jYXRlZCBhdCAkcmVzdWx0c0ZpbGVcbiIpOworCiBpZiAoJHJ1blNoYXJrKSB7CiAg ICAgbXkgJG5ld2VzdE1TaGFyayA9IG5ld2VzdEZpbGUoIi4iLCBxci9cLm1zaGFyayQvKTsKICAg ICBpZiAoJG5ld2VzdE1TaGFyaykgewpJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNjM0NTIpCisrKyBXZWJL aXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0w Ny0xNSAgU3RlcGhhbmllIExld2lzICA8c2xld2lzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDI0MDYKKyAgICAgICAgTWFrZSBTdW5TcGlkZXIgd29yayBiZXR0 ZXIgd2l0aCByb290cy4KKworICAgICAgICAqIFNjcmlwdHMvc3Vuc3BpZGVyLWNvbXBhcmUtcmVz dWx0czogZml4IGFyZ3VtZW50IGJ1ZworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTog bG9vayBpbnNpZGUgSmF2YVNjcmlwdENvcmUgaWYganNjIGlzbid0IHRvcC1sZXZlbC4KKwogMjAx MC0wNy0xNSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3N1bnNwaWRlci1j b21wYXJlLXJlc3VsdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9zdW5zcGlk ZXItY29tcGFyZS1yZXN1bHRzCShyZXZpc2lvbiA2MzQ1MikKKysrIFdlYktpdFRvb2xzL1Njcmlw dHMvc3Vuc3BpZGVyLWNvbXBhcmUtcmVzdWx0cwkod29ya2luZyBjb3B5KQpAQCAtNTUsNyArNTUs NyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBGSUxFIEZJTEUKICAgLS1wYXJzZS1v bmx5ICAgICAgVXNlIHRoZSBwYXJzZS1vbmx5IGJlbmNobWFyayBzdWl0ZS4gU2FtZSBhcyAtLXN1 aXRlPXBhcnNlLW9ubHkKIEVPRgogCi1HZXRPcHRpb25zKCdyb290PXMnID0+IHN1YiB7IG15ICgk YXJnTmFtZSwgJHZhbHVlKTsgc2V0Q29uZmlndXJhdGlvblByb2R1Y3REaXIoQ3dkOjphYnNfcGF0 aCgkdmFsdWUpKTsgfSwKK0dldE9wdGlvbnMoJ3Jvb3Q9cycgPT4gc3ViIHsgbXkgKCRhcmdOYW1l LCAkdmFsdWUpID0gQF87IHNldENvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyKEN3ZDo6YWJzX3BhdGgo JHZhbHVlKSk7IH0sCiAgICAgICAgICAgICdzdWl0ZT1zJyA9PiBcJHN1aXRlLAogICAgICAgICAg ICAndWJlbmNoJyA9PiBcJHViZW5jaCwKICAgICAgICAgICAgJ3Y4JyA9PiBcJHY4LApJbmRleDog V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gNjM0NTIpCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTI1OCw3ICsyNTgsOCBA QCBzdWIganNjUGF0aCgkKQogICAgIG15ICgkcHJvZHVjdERpcikgPSBAXzsKICAgICBteSAkanNj TmFtZSA9ICJqc2MiOwogICAgICRqc2NOYW1lIC49ICJfZGVidWciICBpZiAoaXNDeWd3aW4oKSAm JiAoJGNvbmZpZ3VyYXRpb24gZXEgIkRlYnVnIikpOwotICAgIHJldHVybiAiJHByb2R1Y3REaXIv JGpzY05hbWUiOworICAgIHJldHVybiAiJHByb2R1Y3REaXIvJGpzY05hbWUiIGlmIC1lICIkcHJv ZHVjdERpci8kanNjTmFtZSI7CisgICAgcmV0dXJuICIkcHJvZHVjdERpci9KYXZhU2NyaXB0Q29y ZS5mcmFtZXdvcmsvUmVzb3VyY2VzLyRqc2NOYW1lIjsKIH0KIAogc3ViIGFyZ3VtZW50c0ZvckNv bmZpZ3VyYXRpb24oKQo=