42401 2010-07-15 13:47:59 -0700 Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL 2010-07-15 14:05:50 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr cmarrin dglazkov fishd japhet oliver zmo oldest_to_newest 252081 0 kbr 2010-07-15 13:47:59 -0700 The query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by the WebGL implementation rather than delegating to the underlying OpenGL API, because WebGL 1.0 does not support compressed textures and must return 0 for this query. 252086 1 61715 kbr 2010-07-15 13:55:40 -0700 Created attachment 61715 Patch 252093 2 61715 japhet 2010-07-15 14:02:23 -0700 Comment on attachment 61715 Patch Per offline conversation, please add a comment explaining why we're hard-coding a 0 before submitting. > case GraphicsContext3D::NUM_COMPRESSED_TEXTURE_FORMATS: > - return getLongParameter(pname); > + return WebGLGetInfo(static_cast<long>(0)); 252094 3 kbr 2010-07-15 14:05:50 -0700 Committed r63460: <http://trac.webkit.org/changeset/63460> 61715 2010-07-15 13:55:40 -0700 2010-07-15 14:02:23 -0700 Patch compressed-texture-formats.patch text/plain 2866 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzQ1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMTUgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFF1 ZXJ5IG9mIE5VTV9DT01QUkVTU0VEX1RFWFRVUkVfRk9STUFUUyBtdXN0IGJlIGhhbmRsZWQgYnkg V2ViR0wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQy NDAxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBjb3ZlcmVkIGJ5IGdsLWdldC1jYWxscy5odG1s LgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0UGFyYW1ldGVyKToKKyAg ICAgICAgIC0gUmV0dXJuIDAgZm9yIGdldFBhcmFtZXRlcihOVU1fQ09NUFJFU1NFRF9URVhUVVJF X0ZPUk1BVFMpLgorCiAyMDEwLTA3LTA3ICBKb2huIEdyZWdnICA8am9obm55Z0Bnb29nbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEppYW4gTGkuCkluZGV4OiBXZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA2MzQ0MykKKysrIFdl YkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTM5MCw3ICsxMzkwLDcgQEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4 dDo6Z2V0UAogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6Ok1BWF9WSUVXUE9SVF9ESU1TOgog ICAgICAgICByZXR1cm4gZ2V0V2ViR0xJbnRBcnJheVBhcmFtZXRlcihwbmFtZSk7CiAgICAgY2Fz ZSBHcmFwaGljc0NvbnRleHQzRDo6TlVNX0NPTVBSRVNTRURfVEVYVFVSRV9GT1JNQVRTOgotICAg ICAgICByZXR1cm4gZ2V0TG9uZ1BhcmFtZXRlcihwbmFtZSk7CisgICAgICAgIHJldHVybiBXZWJH TEdldEluZm8oc3RhdGljX2Nhc3Q8bG9uZz4oMCkpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0 M0Q6Ok5VTV9TSEFERVJfQklOQVJZX0ZPUk1BVFM6CiAgICAgICAgIC8vIEZJWE1FOiBzaG91bGQg d2UgYWx3YXlzIHJldHVybiAwIGZvciB0aGlzPwogICAgICAgICByZXR1cm4gZ2V0TG9uZ1BhcmFt ZXRlcihwbmFtZSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzQ1NykKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA3LTE1ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBRdWVyeSBvZiBOVU1fQ09NUFJFU1NFRF9URVhUVVJFX0ZP Uk1BVFMgbXVzdCBiZSBoYW5kbGVkIGJ5IFdlYkdMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQwMQorCisgICAgICAgICogZmFzdC9jYW52YXMvd2Vi Z2wvZ2wtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4dDoKKwogMjAxMC0wNy0wNyAgSm9obiBHcmVnZyAg PGpvaG5ueWdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKaWFuIExpLgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2Fs bHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA2MzQ0NCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2Fu dmFzL3dlYmdsL2dsLWdldC1jYWxscy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTcw LDcgKzcwLDcgQEAgUEFTUyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlZJRVdQTwogUEFT UyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0Lk1BWF9GUkFHTUVOVF9VTklGT1JNX1ZFQ1RP UlMpID49IDE2IGlzIHRydWUKIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5NQVhf VkVSVEVYX1VOSUZPUk1fVkVDVE9SUykgPj0gMTI4IGlzIHRydWUKIFBBU1MgY29udGV4dC5nZXRQ YXJhbWV0ZXIoY29udGV4dC5NQVhfVkFSWUlOR19WRUNUT1JTKSA+PSA4IGlzIHRydWUKLUZBSUwg Y29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5OVU1fQ09NUFJFU1NFRF9URVhUVVJFX0ZPUk1B VFMpIHNob3VsZCBiZSAwLiBXYXMgNC4KK1BBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4 dC5OVU1fQ09NUFJFU1NFRF9URVhUVVJFX0ZPUk1BVFMpIGlzIDAKIEZBSUwgY29udGV4dC5nZXRQ YXJhbWV0ZXIoY29udGV4dC5TSEFERVJfQ09NUElMRVIpIHNob3VsZCBiZSB0cnVlIChvZiB0eXBl IGJvb2xlYW4pLiBXYXMgbnVsbCAob2YgdHlwZSBvYmplY3QpLgogCiBQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCg==