42392 2010-07-15 12:10:57 -0700 [Qt] Replace qMemCopy() usage with memcpy() 2010-07-19 08:06:09 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P3 Enhancement --- 1 viroteck webkit-qt-unassigned commit-queue kling oldest_to_newest 252032 0 61700 viroteck 2010-07-15 12:10:57 -0700 Created attachment 61700 patch replacing qMemCopy -> memcpy Usage of memcpy() directly allows compilers to optimise more. qMemCopy() exists to allow usage in headers. See related Qt merge request at: http://qt.gitorious.org/qt/qt/merge_requests/2430 Patch attach. 252437 1 kling 2010-07-16 03:19:04 -0700 Hi Robin! Your patch needs a ChangeLog entry, see this page for more information: https://trac.webkit.org/wiki/QtWebKitContrib 252470 2 61797 viroteck 2010-07-16 06:15:33 -0700 Created attachment 61797 Same as v1, with ChangeLog entry. Fixed. Sorry about that. ;) 252476 3 61797 kling 2010-07-16 06:26:45 -0700 Comment on attachment 61797 Same as v1, with ChangeLog entry. >WebCore/ChangeLog:7 > + Missing a description of this change and why it's needed. :) 252477 4 61797 tonikitoo 2010-07-16 06:28:27 -0700 Comment on attachment 61797 Same as v1, with ChangeLog entry. > +2010-07-16 Robin Burchell <robin.burchell@collabora.co.uk> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Use memcpy() instead of qMemCopy() > + See: https://bugs.webkit.org/show_bug.cgi?id=42392 Robin, please explain in the change log why changing it make sense. When uploading a new patch, please fill "Reviewed by" with "Antonio Gomes" and you wont need to get it re-reviewed. Just set "cq?" 253181 5 61946 viroteck 2010-07-19 07:20:42 -0700 Created attachment 61946 v3, with added details (again) in ChangeLog Fixed ChangeLog info. 253211 6 61946 commit-queue 2010-07-19 08:06:04 -0700 Comment on attachment 61946 v3, with added details (again) in ChangeLog Clearing flags on attachment: 61946 Committed r63660: <http://trac.webkit.org/changeset/63660> 253212 7 commit-queue 2010-07-19 08:06:09 -0700 All reviewed patches have been landed. Closing bug. 61700 2010-07-15 12:10:57 -0700 2010-07-19 07:20:42 -0700 patch replacing qMemCopy -> memcpy 0001-Use-memcpy-instead-of-qMemCopy.patch text/plain 1183 viroteck RnJvbSAzNTlmZTY2ZWE4YmVlNmU2YmU5MGE0N2Y1ZTU5NmNmNzVkZThjMjQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JpbiBCdXJjaGVsbCA8cm9iaW4uYnVyY2hlbGxAY29sbGFi b3JhLmNvLnVrPgpEYXRlOiBUaHUsIDE1IEp1bCAyMDEwIDIwOjA2OjM3ICswMTAwClN1YmplY3Q6 IFtQQVRDSF0gVXNlIG1lbWNweSgpIGluc3RlYWQgb2YgcU1lbUNvcHkoKS4KClVzaW5nIG1lbWNw eSgpIGRpcmVjdGx5IGFsbG93cyB0aGUgY29tcGlsZXIgdG8gb3B0aW1pc2UgbW9yZS4KLS0tCiBX ZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcCB8ICAgIDIgKy0KIDEgZmlsZXMgY2hhbmdl ZCwgMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwIGIvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5j cHAKaW5kZXggNzdhNjcxNi4uY2ZhYjNhMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9icmlkZ2UvcXQv cXRfcnVudGltZS5jcHAKKysrIGIvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAKQEAg LTg2OSw3ICs4NjksNyBAQCBKU1ZhbHVlIGNvbnZlcnRRVmFyaWFudFRvVmFsdWUoRXhlY1N0YXRl KiBleGVjLCBQYXNzUmVmUHRyPFJvb3RPYmplY3Q+IHJvb3QsIGNvbgogICAgIGlmICh0eXBlID09 IFFNZXRhVHlwZTo6UUJ5dGVBcnJheSkgewogICAgICAgICBRQnl0ZUFycmF5IHF0Qnl0ZUFycmF5 ID0gdmFyaWFudC52YWx1ZTxRQnl0ZUFycmF5PigpOwogICAgICAgICBXVEY6OlJlZlB0cjxXVEY6 OkJ5dGVBcnJheT4gd3RmQnl0ZUFycmF5ID0gV1RGOjpCeXRlQXJyYXk6OmNyZWF0ZShxdEJ5dGVB cnJheS5sZW5ndGgoKSk7Ci0gICAgICAgIHFNZW1Db3B5KHd0ZkJ5dGVBcnJheS0+ZGF0YSgpLCBx dEJ5dGVBcnJheS5jb25zdERhdGEoKSwgcXRCeXRlQXJyYXkubGVuZ3RoKCkpOworICAgICAgICBt ZW1jcHkod3RmQnl0ZUFycmF5LT5kYXRhKCksIHF0Qnl0ZUFycmF5LmNvbnN0RGF0YSgpLCBxdEJ5 dGVBcnJheS5sZW5ndGgoKSk7CiAgICAgICAgIHJldHVybiBuZXcgKGV4ZWMpIEpTQzo6SlNCeXRl QXJyYXkoZXhlYywgSlNDOjpKU0J5dGVBcnJheTo6Y3JlYXRlU3RydWN0dXJlKGpzTnVsbCgpKSwg d3RmQnl0ZUFycmF5LmdldCgpKTsKICAgICB9CiAKLS0gCjEuNy4wLjQKCg== 61797 2010-07-16 06:15:33 -0700 2010-07-19 07:20:42 -0700 Same as v1, with ChangeLog entry. 0001-Use-memcpy-instead-of-qMemCopy.patch text/plain 1352 viroteck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmJmYzNiNC4uMDQwMDU1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xNiAgUm9iaW4gQnVyY2hl bGwgIDxyb2Jpbi5idXJjaGVsbEBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBVc2UgbWVtY3B5KCkgaW5zdGVhZCBv ZiBxTWVtQ29weSgpCisgICAgICAgIFNlZTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQyMzkyCisKKyAgICAgICAgKiBicmlkZ2UvcXQvcXRfcnVudGltZS5jcHA6Cisg ICAgICAgIChKU0M6OkJpbmRpbmdzOjpjb252ZXJ0UVZhcmlhbnRUb1ZhbHVlKToKKwogMjAxMC0w Ny0xNSAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAg IFJ1YmJlci1zdGFtcGVkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAgYi9XZWJDb3JlL2JyaWRnZS9xdC9x dF9ydW50aW1lLmNwcAppbmRleCA3N2E2NzE2Li5jZmFiM2EyIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcAorKysgYi9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50 aW1lLmNwcApAQCAtODY5LDcgKzg2OSw3IEBAIEpTVmFsdWUgY29udmVydFFWYXJpYW50VG9WYWx1 ZShFeGVjU3RhdGUqIGV4ZWMsIFBhc3NSZWZQdHI8Um9vdE9iamVjdD4gcm9vdCwgY29uCiAgICAg aWYgKHR5cGUgPT0gUU1ldGFUeXBlOjpRQnl0ZUFycmF5KSB7CiAgICAgICAgIFFCeXRlQXJyYXkg cXRCeXRlQXJyYXkgPSB2YXJpYW50LnZhbHVlPFFCeXRlQXJyYXk+KCk7CiAgICAgICAgIFdURjo6 UmVmUHRyPFdURjo6Qnl0ZUFycmF5PiB3dGZCeXRlQXJyYXkgPSBXVEY6OkJ5dGVBcnJheTo6Y3Jl YXRlKHF0Qnl0ZUFycmF5Lmxlbmd0aCgpKTsKLSAgICAgICAgcU1lbUNvcHkod3RmQnl0ZUFycmF5 LT5kYXRhKCksIHF0Qnl0ZUFycmF5LmNvbnN0RGF0YSgpLCBxdEJ5dGVBcnJheS5sZW5ndGgoKSk7 CisgICAgICAgIG1lbWNweSh3dGZCeXRlQXJyYXktPmRhdGEoKSwgcXRCeXRlQXJyYXkuY29uc3RE YXRhKCksIHF0Qnl0ZUFycmF5Lmxlbmd0aCgpKTsKICAgICAgICAgcmV0dXJuIG5ldyAoZXhlYykg SlNDOjpKU0J5dGVBcnJheShleGVjLCBKU0M6OkpTQnl0ZUFycmF5OjpjcmVhdGVTdHJ1Y3R1cmUo anNOdWxsKCkpLCB3dGZCeXRlQXJyYXkuZ2V0KCkpOwogICAgIH0KIAo= 61946 2010-07-19 07:20:42 -0700 2010-07-19 08:06:04 -0700 v3, with added details (again) in ChangeLog loldiff text/plain 1590 viroteck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmJmYzNiNC4uOTFjY2VkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNy0xNiAgUm9iaW4gQnVyY2hl bGwgIDxyb2Jpbi5idXJjaGVsbEBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgQW50b25pbyBHb21lcworCisgICAgICAgIFtRdF0gVXNlIG1lbWNweSgpIGluc3RlYWQgb2Yg cU1lbUNvcHkoKQorICAgICAgICBUaGlzIGlzIHN1cHBvc2VkIHRvIGJlIG1vcmUgZWZmaWNpZW50 LCBhcyB0aGUgY29tcGlsZXIgaXMgYWJsZSB0bworICAgICAgICBvcHRpbWlzZSBtb3JlLgorCisg ICAgICAgIEFkZGl0aW9uYWxseSwgIHFNZW1Db3B5KCkgaXMgb25seSBzdHJpY3RseSBzdXBwb3Nl ZCB0byBiZSB1c2VkIGluCisgICAgICAgIGhlYWRlcnMgKHNlZSBRdCdzIHNyYy9jb3JlbGliL3Fn bG9iYWwuaCBmb3IgcmVmZXJlbmNlKQorICAgICAgICBTZWU6IGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjM5MgorCisgICAgICAgICogYnJpZGdlL3F0L3F0X3J1bnRp bWUuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6Y29udmVydFFWYXJpYW50VG9WYWx1ZSk6 CisKIDIwMTAtMDctMTUgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4K IAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwIGIvV2ViQ29yZS9i cmlkZ2UvcXQvcXRfcnVudGltZS5jcHAKaW5kZXggNzdhNjcxNi4uY2ZhYjNhMiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAKKysrIGIvV2ViQ29yZS9icmlkZ2Uv cXQvcXRfcnVudGltZS5jcHAKQEAgLTg2OSw3ICs4NjksNyBAQCBKU1ZhbHVlIGNvbnZlcnRRVmFy aWFudFRvVmFsdWUoRXhlY1N0YXRlKiBleGVjLCBQYXNzUmVmUHRyPFJvb3RPYmplY3Q+IHJvb3Qs IGNvbgogICAgIGlmICh0eXBlID09IFFNZXRhVHlwZTo6UUJ5dGVBcnJheSkgewogICAgICAgICBR Qnl0ZUFycmF5IHF0Qnl0ZUFycmF5ID0gdmFyaWFudC52YWx1ZTxRQnl0ZUFycmF5PigpOwogICAg ICAgICBXVEY6OlJlZlB0cjxXVEY6OkJ5dGVBcnJheT4gd3RmQnl0ZUFycmF5ID0gV1RGOjpCeXRl QXJyYXk6OmNyZWF0ZShxdEJ5dGVBcnJheS5sZW5ndGgoKSk7Ci0gICAgICAgIHFNZW1Db3B5KHd0 ZkJ5dGVBcnJheS0+ZGF0YSgpLCBxdEJ5dGVBcnJheS5jb25zdERhdGEoKSwgcXRCeXRlQXJyYXku bGVuZ3RoKCkpOworICAgICAgICBtZW1jcHkod3RmQnl0ZUFycmF5LT5kYXRhKCksIHF0Qnl0ZUFy cmF5LmNvbnN0RGF0YSgpLCBxdEJ5dGVBcnJheS5sZW5ndGgoKSk7CiAgICAgICAgIHJldHVybiBu ZXcgKGV4ZWMpIEpTQzo6SlNCeXRlQXJyYXkoZXhlYywgSlNDOjpKU0J5dGVBcnJheTo6Y3JlYXRl U3RydWN0dXJlKGpzTnVsbCgpKSwgd3RmQnl0ZUFycmF5LmdldCgpKTsKICAgICB9CiAK