<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>42386</bug_id>
          
          <creation_ts>2010-07-15 10:07:43 -0700</creation_ts>
          <short_desc>[Chromium] Rolls Chromium DEPS forward to 52483.</short_desc>
          <delta_ts>2010-07-15 17:11:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>42412</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Victor Wang">victorw</reporter>
          <assigned_to name="Victor Wang">victorw</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>fishd</cc>
    
    <cc>levin</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>251961</commentid>
    <comment_count>0</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-07-15 10:07:43 -0700</bug_when>
    <thetext>Rolls Chromium DEPS forward to 52483 to land patch for chromium multi-dll build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>251962</commentid>
    <comment_count>1</comment_count>
      <attachid>61682</attachid>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-07-15 10:12:54 -0700</bug_when>
    <thetext>Created attachment 61682
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>251967</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-07-15 10:17:33 -0700</bug_when>
    <thetext>Since something similar just failed yesterday, wait to r+ this until the cr-linux build turns green. (Otherwise the EWS won&apos;t run on it.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>251970</commentid>
    <comment_count>3</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-07-15 10:22:02 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Since something similar just failed yesterday, wait to r+ this until the cr-linux build turns green. (Otherwise the EWS won&apos;t run on it.)

Sure, but I would also like to land it manually as soon as the cr-linux becomes green. My patch yesterday did pass cr-linux bot, however it was landed many hours late and at the time it was landed by the commit queue, cr-linux breaks due to other changes in webkit and chromium.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>251972</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-07-15 10:24:19 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; Since something similar just failed yesterday, wait to r+ this until the cr-linux build turns green. (Otherwise the EWS won&apos;t run on it.)
&gt; 
&gt; Sure, but I would also like to land it manually as soon as the cr-linux becomes green. My patch yesterday did pass cr-linux bot, however it was landed many hours late and at the time it was landed by the commit queue, cr-linux breaks due to other changes in webkit and chromium.

Best not to wait for the commit queue to land it then :).

r=me as soon as cr-linux turns green (so you can land it manually and fill in my name).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>252039</commentid>
    <comment_count>5</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-07-15 12:40:54 -0700</bug_when>
    <thetext>Committed r63446: &lt;http://trac.webkit.org/changeset/63446&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>252142</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-07-15 14:58:06 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/63446 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63446
http://trac.webkit.org/changeset/63447</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>252201</commentid>
    <comment_count>7</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-07-15 16:16:56 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; http://trac.webkit.org/changeset/63446 might have broken Chromium Win Release
&gt; The following changes are on the blame list:
&gt; http://trac.webkit.org/changeset/63446
&gt; http://trac.webkit.org/changeset/63447

This is caused by chromium win bot does not have dx10+ sdk installed. jamesr just installed it and I will land the patch again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>252225</commentid>
    <comment_count>8</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-07-15 16:51:30 -0700</bug_when>
    <thetext>Committed r63495: &lt;http://trac.webkit.org/changeset/63495&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>252235</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-07-15 17:11:09 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/63495 might have broken GTK Linux 32-bit Release and Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63494
http://trac.webkit.org/changeset/63495</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>61682</attachid>
            <date>2010-07-15 10:12:54 -0700</date>
            <delta_ts>2010-07-15 12:20:16 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>chromium_deps.patch</filename>
            <type>text/plain</type>
            <size>855</size>
            <attacher name="Victor Wang">victorw</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjM0MzYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMTUgIFZpY3Rv
ciBXYW5nICA8dmljdG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgUm9sbCBDaHJvbWl1bSBERVBTIGZvcndhcmQgdG8gcjUy
NDgzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIz
ODYKKworICAgICAgICAqIERFUFM6CisKIDIwMTAtMDctMTUgIFBhdmVsIEZlbGRtYW4gIDxwZmVs
ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNr
eS4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9ERVBTCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJv
bWl1bS9ERVBTCShyZXZpc2lvbiA2MzQyOSkKKysrIFdlYktpdC9jaHJvbWl1bS9ERVBTCSh3b3Jr
aW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4n
OiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9y
ZXYnOiAnNTE3MzYnLAorICAnY2hyb21pdW1fcmV2JzogJzUyNDgzJywKIH0KIAogZGVwcyA9IHsK
</data>
<flag name="review"
          id="49748"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>