42385 2010-07-15 09:57:33 -0700 [chromium] WebViewClient::removeAutofillSuggestions is not passed the correct name 2010-07-15 16:31:35 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 sky sky commit-queue dhollowa oldest_to_newest 251954 0 sky 2010-07-15 09:57:33 -0700 removeAutofillSuggestions is not always passed the correct name of the entry to remove. 251958 1 61681 sky 2010-07-15 10:01:10 -0700 Created attachment 61681 Initial fix 251969 2 dhollowa 2010-07-15 10:20:38 -0700 LGTM. One small style question. Might it be slightly cleaner to dispense with the temporary variable? I.e.: WebInputElement(static_cast<HTMLInputElement*>(element)).nameForAutofill(); 251977 3 61684 sky 2010-07-15 10:31:43 -0700 Created attachment 61684 Incorporates review feedback 251983 4 dhollowa 2010-07-15 10:39:34 -0700 SLGTM. 252207 5 61684 commit-queue 2010-07-15 16:31:28 -0700 Comment on attachment 61684 Incorporates review feedback Clearing flags on attachment: 61684 Committed r63489: <http://trac.webkit.org/changeset/63489> 252208 6 commit-queue 2010-07-15 16:31:35 -0700 All reviewed patches have been landed. Closing bug. 61681 2010-07-15 10:01:10 -0700 2010-07-15 10:31:43 -0700 Initial fix webkit.patch text/plain 1630 sky SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjM0MzUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMTUgIFNjb3R0 IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBXZWJWaWV3Q2xpZW50OjpyZW1vdmVBdXRv ZmlsbFN1Z2dlc3Rpb25zIGlzIG5vdCBwYXNzZWQgdGhlIGNvcnJlY3QgbmFtZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIzODUKKworICAgICAgICAq IHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjphdXRv Y29tcGxldGVIYW5kbGVLZXlFdmVudCk6IFVzZSBXZWJJbnB1dEVsZW1lbnQ6Om5hbWVGb3JBdXRv ZmlsbCgpIGluc3RlYWQgb2YgbmFtZS4KKwogMjAxMC0wNy0xNSAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0 c2t5LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDYzNDI5 KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTk0LDYgKzk0LDcgQEAKICNpbmNsdWRlICJXZWJEcmFnRGF0YS5oIgogI2luY2x1ZGUgIldl YkZyYW1lSW1wbC5oIgogI2luY2x1ZGUgIldlYkltYWdlLmgiCisjaW5jbHVkZSAiV2ViSW5wdXRF bGVtZW50LmgiCiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudC5oIgogI2luY2x1ZGUgIldlYklucHV0 RXZlbnRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAiV2ViS2l0LmgiCkBAIC01OTcsNyArNTk4LDcg QEAgYm9vbCBXZWJWaWV3SW1wbDo6YXV0b2NvbXBsZXRlSGFuZGxlS2V5RQogICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogCiAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0RWxlbWVudCA9 IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihlbGVtZW50KTsKLSAgICAgICAgV2ViU3Ry aW5nIG5hbWUgPSBpbnB1dEVsZW1lbnQtPm5hbWUoKTsKKyAgICAgICAgV2ViU3RyaW5nIG5hbWUg PSBXZWJJbnB1dEVsZW1lbnQoaW5wdXRFbGVtZW50KS5uYW1lRm9yQXV0b2ZpbGwoKTsKICAgICAg ICAgV2ViU3RyaW5nIHZhbHVlID0gbV9hdXRvRmlsbFBvcHVwQ2xpZW50LT5pdGVtVGV4dChzZWxl Y3RlZEluZGV4KTsKICAgICAgICAgbV9jbGllbnQtPnJlbW92ZUF1dG9maWxsU3VnZ2VzdGlvbnMo bmFtZSwgdmFsdWUpOwogICAgICAgICAvLyBVcGRhdGUgdGhlIGVudHJpZXMgaW4gdGhlIGN1cnJl bnRseSBzaG93aW5nIHBvcHVwIHRvIHJlZmxlY3QgdGhlCg== 61684 2010-07-15 10:31:43 -0700 2010-07-15 16:31:28 -0700 Incorporates review feedback webkit.patch text/plain 1737 sky SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjM0MzUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMTUgIFNjb3R0 IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBXZWJWaWV3Q2xpZW50OjpyZW1vdmVBdXRv ZmlsbFN1Z2dlc3Rpb25zIGlzIG5vdCBwYXNzZWQgdGhlIGNvcnJlY3QgbmFtZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIzODUKKworICAgICAgICAq IHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjphdXRv Y29tcGxldGVIYW5kbGVLZXlFdmVudCk6IFVzZSBXZWJJbnB1dEVsZW1lbnQ6Om5hbWVGb3JBdXRv ZmlsbCgpIGluc3RlYWQgb2YgbmFtZS4KKwogMjAxMC0wNy0xNSAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0 c2t5LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDYzNDI5 KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTk0LDYgKzk0LDcgQEAKICNpbmNsdWRlICJXZWJEcmFnRGF0YS5oIgogI2luY2x1ZGUgIldl YkZyYW1lSW1wbC5oIgogI2luY2x1ZGUgIldlYkltYWdlLmgiCisjaW5jbHVkZSAiV2ViSW5wdXRF bGVtZW50LmgiCiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudC5oIgogI2luY2x1ZGUgIldlYklucHV0 RXZlbnRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAiV2ViS2l0LmgiCkBAIC01OTYsOCArNTk3LDcg QEAgYm9vbCBXZWJWaWV3SW1wbDo6YXV0b2NvbXBsZXRlSGFuZGxlS2V5RQogICAgICAgICBpZiAo IW1fYXV0b0ZpbGxQb3B1cENsaWVudC0+Y2FuUmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgoc2VsZWN0 ZWRJbmRleCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAgICAgSFRNTElucHV0 RWxlbWVudCogaW5wdXRFbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KGVs ZW1lbnQpOwotICAgICAgICBXZWJTdHJpbmcgbmFtZSA9IGlucHV0RWxlbWVudC0+bmFtZSgpOwor ICAgICAgICBXZWJTdHJpbmcgbmFtZSA9IFdlYklucHV0RWxlbWVudChzdGF0aWNfY2FzdDxIVE1M SW5wdXRFbGVtZW50Kj4oZWxlbWVudCkpLm5hbWVGb3JBdXRvZmlsbCgpOwogICAgICAgICBXZWJT dHJpbmcgdmFsdWUgPSBtX2F1dG9GaWxsUG9wdXBDbGllbnQtPml0ZW1UZXh0KHNlbGVjdGVkSW5k ZXgpOwogICAgICAgICBtX2NsaWVudC0+cmVtb3ZlQXV0b2ZpbGxTdWdnZXN0aW9ucyhuYW1lLCB2 YWx1ZSk7CiAgICAgICAgIC8vIFVwZGF0ZSB0aGUgZW50cmllcyBpbiB0aGUgY3VycmVudGx5IHNo b3dpbmcgcG9wdXAgdG8gcmVmbGVjdCB0aGUK