42344 2010-07-15 02:20:42 -0700 [Chromium] fix compilation failure in AutoFillPopupMenuClient.cpp 2010-07-15 08:54:37 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned sky yurys oldest_to_newest 251746 0 podivilov 2010-07-15 02:20:42 -0700 [Chromium] fix chromium mac compilation failure in AutoFillPopupMenuClient.cpp 251751 1 61622 podivilov 2010-07-15 02:33:23 -0700 Created attachment 61622 Proposed patch. 251761 2 61622 yurys 2010-07-15 02:45:52 -0700 Comment on attachment 61622 Proposed patch. Clearing flags on attachment: 61622 Committed r63418: <http://trac.webkit.org/changeset/63418> 251762 3 yurys 2010-07-15 02:46:01 -0700 All reviewed patches have been landed. Closing bug. 251903 4 sky 2010-07-15 08:39:07 -0700 Sorry I missed this. Do we compile in chrome with a different set of flags that lead to me missing this? 251905 5 podivilov 2010-07-15 08:43:32 -0700 Yes, in chromium-mac warnings are errors (at least comparison signed/unsigned mismatches). 251908 6 yurys 2010-07-15 08:46:43 -0700 (In reply to comment #4) > Sorry I missed this. Do we compile in chrome with a different set of flags that lead to me missing this? I think the flags are a bit different. Moreover, IIRC they differ on different platform for Chromium. 251916 7 sky 2010-07-15 08:54:37 -0700 I compiled on linux which apparently must disable warnings as well. I'll be more careful next time. Sorry. 61622 2010-07-15 02:33:23 -0700 2010-07-15 02:45:52 -0700 Proposed patch. fix_warning.patch text/plain 1788 podivilov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDgxODA3YzIuLmZiM2ZhY2UgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA3LTE1ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBtYWMgY29tcGlsYXRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDIzNDQKKworICAgICAgICAqIHNyYy9BdXRvRmlsbFBvcHVwTWVu dUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBNZW51Q2xpZW50Ojpy ZW1vdmVTdWdnZXN0aW9uQXRJbmRleCk6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBN ZW51Q2xpZW50OjpjYW5SZW1vdmVTdWdnZXN0aW9uQXRJbmRleCk6CisKIDIwMTAtMDctMTQgIEdl b3JnZSBZYWtvdmxldiAgPGdlb3JnZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0Zp bGxQb3B1cE1lbnVDbGllbnQuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVw TWVudUNsaWVudC5jcHAKaW5kZXggZGIyMTRjNy4uNmI3NGY2MCAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5jcHAKKysrIGIvV2ViS2l0L2No cm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5jcHAKQEAgLTkxLDcgKzkxLDcgQEAg dm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6cmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgodW5z aWduZWQgbGlzdEluZGV4KQogCiAgICAgaW50IGluZGV4ID0gY29udmVydExpc3RJbmRleFRvSW50 ZXJuYWxJbmRleChsaXN0SW5kZXgpOwogCi0gICAgQVNTRVJUKGluZGV4IDwgbV9uYW1lcy5zaXpl KCkpOworICAgIEFTU0VSVChzdGF0aWNfY2FzdDx1bnNpZ25lZD4oaW5kZXgpIDwgbV9uYW1lcy5z aXplKCkpOwogCiAgICAgbV9uYW1lcy5yZW1vdmUoaW5kZXgpOwogICAgIG1fbGFiZWxzLnJlbW92 ZShpbmRleCk7CkBAIC0xMDYsNyArMTA2LDcgQEAgYm9vbCBBdXRvRmlsbFBvcHVwTWVudUNsaWVu dDo6Y2FuUmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogICAgIC8v IE9ubHkgYWxsb3cgZGVsZXRpb24gb2YgaXRlbXMgYmVmb3JlIHRoZSBzZXBhcmF0b3IgYW5kIHRo b3NlIHRoYXQgZG9uJ3QKICAgICAvLyBoYXZlIGEgbGFiZWwgKGF1dG9jb21wbGV0ZSkuCiAgICAg aW50IGluZGV4ID0gY29udmVydExpc3RJbmRleFRvSW50ZXJuYWxJbmRleChsaXN0SW5kZXgpOwot ICAgIHJldHVybiBtX2xhYmVsc1tpbmRleF0uaXNFbXB0eSgpICYmIChtX3NlcGFyYXRvckluZGV4 ID09IC0xIHx8IGxpc3RJbmRleCA8IG1fc2VwYXJhdG9ySW5kZXgpOworICAgIHJldHVybiBtX2xh YmVsc1tpbmRleF0uaXNFbXB0eSgpICYmIChtX3NlcGFyYXRvckluZGV4ID09IC0xIHx8IGxpc3RJ bmRleCA8IHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX3NlcGFyYXRvckluZGV4KSk7CiB9CiAKIHZv aWQgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnZhbHVlQ2hhbmdlZCh1bnNpZ25lZCBsaXN0SW5k ZXgsIGJvb2wgZmlyZUV2ZW50cykK