42305 2010-07-14 17:14:07 -0700 Add functions to extract individual RGBA32 components 2010-07-14 17:27:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Performance P2 Normal --- 1 kling webkit-unassigned darin oldest_to_newest 251527 0 kling 2010-07-14 17:14:07 -0700 Right now you have to create a Color object to extract the R, G, B or A component of an RGBA32 value. 251530 1 61585 kling 2010-07-14 17:15:51 -0700 Created attachment 61585 Proposed patch Add functions: {red,green,blue,alpha}Channel(RGBA32) 251540 2 61585 kling 2010-07-14 17:27:44 -0700 Comment on attachment 61585 Proposed patch Clearing flags on attachment: 61585 Committed r63382: <http://trac.webkit.org/changeset/63382> 251541 3 kling 2010-07-14 17:27:54 -0700 All reviewed patches have been landed. Closing bug. 61585 2010-07-14 17:15:51 -0700 2010-07-14 17:27:44 -0700 Proposed patch bug-42305.diff text/plain 3004 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGM5NzFkNy4uODNmNWJmOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNy0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBmdW5jdGlvbnMgdG8gZXh0cmFjdCBpbmRpdmlkdWFs IFJHQkEzMiBjb21wb25lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MjMwNQorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5n Q29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQy RDo6d2lsbERyYXcpOiBVc2UgYWxwaGFDaGFubmVsKCkKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9Db2xvci5oOgorICAgICAgICAoV2ViQ29yZTo6cmVkQ2hhbm5lbCk6CisgICAgICAgIChX ZWJDb3JlOjpncmVlbkNoYW5uZWwpOgorICAgICAgICAoV2ViQ29yZTo6Ymx1ZUNoYW5uZWwpOgor ICAgICAgICAoV2ViQ29yZTo6YWxwaGFDaGFubmVsKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbG9y OjpyZWQpOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3I6OmdyZWVuKToKKyAgICAgICAgKFdlYkNv cmU6OkNvbG9yOjpibHVlKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbG9yOjphbHBoYSk6CisKIDIw MTAtMDctMTQgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXIt c3RhbXBlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCmluZGV4IDk3NDhmZjUuLmIzYmFmYzYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysg Yi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKQEAgLTEz NzUsNyArMTM3NSw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjp3aWxsRHJhdyhj b25zdCBGbG9hdFJlY3QmIHIsIHVuc2lnbmVkIG9wdGlvbnMpCiAgICAgICAgIGRpcnR5UmVjdCA9 IGN0bS5tYXBSZWN0KHIpOwogICAgIH0KICAgICAKLSAgICBpZiAob3B0aW9ucyAmIENhbnZhc1dp bGxEcmF3QXBwbHlTaGFkb3cgJiYgQ29sb3Ioc3RhdGUoKS5tX3NoYWRvd0NvbG9yKS5hbHBoYSgp KSB7CisgICAgaWYgKG9wdGlvbnMgJiBDYW52YXNXaWxsRHJhd0FwcGx5U2hhZG93ICYmIGFscGhh Q2hhbm5lbChzdGF0ZSgpLm1fc2hhZG93Q29sb3IpKSB7CiAgICAgICAgIC8vIFRoZSBzaGFkb3cg Z2V0cyBhcHBsaWVkIGFmdGVyIHRyYW5zZm9ybWF0aW9uCiAgICAgICAgIEZsb2F0UmVjdCBzaGFk b3dSZWN0KGRpcnR5UmVjdCk7CiAgICAgICAgIHNoYWRvd1JlY3QubW92ZShzdGF0ZSgpLm1fc2hh ZG93T2Zmc2V0KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3Iu aCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuaAppbmRleCA3MTkyZDE2Li5kNDFl MzYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmgKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvci5oCkBAIC02OSw2ICs2OSwxMSBAQCBSR0JB MzIgbWFrZVJHQkFGcm9tQ01ZS0EoZmxvYXQgYywgZmxvYXQgbSwgZmxvYXQgeSwgZmxvYXQgaywg ZmxvYXQgYSk7CiAKIGludCBkaWZmZXJlbmNlU3F1YXJlZChjb25zdCBDb2xvciYsIGNvbnN0IENv bG9yJik7CiAKK2lubGluZSBpbnQgcmVkQ2hhbm5lbChSR0JBMzIgY29sb3IpIHsgcmV0dXJuIChj b2xvciA+PiAxNikgJiAweEZGOyB9CitpbmxpbmUgaW50IGdyZWVuQ2hhbm5lbChSR0JBMzIgY29s b3IpIHsgcmV0dXJuIChjb2xvciA+PiA4KSAmIDB4RkY7IH0KK2lubGluZSBpbnQgYmx1ZUNoYW5u ZWwoUkdCQTMyIGNvbG9yKSB7IHJldHVybiBjb2xvciAmIDB4RkY7IH0KK2lubGluZSBpbnQgYWxw aGFDaGFubmVsKFJHQkEzMiBjb2xvcikgeyByZXR1cm4gKGNvbG9yID4+IDI0KSAmIDB4RkY7IH0K KwogY2xhc3MgQ29sb3IgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiBwdWJsaWM6CiAgICAgQ29s b3IoKSA6IG1fY29sb3IoMCksIG1fdmFsaWQoZmFsc2UpIHsgfQpAQCAtOTMsMTAgKzk4LDEwIEBA IHB1YmxpYzoKIAogICAgIGJvb2wgaGFzQWxwaGEoKSBjb25zdCB7IHJldHVybiBhbHBoYSgpIDwg MjU1OyB9CiAKLSAgICBpbnQgcmVkKCkgY29uc3QgeyByZXR1cm4gKG1fY29sb3IgPj4gMTYpICYg MHhGRjsgfQotICAgIGludCBncmVlbigpIGNvbnN0IHsgcmV0dXJuIChtX2NvbG9yID4+IDgpICYg MHhGRjsgfQotICAgIGludCBibHVlKCkgY29uc3QgeyByZXR1cm4gbV9jb2xvciAmIDB4RkY7IH0K LSAgICBpbnQgYWxwaGEoKSBjb25zdCB7IHJldHVybiAobV9jb2xvciA+PiAyNCkgJiAweEZGOyB9 CisgICAgaW50IHJlZCgpIGNvbnN0IHsgcmV0dXJuIHJlZENoYW5uZWwobV9jb2xvcik7IH0KKyAg ICBpbnQgZ3JlZW4oKSBjb25zdCB7IHJldHVybiBncmVlbkNoYW5uZWwobV9jb2xvcik7IH0KKyAg ICBpbnQgYmx1ZSgpIGNvbnN0IHsgcmV0dXJuIGJsdWVDaGFubmVsKG1fY29sb3IpOyB9CisgICAg aW50IGFscGhhKCkgY29uc3QgeyByZXR1cm4gYWxwaGFDaGFubmVsKG1fY29sb3IpOyB9CiAgICAg CiAgICAgUkdCQTMyIHJnYigpIGNvbnN0IHsgcmV0dXJuIG1fY29sb3I7IH0gLy8gUHJlc2VydmUg dGhlIGFscGhhLgogICAgIHZvaWQgc2V0UkdCKGludCByLCBpbnQgZywgaW50IGIpIHsgbV9jb2xv ciA9IG1ha2VSR0IociwgZywgYik7IG1fdmFsaWQgPSB0cnVlOyB9Cg==